[hibernate-dev] Clever dirty checking for Hibernate Search
Context: As a follow-up on "HSEARCH-361 Only index an entity if an indexed property has changed": during development of this improvement we agreed to disable the dirty-checking optimization in case a BoostStrategy or ClassBridge was defined on the class; we also considered the (unlikely) possibility that a FieldBridge could access the full entity in some way, getting access to properties we wouldn't expect (this case requires to disable the new feature). So to fully support proper dirty check,some ideas where proposed to add some way for ClassBridge/BoostStratey/... to define from which properties they are affected. Even if these implementations could list all property names, there are drawbacks: 1) it breaks DRY. It's error prone, people could easily forget to update the used-properties definition after fixing the main method. 2) doesn't take into account branches in the implementation. Maybe in some cases it's affected by A,B, in some others by A,C depending on the value of A. 3) pollutes all existing APIs. Considering these drawbacks, I'm wondering if instead of the entity we could pass to these implementations a proxied entity which could record exactly which properties are being accessed. The index would be not considered dirty if accessed properties aren't, so further Document processing can be skipped. I'd expect Hibernate core already has all required elements to intercept and track access to managed entities? Cheers, Sanne ___ hibernate-dev mailing list hibernate-dev@lists.jboss.org https://lists.jboss.org/mailman/listinfo/hibernate-dev
[hibernate-dev] Broken links in Wiki
Hello All, I'm a newbie to Hibernate development :-). While looking at the wiki I found that some of the links pointed are broken. Specially in the "Building Hibernate from source 3.5". Instead this: http://www.sonatype.com/book/lifecycle.html. I think it should be this : http://www.sonatype.com/books/maven-book/reference/lifecycle.html ? And the link for Maven getting started guide (Maven in 5 Minutes) contains a dot(.) which leads to a 404 error. Regards, Vijitha Kumara. ___ hibernate-dev mailing list hibernate-dev@lists.jboss.org https://lists.jboss.org/mailman/listinfo/hibernate-dev
Re: [hibernate-dev] Broken links in Wiki
Hi Vijitha, thanks for pointing out the broken links. I updated the page. If you sign up JBoss Community account you should be able to edit pages yourself. After all a wiki is a community effort. Note that the current trunk of Hibernate uses Gradle to build the source http://community.jboss.org/wiki/GradleFAQ --Hardy On Sat, 15 Jan 2011 12:38:04 +0100, Vijitha Kumara wrote: > Hello All, > > I'm a newbie to Hibernate development :-). While looking at the wiki I > found > that some of the links pointed are broken. Specially in the "Building > Hibernate from source 3.5". > > Instead this: http://www.sonatype.com/book/lifecycle.html. > > I think it should be this : > http://www.sonatype.com/books/maven-book/reference/lifecycle.html ? > > And the link for Maven getting started guide (Maven in 5 Minutes) > contains a > dot(.) which leads to a 404 error. > > > > > Regards, > Vijitha Kumara. > ___ > hibernate-dev mailing list > hibernate-dev@lists.jboss.org > https://lists.jboss.org/mailman/listinfo/hibernate-dev ___ hibernate-dev mailing list hibernate-dev@lists.jboss.org https://lists.jboss.org/mailman/listinfo/hibernate-dev
Re: [hibernate-dev] missing ANTLR dependency from gradle built pom.xml
Pretty sure I checked this previously. The part you ask about configures
the antlr plugin that generates the parsers from the grammar files. Pretty
positive that also used to add antlr to the project's set or exported
deps. That is where I think something changed. Let me ask about this on
the gradle channels.
On Jan 14, 2011 12:39 PM, "Sanne Grinovero"
wrote:
> Hello,
> It seems that ANTLR is missing from the pom.xml generated by the new
> gradle build of Hibernate Core.
>
> The following patch seems to fix it but I couldn't find any
> information on the "antlr( libraries.antlr )" line, from the
> documentation is seems it's only being used to choose the ANTLR
> version to use to generate the parser code, but I couldn't find an
> option to also include it as dependency so I added an additional line.
>
> Could anybody confirm this change is right? (It seems to work).
>
> diff --git a/hibernate-core/hibernate-core.gradle
> b/hibernate-core/hibernate-core.gradle
> index 59f80aa..4f28e93 100644
> --- a/hibernate-core/hibernate-core.gradle
> +++ b/hibernate-core/hibernate-core.gradle
> @@ -12,6 +12,7 @@ dependencies {
> compile( libraries.commons_annotations )
> compile( libraries.jpa )
> antlr( libraries.antlr )
> + compile( libraries.antlr )
> provided( libraries.javassist )
> provided( libraries.cglib ) {
> transitive = true
>
> thanks,
> Sanne
> ___
> hibernate-dev mailing list
> hibernate-dev@lists.jboss.org
> https://lists.jboss.org/mailman/listinfo/hibernate-dev
___
hibernate-dev mailing list
hibernate-dev@lists.jboss.org
https://lists.jboss.org/mailman/listinfo/hibernate-dev
Re: [hibernate-dev] missing ANTLR dependency from gradle built pom.xml
I don't know if this is directly relevant (as it is a Maven build), but
the other day I downloaded the 3.6.0 final code from github and used
Idea 10 to create a (Maven) project from the sources. Once the project
was created, it did not compile, and the first visible errors showed
classes created by Antler were not present. I simply used the IDE to
build the POM's for different parts of the code and after a few builds,
the project would build and run. I did this to run the tests.
Later, I downloaded the 3.6.1 head and updated the changed files in the
previous Idea setup. The build was successful.
Fred
On Sat, 15 Jan 2011 11:40 -0600, "Steve Ebersole"
wrote:
> Pretty sure I checked this previously. The part you ask about configures
> the antlr plugin that generates the parsers from the grammar files.
> Pretty
> positive that also used to add antlr to the project's set or exported
> deps. That is where I think something changed. Let me ask about this
> on
> the gradle channels.
> On Jan 14, 2011 12:39 PM, "Sanne Grinovero"
> wrote:
> > Hello,
> > It seems that ANTLR is missing from the pom.xml generated by the new
> > gradle build of Hibernate Core.
> >
> > The following patch seems to fix it but I couldn't find any
> > information on the "antlr( libraries.antlr )" line, from the
> > documentation is seems it's only being used to choose the ANTLR
> > version to use to generate the parser code, but I couldn't find an
> > option to also include it as dependency so I added an additional line.
> >
> > Could anybody confirm this change is right? (It seems to work).
> >
> > diff --git a/hibernate-core/hibernate-core.gradle
> > b/hibernate-core/hibernate-core.gradle
> > index 59f80aa..4f28e93 100644
> > --- a/hibernate-core/hibernate-core.gradle
> > +++ b/hibernate-core/hibernate-core.gradle
> > @@ -12,6 +12,7 @@ dependencies {
> > compile( libraries.commons_annotations )
> > compile( libraries.jpa )
> > antlr( libraries.antlr )
> > + compile( libraries.antlr )
> > provided( libraries.javassist )
> > provided( libraries.cglib ) {
> > transitive = true
> >
> > thanks,
> > Sanne
> > ___
> > hibernate-dev mailing list
> > hibernate-dev@lists.jboss.org
> > https://lists.jboss.org/mailman/listinfo/hibernate-dev
> ___
> hibernate-dev mailing list
> hibernate-dev@lists.jboss.org
> https://lists.jboss.org/mailman/listinfo/hibernate-dev
>
___
hibernate-dev mailing list
hibernate-dev@lists.jboss.org
https://lists.jboss.org/mailman/listinfo/hibernate-dev
Re: [hibernate-dev] missing ANTLR dependency from gradle built pom.xml
Completely unrelated. But yes, once you ask Maven to generate the files they
remain generated until you clean or delete them :)
On Saturday, January 15, 2011, at 01:34 pm, Fred Toussi wrote:
> I don't know if this is directly relevant (as it is a Maven build), but
> the other day I downloaded the 3.6.0 final code from github and used
> Idea 10 to create a (Maven) project from the sources. Once the project
> was created, it did not compile, and the first visible errors showed
> classes created by Antler were not present. I simply used the IDE to
> build the POM's for different parts of the code and after a few builds,
> the project would build and run. I did this to run the tests.
>
> Later, I downloaded the 3.6.1 head and updated the changed files in the
> previous Idea setup. The build was successful.
>
> Fred
>
> On Sat, 15 Jan 2011 11:40 -0600, "Steve Ebersole"
>
> wrote:
> > Pretty sure I checked this previously. The part you ask about configures
> > the antlr plugin that generates the parsers from the grammar files.
> > Pretty
> > positive that also used to add antlr to the project's set or exported
> > deps. That is where I think something changed. Let me ask about this
> > on
> > the gradle channels.
> > On Jan 14, 2011 12:39 PM, "Sanne Grinovero"
> >
> > wrote:
> > > Hello,
> > > It seems that ANTLR is missing from the pom.xml generated by the new
> > > gradle build of Hibernate Core.
> > >
> > > The following patch seems to fix it but I couldn't find any
> > > information on the "antlr( libraries.antlr )" line, from the
> > > documentation is seems it's only being used to choose the ANTLR
> > > version to use to generate the parser code, but I couldn't find an
> > > option to also include it as dependency so I added an additional line.
> > >
> > > Could anybody confirm this change is right? (It seems to work).
> > >
> > > diff --git a/hibernate-core/hibernate-core.gradle
> > > b/hibernate-core/hibernate-core.gradle
> > > index 59f80aa..4f28e93 100644
> > > --- a/hibernate-core/hibernate-core.gradle
> > > +++ b/hibernate-core/hibernate-core.gradle
> > > @@ -12,6 +12,7 @@ dependencies {
> > > compile( libraries.commons_annotations )
> > > compile( libraries.jpa )
> > > antlr( libraries.antlr )
> > > + compile( libraries.antlr )
> > > provided( libraries.javassist )
> > > provided( libraries.cglib ) {
> > > transitive = true
> > >
> > > thanks,
> > > Sanne
> > > ___
> > > hibernate-dev mailing list
> > > hibernate-dev@lists.jboss.org
> > > https://lists.jboss.org/mailman/listinfo/hibernate-dev
> >
> > ___
> > hibernate-dev mailing list
> > hibernate-dev@lists.jboss.org
> > https://lists.jboss.org/mailman/listinfo/hibernate-dev
>
> ___
> hibernate-dev mailing list
> hibernate-dev@lists.jboss.org
> https://lists.jboss.org/mailman/listinfo/hibernate-dev
---
Steve Ebersole
http://hibernate.org
___
hibernate-dev mailing list
hibernate-dev@lists.jboss.org
https://lists.jboss.org/mailman/listinfo/hibernate-dev
