Re: [hibernate-dev] Contributing to Hibernate development
On Dec 3, 2010, at 6:20 AM, Strong Liu wrote: > first go through our jira > (http://opensource.atlassian.com/projects/hibernate) and find one you'd like > working on (or create one yourself for thing you think can be improved or > find a bug) > then fork https://github.com/hibernate/hibernate-core > when you finish, open a pull request By the way, is anyone planning to deal with pull requests? I can deal with Infinispan 2LC ones, but anything other than that is out of my league. p.s. I have a pull request myself that I'm waiting to be dealt with. > thanks > > --- > Strong Liu > http://hibernate.org > http://github.com/stliu > > On Dec 3, 2010, at 11:45 AM, Srinivasan Krishnan wrote: > >> Hi, >> >> I have been working on hibernate and I am interested in contributing in >> hibernate development. Could you please let me know the process and how to >> start. >> >> Thanks, >> Srini >> ___ >> hibernate-dev mailing list >> hibernate-dev@lists.jboss.org >> https://lists.jboss.org/mailman/listinfo/hibernate-dev > > > ___ > hibernate-dev mailing list > hibernate-dev@lists.jboss.org > https://lists.jboss.org/mailman/listinfo/hibernate-dev -- Galder Zamarreño Sr. Software Engineer Infinispan, JBoss Cache ___ hibernate-dev mailing list hibernate-dev@lists.jboss.org https://lists.jboss.org/mailman/listinfo/hibernate-dev
Re: [hibernate-dev] Contributing to Hibernate development
actually, I'd think pull request is the same thing as patch attached to a jira case. every commitor can deal with that if he/she think the patch is correct. personally, I check pull request when i'm free, i think others do the same thing --- Strong Liu http://hibernate.org http://github.com/stliu On Dec 3, 2010, at 9:26 PM, Galder Zamarreño wrote: > > On Dec 3, 2010, at 6:20 AM, Strong Liu wrote: > >> first go through our jira >> (http://opensource.atlassian.com/projects/hibernate) and find one you'd like >> working on (or create one yourself for thing you think can be improved or >> find a bug) >> then fork https://github.com/hibernate/hibernate-core >> when you finish, open a pull request > > By the way, is anyone planning to deal with pull requests? I can deal with > Infinispan 2LC ones, but anything other than that is out of my league. > > p.s. I have a pull request myself that I'm waiting to be dealt with. > >> thanks >> >> --- >> Strong Liu >> http://hibernate.org >> http://github.com/stliu >> >> On Dec 3, 2010, at 11:45 AM, Srinivasan Krishnan wrote: >> >>> Hi, >>> >>> I have been working on hibernate and I am interested in contributing in >>> hibernate development. Could you please let me know the process and how to >>> start. >>> >>> Thanks, >>> Srini >>> ___ >>> hibernate-dev mailing list >>> hibernate-dev@lists.jboss.org >>> https://lists.jboss.org/mailman/listinfo/hibernate-dev >> >> >> ___ >> hibernate-dev mailing list >> hibernate-dev@lists.jboss.org >> https://lists.jboss.org/mailman/listinfo/hibernate-dev > > -- > Galder Zamarreño > Sr. Software Engineer > Infinispan, JBoss Cache > ___ hibernate-dev mailing list hibernate-dev@lists.jboss.org https://lists.jboss.org/mailman/listinfo/hibernate-dev
Re: [hibernate-dev] Contributing to Hibernate development
Is there any way to get notified about pullrequests or does one actually have to visit github to see ? /max On Dec 3, 2010, at 14:31, Strong Liu wrote: > actually, I'd think pull request is the same thing as patch attached to a > jira case. > every commitor can deal with that if he/she think the patch is correct. > personally, I check pull request when i'm free, i think others do the same > thing > > --- > Strong Liu > http://hibernate.org > http://github.com/stliu > > On Dec 3, 2010, at 9:26 PM, Galder Zamarreño wrote: > >> >> On Dec 3, 2010, at 6:20 AM, Strong Liu wrote: >> >>> first go through our jira >>> (http://opensource.atlassian.com/projects/hibernate) and find one you'd >>> like working on (or create one yourself for thing you think can be improved >>> or find a bug) >>> then fork https://github.com/hibernate/hibernate-core >>> when you finish, open a pull request >> >> By the way, is anyone planning to deal with pull requests? I can deal with >> Infinispan 2LC ones, but anything other than that is out of my league. >> >> p.s. I have a pull request myself that I'm waiting to be dealt with. >> >>> thanks >>> >>> --- >>> Strong Liu >>> http://hibernate.org >>> http://github.com/stliu >>> >>> On Dec 3, 2010, at 11:45 AM, Srinivasan Krishnan wrote: >>> Hi, I have been working on hibernate and I am interested in contributing in hibernate development. Could you please let me know the process and how to start. Thanks, Srini ___ hibernate-dev mailing list hibernate-dev@lists.jboss.org https://lists.jboss.org/mailman/listinfo/hibernate-dev >>> >>> >>> ___ >>> hibernate-dev mailing list >>> hibernate-dev@lists.jboss.org >>> https://lists.jboss.org/mailman/listinfo/hibernate-dev >> >> -- >> Galder Zamarreño >> Sr. Software Engineer >> Infinispan, JBoss Cache >> > > > ___ > hibernate-dev mailing list > hibernate-dev@lists.jboss.org > https://lists.jboss.org/mailman/listinfo/hibernate-dev ___ hibernate-dev mailing list hibernate-dev@lists.jboss.org https://lists.jboss.org/mailman/listinfo/hibernate-dev
Re: [hibernate-dev] Contributing to Hibernate development
I get email notification, don't you? --- Strong Liu http://hibernate.org http://github.com/stliu On Dec 3, 2010, at 10:14 PM, Max Rydahl Andersen wrote: > Is there any way to get notified about pullrequests or does one actually have > to visit github to see ? > > /max > > On Dec 3, 2010, at 14:31, Strong Liu wrote: > >> actually, I'd think pull request is the same thing as patch attached to a >> jira case. >> every commitor can deal with that if he/she think the patch is correct. >> personally, I check pull request when i'm free, i think others do the same >> thing >> >> --- >> Strong Liu >> http://hibernate.org >> http://github.com/stliu >> >> On Dec 3, 2010, at 9:26 PM, Galder Zamarreño wrote: >> >>> >>> On Dec 3, 2010, at 6:20 AM, Strong Liu wrote: >>> first go through our jira (http://opensource.atlassian.com/projects/hibernate) and find one you'd like working on (or create one yourself for thing you think can be improved or find a bug) then fork https://github.com/hibernate/hibernate-core when you finish, open a pull request >>> >>> By the way, is anyone planning to deal with pull requests? I can deal with >>> Infinispan 2LC ones, but anything other than that is out of my league. >>> >>> p.s. I have a pull request myself that I'm waiting to be dealt with. >>> thanks --- Strong Liu http://hibernate.org http://github.com/stliu On Dec 3, 2010, at 11:45 AM, Srinivasan Krishnan wrote: > Hi, > > I have been working on hibernate and I am interested in contributing in > hibernate development. Could you please let me know the process and how to > start. > > Thanks, > Srini > ___ > hibernate-dev mailing list > hibernate-dev@lists.jboss.org > https://lists.jboss.org/mailman/listinfo/hibernate-dev ___ hibernate-dev mailing list hibernate-dev@lists.jboss.org https://lists.jboss.org/mailman/listinfo/hibernate-dev >>> >>> -- >>> Galder Zamarreño >>> Sr. Software Engineer >>> Infinispan, JBoss Cache >>> >> >> >> ___ >> hibernate-dev mailing list >> hibernate-dev@lists.jboss.org >> https://lists.jboss.org/mailman/listinfo/hibernate-dev > ___ hibernate-dev mailing list hibernate-dev@lists.jboss.org https://lists.jboss.org/mailman/listinfo/hibernate-dev
Re: [hibernate-dev] Contributing to Hibernate development
No, and I don't get either :( I think the problem is - http://support.github.com/discussions/organization-issues/190-pull-request-notifications-for-organisations --Hardy On Fri, 03 Dec 2010 15:15:10 +0100, Strong Liu wrote: > I get email notification, don't you? ___ hibernate-dev mailing list hibernate-dev@lists.jboss.org https://lists.jboss.org/mailman/listinfo/hibernate-dev
Re: [hibernate-dev] Contributing to Hibernate development
Just noticed that I was not a team member of core-dev team. I am receiving pull request emails for Search and Validator (where I am member of the dev team). The key is not be "just" the repo owner, but also in the corresponding dev team. --Hardy On Fri, 03 Dec 2010 15:18:55 +0100, Hardy Ferentschik wrote: > No, and I don't get either :( > I think the problem is - > http://support.github.com/discussions/organization-issues/190-pull-request-notifications-for-organisations > > --Hardy > > On Fri, 03 Dec 2010 15:15:10 +0100, Strong Liu > wrote: > >> I get email notification, don't you? > ___ > hibernate-dev mailing list > hibernate-dev@lists.jboss.org > https://lists.jboss.org/mailman/listinfo/hibernate-dev ___ hibernate-dev mailing list hibernate-dev@lists.jboss.org https://lists.jboss.org/mailman/listinfo/hibernate-dev
Re: [hibernate-dev] Contributing to Hibernate development
You need to add yourself explicitly to the teams with access to the repo. As stated members of the organization owner team does not receive these requests by github design. On Friday, December 03, 2010, at 08:18 am, Hardy Ferentschik wrote: > No, and I don't get either :( > I think the problem is - > http://support.github.com/discussions/organization-issues/190-pull-request- > notifications-for-organisations > > --Hardy > > On Fri, 03 Dec 2010 15:15:10 +0100, Strong Liu wrote: > > I get email notification, don't you? > > ___ > hibernate-dev mailing list > hibernate-dev@lists.jboss.org > https://lists.jboss.org/mailman/listinfo/hibernate-dev --- Steve Ebersole http://hibernate.org ___ hibernate-dev mailing list hibernate-dev@lists.jboss.org https://lists.jboss.org/mailman/listinfo/hibernate-dev
Re: [hibernate-dev] Contributing to Hibernate development
im browsing the github repo and i can't find where I can add my self explicitly beyond where Im not already. weird. /max On Dec 3, 2010, at 15:27, Steve Ebersole wrote: > You need to add yourself explicitly to the teams with access to the repo. As > stated members of the organization owner team does not receive these requests > by github design. > > On Friday, December 03, 2010, at 08:18 am, Hardy Ferentschik wrote: >> No, and I don't get either :( >> I think the problem is - >> http://support.github.com/discussions/organization-issues/190-pull-request- >> notifications-for-organisations >> >> --Hardy >> >> On Fri, 03 Dec 2010 15:15:10 +0100, Strong Liu wrote: >>> I get email notification, don't you? >> >> ___ >> hibernate-dev mailing list >> hibernate-dev@lists.jboss.org >> https://lists.jboss.org/mailman/listinfo/hibernate-dev > > --- > Steve Ebersole > http://hibernate.org > ___ > hibernate-dev mailing list > hibernate-dev@lists.jboss.org > https://lists.jboss.org/mailman/listinfo/hibernate-dev ___ hibernate-dev mailing list hibernate-dev@lists.jboss.org https://lists.jboss.org/mailman/listinfo/hibernate-dev
Re: [hibernate-dev] Contributing to Hibernate development
You are not part of the core-dev team - https://github.com/organizations/hibernate/teams/18292 On Fri, 03 Dec 2010 15:40:22 +0100, Max Rydahl Andersen wrote: > im browsing the github repo and i can't find where I can add my self > explicitly beyond where > Im not already. > > weird. ___ hibernate-dev mailing list hibernate-dev@lists.jboss.org https://lists.jboss.org/mailman/listinfo/hibernate-dev
Re: [hibernate-dev] Contributing to Hibernate development
Bingo! You had access (pull/push) before because you were an owner in the organization (which is a group too); however, GitHub says that group does not get pull request notifications (which is Goodness imo). Notice how each repo has group(s) associated with it also... Those are the ones where pull request notifications are managed. So basically you have to opt-in to each repo for which you want pull request notifications. On Friday, December 03, 2010, at 08:45 am, Hardy Ferentschik wrote: > You are not part of the core-dev team - > https://github.com/organizations/hibernate/teams/18292 > > On Fri, 03 Dec 2010 15:40:22 +0100, Max Rydahl Andersen > > wrote: > > im browsing the github repo and i can't find where I can add my self > > explicitly beyond where > > Im not already. > > > > weird. --- Steve Ebersole http://hibernate.org ___ hibernate-dev mailing list hibernate-dev@lists.jboss.org https://lists.jboss.org/mailman/listinfo/hibernate-dev
Re: [hibernate-dev] Contributing to Hibernate development
yup got it - my brain didn't think about clicking on the team names to see their member list ;) /max On Dec 3, 2010, at 16:58, Steve Ebersole wrote: > Bingo! > > You had access (pull/push) before because you were an owner in the > organization (which is a group too); however, GitHub says that group does not > get pull request notifications (which is Goodness imo). > > Notice how each repo has group(s) associated with it also... Those are the > ones where pull request notifications are managed. So basically you have to > opt-in to each repo for which you want pull request notifications. > > > On Friday, December 03, 2010, at 08:45 am, Hardy Ferentschik wrote: >> You are not part of the core-dev team - >> https://github.com/organizations/hibernate/teams/18292 >> >> On Fri, 03 Dec 2010 15:40:22 +0100, Max Rydahl Andersen >> >> wrote: >>> im browsing the github repo and i can't find where I can add my self >>> explicitly beyond where >>> Im not already. >>> >>> weird. > > --- > Steve Ebersole > http://hibernate.org > ___ > hibernate-dev mailing list > hibernate-dev@lists.jboss.org > https://lists.jboss.org/mailman/listinfo/hibernate-dev ___ hibernate-dev mailing list hibernate-dev@lists.jboss.org https://lists.jboss.org/mailman/listinfo/hibernate-dev
[hibernate-dev] Why don't session filters affect UPDATE / DELETE statements?
I am curious as to why the decision was made to not append a WHERE clause to deletes and updates that could be affected by a session filter. I was looking at the source for HqlSqlWalker.postProcessDML, and it has the comment "append any filter fragments; the EMPTY_MAP is used under the assumption that currently enabled filters should not affect this process." So, it seems this was a conscious choice. I would actually like filters to affect updates and deletes and will probably modify this class to enable this. My reasoning is that if you have a filter turned on and perform a select then perform an update using HQL you would expect it to only modify those things returned in the select (lets ignore the fact that this is a race condition as I am oversimplifying). We are using session filters to automatically restrict a logged in user's view of certain data. This works great for selects, but obviously allows HQL updates and deletes to bypass this restricted view. So, my questions are, why this choice? and would you consider changing your mind? Thanks, Jason ___ hibernate-dev mailing list hibernate-dev@lists.jboss.org https://lists.jboss.org/mailman/listinfo/hibernate-dev
