Re: [hibernate-dev] CGLIB

[Emmanuel Bernard]

I fixed the bug where field level annotations are swallowed (patch not applied 
by the CGLIB team though) 
http://sourceforge.net/tracker/index.php?func=detail&aid=2796998&group_id=56933&atid=482368

But I could not fix the bug where generics information is simply swallowed (not 
enough internal knowledge). 

I think we should focus on Javassist.

On 12 mai 2010, at 03:14, Steve Ebersole wrote:

> I thought one of the issues was that cglib does not handle annotations? 
>  That's a pretty big 'workaround' if that's the case.
> 
> 
> -- Sent from my Palm Pre
> st...@hibernate.org
> http://hibernate.orgOn May 11, 2010 1:06 PM, Strong Liu 
>  wrote: 
> 
> these are the issues Steve mentioned below:
> 
> 
> 
> http://opensource.atlassian.com/projects/hibernate/browse/HHH-4703
> 
> https://jira.jboss.org/jira/browse/JBPAPP-2971
> 
> 
> 
> to be fair, these issues can be workaround, and we already have patches, 
> users who run into these issues can pick up our patch for cglib and rebuild 
> it themselves.
> 
> 
> 
> 
> 
> 
> 
> On May 11, 2010, at 10:34 PM, Hardy Ferentschik wrote:
> 
> 
> 
> > Is there any advantage of CGLIB over javassist?
> 
> > 
> 
> > On Tue, 11 May 2010 16:24:12 +0200, Steve Ebersole 
>   
> 
> > wrote:
> 
> > 
> 
> >> I think the time has come to drop CGLIB support :(  It is just 
> becoming
> 
> >> near impossible to get them to respond to issues.  We even recently 
> sent
> 
> >> them 2 patches of major issues and still cannot get them to apply the
> 
> >> changes upstream and cut releases.
> 
> >> 
> 
> >> So that leaves us the choice of deprecating CGLIB support and 
> eventually
> 
> >> dropping it altogether or forking it.  I personally do not want to 
> fork
> 
> >> it, mainly because I do not want to have to maintain it.  Anyway lets
> 
> >> discuss it this week if need be and we'll vote at the meeting monday.
> 
> >> 
> 
> > 
> 
> > ___
> 
> > hibernate-dev mailing list
> 
> > hibernate-dev@lists.jboss.org
> 
> > https://lists.jboss.org/mailman/listinfo/hibernate-dev
> 
> 
> 
> 
> ___
> hibernate-dev mailing list
> hibernate-dev@lists.jboss.org
> https://lists.jboss.org/mailman/listinfo/hibernate-dev


___
hibernate-dev mailing list
hibernate-dev@lists.jboss.org
https://lists.jboss.org/mailman/listinfo/hibernate-dev

Re: [hibernate-dev] CGLIB

[Strong Liu]

that cglib with annotations issue only shows when using cglib to instrument the 
domain class in compile time.

but I'd agree with drop it, actually i'm happy with that :D, cglib issues has 
taken too much time from us

On May 12, 2010, at 4:10 PM, Emmanuel Bernard wrote:

> I fixed the bug where field level annotations are swallowed (patch not 
> applied by the CGLIB team though) 
> http://sourceforge.net/tracker/index.php?func=detail&aid=2796998&group_id=56933&atid=482368
> 
> But I could not fix the bug where generics information is simply swallowed 
> (not enough internal knowledge). 
> 
> I think we should focus on Javassist.
> 
> On 12 mai 2010, at 03:14, Steve Ebersole wrote:
> 
>> I thought one of the issues was that cglib does not handle annotations? 
>>  That's a pretty big 'workaround' if that's the case.
>> 
>> 
>> -- Sent from my Palm Pre
>> st...@hibernate.org
>> http://hibernate.orgOn May 11, 2010 1:06 PM, Strong Liu 
>>  wrote: 
>> 
>> these are the issues Steve mentioned below:
>> 
>> 
>> 
>> http://opensource.atlassian.com/projects/hibernate/browse/HHH-4703
>> 
>> https://jira.jboss.org/jira/browse/JBPAPP-2971
>> 
>> 
>> 
>> to be fair, these issues can be workaround, and we already have patches, 
>> users who run into these issues can pick up our patch for cglib and rebuild 
>> it themselves.
>> 
>> 
>> 
>> 
>> 
>> 
>> 
>> On May 11, 2010, at 10:34 PM, Hardy Ferentschik wrote:
>> 
>> 
>> 
>> > Is there any advantage of CGLIB over javassist?
>> 
>> > 
>> 
>> > On Tue, 11 May 2010 16:24:12 +0200, Steve Ebersole 
>>   
>> 
>> > wrote:
>> 
>> > 
>> 
>> >> I think the time has come to drop CGLIB support :(  It is just 
>> becoming
>> 
>> >> near impossible to get them to respond to issues.  We even recently 
>> sent
>> 
>> >> them 2 patches of major issues and still cannot get them to apply 
>> the
>> 
>> >> changes upstream and cut releases.
>> 
>> >> 
>> 
>> >> So that leaves us the choice of deprecating CGLIB support and 
>> eventually
>> 
>> >> dropping it altogether or forking it.  I personally do not want to 
>> fork
>> 
>> >> it, mainly because I do not want to have to maintain it.  Anyway 
>> lets
>> 
>> >> discuss it this week if need be and we'll vote at the meeting 
>> monday.
>> 
>> >> 
>> 
>> > 
>> 
>> > ___
>> 
>> > hibernate-dev mailing list
>> 
>> > hibernate-dev@lists.jboss.org
>> 
>> > https://lists.jboss.org/mailman/listinfo/hibernate-dev
>> 
>> 
>> 
>> 
>> ___
>> hibernate-dev mailing list
>> hibernate-dev@lists.jboss.org
>> https://lists.jboss.org/mailman/listinfo/hibernate-dev
> 


___
hibernate-dev mailing list
hibernate-dev@lists.jboss.org
https://lists.jboss.org/mailman/listinfo/hibernate-dev

Re: [hibernate-dev] CGLIB

[Hardy Ferentschik]

Seems it is a simple choice after all. Let's just drop it.

--Hardy

On Wed, 12 May 2010 10:41:38 +0200, Strong Liu  wrote:

> that cglib with annotations issue only shows when using cglib to  
> instrument the domain class in compile time.
>
> but I'd agree with drop it, actually i'm happy with that :D, cglib  
> issues has taken too much time from us
>
> On May 12, 2010, at 4:10 PM, Emmanuel Bernard wrote:
>
>> I fixed the bug where field level annotations are swallowed (patch not  
>> applied by the CGLIB team though)  
>> http://sourceforge.net/tracker/index.php?func=detail&aid=2796998&group_id=56933&atid=482368
>>
>> But I could not fix the bug where generics information is simply  
>> swallowed (not enough internal knowledge).
>>
>> I think we should focus on Javassist.
>>
>> On 12 mai 2010, at 03:14, Steve Ebersole wrote:
>>
>>> I thought one of the issues was that cglib does not handle  
>>> annotations?  That's a pretty big 'workaround' if that's the case.
>>>
>>>
>>> -- Sent from my Palm Pre
>>> st...@hibernate.org
>>> http://hibernate.orgOn May 11, 2010 1:06 PM, Strong Liu  
>>>  wrote:
>>>
>>> these are the issues Steve mentioned below:
>>>
>>>
>>>
>>> http://opensource.atlassian.com/projects/hibernate/browse/HHH-4703
>>>
>>> https://jira.jboss.org/jira/browse/JBPAPP-2971
>>>
>>>
>>>
>>> to be fair, these issues can be workaround, and we already have  
>>> patches, users who run into these issues can pick up our patch for  
>>> cglib and rebuild it themselves.
>>>
>>>
>>>
>>>
>>>
>>>
>>>
>>> On May 11, 2010, at 10:34 PM, Hardy Ferentschik wrote:
>>>
>>>
>>>
>>> > Is there any advantage of CGLIB over javassist?
>>>
>>> >
>>>
>>> > On Tue, 11 May 2010 16:24:12 +0200, Steve Ebersole  
>>> 
>>>
>>> > wrote:
>>>
>>> >
>>>
>>> >> I think the time has come to drop CGLIB support :(  It is  
>>> just becoming
>>>
>>> >> near impossible to get them to respond to issues.  We even  
>>> recently sent
>>>
>>> >> them 2 patches of major issues and still cannot get them to  
>>> apply the
>>>
>>> >> changes upstream and cut releases.
>>>
>>> >>
>>>
>>> >> So that leaves us the choice of deprecating CGLIB support and  
>>> eventually
>>>
>>> >> dropping it altogether or forking it.  I personally do not  
>>> want to fork
>>>
>>> >> it, mainly because I do not want to have to maintain it.   
>>> Anyway lets
>>>
>>> >> discuss it this week if need be and we'll vote at the meeting  
>>> monday.
>>>
>>> >>
>>>
>>> >
>>>
>>> > ___
>>>
>>> > hibernate-dev mailing list
>>>
>>> > hibernate-dev@lists.jboss.org
>>>
>>> > https://lists.jboss.org/mailman/listinfo/hibernate-dev
>>>
>>>
>>>
>>>
>>> ___
>>> hibernate-dev mailing list
>>> hibernate-dev@lists.jboss.org
>>> https://lists.jboss.org/mailman/listinfo/hibernate-dev
>>
>

___
hibernate-dev mailing list
hibernate-dev@lists.jboss.org
https://lists.jboss.org/mailman/listinfo/hibernate-dev

[hibernate-dev] identify to join irc

[Hardy Ferentschik]

Hi,

is it just me or have we changed the #hibernate-dev channel settings to  
enforce identification towards
irc.freenode.net in order to join the channel? I cannot join anymore  
unless I identify myself.

If this is a changed policy we should mention it here -  
http://www.hibernate.org/community/irc.html


--Hardy

___
hibernate-dev mailing list
hibernate-dev@lists.jboss.org
https://lists.jboss.org/mailman/listinfo/hibernate-dev