Re: [hibernate-dev] publishing testsuite jars for Hibernate Search
My problem with that is that we don't spend as much energy as we do for the core product on API stability. We should clearly mark these as non stable APIs. Aside from that, feel free to go. Maybe we should split the helper bits in a dedicated submodule once we have a multi module Hibernate Search. On 14 mars 2010, at 20:51, Sanne Grinovero wrote: > Hello, > while writing tests for Infinispan I would like to be able to depend > on Hibernate Search's testsuite, as it contains several helpers which > I would use. > This happened me on other projects too, quite always if Lucene is involved. > > Would you be ok in publishing the maven artifacts of the testsuite too? > Infinispan is doing that for core, and it's nice to have general > testing utilities available on the test classpath of other modules; > It's probably going to be required anyway wen modularizing Hibernate Search. > > I have the local changes ready, just need an ok for commit; it only > implies some additional entries for the configuration of > maven-jar-plugin. > > Cheers, > Sanne > ___ > hibernate-dev mailing list > hibernate-dev@lists.jboss.org > https://lists.jboss.org/mailman/listinfo/hibernate-dev ___ hibernate-dev mailing list hibernate-dev@lists.jboss.org https://lists.jboss.org/mailman/listinfo/hibernate-dev
Re: [hibernate-dev] publishing testsuite jars for Hibernate Search
you're right, but how should I "mark these as non stable APIs" ? These artifacts are not included in the main jar, so if somebody wants to depend on them they are supposed to know what they're doing. I've created HSEARCH-467 and the pom change is committed - I'll keep it open to apply some warning you might want to add somewhere. We can write something in the Manifest, but that's not likely to be read, WDYT? Sanne 2010/3/15 Emmanuel Bernard : > My problem with that is that we don't spend as much energy as we do for the > core product on API stability. We should clearly mark these as non stable > APIs. > Aside from that, feel free to go. Maybe we should split the helper bits in a > dedicated submodule once we have a multi module Hibernate Search. > > On 14 mars 2010, at 20:51, Sanne Grinovero wrote: > >> Hello, >> while writing tests for Infinispan I would like to be able to depend >> on Hibernate Search's testsuite, as it contains several helpers which >> I would use. >> This happened me on other projects too, quite always if Lucene is involved. >> >> Would you be ok in publishing the maven artifacts of the testsuite too? >> Infinispan is doing that for core, and it's nice to have general >> testing utilities available on the test classpath of other modules; >> It's probably going to be required anyway wen modularizing Hibernate Search. >> >> I have the local changes ready, just need an ok for commit; it only >> implies some additional entries for the configuration of >> maven-jar-plugin. >> >> Cheers, >> Sanne >> ___ >> hibernate-dev mailing list >> hibernate-dev@lists.jboss.org >> https://lists.jboss.org/mailman/listinfo/hibernate-dev > > ___ hibernate-dev mailing list hibernate-dev@lists.jboss.org https://lists.jboss.org/mailman/listinfo/hibernate-dev
Re: [hibernate-dev] publishing testsuite jars for Hibernate Search
Just giving everyone the heads up that I an planning to do the Search build refactoring, starting probably later today or latest tomorrow. I don't think that it will be hard to merge any outstanding changes you have into the new layout, but in case you think you need more time to check something in let me know. --Hardy On Mon, 15 Mar 2010 07:49:27 -0300, Sanne Grinovero wrote: > you're right, but how should I "mark these as non stable APIs" ? > These artifacts are not included in the main jar, so if somebody wants > to depend on them they are supposed to know what they're doing. > > I've created HSEARCH-467 and the pom change is committed - I'll keep > it open to apply some warning you might want to add somewhere. > > We can write something in the Manifest, but that's not likely to be > read, WDYT? > > Sanne > > 2010/3/15 Emmanuel Bernard : >> My problem with that is that we don't spend as much energy as we do for >> the core product on API stability. We should clearly mark these as non >> stable APIs. >> Aside from that, feel free to go. Maybe we should split the helper bits >> in a dedicated submodule once we have a multi module Hibernate Search. ___ hibernate-dev mailing list hibernate-dev@lists.jboss.org https://lists.jboss.org/mailman/listinfo/hibernate-dev
Re: [hibernate-dev] publishing testsuite jars for Hibernate Search
IMO the best approach is a separate module for the test helper/infrastructure bits. This is what we do in core with the hibernate-test module as opposed to the hibernate-testsuite module. To me it makes the intent clearer. If I see including a testuite (test-jar artifact) I immediately think inclusion of those tests for running. On 03/14/2010 02:51 PM, Sanne Grinovero wrote: > Hello, > while writing tests for Infinispan I would like to be able to depend > on Hibernate Search's testsuite, as it contains several helpers which > I would use. > This happened me on other projects too, quite always if Lucene is involved. > > Would you be ok in publishing the maven artifacts of the testsuite too? > Infinispan is doing that for core, and it's nice to have general > testing utilities available on the test classpath of other modules; > It's probably going to be required anyway wen modularizing Hibernate Search. > > I have the local changes ready, just need an ok for commit; it only > implies some additional entries for the configuration of > maven-jar-plugin. > > Cheers, > Sanne > ___ > hibernate-dev mailing list > hibernate-dev@lists.jboss.org > https://lists.jboss.org/mailman/listinfo/hibernate-dev -- st...@hibernate.org http://hibernate.org ___ hibernate-dev mailing list hibernate-dev@lists.jboss.org https://lists.jboss.org/mailman/listinfo/hibernate-dev
[hibernate-dev] [HV] Ability to apply constraint on elements of an Iterable instance
Hi there, Emmanuel and I had a discussion regarding a use case given in http://opensource.atlassian.com/projects/hibernate/browse/HV-264 What if you have a list of strings and want to make sure that each string is a valid email. Something like this (@Valid is not helping here either): @Email List emails ; Initially I thought the problem could be quite easily solved by a custom ConstraintValidator>, but as it turns out there are issues with generating the right property path for invalid emails using the current ConstraintValidatorContext API. Besides a custom ConstraintValidator would only be a specific solution for a general problem. Hence, Emmanuel and I discussed some solutions and summarized them on http://opensource.atlassian.com/projects/hibernate/browse/BVAL-202 and http://opensource.atlassian.com/projects/hibernate/browse/HV-296 It would be great to get some feedback. --Hardy ___ hibernate-dev mailing list hibernate-dev@lists.jboss.org https://lists.jboss.org/mailman/listinfo/hibernate-dev
Re: [hibernate-dev] publishing testsuite jars for Hibernate Search
I agree. A separate module is the best approach. I will go for that approach. On Mon, 15 Mar 2010 11:35:02 -0300, Steve Ebersole wrote: > IMO the best approach is a separate module for the test > helper/infrastructure bits. This is what we do in core with the > hibernate-test module as opposed to the hibernate-testsuite module. > > To me it makes the intent clearer. If I see including a testuite > (test-jar artifact) I immediately think inclusion of those tests for > running. ___ hibernate-dev mailing list hibernate-dev@lists.jboss.org https://lists.jboss.org/mailman/listinfo/hibernate-dev
