building kodi fails on hydra
The kodi build on hydra fails due to seemingly random test failures: 2 to 4 of its 516 tests tend to fail due to a segfault, and it seems like different tests fail at each build attempt: http://hydra.gnu.org/build/1971604 http://hydra.gnu.org/build/1973068 http://hydra.gnu.org/build/1973406 It builds fine on my laptop. Does anybody have an idea what might cause this problem (could it be a hydra resource shortage)? Does it make sense to restart the build once again? Thomas
about gimp-console.1
find-files: /gnu/store/p10lw87jcqa9q3fnf5pfd9d8gcn2dy4l-gimp-2.8.18/share/man/man1/gimp-console.1: No such file or directory --
Re: gnu: add you-get
Hi Feng Shu, Thanks or contributing to Guix ! This patch for you-download is almost good, just a few notes: +(define-public you-get + (package +(name "you-get") +(version "0.4.652") +(source (origin + (method url-fetch) + (uri (string-append +"https://github.com/soimort/you-get/releases/download/v"; +version "/you-get-" version ".tar.gz")) + (sha256 + (base32 +"0brkz98lycx8mmxjwmn7jlhqfdbvl0hy070n7skwr1k75kh99q30" +(build-system python-build-system) +(arguments '(#:tests? #f)) In the source code I can find no tests. But a comment about tests absence, here, would be preferable. Would you mind to add it ? Also, on the home page of this project I see that Ffmpeg or libva are dependencies but the are no inputs or propagated inputs in this package definition I didn't try to run this package but I suppose it won't run properly. Am I wrong ? +(synopsis "Download videos, audios or images from the websites") +(description + "you-get is a tiny command-line utility, which can download media +contents (videos, audios, images) from the Web, in case there is no other +handy way to do it.") +(home-page "https://you-get.org/";) +(license license:expat))) I downloaded the tarball from git and the source files in the folder "cli_wrapper" are empty. Both Gedit and nano can read no lines Some files have a size of 0 Others are extremely small I don't know what this could be. Can you confirm that instead they are correctly written ? Or are they empty or you too ? Also, you should add a line about copyright attribution to yourself. At the beginning of the file there are many lines like this ;;; Copyright © 2017 humanitiesNerd You should add one or yourself. As you can see, niknames are ok ;-) Would you send a new patch with these suggestions integrated ? Thanks and welcome !
Re: gnu: add you-get
I forgot one last note ! Guix has a brand new issue tracker ! In the future would you send your patches to guix-patc...@gnu.org ? Thanks again ! 2017-04-08 10:55 GMT+02:00 Catonano : > Hi Feng Shu, > > Thanks or contributing to Guix ! > > This patch for you-download is almost good, just a few notes: > > +(define-public you-get > + (package > +(name "you-get") > +(version "0.4.652") > +(source (origin > + (method url-fetch) > + (uri (string-append > +"https://github.com/soimort/ > you-get/releases/download/v" > +version "/you-get-" version ".tar.gz")) > + (sha256 > + (base32 > +"0brkz98lycx8mmxjwmn7jlhqfdbvl0hy070n7skwr1k75kh99q30" > > +(build-system python-build-system) > +(arguments '(#:tests? #f)) > > In the source code I can find no tests. But a comment about tests absence, > here, would be preferable. > > Would you mind to add it ? > > Also, on the home page of this project I see that Ffmpeg or libva are > dependencies but the are no inputs or propagated inputs in this package > definition > > I didn't try to run this package but I suppose it won't run properly. > Am I wrong ? > > +(synopsis "Download videos, audios or images from the websites") > +(description > + "you-get is a tiny command-line utility, which can download media > +contents (videos, audios, images) from the Web, in case there is no other > +handy way to do it.") > +(home-page "https://you-get.org/";) > +(license license:expat))) > > I downloaded the tarball from git and the source files in the folder > "cli_wrapper" are empty. > > Both Gedit and nano can read no lines > > Some files have a size of 0 > Others are extremely small > > I don't know what this could be. > > Can you confirm that instead they are correctly written ? > > Or are they empty or you too ? > > Also, you should add a line about copyright attribution to yourself. > At the beginning of the file there are many lines like this > > ;;; Copyright © 2017 humanitiesNerd > > You should add one or yourself. > As you can see, niknames are ok ;-) > > Would you send a new patch with these suggestions integrated ? > > Thanks and welcome ! > > >
[PATCH 1/2] gnu: hurd: Add hurd-source-url procedure.
From: Manolis Ragkousis * gnu/packages/hurd.scm (hurd-source-url): New procedure. (hurd-headers)[source]: Adjust accordingly. --- gnu/packages/hurd.scm | 7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/gnu/packages/hurd.scm b/gnu/packages/hurd.scm index b5da4cb96..12fce5453 100644 --- a/gnu/packages/hurd.scm +++ b/gnu/packages/hurd.scm @@ -39,6 +39,10 @@ (string-append "mirror://gnu/gnumach/gnumach-" version ".tar.gz")) +(define (hurd-source-url version) + (string-append "mirror://gnu/hurd/hurd-" + version ".tar.gz")) + (define-public gnumach-headers (package (name "gnumach-headers") @@ -113,8 +117,7 @@ communication.") (version "0.9") (source (origin (method url-fetch) - (uri (string-append "mirror://gnu/hurd/hurd-" - version ".tar.gz")) + (uri (hurd-source-url version)) (sha256 (base32 "1nw9gly0n7pyv3cpfm4mmxy4yccrx4g0lyrvd3vk2vil26jpbggw" -- 2.12.1
[PATCH 2/2] gnu: Add the Hurd.
From: Manolis Ragkousis
* gnu/packages/hurd.scm (hurd): New variable.
* gnu/packages/patches/hurd-fix-eth-multiplexer-dependency.patch: New file.
* gnu/local.mk (dist_patch_DATA): Add it.
---
gnu/local.mk | 1 +
gnu/packages/hurd.scm | 43 ++
.../hurd-fix-eth-multiplexer-dependency.patch | 26 +
3 files changed, 70 insertions(+)
create mode 100644
gnu/packages/patches/hurd-fix-eth-multiplexer-dependency.patch
diff --git a/gnu/local.mk b/gnu/local.mk
index 5da359037..81beea4ba 100644
--- a/gnu/local.mk
+++ b/gnu/local.mk
@@ -650,6 +650,7 @@ dist_patch_DATA =
\
%D%/packages/patches/higan-remove-march-native-flag.patch\
%D%/packages/patches/hop-linker-flags.patch \
%D%/packages/patches/hubbub-sort-entities.patch \
+ %D%/packages/patches/hurd-fix-eth-multiplexer-dependency.patch\
%D%/packages/patches/hydra-disable-darcs-test.patch \
%D%/packages/patches/hypre-doc-tables.patch \
%D%/packages/patches/hypre-ldflags.patch \
diff --git a/gnu/packages/hurd.scm b/gnu/packages/hurd.scm
index 12fce5453..e3f50ee06 100644
--- a/gnu/packages/hurd.scm
+++ b/gnu/packages/hurd.scm
@@ -245,3 +245,46 @@ Hurd-minimal package which are needed for both glibc and
GCC.")
(description
"GNU Mach is the microkernel upon which a GNU Hurd system is based.")
(license gpl2+)))
+
+(define-public hurd
+ (package
+(name "hurd")
+(version "0.9")
+(source (origin
+ (method url-fetch)
+ (uri (hurd-source-url version))
+ (sha256
+ (base32
+"1nw9gly0n7pyv3cpfm4mmxy4yccrx4g0lyrvd3vk2vil26jpbggw"))
+ (patches (search-patches
"hurd-fix-eth-multiplexer-dependency.patch"
+(arguments
+ `(#:phases
+ (modify-phases %standard-phases
+ (add-before 'build 'pre-build
+ (lambda _
+ ;; Don't change the ownership of any file at this time.
+ (substitute* "daemons/Makefile"
+ (("-o root -m 4755") ""))
+ (substitute* "utils/Makefile"
+ (("-o root -m 4755") ""))
+ #t)))
+ #:configure-flags (list (string-append "LDFLAGS=-Wl,-rpath="
+ %output "/lib")
+ "--disable-ncursesw"
+ "--without-libbz2"
+ "--without-libz"
+ "--without-parted")))
+(build-system gnu-build-system)
+(inputs `(("glibc-hurd-headers" ,glibc/hurd-headers)))
+(native-inputs
+ `(("mig" ,mig)
+ ("perl" ,perl)))
+(supported-systems %hurd-systems)
+(home-page "https://www.gnu.org/software/hurd/hurd.html";)
+(synopsis "The kernel servers for the GNU operating system")
+(description
+ "The Hurd is the kernel for the GNU system, a replacement and
+augmentation of standard Unix kernels. It is a collection of protocols for
+system interaction (file systems, networks, authentication), and servers
+implementing them.")
+(license gpl2+)))
diff --git a/gnu/packages/patches/hurd-fix-eth-multiplexer-dependency.patch
b/gnu/packages/patches/hurd-fix-eth-multiplexer-dependency.patch
new file mode 100644
index 0..4a4b9c634
--- /dev/null
+++ b/gnu/packages/patches/hurd-fix-eth-multiplexer-dependency.patch
@@ -0,0 +1,26 @@
+From def663310ba75c46a6345983e9480abc425b1c94 Mon Sep 17 00:00:00 2001
+From: Manolis Ragkousis
+Date: Sat, 8 Apr 2017 16:25:14 +0300
+Subject: [PATCH] eth-multiplexer: Fix iohelp missing dependency.
+
+* eth-multiplexer/Makefile (HURDLIBS): Add iohelp.
+---
+ eth-multiplexer/Makefile | 2 +-
+ 1 file changed, 1 insertion(+), 1 deletion(-)
+
+diff --git a/eth-multiplexer/Makefile b/eth-multiplexer/Makefile
+index 07f909e7..cefa0abd 100644
+--- a/eth-multiplexer/Makefile
b/eth-multiplexer/Makefile
+@@ -26,7 +26,7 @@ MIGSFLAGS = -imacros $(srcdir)/mig-mutate.h
+ device-MIGSFLAGS="-DMACH_PAYLOAD_TO_PORT=ports_payload_get_name"
+ OBJS = $(SRCS:.c=.o) $(MIGSTUBS)
+ LCLHDRS = ethernet.h util.h vdev.h netfs_impl.h
+-HURDLIBS = ports ihash fshelp shouldbeinlibc netfs bpf
++HURDLIBS = ports ihash iohelp fshelp shouldbeinlibc netfs bpf
+ LDLIBS = -lpthread
+
+ CFLAGS += -I$(top_srcdir)/libbpf
+--
+2.12.1
+
--
2.12.1
Re: [PATCH] gnu: grep: Fix for gnulib library.
Hello Rene, I pushed the patch to core-updates. Thank you, Manolis
tor package: reconsider --with-openbsd-malloc
A while back I introduced the hardening flags to the tor package. TGR wrote about an additional option, --with-openbsd-malloc, which can be used[0]. Now I know that some (or only one?) of the settings I introduced will be dropped again (after a long time) in one of the next releases of tor. My "tor" process on clients in htop displays a constant 20.0T for the virtual size, a resident size of around 525M, and in fact only 464(M?) of the 20.0T are sharable. If we would compile tor with openbsd malloc, we would have more cpu load but apparently the process would be easier on the RAM. I would be surprised if anyone is running a relay (non-exit, exit) with GuixSD or tor from Guix already, but if you do and you can speak out about it without facing issues for making it publicly known, your advice is welcome. You can also contact me offlist, my keys can be found on https://people.pragmatique.xyz/ng0/ or on the sks keyservers. If no one replies within a sufficient timeframe of 4 weeks, I will go ahead and create a patch for what TGR adviced back then. Of course I'm also interested in the opion of those who just use it as a client. 0: https://lists.gnu.org/archive/html/guix-devel/2017-01/msg02306.html
Re: ‘core-updates’ schedule
On Fri, Apr 07, 2017 at 05:22:13PM +0200, Ludovic Courtès wrote: > Leo Famulari skribis: > > On Thu, Apr 06, 2017 at 10:34:29AM +0200, Ludovic Courtès wrote: > >> Last but not least: who wants to be the timekeeper? The position mostly > >> consists in firmly reminding people of the schedule. :-) > > > > I tried to do it this time around, but we kept finding bugs and > > experiencing build failures that we couldn't ignore. > > My thought was that fixing specific dates might help get everyone > psychologically prepared and ready to focus on stabilizing the branch > when the time comes. Agreed, we should try to stick to your suggested schedule this time. I'm not trying to discourage anyone :) Just sharing my experience of what sort of problems we can expect, for those who haven't paid close attention to a core-updates cycle before.
Why did INFO disappear in 13e4a6c86 * gnu: screen: Update to 4.5.1?
Hi Efraim & Leo, gnu screen 4.5.0 has INFO ... /gnu/store/bxnzlqz31011w3rf04bvg03agz15s4dw-screen-4.5.0/share/info: -r--r--r-- 3 root root 74621 Dec 31 1969 screen.info.gz ... but 4.5.1 doesn't ... /gnu/store/3si822dbkwnr4y71imwzgx9r3sx2q8cp-screen-4.5.1/share/info: I can't figure out how/why it disappeared. Any idea how to get it back? TIA - George
Re: Why did INFO disappear in 13e4a6c86 * gnu: screen: Update to 4.5.1?
Please ignore. I see the problem ... https://mirror.hydra.gnu.org/log/3si822dbkwnr4y71imwzgx9r3sx2q8cp-screen-4.5.1 [...] ./screen.texinfo:5799: unknown command `suse' ./screen.texinfo:5800: unknown command `deuxchevaux' make[2]: *** [Makefile:31: screen.info] Error 1 [...] ... and it has been reported upstream ... http://lists.gnu.org/archive/html/screen-devel/2017-03/msg0.html ... so sorry for the chatter ... ... but happy to discover hydra build logs ;-) On 04/08/2017 at 18:10 myglc2 writes: > Hi Efraim & Leo, > > gnu screen 4.5.0 has INFO ... > > /gnu/store/bxnzlqz31011w3rf04bvg03agz15s4dw-screen-4.5.0/share/info: > -r--r--r-- 3 root root 74621 Dec 31 1969 screen.info.gz > > ... but 4.5.1 doesn't ... > > /gnu/store/3si822dbkwnr4y71imwzgx9r3sx2q8cp-screen-4.5.1/share/info: > > I can't figure out how/why it disappeared. Any idea how to get it back? > > TIA - George
Re: 04/06: profiles: Generate database file for man pages.
On Wed, Apr 05, 2017 at 04:56:39PM -0400, Ludovic Court�s wrote: > civodul pushed a commit to branch master > in repository guix. > > commit a0b87ef8ec7735aa42cf35d380e9cff04f3236f3 > Author: Maxim Cournoyer > Date: Wed Apr 5 01:09:22 2017 -0700 > > profiles: Generate database file for man pages. > > The mandb database file (index.db) is used by the "apropos" (whatis) or > "man -k" commands. This change introduces a profile hook to generate > such database file. > > * guix/profiles.scm (manual-database): New procedure. > (%default-profile-hooks): Add it. > > Co-authored-by: Ludovic Courtès Recently, I notice messages like this when doing profile operations: [...] creating manual page database for 49 packages... find-files: /gnu/store/0y3qrzzwfxf601g885967wcringvnw69-gimp-2.8.18/share/man/man1/gimp-console.1: No such file or directory [...] The file in question is a symlink: $ ls -l /gnu/store/0y3qrzzwfxf601g885967wcringvnw69-gimp-2.8.18/share/man/man1/gimp-console.1 lrwxrwxrwx 5 root root 21 Dec 31 1969 /gnu/store/0y3qrzzwfxf601g885967wcringvnw69-gimp-2.8.18/share/man/man1/gimp-console.1 -> gimp-console-2.8.1.gz
Re: Why did INFO disappear in 13e4a6c86 * gnu: screen: Update to 4.5.1?
On Sat, Apr 08, 2017 at 02:54:56PM -0400, myglc2 wrote: > Please ignore. I see the problem ... > > https://mirror.hydra.gnu.org/log/3si822dbkwnr4y71imwzgx9r3sx2q8cp-screen-4.5.1 > [...] > ./screen.texinfo:5799: unknown command `suse' > ./screen.texinfo:5800: unknown command `deuxchevaux' > make[2]: *** [Makefile:31: screen.info] Error 1 > [...] > > ... and it has been reported upstream ... > > http://lists.gnu.org/archive/html/screen-devel/2017-03/msg0.html > > ... so sorry for the chatter ... > > ... but happy to discover hydra build logs ;-) Fixed in ea240de4af85ae8ecc0c1afcd4778e01a88e6f5c. Thanks for the report and investigation!
Having trouble packaging DefaultEncrypt for Emacs
Hi,
I'm trying to package DefaultEncrypt:
https://www.emacswiki.org/emacs/DefaultEncrypt
I've made a package definition (see attached patch), and it builds
without error. I've installed it into my user profile. Per the
documentation, I've added the following to my ~/.emacs:
(require 'jl-encrypt)
However, when I start Emacs, I get the following warning:
--8<---cut here---start->8---
Warning (initialization): An error occurred while loading
‘/home/marusich/.emacs’:
File error: Cannot open load file, No such file or directory, jl-encrypt
--8<---cut here---end--->8---
Why is this happening? How can I fix it? I'm still a bit of an Emacs
newbie, so maybe there's an obvious solution I'm unaware of.
I've also noticed that the elisp file gets installed with the name
"jl-encrypt.el.el", which seems weird, but I don't know if that's
related to the preceding issue:
--8<---cut here---start->8---
$ tree -a $(./pre-inst-env guix build --rounds=2 --keep-failed
emacs-default-encrypt)
/gnu/store/3dcbalb6zgc7a7iizni3hyzy6llb6c6p-emacs-default-encrypt-4.3
└── share
└── emacs
└── site-lisp
└── guix.d
└── default-encrypt-4.3
├── default-encrypt-autoloads.el
├── jl-encrypt.el.el
└── jl-encrypt.el.elc
--8<---cut here---end--->8---
Why does the ".el" suffix appear twice? Is it causing the preceding
problem? I tried changing
(require 'jl-encrypt)
to
(require 'jl-encrypt.el)
but it didn't fix the problem.
I don't know why the require statement is failing, and I don't know why
the elisp file is being installed with an ".el.el" suffix. I'd love to
use this module and package it for everyone, so if you have any advice,
please let me know. Thank you in advance!
--
Chris
From f77c1b669d91fb5ff4421da544fb2e6870ff9f56 Mon Sep 17 00:00:00 2001
From: Chris Marusich
Date: Sat, 8 Apr 2017 15:16:52 -0700
Subject: [PATCH] gnu: Add emacs-default-encrypt.
* gnu/packages/emacs.scm (emacs-default-encrypt): New variable.
---
gnu/packages/emacs.scm | 27 +++
1 file changed, 27 insertions(+)
diff --git a/gnu/packages/emacs.scm b/gnu/packages/emacs.scm
index 3db31f207..63d9da03e 100644
--- a/gnu/packages/emacs.scm
+++ b/gnu/packages/emacs.scm
@@ -4057,3 +4057,30 @@ jQuery and Bootstrap resources included via osscdn.")
(description
"This Emacs package highlights the s-exp at the current position.")
(license license:gpl3+)))
+
+(define-public emacs-default-encrypt
+ (package
+(name "emacs-default-encrypt")
+(version "4.3")
+(source
+ (origin
+ (method url-fetch)
+ (uri (string-append
+ ;; A versioned, signed copy of this package is avialable on the
+ ;; home page, but 'guix download' fails to download it.
+ "https://github.com/emacsmirror/emacswiki.org/raw/master/jl-encrypt.el";))
+ (sha256
+(base32
+ "16i3rlfp3jxlqvndn8idylhmczync3gwmy8a019v29vyr48rnnr0"
+(build-system emacs-build-system)
+(home-page "https://www.informationelle-selbstbestimmung-im-internet.de/Emacs.html";)
+(synopsis "Automatically encrypt and sign Gnus messages")
+(description
+ "DefaultEncrypt is designed to be used with Gnus. It automatically
+encrypts messages that you send (e.g., email) when public keys for all
+recipients are available, and it protects you from accidentally sending
+un-encrypted messages. It can also be configured to automatically sign
+messages that you send. For details and instructions on how to use
+DefaultEncrypt, please refer to the home page or read the comments in the
+source file, @file{jl-encrypt.el}.")
+(license license:gpl3+)))
--
2.12.0
signature.asc
Description: PGP signature
Re: gnu: add leafpad
On Sat, Apr 08, 2017 at 12:16:40PM +0800, Feng Shu wrote: > From 54c338b9bfe96cead2663506b55493d156e816dc Mon Sep 17 00:00:00 2001 > From: Feng Shu > Date: Sat, 8 Apr 2017 12:13:41 +0800 > Subject: [PATCH] gnu: add leafpad Thanks! Pushed as 0bf11648fc90cf0689fdc674f4aee4592694b341 with the following changes: > * gnu/packages/leafpad.scm (gnu): Add leafpad.scm file I moved it to gnu/packages/text-editors.scm. > + (uri (string-append > "http://http.debian.net/debian/pool/main/l/"; > + name "/" name "_" version ".orig.tar.gz")) I used the upstream source URL instead of fetching the source from Debian. > +(home-page "https://wiki.gnome.org/Apps/Gedit";) I fixed this URL in a subsequent commit (I missed it at first, or I would have made the change in the original commit. > +(synopsis "GTK+ based simple text editor ") > +(description "Leafpad is a simple GTK+ text editor that emphasizes > simplicity. > +As development focuses on keeping weight down to a minimum, only the most > essential > +features are implemented in the editor. Leafpad is simple to use, is easily > compiled, > +requires few libraries, and starts up quickly. ") Minor changes here. signature.asc Description: PGP signature
Use OpenSSH in the bare-bones GuixSD template [was Re: how to "install" guixsd on a digitalocean server]
On Fri, Apr 07, 2017 at 09:57:56PM +0200, Ludovic Courtès wrote: > Leo Famulari skribis: > > > On Fri, Apr 07, 2017 at 02:07:16PM +0200, Andy Wingo wrote: > >> (3) Why do we promote lsh by default? It took me quite some looking to > >> figure out why my authorized_keys wasn't working. The fix was to > >> just use OpenSSH. > > > > lsh is a GNU project and we did not have an OpenSSH service until a few > > months ago. I'm in favor of changing the OS declaration templates to use > > OpenSSH. > > I agree with this change (lsh upstream hasn’t been receiving the > attention I was hoping for.) Here's a patch for discussion.
Re: Use OpenSSH in the bare-bones GuixSD template [was Re: how to "install" guixsd on a digitalocean server]
On Sat, Apr 08, 2017 at 09:42:17PM -0400, Leo Famulari wrote: > On Fri, Apr 07, 2017 at 09:57:56PM +0200, Ludovic Courtès wrote: > > Leo Famulari skribis: > > > > > On Fri, Apr 07, 2017 at 02:07:16PM +0200, Andy Wingo wrote: > > >> (3) Why do we promote lsh by default? It took me quite some looking to > > >> figure out why my authorized_keys wasn't working. The fix was to > > >> just use OpenSSH. > > > > > > lsh is a GNU project and we did not have an OpenSSH service until a few > > > months ago. I'm in favor of changing the OS declaration templates to use > > > OpenSSH. > > > > I agree with this change (lsh upstream hasn’t been receiving the > > attention I was hoping for.) > > Here's a patch for discussion. And the patch... >From bac586572af3fdc720f1ff2c873864fd4c1ebf05 Mon Sep 17 00:00:00 2001 From: Leo Famulari Date: Sat, 8 Apr 2017 21:38:54 -0400 Subject: [PATCH] doc: Use OpenSSH instead of lsh in bare-bones template. * gnu/system/examples/bare-bones.tmpl (services): Use openssh-service-type instead of lsh-service. --- gnu/system/examples/bare-bones.tmpl | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/gnu/system/examples/bare-bones.tmpl b/gnu/system/examples/bare-bones.tmpl index 222ddda57..f7b8823d4 100644 --- a/gnu/system/examples/bare-bones.tmpl +++ b/gnu/system/examples/bare-bones.tmpl @@ -43,5 +43,7 @@ ;; Add services to the baseline: a DHCP client and ;; an SSH server. (services (cons* (dhcp-client-service) - (lsh-service #:port-number ) + (service openssh-service-type +(openssh-configuration + (port-number ))) %base-services))) -- 2.12.2
Re: [PATCH 2/2] gnu: Add the Hurd.
On Sat, Apr 08, 2017 at 05:06:57PM +0300, manolis...@gmail.com wrote:
> From: Manolis Ragkousis
>
> + (modify-phases %standard-phases
> + (add-before 'build 'pre-build
> + (lambda _
> + ;; Don't change the ownership of any file at this
> time.
> + (substitute* "daemons/Makefile"
> + (("-o root -m 4755") ""))
> + (substitute* "utils/Makefile"
> + (("-o root -m 4755") ""))
> + #t)))
These substitute* lines could be written as:
(substitute* '("daemons/Makefile" "utils/Makefile")
(("-o root -m 4775") ""))
--
Efraim Flashner אפרים פלשנר
GPG key = A28B F40C 3E55 1372 662D 14F7 41AA E7DC CA3D 8351
Confidentiality cannot be guaranteed on emails sent or received unencrypted
signature.asc
Description: PGP signature
Re: [PATCH 2/2] gnu: Add the Hurd.
Hello Efraim,
On 04/09/17 05:41, Efraim Flashner wrote:
> On Sat, Apr 08, 2017 at 05:06:57PM +0300, manolis...@gmail.com wrote:
>> From: Manolis Ragkousis
>>
>> + (modify-phases %standard-phases
>> + (add-before 'build 'pre-build
>> + (lambda _
>> + ;; Don't change the ownership of any file at this
>> time.
>> + (substitute* "daemons/Makefile"
>> + (("-o root -m 4755") ""))
>> + (substitute* "utils/Makefile"
>> + (("-o root -m 4755") ""))
>> + #t)))
>
> These substitute* lines could be written as:
> (substitute* '("daemons/Makefile" "utils/Makefile")
> (("-o root -m 4775") ""))
>
Yes you are right. I will fix it and push to master. :)
Manolis
