Re: Emacs interface for Guix

[Alex Kost]

Ludovic Courtès (2014-07-26 00:36 +0400) wrote:

[...]

> Namely, (guix scripts package) needs to be made more modular, and the
> generic bits must be moved to (guix profiles).  Now that there’s a
> second consumer for this API, there’s more of an incentive to do it.
>
> I’m willing to help for that, but I’m happy if you give it a try.
> WDYT?

Sure, I'll do what I can, however the quality of my try may be
unsatisfactory.  Anyway I think I'll send a patch in several days.

--
Alex Kost

New Czech PO file for 'guix' (version 0.7-pre1)

[Translation Project Robot]

Hello, gentle maintainer.

This is a message from the Translation Project robot.

A revised PO file for textual domain 'guix' has been submitted
by the Czech team of translators.  The file is available at:

http://translationproject.org/latest/guix/cs.po

(We can arrange things so that in the future such files are automatically
e-mailed to you when they arrive.  Ask at the address below if you want this.)

All other PO files for your package are available in:

http://translationproject.org/latest/guix/

Please consider including all of these in your next release, whether
official or a pretest.

Whenever you have a new distribution with a new version number ready,
containing a newer POT file, please send the URL of that distribution
tarball to the address below.  The tarball may be just a pretest or a
snapshot, it does not even have to compile.  It is just used by the
translators when they need some extra translation context.

The following HTML page has been updated:

http://translationproject.org/domain/guix.html

If any question arises, please contact the translation coordinator.

Thank you for all your work,

The Translation Project robot, in the
name of your translation coordinator.

Re: Emacs interface for Guix

[Ludovic Courtès]

Alex Kost  skribis:

> (“package->manifest-entry” from “options->installable” would be very
> useful for example)

Commit 462f5cc makes it public.

Ludo’.

Re: [PATCH] gnu: Add orpheus.

[Ludovic Courtès]

Eric Bavier  skribis:

> From 9ffcb2c959be8187c11e5b9d9f29debba57b2c4a Mon Sep 17 00:00:00 2001
> From: Eric Bavier 
> Date: Thu, 24 Jul 2014 23:40:44 -0500
> Subject: [PATCH] gnu: Add orpheus.
>
> * gnu/packages/orpheus.scm: New file.
> * gnu/packages/patches/orpheus-cast-errors-and-includes.patch: New patch.
> * gnu-system.am (GNU_SYSTEM_MODULES): Add file.
>   (dist_patch_DATA): Add patch.

Looks good to me!

I wonder if one of (gnu packages mp3) or (gnu packages xiph) would be a
better home.  Perhaps both should be merged in (gnu packages music) or
similar?  (“audio” might be too vague since that could include support
libraries like ALSA.)

Ludo’.

Re: Things to do for 0.8

[Ludovic Courtès]

Another one:

  - httpd or similar installed on hydra.gnu.org, with caching for the
.narinfo pages, after which wip-http-pipelining can be merged.

Ludo’.

Re: [PATCH] gnu: Add texi2html.

[Ludovic Courtès]

Eric Bavier  skribis:

> From e2a9c7cd9015e0ff09b5b3918797b3a64394fea2 Mon Sep 17 00:00:00 2001
> From: Eric Bavier 
> Date: Fri, 25 Jul 2014 16:37:44 -0500
> Subject: [PATCH] gnu: Add texi2html.
>
> * gnu/packages/texinfo.scm (texi2html): New variable.
> * gnu/packages/patches/texi2html-document-encoding.patch: New patch.
> * gnu-system.am (dist_patch_DATA): Add it.

LGTM.

Does it provide any features, or does it have any uses not covered by
Texinfo 5.x?

Thanks,
Ludo’.

[PATCH] guix: Fix handling of periods by fill-paragraph.

[Cyrill Schenkel]

Hi.

This is a fix for the bug #17468.

>From 9fc7a445ad0249c0f4824b5f5338aa9aa6c16237 Mon Sep 17 00:00:00 2001
From: Cyrill Schenkel 
Date: Sun, 27 Jul 2014 00:00:09 +0200
Subject: [PATCH] guix: Fix handling of periods by fill-paragraph.

* guix/ui.scm (fill-paragraph): Two spaces after period and no spaces before newline.
---
 guix/ui.scm | 9 +++--
 1 file changed, 7 insertions(+), 2 deletions(-)

diff --git a/guix/ui.scm b/guix/ui.scm
index 9112d55..d8b0109 100644
--- a/guix/ui.scm
+++ b/guix/ui.scm
@@ -395,7 +395,9 @@ converted to a space; sequences of more than one line break are preserved."
  (else
   (let ((chars  (case newlines
   ((0) chars)
-  ((1) (cons #\space chars))
+  ((1)
+   (append (make-list (if (eqv? (car chars) #\.) 2 1)
+#\space) chars))
   (else
(append (make-list newlines #\newline) chars
 (column (case newlines
@@ -414,7 +416,10 @@ converted to a space; sequences of more than one line break are preserved."
   0
   ,(if (null? after)
before
-   (append before (cons #\newline (cdr after)
+   (append before
+   (cons #\newline
+ (drop-while (cut eqv? #\space <>)
+ after)
 `(,column 0 ,chars))) ; unbreakable
   `(,column 0 ,chars)
 
-- 
2.0.0

Re: [PATCH] guix: Fix handling of periods by fill-paragraph.

[Cyrill Schenkel]

Hi.

There was invalidly indented code in my previously sent patch.
So here's an updated version.
From 2dc0cb0eaafbcfce062f4d0acbc7e5cad200bfbf Mon Sep 17 00:00:00 2001
From: Cyrill Schenkel 
Date: Sun, 27 Jul 2014 00:03:16 +0200
Subject: [PATCH] guix: Fix handling of periods by fill-paragraph.

* guix/ui.scm (fill-paragraph): Two spaces after period and no spaces before newline.
---
 guix/ui.scm | 9 +++--
 1 file changed, 7 insertions(+), 2 deletions(-)

diff --git a/guix/ui.scm b/guix/ui.scm
index 9112d55..74d227d 100644
--- a/guix/ui.scm
+++ b/guix/ui.scm
@@ -395,7 +395,9 @@ converted to a space; sequences of more than one line break are preserved."
  (else
   (let ((chars  (case newlines
   ((0) chars)
-  ((1) (cons #\space chars))
+  ((1)
+   (append (make-list (if (eqv? (car chars) #\.) 2 1)
+  #\space) chars))
   (else
(append (make-list newlines #\newline) chars
 (column (case newlines
@@ -414,7 +416,10 @@ converted to a space; sequences of more than one line break are preserved."
   0
   ,(if (null? after)
before
-   (append before (cons #\newline (cdr after)
+   (append before
+   (cons #\newline
+ (drop-while (cut eqv? #\space <>)
+ after)
 `(,column 0 ,chars))) ; unbreakable
   `(,column 0 ,chars)
 
-- 
2.0.0

Re: [PATCH] guix: Fix handling of periods by fill-paragraph.

[Ludovic Courtès]

Cyrill Schenkel  skribis:

> From 2dc0cb0eaafbcfce062f4d0acbc7e5cad200bfbf Mon Sep 17 00:00:00 2001
> From: Cyrill Schenkel 
> Date: Sun, 27 Jul 2014 00:03:16 +0200
> Subject: [PATCH] guix: Fix handling of periods by fill-paragraph.
>
> * guix/ui.scm (fill-paragraph): Two spaces after period and no spaces before 
> newline.

Could you add a test in tests/ui.scm that demonstrates bug #17468?

Also please add “Fixes .” at the beginning of
the commit message.

Thanks,
Ludo’.

Re: [PATCH] guix: Fix handling of periods by fill-paragraph.

[Cyrill Schenkel]

l...@gnu.org (Ludovic Courtès) writes:

> Cyrill Schenkel  skribis:
>
>> From 2dc0cb0eaafbcfce062f4d0acbc7e5cad200bfbf Mon Sep 17 00:00:00 2001
>> From: Cyrill Schenkel 
>> Date: Sun, 27 Jul 2014 00:03:16 +0200
>> Subject: [PATCH] guix: Fix handling of periods by fill-paragraph.
>>
>> * guix/ui.scm (fill-paragraph): Two spaces after period and no spaces before 
>> newline.
>
> Could you add a test in tests/ui.scm that demonstrates bug #17468?
>
> Also please add “Fixes .” at the beginning of
> the commit message.

Done.

Regards

Cyrill

>From f4240f7a360650383b1820dfe2004a0a3e3ffe50 Mon Sep 17 00:00:00 2001
From: Cyrill Schenkel 
Date: Sun, 27 Jul 2014 00:53:16 +0200
Subject: [PATCH] guix: Fix handling of periods by fill-paragraph.

Fixes .

* guix/ui.scm (fill-paragraph): Two spaces after period and no spaces before newline.
* tests/ui.scm: New test case.
---
 guix/ui.scm  | 25 +++--
 tests/ui.scm |  5 +
 2 files changed, 20 insertions(+), 10 deletions(-)

diff --git a/guix/ui.scm b/guix/ui.scm
index 9112d55..f11c2e9 100644
--- a/guix/ui.scm
+++ b/guix/ui.scm
@@ -393,15 +393,17 @@ converted to a space; sequences of more than one line break are preserved."
  ((#\newline)
   `(,column ,(+ 1 newlines) ,chars))
  (else
-  (let ((chars  (case newlines
-  ((0) chars)
-  ((1) (cons #\space chars))
-  (else
-   (append (make-list newlines #\newline) chars
-(column (case newlines
-  ((0) column)
-  ((1) (+ 1 column))
-  (else 0
+  (let* ((spaces (if (and (pair? chars) (eqv? (car chars) #\.)) 2 1))
+ (chars  (case newlines
+   ((0) chars)
+   ((1)
+(append (make-list spaces #\space) chars))
+   (else
+(append (make-list newlines #\newline) chars
+ (column (case newlines
+   ((0) column)
+   ((1) (+ spaces column))
+   (else 0
 (let ((chars  (cons chr chars))
   (column (+ 1 column)))
   (if (> column width)
@@ -414,7 +416,10 @@ converted to a space; sequences of more than one line break are preserved."
   0
   ,(if (null? after)
before
-   (append before (cons #\newline (cdr after)
+   (append before
+   (cons #\newline
+ (drop-while (cut eqv? #\space <>)
+ after)
 `(,column 0 ,chars))) ; unbreakable
   `(,column 0 ,chars)
 
diff --git a/tests/ui.scm b/tests/ui.scm
index 4bf7a77..7cc0264 100644
--- a/tests/ui.scm
+++ b/tests/ui.scm
@@ -67,6 +67,11 @@ interface, and powerful string processing.")
10)
#\newline))
 
+(test-equal "fill-paragraph, two spaces after period"
+  "First line.  Second line"
+  (fill-paragraph "First line.
+Second line" 24))
+
 (test-equal "package-specification->name+version+output"
   '(("guile" #f "out")
 ("guile" "2.0.9" "out")
-- 
2.0.0