Re: [PATCH v1] SRFI-19: Add support for ISO 8601 zones with a colon.
Rob Browning writes: > Apologies for the delay, and good point. I should have used eqv? rather > than char=?, i.e. > > (let ((ch (read-char port))) >(if (eqv? ch #\:) >(set! ch (read-char port)) >(if (eof-object? ch) >(time-error 'string->date 'bad-date-template-string >(list "Invalid time zone number" ch))) >(set! ...)) Just checking back -- does that adjustment seem plausible to you? If so, I may adjust your patch and proceed with it. Thanks for the help -- Rob Browning rlb @defaultvalue.org and @debian.org GPG as of 2011-07-10 E6A9 DA3C C9FD 1FF8 C676 D2C4 C0F0 39E9 ED1B 597A GPG as of 2002-11-03 14DD 432F AE39 534D B592 F9A0 25C8 D377 8C7E 73A4
Re: [PATCH] eval-string: Fix setting port column
Nikita Domnitskii writes: > --- > module/ice-9/eval-string.scm | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/module/ice-9/eval-string.scm b/module/ice-9/eval-string.scm > index ea0f1..9cac03632 100644 > --- a/module/ice-9/eval-string.scm > +++ b/module/ice-9/eval-string.scm > @@ -81,7 +81,7 @@ >(if line >(set-port-line! port line)) >(if column > - (set-port-column! port line)) > + (set-port-column! port column)) > >(if (or compile? (not (language-evaluator lang))) >((load-thunk-from-memory Thanks - added a test and pushed to main. -- Rob Browning rlb @defaultvalue.org and @debian.org GPG as of 2011-07-10 E6A9 DA3C C9FD 1FF8 C676 D2C4 C0F0 39E9 ED1B 597A GPG as of 2002-11-03 14DD 432F AE39 534D B592 F9A0 25C8 D377 8C7E 73A4
