Re: [PATCH v3 1/3] Allow explicit module dependencies
Thu, 16 Nov 2023 16:37:38 +0100 Oliver Steffen : > +syminfo.lst: gensyminfo.sh kernel_syms.lst extra_deps.lst $(MODULE_FILES) > + cat kernel_syms.lst extra_deps.lst > $@.new There are rules to create gensyminfo.sh and kernel_syms.lst, but there is no rule to create extra_deps.lst. As a result out of tree builds fail with 154dcb1aea9f8fc42b2bce98bebed004d7783a7d. Olaf pgpEb1Ot5So72.pgp Description: Digitale Signatur von OpenPGP ___ Grub-devel mailing list Grub-devel@gnu.org https://lists.gnu.org/mailman/listinfo/grub-devel
Re: [PATCH v3 1/3] Allow explicit module dependencies
Hi Olaf, On Wed, Dec 06, 2023 at 09:19:06AM +0100, Olaf Hering wrote: > Thu, 16 Nov 2023 16:37:38 +0100 Oliver Steffen : > > > +syminfo.lst: gensyminfo.sh kernel_syms.lst extra_deps.lst $(MODULE_FILES) > > + cat kernel_syms.lst extra_deps.lst > $@.new > > There are rules to create gensyminfo.sh and kernel_syms.lst, but there is no > rule to create extra_deps.lst. > As a result out of tree builds fail with > 154dcb1aea9f8fc42b2bce98bebed004d7783a7d. I run build tests before push and did not spot any issues. Could you provide us exact steps to reproduce the problem? Daniel ___ Grub-devel mailing list Grub-devel@gnu.org https://lists.gnu.org/mailman/listinfo/grub-devel
Re: [PATCH v3 1/3] Allow explicit module dependencies
Wed, 6 Dec 2023 16:24:53 +0100 Daniel Kiper : > Could you provide us exact steps to reproduce the problem? Something like this? mkdir .b cd $_ ../grub-src-dir/configure [options] A brief look at the sources indicates the new file could be generated during build, with "echo content > $@". Olaf pgpAtPanA8Ihn.pgp Description: Digitale Signatur von OpenPGP ___ Grub-devel mailing list Grub-devel@gnu.org https://lists.gnu.org/mailman/listinfo/grub-devel
Re: [PATCH v3 1/3] Allow explicit module dependencies
On Wed, Dec 06, 2023 at 04:39:29PM +0100, Olaf Hering wrote: > Wed, 6 Dec 2023 16:24:53 +0100 Daniel Kiper : > > > Could you provide us exact steps to reproduce the problem? > > Something like this? > > mkdir .b > cd $_ > ../grub-src-dir/configure [options] Ugh, yeah, the file is missing in this case. Oliver, could you fix that? > A brief look at the sources indicates the new file could be generated during > build, with "echo content > $@". Or copy original file... But generation can be a bit more universal... Daniel ___ Grub-devel mailing list Grub-devel@gnu.org https://lists.gnu.org/mailman/listinfo/grub-devel
