Re: [PATCH v2] grub-core/net/http.c: Fix gcc-13 errors relating to type signedness

2023-12-01 Thread Daniel Kiper
On Wed, Nov 29, 2023 at 07:58:25PM +, Mate Kukri wrote:
> Replace definition of `HTTP_PORT` with a pre-processor macro that converts
> the constant to the correct type `grub_uint16_t`.
>
> Change the defintion of local variable `port` in `http_establish()` to
> have the same type.
>
> Signed-off-by: Mate Kukri 

Reviewed-by: Daniel Kiper 

Daniel

___
Grub-devel mailing list
Grub-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/grub-devel


Re: [PATCH v8 00/10] ppc64: Restrict memory allocations for kernel and initrd

2023-12-01 Thread Daniel Kiper
On Thu, Nov 30, 2023 at 09:17:14AM -0500, Stefan Berger wrote:
> This series of patches converts the PowerPC ieee1275 memory allocator
> for kernel and initrd to use the (PowerPC) regions_claim memory allocator
> that takes into account memory regions that are not allowed to be used,
> such as the gap between 640MB and 768MB as well as memory regions beyond
> an address in case an fadump is present. Otherwise those two could be
> loaded into restricted memory regions and either cause a crash or
> corruption of the fadump.
>
> I adjusted the kernel and initrd load in loader/powerpc/ieee1275 to use
> the new memory allocator only on PowerVM and PowerKVM since this code is
> shared with other platforms, such as old PowerMACs and i386.

For the patches which do not have my RB Reviewed-by: Daniel Kiper 
...

I will merge these patches next week.

Thanks,

Daniel

___
Grub-devel mailing list
Grub-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/grub-devel


Re: GRUB Coverity x86_64/EFI and ARM64/EFI runs - 0 outstanding defects

2023-12-01 Thread Daniel Kiper
On Tue, Nov 28, 2023 at 05:57:40PM +, Darren Kenny wrote:
>
> Hi Daniel,
>
> Great to know the target was reached.
>
> The last set of issues seemed to be a real challenge.
>
> You set a high bar as a maintainer, encouraging everyone towards a
> resolution and making GRUB all the better for it.
>
> Well done all!

Thank you!

Daniel

___
Grub-devel mailing list
Grub-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/grub-devel


Re: [PATCH v3 0/3] Bli: fix hidden module dependency

2023-12-01 Thread Daniel Kiper
On Thu, Nov 16, 2023 at 04:37:37PM +0100, Oliver Steffen wrote:
> The bli module has a hidden/implicit dependency on the part_gpt module.
> The part_gpt module has to be loaded before the bli module.
> This dependency is not picked up automatically by the build system
> because the bli module does not use any function of part_gpt. It just
> expects GRUB to be able to parse GPT formatted disks.
>
> This series introduces a mechanism that allows specifying module
> dependencies explicitly in a new file called extra_deps.lst.
>
> An explicit dependency is then added for the bli module on the part_gpt
> module and the documentation is improved.

For all patches Reviewed-by: Daniel Kiper ...

Daniel

___
Grub-devel mailing list
Grub-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/grub-devel