Re: [v5 PATCH 0/3] Unify ARM64 & RISC-V Linux Loader
On 22-10-10 22:26:26, Daniel Kiper wrote: > On Mon, Oct 10, 2022 at 11:12:16AM -0700, Atish Kumar Patra wrote: > > On Mon, Oct 10, 2022 at 7:54 AM Daniel Kiper wrote: > > On Fri, Oct 07, 2022 at 01:50:27AM -0700, Atish Patra wrote: > > > This series unifies the linux loader for ARM64 & RISC-V. The linux > > loader > > > for ARM64 is pretty much arch independent. Thus, this series just > > moves > > > it to the common directory and update the make files. > > > > > > This series is rebased on top of Ard's LoadFile2 series[1]. > > > > > > The unification effort was a little mess and I was to blame :(. > > > I started the effort but couldn't follow up after. Nikita picked it > > up > > > and rebased all the patches along with LoadFile2. > > > > > > However, Nikita did not follow up after v3 as well. Ard revised his > > > LoadFile2 series few weeks back. As the ocotober deadline for next > > grub > > > release is closing, I decided to rebase the patches so that RISC- > > V support > > > can be officially part of the release. Sorry for the mess/ > > confusion. > > > > No worries, I know how it works. Thank you for rebase. > > > > Ard, Atish, your patch series seem to conflict. I think I would > > review > > and take Atish first. Then Ard would need to rebase. Any objections? > > > > I have rebased this series on top of Ard's series already. So I think it > > would > > be easier if Ard's series > > is merged first. As this series has minimal changes, it won't take much > > time to > > rebase once again > > if required. > > Cool! Thanks a lot! > > Daniel Great, I hope the v4 and v5 patches are merged into the master branch soon. > ___ > Grub-devel mailing list > Grub-devel@gnu.org > https://lists.gnu.org/mailman/listinfo/grub-devel ___ Grub-devel mailing list Grub-devel@gnu.org https://lists.gnu.org/mailman/listinfo/grub-devel
Re: [PATCH] efi: compile kernel.img with -fshort-wchar on all EFI targets
On Tue, Oct 11, 2022 at 01:26:33PM +0100, Chris Coulson wrote: > The stack check logs a console message on failure, and the EFI API expects > a NULL terminated UCS-2 string. In order to define a UCS-2 string literal, > kernel.img on amd64 and i386 EFI targets is built with -fshort-wchar. > > Also compile kernel.img on other EFI targets with -fshort-wchar. > > Fixes: 37ddd94 (kern/efi/init: Log a console error during a stack check > failure) > > Signed-off-by: Chris Coulson Reviewed-by: Daniel Kiper Thank you for fixing this! Daniel ___ Grub-devel mailing list Grub-devel@gnu.org https://lists.gnu.org/mailman/listinfo/grub-devel
Re: [PATCH] util/grub-mkfont: use valid conversion specifications in printf and fprintf
On Tue, Oct 11, 2022 at 08:31:02PM +0800, Qiumiao Zhang via Grub-devel wrote: > For printf/fprintf functions, unsigned integers should use %u as the valid > conversion specification instead of %d. > > Signed-off-by: Qiumiao Zhang Reviewed-by: Daniel Kiper Daniel ___ Grub-devel mailing list Grub-devel@gnu.org https://lists.gnu.org/mailman/listinfo/grub-devel
Re: [RFC PATCH v3 1/2] mm: Try invalidate disk caches last when out of memory
On Thu, Oct 13, 2022 at 09:29:18AM +0800, Zhang Boyang wrote: > Previously, every heap grow will cause all disk caches invalidated, > which decreases performance severely. This patch moves disk cache > invalidation code to the last of memory squeezing measures, so disk > caches are released only when no other ways to get free memory. > > Signed-off-by: Zhang Boyang Reviewed-by: Daniel Kiper Daniel ___ Grub-devel mailing list Grub-devel@gnu.org https://lists.gnu.org/mailman/listinfo/grub-devel
[PATCH] grub-core/disk/cryptodisk.c: Fix unintentional integer overflow
In the function grub_cryptodisk_endecrypt(), a for loop is incrementing the
variable i by (1U << log_sector_size). The variable i is of type grub_size_t
which is a 64-bit unsigned integer on x86_64 architecture. On the other hand, 1U
is a 32-bit unsigned integer. By performing a left shift between these two
values of different types, there may be potential for an integer overflow. To
avoid this, we replace 1U with (grub_size_t) 1.
Fixes: CID 307788
Signed-off-by: Alec Brown
---
grub-core/disk/cryptodisk.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/grub-core/disk/cryptodisk.c b/grub-core/disk/cryptodisk.c
index 9f5dc7acb..cdcb882ca 100644
--- a/grub-core/disk/cryptodisk.c
+++ b/grub-core/disk/cryptodisk.c
@@ -239,7 +239,7 @@ grub_cryptodisk_endecrypt (struct grub_cryptodisk *dev,
return (do_encrypt ? grub_crypto_ecb_encrypt (dev->cipher, data, data, len)
: grub_crypto_ecb_decrypt (dev->cipher, data, data, len));
- for (i = 0; i < len; i += (1U << log_sector_size))
+ for (i = 0; i < len; i += ((grub_size_t) 1 << log_sector_size))
{
grub_size_t sz = ((dev->cipher->cipher->blocksize
+ sizeof (grub_uint32_t) - 1)
--
2.27.0
___
Grub-devel mailing list
Grub-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/grub-devel
