Re: [bug #64301] [troff] susceptible to integer overflow
[looping in groff list; bug-groff is largely a reflector for the Savannah ticket tracker] At 2024-07-15T17:03:53-0700, Collin Funk wrote: > "G. Branden Robinson" writes: > > Patch #7 was hosed. Fixed that, and patch #12 (new) keeps all tests > > passing. > > > > Is the finish line in sight? > > The ckd_* functions from gnulib are very helpful. Context: https://savannah.gnu.org/bugs/?64301 This won't be in my next push, but it's looking landable soon. > Not directly related, but I noticed that groff uses a ./bootstrap > script which is 2 years behind gnulib updates. > > Whenever you update the gnulib git submodule I would recommend running: > > $ ./bootstrap --bootstrap-sync Ah, thank you. I noticed Colin Watson had recently achieved that update for man-db and was going to ask him how to do it. Another Col(l)in to the rescue! I think I will also update our "HACKING" file to document how to update the gnulib submodule and do the foregoing as well. Regards, Branden signature.asc Description: PGP signature
Re: [bug #64301] [troff] susceptible to integer overflow
On Tue, Jul 16, 2024 at 06:59:08AM -0500, G. Branden Robinson wrote: > At 2024-07-15T17:03:53-0700, Collin Funk wrote: > > Not directly related, but I noticed that groff uses a ./bootstrap > > script which is 2 years behind gnulib updates. > > > > Whenever you update the gnulib git submodule I would recommend running: > > > > $ ./bootstrap --bootstrap-sync > > Ah, thank you. I noticed Colin Watson had recently achieved that update > for man-db and was going to ask him how to do it. I must confess that I'd generally just been copying the file by hand from the gnulib checkout (build-aux/bootstrap). I will try to remember that the --bootstrap-sync option exists! -- Colin Watson (he/him) [cjwat...@debian.org]
Re: [bug #64301] [troff] susceptible to integer overflow
"G. Branden Robinson" writes: > Another Col(l)in to the rescue! I think I will also update our > "HACKING" file to document how to update the gnulib submodule and do the > foregoing as well. :). Sounds good. If I remember correctly Coreutils has instructions on how to update Gnulib in README-hacking. I always use that since I never use git submodules. Not sure if it mentions ./bootstrap --bootstrap-sync though. Colin Watson writes: > I must confess that I'd generally just been copying the file by hand > from the gnulib checkout (build-aux/bootstrap). I will try to remember > that the --bootstrap-sync option exists! That most likely works fine too. The build-aux/bootstrap script is autogenerated from some files in top/* in Gnulib's Makefile. Packages can copy all of the files from top/* into their sources or alternatively just the single build-aux/bootstrap script. The --bootstrap-sync option should work correctly in either of those cases so I suppose there is less work if you decide to reorganize things. Collin
