Re: [GNC-dev] [Gnucash/gnucash] [gnc-budget-view.c] totals - 5 fundamental types (775200e)

[Phil Longstaff]

I will continue this discussion here because I can no longer comment on the
change on github.

No, I understand you aren't trying to be difficult.

I think when I made the original change, my books were set with a certain
sign-reversal setting and I didn't test with other settings. My problem now
is that I have very little time to spend to fix this. It has been a few
years since I have done anything on the gnucash code base and no longer
have a working development environment.

Phil

On Thu, Jan 2, 2020 at 6:04 AM Christopher Lam 
wrote:

> P.S. I'm not intending to be difficult here -- the previous strategy had
> assumed that all budget values asset/liability/income/expense/equity had
> assumed sign-reversal=credit-balances, and was adding/subtracting them as
> such. After bug fix, if this commit, the summary totals would have been
> extremely broken e.g. asset=$300, liability=$1000; the transfer column
> would have shown $1300 or $700 according to sign-reversal preference, and
> the total column would be much more wild.
>
> —
> You are receiving this because you were mentioned.
> Reply to this email directly, view it on GitHub
> ,
> or unsubscribe
> 
> .
>
___
gnucash-devel mailing list
gnucash-devel@gnucash.org
https://lists.gnucash.org/mailman/listinfo/gnucash-devel

Re: [GNC-dev] [Gnucash/gnucash] [gnc-budget-view.c] totals - 5 fundamental types (775200e)

[Christopher Lam]

Thank you Phil.  Github isn't logged anywhere apart from web interface,
hence not the best for discussion.

The only hiccup I really want to elucidate is whether equity being part of
Transfer line is needed at all. So please let me know whether it should be
part of the equation at all.

My suggestions for summary lines as follows would encourage users to think
'incoming funds --> outgoing expenses, and invest into savings and pay off
loans"

"Inflow from Income" = normally positive
"Outflow to Expenses" = normally positive
"Outflow to Asset&Liability" = normally positive
"Unbudgeted balance" = aiming towards zero

On Fri, 3 Jan 2020 at 11:32, Phil Longstaff 
wrote:

> I will continue this discussion here because I can no longer comment on the
> change on github.
>
> No, I understand you aren't trying to be difficult.
>
> I think when I made the original change, my books were set with a certain
> sign-reversal setting and I didn't test with other settings. My problem now
> is that I have very little time to spend to fix this. It has been a few
> years since I have done anything on the gnucash code base and no longer
> have a working development environment.
>
> Phil
>
> On Thu, Jan 2, 2020 at 6:04 AM Christopher Lam 
> wrote:
>
> > P.S. I'm not intending to be difficult here -- the previous strategy had
> > assumed that all budget values asset/liability/income/expense/equity had
> > assumed sign-reversal=credit-balances, and was adding/subtracting them as
> > such. After bug fix, if this commit, the summary totals would have been
> > extremely broken e.g. asset=$300, liability=$1000; the transfer column
> > would have shown $1300 or $700 according to sign-reversal preference, and
> > the total column would be much more wild.
> >
> > —
> > You are receiving this because you were mentioned.
> > Reply to this email directly, view it on GitHub
> > <
> https://github.com/Gnucash/gnucash/commit/775200ef348f8579a3e0258988ae25a8026dbd6d?email_source=notifications&email_token=AE6Z25I2JTMG4J3KIZ26GT3Q3XC4FA5CNFSM4KB3HZ4KYY3PNVWWK3TUL52HS4DFVVBW63LNNF2EG33NNVSW45FKMNXW23LFNZ2F62LEZYBC6A6C#commitcomment-36635586
> >,
> > or unsubscribe
> > <
> https://github.com/notifications/unsubscribe-auth/AE6Z25OEXIQVNT5ACQEDTBTQ3XC4FANCNFSM4KB3HZ4A
> >
> > .
> >
> ___
> gnucash-devel mailing list
> gnucash-devel@gnucash.org
> https://lists.gnucash.org/mailman/listinfo/gnucash-devel
>
___
gnucash-devel mailing list
gnucash-devel@gnucash.org
https://lists.gnucash.org/mailman/listinfo/gnucash-devel

Re: [GNC-dev] [Gnucash/gnucash] [gnc-budget-view.c] totals - 5 fundamental types (775200e)

[Phil Longstaff]

I can't think of any reason that equity needs to be included.

On Fri, Jan 3, 2020 at 9:54 AM Christopher Lam 
wrote:

> Thank you Phil.  Github isn't logged anywhere apart from web interface,
> hence not the best for discussion.
>
> The only hiccup I really want to elucidate is whether equity being part of
> Transfer line is needed at all. So please let me know whether it should be
> part of the equation at all.
>
> My suggestions for summary lines as follows would encourage users to think
> 'incoming funds --> outgoing expenses, and invest into savings and pay off
> loans"
>
> "Inflow from Income" = normally positive
> "Outflow to Expenses" = normally positive
> "Outflow to Asset&Liability" = normally positive
> "Unbudgeted balance" = aiming towards zero
>
> On Fri, 3 Jan 2020 at 11:32, Phil Longstaff 
> wrote:
>
>> I will continue this discussion here because I can no longer comment on
>> the
>> change on github.
>>
>> No, I understand you aren't trying to be difficult.
>>
>> I think when I made the original change, my books were set with a certain
>> sign-reversal setting and I didn't test with other settings. My problem
>> now
>> is that I have very little time to spend to fix this. It has been a few
>> years since I have done anything on the gnucash code base and no longer
>> have a working development environment.
>>
>> Phil
>>
>> On Thu, Jan 2, 2020 at 6:04 AM Christopher Lam 
>> wrote:
>>
>> > P.S. I'm not intending to be difficult here -- the previous strategy had
>> > assumed that all budget values asset/liability/income/expense/equity had
>> > assumed sign-reversal=credit-balances, and was adding/subtracting them
>> as
>> > such. After bug fix, if this commit, the summary totals would have been
>> > extremely broken e.g. asset=$300, liability=$1000; the transfer column
>> > would have shown $1300 or $700 according to sign-reversal preference,
>> and
>> > the total column would be much more wild.
>> >
>> > —
>> > You are receiving this because you were mentioned.
>> > Reply to this email directly, view it on GitHub
>> > <
>> https://github.com/Gnucash/gnucash/commit/775200ef348f8579a3e0258988ae25a8026dbd6d?email_source=notifications&email_token=AE6Z25I2JTMG4J3KIZ26GT3Q3XC4FA5CNFSM4KB3HZ4KYY3PNVWWK3TUL52HS4DFVVBW63LNNF2EG33NNVSW45FKMNXW23LFNZ2F62LEZYBC6A6C#commitcomment-36635586
>> >,
>> > or unsubscribe
>> > <
>> https://github.com/notifications/unsubscribe-auth/AE6Z25OEXIQVNT5ACQEDTBTQ3XC4FANCNFSM4KB3HZ4A
>> >
>> > .
>> >
>> ___
>> gnucash-devel mailing list
>> gnucash-devel@gnucash.org
>> https://lists.gnucash.org/mailman/listinfo/gnucash-devel
>>
>
___
gnucash-devel mailing list
gnucash-devel@gnucash.org
https://lists.gnucash.org/mailman/listinfo/gnucash-devel

Re: [GNC-dev] Enabling github branch protection rules? Re: [Gnucash/gnucash] po/de.po: fix translation bug (#627)

[Christian Stimming]

John,

thanks a lot for testing. Well, that's unfortunate. However, maybe some of the 
other rules would help us to avoid this better? 
https://github.com/Gnucash/gnucash/settings/branch_protection_rules/new
How about activating "Require pull request reviews before merging" with maybe 
"2"? Again, I'm not sure whether code-gnucash-user can still push the commits. 
Could you give it a try? Thanks a lot.

Regards,
Christian



Am Freitag, 3. Januar 2020, 00:15:02 CET schrieb John Ralls:
> Christian,
> 
> Just tried it as a test (the user id is code-gnucash-user). It doesn't
> prevent merging from the web page.
> 
> Regards,
> John Ralls
> 
> > On Jan 2, 2020, at 1:11 PM, Christian Stimming 
> > wrote:
> > 
> > Dear developers,
> > 
> > yesterday I accidentally used the web interface of github to merge a pull
> > request, but we don't want this, because the merge (or any other commit)
> > on
> > github is going to be overwritten by the next push from code.gnucash.org.
> > 
> > I was wondering whether we could enable the github "Protect matching
> > branches" rules
> > https://github.com/Gnucash/gnucash/settings/branch_protection_rules/new
> > There's a rule "Restrict who can push to matching branches", which we
> > could
> > restrict to the user that pushes from code.gnucash.org. This should
> > prevent
> > any such accidental merges from github's web interface, shouldn't it?
> > However, this needs to be enabled by somebody who immediately can check
> > that the push from code still works. Anybody there care to take a look?
> > Thanks a lot!
> > 
> > Regards,
> > 
> > Christian
> > 
> > Am Donnerstag, 2. Januar 2020, 11:42:12 CET schrieb Frank H. Ellenberger:
> >> Never use githubs webinterface for merging for any gnucash project!
> >> Because code.gnucash.org is canonical, the merge got overwritten by the
> >> next push.
> > 
> > ___
> > gnucash-devel mailing list
> > gnucash-devel@gnucash.org
> > https://lists.gnucash.org/mailman/listinfo/gnucash-devel




___
gnucash-devel mailing list
gnucash-devel@gnucash.org
https://lists.gnucash.org/mailman/listinfo/gnucash-devel

Re: [GNC-dev] Enabling github branch protection rules? Re: [Gnucash/gnucash] po/de.po: fix translation bug (#627)

[John Ralls]

Christian,

Well, it does disable the merge button. "applies to administrators" has to be 
checked too for it to apply to you, me, and Geert. Unfortunately it also 
applies to pushes from code:

Counting objects: 16, done.
Delta compression using up to 16 threads.
Compressing objects: 100% (16/16), done.
Writing objects: 100% (16/16), 1.58 KiB | 0 bytes/s, done.
Total 16 (delta 12), reused 0 (delta 0)
remote: *** Mirror changes to origin (usually github)...
remote: remote: error: GH006: Protected branch update failed for 
refs/heads/maint.
remote: remote: error: At least 2 approving reviews are required by reviewers 
with write access.
remote: To ssh://github.com/Gnucash/gnucash.git
remote:d409d009f..b5fdcfcb5  origin/maint -> origin/maint
remote:  ! [remote rejected] maint -> maint (protected branch hook declined)
remote: error: failed to push some refs to 
'ssh://g...@github.com/Gnucash/gnucash.git'
To ssh://code.gnucash.org/gnucash
   b5fdcfc..c9998a8  maint -> maint

That could probably be worked around by making code a maintainer and reducing 
your privs to regular developer. Geert and I would still get the merge button 
but we know better than to use it.

Regards,
John Ralls


> On Jan 3, 2020, at 12:57 PM, Christian Stimming  
> wrote:
> 
> John,
> 
> thanks a lot for testing. Well, that's unfortunate. However, maybe some of 
> the 
> other rules would help us to avoid this better? 
> https://github.com/Gnucash/gnucash/settings/branch_protection_rules/new
> How about activating "Require pull request reviews before merging" with maybe 
> "2"? Again, I'm not sure whether code-gnucash-user can still push the 
> commits. 
> Could you give it a try? Thanks a lot.
> 
> Regards,
> Christian
> 
> 
> 
> Am Freitag, 3. Januar 2020, 00:15:02 CET schrieb John Ralls:
>> Christian,
>> 
>> Just tried it as a test (the user id is code-gnucash-user). It doesn't
>> prevent merging from the web page.
>> 
>> Regards,
>> John Ralls
>> 
>>> On Jan 2, 2020, at 1:11 PM, Christian Stimming 
>>> wrote:
>>> 
>>> Dear developers,
>>> 
>>> yesterday I accidentally used the web interface of github to merge a pull
>>> request, but we don't want this, because the merge (or any other commit)
>>> on
>>> github is going to be overwritten by the next push from code.gnucash.org.
>>> 
>>> I was wondering whether we could enable the github "Protect matching
>>> branches" rules
>>> https://github.com/Gnucash/gnucash/settings/branch_protection_rules/new
>>> There's a rule "Restrict who can push to matching branches", which we
>>> could
>>> restrict to the user that pushes from code.gnucash.org. This should
>>> prevent
>>> any such accidental merges from github's web interface, shouldn't it?
>>> However, this needs to be enabled by somebody who immediately can check
>>> that the push from code still works. Anybody there care to take a look?
>>> Thanks a lot!
>>> 
>>> Regards,
>>> 
>>> Christian
>>> 
>>> Am Donnerstag, 2. Januar 2020, 11:42:12 CET schrieb Frank H. Ellenberger:
 Never use githubs webinterface for merging for any gnucash project!
 Because code.gnucash.org is canonical, the merge got overwritten by the
 next push.
>>> 
>>> ___
>>> gnucash-devel mailing list
>>> gnucash-devel@gnucash.org
>>> https://lists.gnucash.org/mailman/listinfo/gnucash-devel
> 
> 
> 
> 

___
gnucash-devel mailing list
gnucash-devel@gnucash.org
https://lists.gnucash.org/mailman/listinfo/gnucash-devel

Re: [GNC-dev] [Gnucash/gnucash] [gnc-budget-view.c] totals - 5 fundamental types (775200e)

[Christopher Lam]

Thanks for clarifying that equity was probably a coding error. I also
managed to find the original commit message 190665ac which confirms. I'll
try to redo, and ensure that the summary lines are as follows... I think
they should be insensitive to the sign-reversal preference.

"2) GncBudgetView changes:
a) If an account has children but does not have a specific budget value
for a period, the sum of the children's budget values will be displayed in
gray
b) Totals column on the right provides total for a budget row (account)
c) At the bottom, totals lines with total income, total expenses, total
transfers (assets+liabilities) and grand total (income - expenses -
transfers)"

On Fri, 3 Jan 2020 at 15:35, Phil Longstaff 
wrote:

> I can't think of any reason that equity needs to be included.
>
> On Fri, Jan 3, 2020 at 9:54 AM Christopher Lam 
> wrote:
>
> > Thank you Phil.  Github isn't logged anywhere apart from web interface,
> > hence not the best for discussion.
> >
> > The only hiccup I really want to elucidate is whether equity being part
> of
> > Transfer line is needed at all. So please let me know whether it should
> be
> > part of the equation at all.
> >
> > My suggestions for summary lines as follows would encourage users to
> think
> > 'incoming funds --> outgoing expenses, and invest into savings and pay
> off
> > loans"
> >
> > "Inflow from Income" = normally positive
> > "Outflow to Expenses" = normally positive
> > "Outflow to Asset&Liability" = normally positive
> > "Unbudgeted balance" = aiming towards zero
> >
> > On Fri, 3 Jan 2020 at 11:32, Phil Longstaff 
> > wrote:
> >
> >> I will continue this discussion here because I can no longer comment on
> >> the
> >> change on github.
> >>
> >> No, I understand you aren't trying to be difficult.
> >>
> >> I think when I made the original change, my books were set with a
> certain
> >> sign-reversal setting and I didn't test with other settings. My problem
> >> now
> >> is that I have very little time to spend to fix this. It has been a few
> >> years since I have done anything on the gnucash code base and no longer
> >> have a working development environment.
> >>
> >> Phil
> >>
> >> On Thu, Jan 2, 2020 at 6:04 AM Christopher Lam <
> notificati...@github.com>
> >> wrote:
> >>
> >> > P.S. I'm not intending to be difficult here -- the previous strategy
> had
> >> > assumed that all budget values asset/liability/income/expense/equity
> had
> >> > assumed sign-reversal=credit-balances, and was adding/subtracting them
> >> as
> >> > such. After bug fix, if this commit, the summary totals would have
> been
> >> > extremely broken e.g. asset=$300, liability=$1000; the transfer column
> >> > would have shown $1300 or $700 according to sign-reversal preference,
> >> and
> >> > the total column would be much more wild.
> >> >
> >> > —
> >> > You are receiving this because you were mentioned.
> >> > Reply to this email directly, view it on GitHub
> >> > <
> >>
> https://github.com/Gnucash/gnucash/commit/775200ef348f8579a3e0258988ae25a8026dbd6d?email_source=notifications&email_token=AE6Z25I2JTMG4J3KIZ26GT3Q3XC4FA5CNFSM4KB3HZ4KYY3PNVWWK3TUL52HS4DFVVBW63LNNF2EG33NNVSW45FKMNXW23LFNZ2F62LEZYBC6A6C#commitcomment-36635586
> >> >,
> >> > or unsubscribe
> >> > <
> >>
> https://github.com/notifications/unsubscribe-auth/AE6Z25OEXIQVNT5ACQEDTBTQ3XC4FANCNFSM4KB3HZ4A
> >> >
> >> > .
> >> >
> >> ___
> >> gnucash-devel mailing list
> >> gnucash-devel@gnucash.org
> >> https://lists.gnucash.org/mailman/listinfo/gnucash-devel
> >>
> >
> ___
> gnucash-devel mailing list
> gnucash-devel@gnucash.org
> https://lists.gnucash.org/mailman/listinfo/gnucash-devel
>
___
gnucash-devel mailing list
gnucash-devel@gnucash.org
https://lists.gnucash.org/mailman/listinfo/gnucash-devel