Re: r21892 - gnucash/tags - Tagging the 2.4.10 release

2012-01-28 Thread Geert Janssens
Op vrijdag 27 januari 2012 12:35:33 schreef John Ralls:
> On Jan 27, 2012, at 12:17 PM, Geert Janssens wrote:
> > Op donderdag 26 januari 2012 22:42:20 schreef Derek Atkins:
> >> Author: warlord
> >> Date: 2012-01-26 22:42:20 -0500 (Thu, 26 Jan 2012)
> >> New Revision: 21892
> >> Trac: http://svn.gnucash.org/trac/changeset/21892
> >> 
> >> Added:
> >>   gnucash/tags/2.4.10/
> >> 
> >> Log:
> >> Tagging the 2.4.10 release
> > 
> > Unfortunately, this tag is missing the fix for the startup crash on
> > Windows (which required to patch the Windows installer).
> > 
> > I was too late to add it (due to other issues in real life).
> > 
> > I have committed it now. It should help fix part of upgrade troubles on
> > Windows, although I can't seem to start my locally built 2.4 branch
> > checkout. The checkout is from yesterday, I haven't got time to check
> > the currently tagged 2.4.10 to see if this one is also affected.
> > 
> > I'm sorry I can't be of more help here.
> 
> Geert,
> 
> I think you're the only dev with Win7 at the moment. I can re-tag 2.4.10 to
> get the change you just committed, but if you're going to have time to look
> at the Win7 crash over the weekend, maybe it would be better for me to hold
> off.
> 
I'm sorry, my message may have been confusing. I only have Windows XP SP3. The 
original poster reported the problem on Windows 7, and I neglected to mention 
my Windows version in my reply.

Today I installed the 2.4.10 version that got built last night, but 
unfortunately it still crashes with the same error.

I also tried on another Windows XP installation, figuring that my test VM got 
corrupted somehow, but I get exactly the same results there.

I tried removing the .gtkrc, as at least for 2.4.9, it worked (even with the 
Nimbus theme), but I can't get 2.4.10 to run. 

It's very unlikely I can continue to debug this shortly, so as far as I'm 
concerned, you can retag now. The crash caused by the installation issue is 
fixed at least, what remains it to figure out why the app crashes on libgdk-
win32-2.0-0.dll.

Geert
___
gnucash-devel mailing list
gnucash-devel@gnucash.org
https://lists.gnucash.org/mailman/listinfo/gnucash-devel


[PATCH] Make report Budget Flow 100% translatable

2012-01-28 Thread Aurimas Fišeras

Hello,
I was working on GnuCash translation and noticed that Budget Flow report 
doesn't react to my translation of the string "Total".


Please apply this to the 2.4 branch too, since it does not introduce a 
new translation, just uses an existing one.


Aurimas.

>From ff84ef23f9a408096a69d837c3abd56cf81a27ce Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Aurimas=20Fi=C5=A1eras?= 
Date: Sat, 28 Jan 2012 13:44:36 +0200
Subject: reports: Make report Budget Flow 100% translatable

---
 src/report/standard-reports/budget-flow.scm |4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/src/report/standard-reports/budget-flow.scm b/src/report/standard-reports/budget-flow.scm
index 0a76558..a808834 100644
--- a/src/report/standard-reports/budget-flow.scm
+++ b/src/report/standard-reports/budget-flow.scm
@@ -159,7 +159,7 @@
 (bgt-total-numeric (gnc:sum-collector-commodity bgt-total report-currency exchange-fn))
 (act-total-numeric (gnc:sum-collector-commodity act-total report-currency exchange-fn))
   )
-  (gnc:html-table-add-budget-row! html-table "total-number-cell" "Total:" bgt-total-numeric act-total-numeric)
+  (gnc:html-table-add-budget-row! html-table "total-number-cell" (string-append (_ "Total") ":") bgt-total-numeric act-total-numeric)
   
   ;; Display hr FIXME: kind of a hack
   (gnc:html-table-append-row! html-table "")
@@ -241,7 +241,7 @@
   )
 
   ;; Display Grand Total
-  (gnc:html-table-add-budget-row! html-table "total-number-cell" "Total:" bgt-total-numeric act-total-numeric)
+  (gnc:html-table-add-budget-row! html-table "total-number-cell" (string-append (_ "Total") ":") bgt-total-numeric act-total-numeric)
 
 )))
 
-- 
1.7.8.3

___
gnucash-devel mailing list
gnucash-devel@gnucash.org
https://lists.gnucash.org/mailman/listinfo/gnucash-devel


Re: r21892 - gnucash/tags - Tagging the 2.4.10 release

2012-01-28 Thread John Ralls

On Jan 28, 2012, at 2:50 AM, Geert Janssens wrote:

> Op vrijdag 27 januari 2012 12:35:33 schreef John Ralls:
>> On Jan 27, 2012, at 12:17 PM, Geert Janssens wrote:
>>> Op donderdag 26 januari 2012 22:42:20 schreef Derek Atkins:
 Author: warlord
 Date: 2012-01-26 22:42:20 -0500 (Thu, 26 Jan 2012)
 New Revision: 21892
 Trac: http://svn.gnucash.org/trac/changeset/21892
 
 Added:
  gnucash/tags/2.4.10/
 
 Log:
 Tagging the 2.4.10 release
>>> 
>>> Unfortunately, this tag is missing the fix for the startup crash on
>>> Windows (which required to patch the Windows installer).
>>> 
>>> I was too late to add it (due to other issues in real life).
>>> 
>>> I have committed it now. It should help fix part of upgrade troubles on
>>> Windows, although I can't seem to start my locally built 2.4 branch
>>> checkout. The checkout is from yesterday, I haven't got time to check
>>> the currently tagged 2.4.10 to see if this one is also affected.
>>> 
>>> I'm sorry I can't be of more help here.
>> 
>> Geert,
>> 
>> I think you're the only dev with Win7 at the moment. I can re-tag 2.4.10 to
>> get the change you just committed, but if you're going to have time to look
>> at the Win7 crash over the weekend, maybe it would be better for me to hold
>> off.
>> 
> I'm sorry, my message may have been confusing. I only have Windows XP SP3. 
> The 
> original poster reported the problem on Windows 7, and I neglected to mention 
> my Windows version in my reply.
> 
> Today I installed the 2.4.10 version that got built last night, but 
> unfortunately it still crashes with the same error.
> 
> I also tried on another Windows XP installation, figuring that my test VM got 
> corrupted somehow, but I get exactly the same results there.
> 
> I tried removing the .gtkrc, as at least for 2.4.9, it worked (even with the 
> Nimbus theme), but I can't get 2.4.10 to run. 
> 
> It's very unlikely I can continue to debug this shortly, so as far as I'm 
> concerned, you can retag now. The crash caused by the installation issue is 
> fixed at least, what remains it to figure out why the app crashes on libgdk-
> win32-2.0-0.dll.

OK, if it's crashing for you on XP, maybe it will for me too. I'll have a look 
in a bit.

Regards,
John Ralls


___
gnucash-devel mailing list
gnucash-devel@gnucash.org
https://lists.gnucash.org/mailman/listinfo/gnucash-devel


Re: Git Migration: github with svn access

2012-01-28 Thread Christian Stimming
Am Freitag, 27. Januar 2012, 19:04:10 schrieb Andy Clayton:
> > If I have some time during the next days, I'll look into porting the
> > SVN-
> > dependencies in our build scripts to using git. Also, I don't think it's
> > necessary to distinguish tags that should trigger a build from those
> > which don't - we can just as well have *each* tag trigger a rebuild on
> > its own. The build server "just" needs a list of tag and SHA1.
> 
> Is the switch to git stuck on 1) the sed crash on windows after adding
> git and then 2) porting the build scripts?

Yes, both.

The porting of the build scripts is a task that I thought I could look into, 
but don't have had time for it so far.

The sed crash indicates a conflict of msys-git's msys environment with the 
build server's main msys environment. Maybe we can live with that by calling 
git by its absolute path so that its msys DLLs are not in PATH, but I haven't 
checked this further.

Regards,

Christian
___
gnucash-devel mailing list
gnucash-devel@gnucash.org
https://lists.gnucash.org/mailman/listinfo/gnucash-devel


Re: [PATCH] Make report Budget Flow 100% translatable

2012-01-28 Thread Christian Stimming
Am Samstag, 28. Januar 2012, 13:52:31 schrieb Aurimas Fišeras:
> Hello,
> I was working on GnuCash translation and noticed that Budget Flow report
> doesn't react to my translation of the string "Total".
> 
> Please apply this to the 2.4 branch too, since it does not introduce a
> new translation, just uses an existing one.

Done. Thanks a lot!

Regards,

Christian

___
gnucash-devel mailing list
gnucash-devel@gnucash.org
https://lists.gnucash.org/mailman/listinfo/gnucash-devel


make check doesn't work

2012-01-28 Thread Alex Aycinena
I can checkout, configure, make, install and run a clean copy of
gnucash (r21907) from svn without any problem. But when I try a 'make
check' to run the tests, I get:

/home/gnucash-dev/svncheckouts/gnucash-clean/src/gnome-utils/test/test-gnc-recurrence.c:13:21:
fatal error: gtk/gtk.h: No such file or directory
compilation terminated.
make[4]: *** [test-gnc-recurrence.o] Error 1

I'm doing this on Fedora 16. Anybody have any ideas what could be
wrong? Does it work for others?

Alex
___
gnucash-devel mailing list
gnucash-devel@gnucash.org
https://lists.gnucash.org/mailman/listinfo/gnucash-devel


Re: Git Migration: github with svn access

2012-01-28 Thread John Ralls

On Jan 28, 2012, at 2:30 PM, Christian Stimming wrote:

> Am Freitag, 27. Januar 2012, 19:04:10 schrieb Andy Clayton:
>>> If I have some time during the next days, I'll look into porting the
>>> SVN-
>>> dependencies in our build scripts to using git. Also, I don't think it's
>>> necessary to distinguish tags that should trigger a build from those
>>> which don't - we can just as well have *each* tag trigger a rebuild on
>>> its own. The build server "just" needs a list of tag and SHA1.
>> 
>> Is the switch to git stuck on 1) the sed crash on windows after adding
>> git and then 2) porting the build scripts?
> 
> Yes, both.
> 
> The porting of the build scripts is a task that I thought I could look into, 
> but don't have had time for it so far.
> 
> The sed crash indicates a conflict of msys-git's msys environment with the 
> build server's main msys environment. Maybe we can live with that by calling 
> git by its absolute path so that its msys DLLs are not in PATH, but I haven't 
> checked this further.

No, that won't work, because it will still need $PATH to find its dlls. 

Jhbuild-windows (http://afuera.me.uk/jhbuild-windows/, don't use the GnomeLive! 
page, it doesn't work) where he uses a one-line .cmd file to run git from 
inside Msys:

@c:\\tools\\git\\bin\\sh.exe -c "/c/tools/git/bin/git %*"

Regards,
John Ralls


___
gnucash-devel mailing list
gnucash-devel@gnucash.org
https://lists.gnucash.org/mailman/listinfo/gnucash-devel


Re: make check doesn't work

2012-01-28 Thread John Ralls

On Jan 28, 2012, at 5:18 PM, Alex Aycinena wrote:

> I can checkout, configure, make, install and run a clean copy of
> gnucash (r21907) from svn without any problem. But when I try a 'make
> check' to run the tests, I get:
> 
> /home/gnucash-dev/svncheckouts/gnucash-clean/src/gnome-utils/test/test-gnc-recurrence.c:13:21:
> fatal error: gtk/gtk.h: No such file or directory
> compilation terminated.
> make[4]: *** [test-gnc-recurrence.o] Error 1
> 
> I'm doing this on Fedora 16. Anybody have any ideas what could be
> wrong? Does it work for others?

The includes in Makefile.am are missing ${GTK_CFLAGS}, which were implicitly 
included by ${GLADE_CFLAGS} until Geert took them out in r21880.

Regards,
John Ralls


___
gnucash-devel mailing list
gnucash-devel@gnucash.org
https://lists.gnucash.org/mailman/listinfo/gnucash-devel