Re: String additions to 'gdm2.gnome-2-20'
Le mercredi 10 octobre 2007 à 01:19 +0100, GNOME Status Pages a écrit : > This is an automatic notification from status generation scripts on: > http://l10n.gnome.org/. > > There have been following string additions to module 'gdm2.gnome-2-20': > > + "Cannot get passwd structure for user" > + "Cannot get passwd structure" > + "Cannot set user group" > + "User not allowed to log in" > + "User password has expired" > > Note that this doesn't directly indicate a string freeze break, but it > might be worth investigating. Hi Brian, This seems to be clearly a string freeze breakage (from verify-crypt.c). Could you please revert the changes, and explains to the list why you think this should really go into gnome-2-20 branch? Regards, Claude ___ gnome-i18n mailing list gnome-i18n@gnome.org http://mail.gnome.org/mailman/listinfo/gnome-i18n
Re: String additions to 'gdm2.gnome-2-20'
Claude/Others: Apologies for breaking string freeze in GDM 2.20. However, I think that this change is acceptable for the following reasons, mainly reason #2 which is a security issue. I think, in this case, security trumps translation. However, I do recognize that I should have sent an email to the gnome-i18n list to let people know about this change. Sorry for not doing that. 1) These strings are in debug messages, which are only used when debug is turned on. These debug messages are sent to the system log (/var/log/messages or /var/adm/messages depending on your OS). I am not sure it really adds value to even translate such debug messages anyway. When people provide debug logs to bugzilla, etc. translated messages can make it harder for the people who maintain GDM, who typically speak English, to help debug the problem. 2) These messages replaced older messages which included the login user in the message. Bugzilla bug #484750 pointed out that if a user were to, by accident, type their password into the username field that this would cause their password to get logged to syslog, which we should avoid doing ever. 3) These debug messages are only used when the user configures GDM to use crypt or shadow passwords, which are not typically used. Most users use PAM. So these messages only affect a small number of GDM users. The commonly used PAM code is smarter about not ever logging the username to the system log. I recommend that we not worry about whether these debug messages are translated. Or, I can change these strings so they aren't marked for translation if that makes things easier. As I said, I don't think it adds any significant value to translate these messages. Or, I could remove the messages completely from the code if people think that is a better choice. Since this affects security, it might also make sense to backport a similar change to older GDM releases. I'm not sure if there are distros/people out there who configure/use older versions of GDM with shadow/crypt passwords. If so, let me know and I can make a release of older versions of GDM's with this security issue fixed. Please advise if you think further work is needed to fix this issue properly. The GDM documentation recommends that people not leave on debug, and I would like to further stress that users who have configured GDM to use shadow/crypt passwords should ensure that they have debug turned off to avoid this sort of problem. Debug is only intended to be used briefly when trying to figure out why GDM may not be functioning properly. Brian > Le mercredi 10 octobre 2007 à 01:19 +0100, GNOME Status Pages a écrit : >> This is an automatic notification from status generation scripts on: >> http://l10n.gnome.org/. >> >> There have been following string additions to module 'gdm2.gnome-2-20': >> >> + "Cannot get passwd structure for user" >> + "Cannot get passwd structure" >> + "Cannot set user group" >> + "User not allowed to log in" >> + "User password has expired" >> >> Note that this doesn't directly indicate a string freeze break, but it >> might be worth investigating. > > Hi Brian, > > This seems to be clearly a string freeze breakage (from verify-crypt.c). > Could you please revert the changes, and explains to the list why you > think this should really go into gnome-2-20 branch? > > Regards, > > Claude > ___ gnome-i18n mailing list gnome-i18n@gnome.org http://mail.gnome.org/mailman/listinfo/gnome-i18n
Re: Add translation contexts
On 9/22/07, Danilo Šegan <[EMAIL PROTECTED]> wrote: > GNOME is still not using msgctxt. It would be worthwhile to switch, > but note that msgctxt is incompatible with the existing GNOME-way, so > it's not trivial (as in change just one library [namely glib]), but it > will involve changing it all over GNOME. I'd always tend to think this is laziness rather than anything else, as KDE4 has had concerted effort on converting home-brew solution to native gettext support, and seems to go well. And why changing everything all over GNOME is needed? Isn't all Q_() calls end up in glib/gi18n.h, which calls g_strip_context()? Abel > > And that also means breaking PO files, so a migration would be due as > well. > > Cheers, > Danilo > ___ > gnome-i18n mailing list > gnome-i18n@gnome.org > http://mail.gnome.org/mailman/listinfo/gnome-i18n > -- Abel Cheung (GPG Key: 0xC67186FF) Key fingerprint: 671C C7AE EFB5 110C D6D1 41EE 4152 E1F1 C671 86FF * My own cave: http://me.abelcheung.org/ * Opensource Application Knowledge Assoc. - http://oaka.org/ ___ gnome-i18n mailing list gnome-i18n@gnome.org http://mail.gnome.org/mailman/listinfo/gnome-i18n
Re: Add translation contexts
On 10/11/07, Abel Cheung <[EMAIL PROTECTED]> wrote: > And why changing everything all over GNOME is needed? Isn't all > Q_() calls end up in glib/gi18n.h, which calls g_strip_context()? OK, I need some coffee... all Q_() calls should better be replaced by pgettext(). But seriously, how many Q_() calls are there throughout GNOME? Haven't grep'ed that yet, but shouldn't be too much. Or not? Abel > > Abel > > > > > > And that also means breaking PO files, so a migration would be due as > > well. > > > > Cheers, > > Danilo > > ___ > > gnome-i18n mailing list > > gnome-i18n@gnome.org > > http://mail.gnome.org/mailman/listinfo/gnome-i18n > > > > > -- > Abel Cheung (GPG Key: 0xC67186FF) > Key fingerprint: 671C C7AE EFB5 110C D6D1 41EE 4152 E1F1 C671 86FF > > * My own cave: http://me.abelcheung.org/ > * Opensource Application Knowledge Assoc. - http://oaka.org/ > -- Abel Cheung (GPG Key: 0xC67186FF) Key fingerprint: 671C C7AE EFB5 110C D6D1 41EE 4152 E1F1 C671 86FF * My own cave: http://me.abelcheung.org/ * Opensource Application Knowledge Assoc. - http://oaka.org/ ___ gnome-i18n mailing list gnome-i18n@gnome.org http://mail.gnome.org/mailman/listinfo/gnome-i18n
Re: Add translation contexts
Abel Cheung wrote: > On 10/11/07, Abel Cheung <[EMAIL PROTECTED]> wrote: > > And why changing everything all over GNOME is needed? Isn't all > > Q_() calls end up in glib/gi18n.h, which calls g_strip_context()? > > OK, I need some coffee... all Q_() calls should better be replaced > by pgettext(). > But seriously, how many Q_() calls are there throughout GNOME? > Haven't grep'ed that yet, but shouldn't be too much. Or not? Probably not totally accurate, I just ran a big grep on a jhbuild checkout and here is the result; 21 files, in 10 modules. Epiphany: 3 epiphany/embed/downloader-view.c 1 epiphany/embed/ephy-encodings.c 4 epiphany/src/bookmarks/ephy-bookmarks.c 1 epiphany/src/ephy-toolbar-editor.c 4 epiphany/src/prefs-dialog.c Evince: 2 evince/shell/eggfindbar.c Evolution: 1 evolution/mail/em-folder-tree.c GEdit: 4 gedit/plugins/spell/gedit-spell-checker-language.c Control Center: 1 gnome-control-center/capplets/background/gnome-wp-item.c GNOME Games: 1 gnome-games/libgames-support/games-scores-dialog.c Panel: 2 gnome-panel/gnome-panel/panel-menu-items.c 1 gnome-panel/gnome-panel/panel-properties-dialog.c 1 gnome-panel/libpanel-applet/panel-test-applets.c GTK+: 8 gtk+/gtk/gtkaccellabel.c 6 gtk+/gtk/gtkcalendar.c 1 gtk+/gtk/gtkcellrendereraccel.c 2 gtk+/gtk/gtkcellrendererprogress.c 2 gtk+/gtk/gtkrecentchoosermenu.c 1 gtk+/gtk/gtkvolumebutton.c libsexy: (actually not a GNOME component) 2 libsexy/libsexy/gtkspell-iso-codes.c Totem: 2 totem/src/backend/video-utils.c Frederic ___ gnome-i18n mailing list gnome-i18n@gnome.org http://mail.gnome.org/mailman/listinfo/gnome-i18n
Re: libgnome/libgnomeui branched
Le mardi 02 octobre 2007 à 23:00 +0200, Kjartan Maraas a écrit : > tir, 02.10.2007 kl. 21.12 +0200, skrev Kjartan Maraas: > > Hi. > > > > I've branched libgnome and libgnomeui. Branch name is gnome-2-20 as > > expected. > > > And now I branched libgnomecanvas as well. Same name. Thanks. l10n.gnome.org updated. Claude ___ gnome-i18n mailing list gnome-i18n@gnome.org http://mail.gnome.org/mailman/listinfo/gnome-i18n
Re: Evince branched for 2.20
Le mardi 09 octobre 2007 à 22:35 +0400, Nickolay V. Shmyrev a écrit : > Stable branch is gnome-2-20 > > We hope next stable release will bring us a lot of useful features like > imported GSoC annotations work, DVI specials support. Probably there > will be time to solve zoom problems for big zoom. But the main priority > will be stability, test coverage and proper documentation. Thanks. l10n.gnome.org updated. Claude ___ gnome-i18n mailing list gnome-i18n@gnome.org http://mail.gnome.org/mailman/listinfo/gnome-i18n
Re: String additions to 'gdm2.gnome-2-20'
Brian, thanks for your thorough explanation. I tend to approve this, because I know that most other programs don't translate debug messages and it wouldn't be fair to disadvantage you for doing this. Formally, we need a second approval though. And please, next time ask before committing! Regards, Claude Le mercredi 10 octobre 2007 à 12:36 -0500, Brian Cameron a écrit : > Claude/Others: > > Apologies for breaking string freeze in GDM 2.20. However, I think that > this change is acceptable for the following reasons, mainly reason #2 > which is a security issue. I think, in this case, security trumps > translation. However, I do recognize that I should have sent an email > to the gnome-i18n list to let people know about this change. Sorry for > not doing that. > > 1) These strings are in debug messages, which are only used when debug > is turned on. These debug messages are sent to the system log > (/var/log/messages or /var/adm/messages depending on your OS). > > I am not sure it really adds value to even translate such debug > messages anyway. When people provide debug logs to bugzilla, etc. > translated messages can make it harder for the people who maintain > GDM, who typically speak English, to help debug the problem. > > 2) These messages replaced older messages which included the login user > in the message. Bugzilla bug #484750 pointed out that if a user > were to, by accident, type their password into the username field > that this would cause their password to get logged to syslog, which > we should avoid doing ever. > > 3) These debug messages are only used when the user configures GDM > to use crypt or shadow passwords, which are not typically used. > Most users use PAM. So these messages only affect a small number > of GDM users. The commonly used PAM code is smarter about not ever > logging the username to the system log. > > I recommend that we not worry about whether these debug messages are > translated. Or, I can change these strings so they aren't marked for > translation if that makes things easier. As I said, I don't think it > adds any significant value to translate these messages. Or, I could > remove the messages completely from the code if people think that is > a better choice. > > Since this affects security, it might also make sense to backport > a similar change to older GDM releases. I'm not sure if there are > distros/people out there who configure/use older versions of GDM with > shadow/crypt passwords. If so, let me know and I can make a release > of older versions of GDM's with this security issue fixed. > > Please advise if you think further work is needed to fix this issue > properly. > > The GDM documentation recommends that people not leave on debug, and > I would like to further stress that users who have configured GDM > to use shadow/crypt passwords should ensure that they have debug > turned off to avoid this sort of problem. Debug is only intended to > be used briefly when trying to figure out why GDM may not be > functioning properly. > > Brian > > > > Le mercredi 10 octobre 2007 à 01:19 +0100, GNOME Status Pages a écrit : > >> This is an automatic notification from status generation scripts on: > >> http://l10n.gnome.org/. > >> > >> There have been following string additions to module 'gdm2.gnome-2-20': > >> > >> + "Cannot get passwd structure for user" > >> + "Cannot get passwd structure" > >> + "Cannot set user group" > >> + "User not allowed to log in" > >> + "User password has expired" > >> > >> Note that this doesn't directly indicate a string freeze break, but it > >> might be worth investigating. > > > > Hi Brian, > > > > This seems to be clearly a string freeze breakage (from verify-crypt.c). > > Could you please revert the changes, and explains to the list why you > > think this should really go into gnome-2-20 branch? > > > > Regards, > > > > Claude > > ___ gnome-i18n mailing list gnome-i18n@gnome.org http://mail.gnome.org/mailman/listinfo/gnome-i18n
Re: String additions to 'gdm2.gnome-2-20'
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Hi! > Formally, we need a second approval though. > And please, next time ask before committing! Second approval of i18n-team! I would also agree not to translate these debug messages. Note that you might need some more approval from release and doc-team, see http://live.gnome.org/TranslationProject/HandlingStringFreezes for details. Regards, Johannes -BEGIN PGP SIGNATURE- Version: GnuPG v1.4.6 (GNU/Linux) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org iD8DBQFHDUzu7Dsf+G5b/WsRArfiAJ98MvqlMK/uJwJKex6FqSNUQ1KsrQCfdjQo idnAMJJlMU6FuQ2ZG0EWxlo= =glVW -END PGP SIGNATURE- ___ gnome-i18n mailing list gnome-i18n@gnome.org http://mail.gnome.org/mailman/listinfo/gnome-i18n
Re: String additions to 'gdm2.gnome-2-20'
Johannes: >> Formally, we need a second approval though. >> And please, next time ask before committing! > > Second approval of i18n-team! Thanks. > I would also agree not to translate these debug messages. I think this also makes the most sense. Those doing translations shouldn't be bothered worrying about translating these strings at all. I went ahead and removed all string translations from debug messages in the GDM daemon. There were some additional ones in daemon/filecheck.c and daemon/gdm-xdmcp-manager.c. This is better since it was being done very inconsistently (even in the same functions some messages were translated and others were not). > Note that you might need some more approval from release and doc-team, > see http://live.gnome.org/TranslationProject/HandlingStringFreezes for > details. Since the removal of translated strings is not affected by the string freeze, and since people seem in general agreement that debug messages don't need translation, I don't think any notifications are necessary. Thanks for helping me to work through this. Brian ___ gnome-i18n mailing list gnome-i18n@gnome.org http://mail.gnome.org/mailman/listinfo/gnome-i18n
