Re: [ANNOUNCE] Git v2.0.0

[NeilBrown]

On Wed, 28 May 2014 15:31:13 -0700 Junio C Hamano  wrote:

> The latest feature release Git v2.0.0 is now available at the
> usual places.


> 
> "git request-pull" lost a few "heuristics" that often led to mistakes.
> 

I've installed git 2.0.0 and now when I

  git request-pull master git://neil.brown.name/md

after tagging the current commit as "md/3.15-fixes" and pushing out the tag,
I get

warn: No match for commit 2ac295a544dcae9299cba13ce250419117ae7fd1 found at 
git://neil.brown.name/md
warn: Are you sure you pushed 'HEAD' there?

Yet 
   git ls-remote git://neil.brown.name/md | grep 2ac29
shows

2ac295a544dcae9299cba13ce250419117ae7fd1refs/tags/md/3.15-fixes^{}

Which seems clear and unambiguous.

Does this mean that the 'end' arg to 'git request-pull' is no longer optional
(i.e. the man page is wrong), or that too many heuristics were removed?

 Looking through the change log a bit, it seems that if the 'end' arg is
omitted, then the current 'branch' name is used and must match the same name
at the git URL.  Could it also check the current 'tag' name?  As we are
encouraged to used signed tags, this seems sensible.
In fact, I would suggest checking for a tag first, and only considering the
branch name if there is no tag on the current commit.

Thanks,
NeilBrown



signature.asc
Description: PGP signature

Re: [ANNOUNCE] Git v2.0.0

[NeilBrown]

On Mon, 2 Jun 2014 19:59:53 -0700 Linus Torvalds
 wrote:

> On Mon, Jun 2, 2014 at 7:08 PM, NeilBrown  wrote:
> >
> >   git request-pull master git://neil.brown.name/md
> >
> > after tagging the current commit as "md/3.15-fixes" and pushing out the tag
> 
> You should *tell* "git request-pull" what you're actually requesting to pull.
> 
> The old "let's guess based on the commit at the top of your tree" may
> have worked for you (because you only ever had one matching thing),
> but it did not work in general.
> 
> So the new "git request-pull" does not guess. If you want to request a
> tag to be pulled, you name it.  Because if you don't name it, it now
> defaults to HEAD (like all other git log commands) rather than
> guessing. So please write it as
> 
>git request-pull master git://neil.brown.name/md md/3.15-fixes
> 
> I guess the man-page should be made more explicit about this too.
> 
>   Linus

OK, thanks.   I guess I can live with being a bit more explicit.

NeilBrown


signature.asc
Description: PGP signature