[gentoo-dev] Re: [gentoo-commits] gentoo-x86 commit in net-libs/wvstreams: wvstreams-4.4.ebuild wvstreams-4.3-r2.ebuild ChangeLog

2007-09-19 Thread Mike Frysinger
On Tuesday 18 September 2007, Alin Nastac (mrness) wrote:
> mrness  07/09/18 18:53:40
>
>   Modified: wvstreams-4.4.ebuild wvstreams-4.3-r2.ebuild
> ChangeLog
>   Log:
>   Set WANT_AUTOCONF=latest (#192947).
>   (Portage version: 2.1.2.12)

there is no need to do that explicitly anymore as that is the default in 
autotools.eclass ...
-mike


signature.asc
Description: This is a digitally signed message part.


[gentoo-dev] Re: [gentoo-commits] gentoo-x86 commit in sci-biology/phylip: ChangeLog phylip-3.67.ebuild

2007-09-19 Thread Donnie Berkholz
On 18:32 Wed 19 Sep , Olivier Fisette (ribosome) wrote:
>   Modified: ChangeLog
>   Added:phylip-3.67.ebuild
>   Log:
>   New upstream version.
>   (Portage version: 2.1.3.9)
> 

> file : 
> http://sources.gentoo.org/viewcvs.py/gentoo-x86/sci-biology/phylip/ChangeLog?rev=1.27&view=markup
> plain: 
> http://sources.gentoo.org/viewcvs.py/gentoo-x86/sci-biology/phylip/ChangeLog?rev=1.27&content-type=text/plain
> diff : 
> http://sources.gentoo.org/viewcvs.py/gentoo-x86/sci-biology/phylip/ChangeLog?r1=1.26&r2=1.27

> src_compile() {
>   sed -e "s/CFLAGS  = -O3 -fomit-frame-pointer/CFLAGS = ${CFLAGS}/" \
>   -e "s/CC= cc/CC= $(tc-getCC)/" \
>   -e "s/DC= cc/DC= $(tc-getCC)/" \
>   -i Makefile || die "Patching Makefile failed."

This sed is pretty fragile, since it relies on upstream not changing the 
spacing or the default CFLAGS. Better tokens might do something like this:

sed -e "s:^\(CFLAGS.*=\).*:\1 ${CFLAGS}:g"

Thanks,
Donnie
-- 
[EMAIL PROTECTED] mailing list



Re: [gentoo-dev] Re: [gentoo-commits] gentoo-x86 commit in sci-biology/phylip: ChangeLog phylip-3.67.ebuild

2007-09-19 Thread Mike Frysinger
On Wednesday 19 September 2007, Donnie Berkholz wrote:
> On 18:32 Wed 19 Sep , Olivier Fisette (ribosome) wrote:
> >   Modified: ChangeLog
> >   Added:phylip-3.67.ebuild
> >   Log:
> >   New upstream version.
> >   (Portage version: 2.1.3.9)
> >
> >
> > file :
> > http://sources.gentoo.org/viewcvs.py/gentoo-x86/sci-biology/phylip/Change
> >Log?rev=1.27&view=markup plain:
> > http://sources.gentoo.org/viewcvs.py/gentoo-x86/sci-biology/phylip/Change
> >Log?rev=1.27&content-type=text/plain diff :
> > http://sources.gentoo.org/viewcvs.py/gentoo-x86/sci-biology/phylip/Change
> >Log?r1=1.26&r2=1.27
> >
> > src_compile() {
> > sed -e "s/CFLAGS  = -O3 -fomit-frame-pointer/CFLAGS = ${CFLAGS}/" \
> > -e "s/CC= cc/CC= $(tc-getCC)/" \
> > -e "s/DC= cc/DC= $(tc-getCC)/" \
> > -i Makefile || die "Patching Makefile failed."
>
> This sed is pretty fragile, since it relies on upstream not changing the
> spacing or the default CFLAGS. Better tokens might do something like this:
>
> sed -e "s:^\(CFLAGS.*=\).*:\1 ${CFLAGS}:g"

or do a match/replace and let the env accumulate like normal:
sed -e '/^CFLAGS =/s:=.*:+=:' 
-mike


signature.asc
Description: This is a digitally signed message part.


[gentoo-dev] Why isn't /root/.bash_profile in the stage tarballs?

2007-09-19 Thread John R. Graham
On the forums, I've seen the question, "Why isn't my .bashrc being
executed when I log in as root but is being executed when I log in as a
normal user?," asked half a dozen times on the forums. Heck, I even
asked it myself a few years ago. Now, two years later, from a slightly
more mature level of domain knowledge, I have to ask why the root cause
shouldn't be addressed. Why can't the simple little default
.bash_profile from /etc/skel be put into /root as well?

- John
-- 
[EMAIL PROTECTED] mailing list



Re: [gentoo-dev] Why isn't /root/.bash_profile in the stage tarballs?

2007-09-19 Thread Andrew Gaffney

John R. Graham wrote:

On the forums, I've seen the question, "Why isn't my .bashrc being
executed when I log in as root but is being executed when I log in as a
normal user?," asked half a dozen times on the forums. Heck, I even
asked it myself a few years ago. Now, two years later, from a slightly
more mature level of domain knowledge, I have to ask why the root cause
shouldn't be addressed. Why can't the simple little default
.bash_profile from /etc/skel be put into /root as well?


When catalyst builds a stage tarball, it doesn't add any additional files. All 
files in any stage tarball are created by one of the packages contained within. 
In order to do this, a package such as baselayout would have to install the file.


Looking at my local install, it's actually bash that creates 
/etc/skel/.bash{rc,_logout,_profile}. You can appeal to the maintainer(s) of the 
bash ebuild (should be the base-system herd) to add that functionality, but I 
really doubt you'll convince them.


--
Andrew Gaffney http://dev.gentoo.org/~agaffney/
Gentoo Linux Developer Catalyst/Installer + x86 release coordinator
--
[EMAIL PROTECTED] mailing list



Re: [gentoo-dev] Why isn't /root/.bash_profile in the stage tarballs?

2007-09-19 Thread John R. Graham


Andrew Gaffney wrote:
> When catalyst builds a stage tarball, it doesn't add any additional
> files. All files in any stage tarball are created by one of the
> packages contained within. In order to do this, a package such as
> baselayout would have to install the file.
>
> Looking at my local install, it's actually bash that creates
> /etc/skel/.bash{rc,_logout,_profile}. You can appeal to the
> maintainer(s) of the bash ebuild (should be the base-system herd) to
> add that functionality, but I really doubt you'll convince them.
I understand.  Philosophically, it probably fits better in something
like sys-apps/miscfiles.  But where it should or shouldn't come from
doesn't answer the fundamental question, "Shouldn't it be there, from
*some* source?"

- John
-- 
[EMAIL PROTECTED] mailing list



Re: [gentoo-dev] Why isn't /root/.bash_profile in the stage tarballs?

2007-09-19 Thread Mike Doty

John R. Graham wrote:

like sys-apps/miscfiles.  But where it should or shouldn't come from
doesn't answer the fundamental question, "Shouldn't it be there, from
*some* source?"
Easy answer: no.  Do you really want any script to automatically run 
when you login as root?  think of exploits and the ability to do 
"/bin/echo rm -rf / >> /root/.bash_profile"


It would be nice if one could tell bash to not run any ~/.bash* when 
{e,}uid==0.


--
===
Mike Doty  kingtaco -at- gentoo.org
Gentoo Council
Gentoo Infrastructure
Gentoo/AMD64 Strategic Lead
GPG: E1A5 1C9C 93FE F430 C1D6  F2AF 806B A2E4 19F4 AE05
===
--
[EMAIL PROTECTED] mailing list



Re: [gentoo-dev] Why isn't /root/.bash_profile in the stage tarballs?

2007-09-19 Thread John R. Graham
Mike, that exploit is neither easier nor harder if a default
.bash_profile exists.  Or, am I missing something?

- John

Mike Doty wrote:
> John R. Graham wrote:
>> like sys-apps/miscfiles.  But where it should or shouldn't come from
>> doesn't answer the fundamental question, "Shouldn't it be there, from
>> *some* source?"
> Easy answer: no.  Do you really want any script to automatically run
> when you login as root?  think of exploits and the ability to do
> "/bin/echo rm -rf / >> /root/.bash_profile"
>
> It would be nice if one could tell bash to not run any ~/.bash* when
> {e,}uid==0.
>
-- 
[EMAIL PROTECTED] mailing list



Re: [gentoo-dev] Why isn't /root/.bash_profile in the stage tarballs?

2007-09-19 Thread Alin Năstac
John R. Graham wrote:
> Why can't the simple little default
> .bash_profile from /etc/skel be put into /root as well?
>   

$HOME directories shouldn't be touched by emerge. This is the user's turf.



signature.asc
Description: OpenPGP digital signature