Re: [VOTE] Release Apache Teaclave (incubating) v0.5.1-rc.1

2023-05-17 Thread He Sun
Hi  Justin,

I read your comments carefully and found that the only gap was in 
./third_party/rust-sgx-sdk and I am going to fix it soon.

- I did not see any license problem with crypto/src/lib.rs or its relation with 
https://github.com/skalenetwork/sgxwallet/blob/develop/LevelDB.cpp. 
- The GPL in ./third_party/wamr.patch is from a removed file. We do not add any 
GPL file in the patch.
- common/rusty_leveldb_sgx is modified from 
https://github.com/dermesser/leveldb-rs that I think is a reimplementation of 
https://github.com/google/leveldb.
- Those different copyright statements from Google, HP, Sun, Intel, Android, 
Ant Financial, XiaoMi and many many others use SPDX-License-Identifier: 
Apache-2.0 WITH LLVM-exception. They are from third_party/wasm-micro-runtime.

Correct me if I am wrong.

Sincerely,
He

On 2023/05/15 06:55:58 Justin Mclean wrote:
> Hi,
> 
> A search for “General Public License” shows up in these files:
> ./third_party/wamr.patch
> ./third_party/rust-sgx-sdk/licenses/LICENSE-tlibc.txt
> ./third_party/rust-sgx-sdk/licenses/LICENSE-common-inc.txt
> ./third_party/rust-sgx-sdk/sgx_backtrace/sgx_backtrace_sys/libbacktrace/ltmain.sh
> ./third_party/rust-sgx-sdk/sgx_backtrace/sgx_backtrace_sys/libbacktrace/configure
> ./third_party/rust-sgx-sdk/sgx_backtrace/sgx_backtrace_sys/libbacktrace/config.guess
> ./third_party/rust-sgx-sdk/sgx_backtrace/sgx_backtrace_sys/libbacktrace/missing
> ./third_party/rust-sgx-sdk/sgx_backtrace/sgx_backtrace_sys/libbacktrace/config.sub
> 
> There are also a number of file copyright the Free Software Foundation. (also 
> in libbacktrace)
> 
> I’ve not looked at each one and the first couple do seem to be false 
> positives. However this file [1], which might incorrectly has a ASF header on 
> it, seems to be a 1:1 implementation of this [2]??? Even if it not file that 
> does look like 3rd party code to me. Do you know where it originally come 
> from? See also [4]. It seems the original is GPL licensed(?) and porting it 
> to another language wouldn’t change that.
> 
> This file [2] looks to be licensed (or at least some of it) under the Mozilla 
> license and that is Category B and can’t be included in a source release. The 
> very first part of that file is license "Apache-2.0 WITH LLVM-exception” I’m 
> not sure that would be allowed ether. There are other files wth this license 
> in the source release.
> 
> The LICENSE list three 3rd party piece of software:
> third_party/wasm-micro-runtime
> third_party/rust-sgx-sdk
> common/rusty_leveldb_sgx
> 
> But there is other 3rd party files in the source release, for instance 
> libunwind. Note also the number of different copyright statements fm Google, 
> HP, Sun, Intel, Android, Ant Financial, XiaoMi and many many others.
> 
> Kind Regards,
> Justin
> 
> 1. crypto/src/lib.rs
> 2. https://github.com/skalenetwork/sgxwallet/blob/develop/LevelDB.cpp
> 3. ./third_party/wamr.patch
> 4. https://teaclave.apache.org/teaclave/common/rusty_leveldb_sgx/

-
To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org
For additional commands, e-mail: general-h...@incubator.apache.org



Re: [VOTE] Release Apache Teaclave (incubating) v0.5.1-rc.1

2023-05-17 Thread Justin Mclean
Hi,

I would need to do a review in more detail to find out what should be added to 
LICENSE (and NOTICE) or if there are any other issues. I can see there further 
3rd party software included in your source please than needs to bee mentioned 
in LICENSE.

Re [1] it is under the MIT license but that may not accurate as it states "A 
fully compatible implementation of LevelDB in Rust. .. The implementation is 
very close to the original; often, you can see the same algorithm translated 
1:1, and class (struct) and method names are similar or the same.”. Given it is 
a copy of the original it should be under the same license as the original. Do 
you know where the original is? It's odd to me that [2] is BSD license but this 
copy is MIT licensed so perhaps that wasn’t the source?

Kind Regards,
Justin

1. https://github.com/dermesser/leveldb-rs
2. https://github.com/google/leveldb



-
To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org
For additional commands, e-mail: general-h...@incubator.apache.org



Re: [VOTE] Release Apache Paimon(incubating) 0.4.0-incubating rc5

2023-05-17 Thread Yu Li
+1 (binding)

- Checked release file name and location: *OK*

- Checked sum and signatures: *OK*

- Checked DISCLAIMER file exists: *OK*

- Checked LICENSE and NOTICE files: *OK*

   * License of 3rd-party code contained correctly mentioned in LICENSE:
*OK*

   * Included dependencies are mentioned in LICENSE: *OK*

   * Un-included software dependencies are not mentioned in LICENSE or
NOTICE: *OK*

   * Relevant part of NOTICE files of referred/contained ASF codes added
into NOTICE: *OK*

   * NOTICE year: *OK*

- Checked no binary files in source package: *OK*

- Checked compile from source: *OK* (JDK 8u181)

- Checked UT could pass: *OK* (JDK 8u181)

Best Regards,
Yu


On Mon, 15 May 2023 at 17:53, Jingsong Li  wrote:

> Hello Incubator PMC,
>
> The Apache Paimon community has voted and approved the release of
> Apache Paimon(incubating) 0.4.0-incubating rc5. We now kindly request
> the IPMC members review and vote for this release.
>
> Apache Paimon(incubating) is a streaming data lake platform that
> supports high-speed data ingestion, change data tracking and efficient
> real-time analytics.
>
> Paimon community vote thread:
>
> https://lists.apache.org/thread/wkqlokj752vm097wrqmks87mkl30bzoz
>
> Vote result thread:
>
> https://lists.apache.org/thread/1j7zd3fv11jcryy913d1rbpj84ysbx7b
>
> The official Apache source release to be deployed to dist.apache.org:
>
>
> https://dist.apache.org/repos/dist/dev/incubator/paimon/paimon-0.4.0-incubating-rc5/
>
> This source release has been signed with a PGP available here:
>
> https://downloads.apache.org/incubator/paimon/KEYS
>
> All artifacts to be deployed to the Maven Central Repository:
>
> https://repository.apache.org/content/repositories/orgapachepaimon-1016/
>
> Git branch for the release:
>
>
> https://github.com/apache/incubator-paimon-shade/tree/release-0.4.0-incubating-rc5
>
> https://github.com/apache/incubator-paimon/tree/release-0.4.0-incubating-rc5
>
> Please download, verify, and test.
>
> The VOTE will pass after 3 binding approve.
>
> [ ] +1 approve
> [ ] +0 no opinion
> [ ] -1 disapprove with the reason
>
> To learn more about apache paimon, please see https://paimon.apache.org/
>
> Checklist for reference:
>
> [ ] Download links are valid.
> [ ] Checksums and signatures.
> [ ] LICENSE/NOTICE files exist
> [ ] No unexpected binary files
> [ ] All source files have ASF headers
> [ ] Can compile from source
>
> Best,
> Jingsong
>
> -
> To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org
> For additional commands, e-mail: general-h...@incubator.apache.org
>
>


Re: [VOTE] Release Apache Teaclave (incubating) v0.5.1-rc.1

2023-05-17 Thread He Sun
Hi Justin,

I opened an issue in https://github.com/dermesser/leveldb-rs/issues/26.
The auther confirmed the original and gave some explanation about the different 
license.

Thanks,
He

On 2023/05/17 07:28:43 Justin Mclean wrote:
> Hi,
> 
> I would need to do a review in more detail to find out what should be added 
> to LICENSE (and NOTICE) or if there are any other issues. I can see there 
> further 3rd party software included in your source please than needs to bee 
> mentioned in LICENSE.
> 
> Re [1] it is under the MIT license but that may not accurate as it states "A 
> fully compatible implementation of LevelDB in Rust. .. The implementation is 
> very close to the original; often, you can see the same algorithm translated 
> 1:1, and class (struct) and method names are similar or the same.”. Given it 
> is a copy of the original it should be under the same license as the 
> original. Do you know where the original is? It's odd to me that [2] is BSD 
> license but this copy is MIT licensed so perhaps that wasn’t the source?
> 
> Kind Regards,
> Justin
> 
> 1. https://github.com/dermesser/leveldb-rs
> 2. https://github.com/google/leveldb
> 
> 
> 
> -
> To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org
> For additional commands, e-mail: general-h...@incubator.apache.org
> 
> 

-
To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org
For additional commands, e-mail: general-h...@incubator.apache.org



Re: [Podlings]Please check the checksum and signature link

2023-05-17 Thread Calvin Kirs
Hi Dave,
On Tue, May 16, 2023 at 9:14 AM Dave Fisher  wrote:
>
> Hi Calvin,
>
> I think that since the ASF has moved from a mirror network to a CDN this 
> requirement may have changed without proper updates.
>
> Would you mind reaching out to infra to confirm.
Thank you point for this, and I confirmed with INFRA that we still
need to follow this[1].
[1]https://infra.apache.org/release-distribution.html#sigs-and-sums
>
> Thanks,
> Dave
>
> Sent from my iPhone
>
> > On May 14, 2023, at 10:55 PM, Calvin Kirs  wrote:
> >
> > On Mon, May 15, 2023 at 1:24 PM Riley Kuttruff  wrote:
> >>
> >> Hi Calvin,
> >>
> >> Thanks for pointing that out. I'll get it addressed for the next vote 
> >> threads.
> >
> > Hi,
> > you just need to change the checksum and signature link prefix on the
> > download page [1] to downloads.apache.org.
> > For example: 
> > https://www.apache.org/dyn/closer.lua/incubator/sdap/1.0.0-incubating/apache-sdap-ingester-1.0.0-incubating-src.tar.gz.asc
> > to
> > https://downloads.apache.org/incubator/sdap/1.0.0-incubating/apache-sdap-ingester-1.0.0-incubating-src.tar.gz.asc
> >
> > [1] https://sdap.apache.org/downloads
> >>
> >> -Riley
> >>
> >>> On 2023/05/15 05:19:56 Calvin Kirs wrote:
> >>> Hi Podlings,
> >>>
> >>> Note that the links to the checksum and signature must not be to the
> >>> mirror selector, but must be direct to downloads.apache.org.
> >>>
> >>> I noticed that StreamPark and SDAP use the mirror address. If this is
> >>> the case in other projects, please update it in time.
> >>>
> >>> --
> >>> Best wishes!
> >>> CalvinKirs
> >>>
> >>> -
> >>> To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org
> >>> For additional commands, e-mail: general-h...@incubator.apache.org
> >>>
> >>>
> >>
> >> -
> >> To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org
> >> For additional commands, e-mail: general-h...@incubator.apache.org
> >>
> >
> >
> > --
> > Best wishes!
> > CalvinKirs
> >
> > -
> > To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org
> > For additional commands, e-mail: general-h...@incubator.apache.org
> >
>
>
> -
> To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org
> For additional commands, e-mail: general-h...@incubator.apache.org
>


-- 
Best wishes!
CalvinKirs

-
To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org
For additional commands, e-mail: general-h...@incubator.apache.org



Re: [VOTE] Release Apache Paimon(incubating) 0.4.0-incubating rc5

2023-05-17 Thread Becket Qin
+1 (binding)

- verified signature and checksum
- verified license in the source code
- locally built the source and ran all the tests. (Some of the tests are
occasionally failing due to testcontainer timeout, but does not seem a
blocker of release).

Thanks,

Jiangjie (Becket) Qin



On Wed, May 17, 2023 at 10:33 AM Yu Li  wrote:

> +1 (binding)
>
> - Checked release file name and location: *OK*
>
> - Checked sum and signatures: *OK*
>
> - Checked DISCLAIMER file exists: *OK*
>
> - Checked LICENSE and NOTICE files: *OK*
>
>* License of 3rd-party code contained correctly mentioned in LICENSE:
> *OK*
>
>* Included dependencies are mentioned in LICENSE: *OK*
>
>* Un-included software dependencies are not mentioned in LICENSE or
> NOTICE: *OK*
>
>* Relevant part of NOTICE files of referred/contained ASF codes added
> into NOTICE: *OK*
>
>* NOTICE year: *OK*
>
> - Checked no binary files in source package: *OK*
>
> - Checked compile from source: *OK* (JDK 8u181)
>
> - Checked UT could pass: *OK* (JDK 8u181)
>
> Best Regards,
> Yu
>
>
> On Mon, 15 May 2023 at 17:53, Jingsong Li  wrote:
>
> > Hello Incubator PMC,
> >
> > The Apache Paimon community has voted and approved the release of
> > Apache Paimon(incubating) 0.4.0-incubating rc5. We now kindly request
> > the IPMC members review and vote for this release.
> >
> > Apache Paimon(incubating) is a streaming data lake platform that
> > supports high-speed data ingestion, change data tracking and efficient
> > real-time analytics.
> >
> > Paimon community vote thread:
> >
> > https://lists.apache.org/thread/wkqlokj752vm097wrqmks87mkl30bzoz
> >
> > Vote result thread:
> >
> > https://lists.apache.org/thread/1j7zd3fv11jcryy913d1rbpj84ysbx7b
> >
> > The official Apache source release to be deployed to dist.apache.org:
> >
> >
> >
> https://dist.apache.org/repos/dist/dev/incubator/paimon/paimon-0.4.0-incubating-rc5/
> >
> > This source release has been signed with a PGP available here:
> >
> > https://downloads.apache.org/incubator/paimon/KEYS
> >
> > All artifacts to be deployed to the Maven Central Repository:
> >
> > https://repository.apache.org/content/repositories/orgapachepaimon-1016/
> >
> > Git branch for the release:
> >
> >
> >
> https://github.com/apache/incubator-paimon-shade/tree/release-0.4.0-incubating-rc5
> >
> >
> https://github.com/apache/incubator-paimon/tree/release-0.4.0-incubating-rc5
> >
> > Please download, verify, and test.
> >
> > The VOTE will pass after 3 binding approve.
> >
> > [ ] +1 approve
> > [ ] +0 no opinion
> > [ ] -1 disapprove with the reason
> >
> > To learn more about apache paimon, please see https://paimon.apache.org/
> >
> > Checklist for reference:
> >
> > [ ] Download links are valid.
> > [ ] Checksums and signatures.
> > [ ] LICENSE/NOTICE files exist
> > [ ] No unexpected binary files
> > [ ] All source files have ASF headers
> > [ ] Can compile from source
> >
> > Best,
> > Jingsong
> >
> > -
> > To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org
> > For additional commands, e-mail: general-h...@incubator.apache.org
> >
> >
>


Re: [VOTE] Release Apache Paimon(incubating) 0.4.0-incubating rc5

2023-05-17 Thread JUN GAO
+1 (non-binding)
Download links are valid.
Checksums and signatures.
LICENSE/NOTICE files exist
All source files have ASF headers


Becket Qin  于2023年5月18日周四 14:22写道:

> +1 (binding)
>
> - verified signature and checksum
> - verified license in the source code
> - locally built the source and ran all the tests. (Some of the tests are
> occasionally failing due to testcontainer timeout, but does not seem a
> blocker of release).
>
> Thanks,
>
> Jiangjie (Becket) Qin
>
>
>
> On Wed, May 17, 2023 at 10:33 AM Yu Li  wrote:
>
> > +1 (binding)
> >
> > - Checked release file name and location: *OK*
> >
> > - Checked sum and signatures: *OK*
> >
> > - Checked DISCLAIMER file exists: *OK*
> >
> > - Checked LICENSE and NOTICE files: *OK*
> >
> >* License of 3rd-party code contained correctly mentioned in LICENSE:
> > *OK*
> >
> >* Included dependencies are mentioned in LICENSE: *OK*
> >
> >* Un-included software dependencies are not mentioned in LICENSE or
> > NOTICE: *OK*
> >
> >* Relevant part of NOTICE files of referred/contained ASF codes added
> > into NOTICE: *OK*
> >
> >* NOTICE year: *OK*
> >
> > - Checked no binary files in source package: *OK*
> >
> > - Checked compile from source: *OK* (JDK 8u181)
> >
> > - Checked UT could pass: *OK* (JDK 8u181)
> >
> > Best Regards,
> > Yu
> >
> >
> > On Mon, 15 May 2023 at 17:53, Jingsong Li 
> wrote:
> >
> > > Hello Incubator PMC,
> > >
> > > The Apache Paimon community has voted and approved the release of
> > > Apache Paimon(incubating) 0.4.0-incubating rc5. We now kindly request
> > > the IPMC members review and vote for this release.
> > >
> > > Apache Paimon(incubating) is a streaming data lake platform that
> > > supports high-speed data ingestion, change data tracking and efficient
> > > real-time analytics.
> > >
> > > Paimon community vote thread:
> > >
> > > https://lists.apache.org/thread/wkqlokj752vm097wrqmks87mkl30bzoz
> > >
> > > Vote result thread:
> > >
> > > https://lists.apache.org/thread/1j7zd3fv11jcryy913d1rbpj84ysbx7b
> > >
> > > The official Apache source release to be deployed to dist.apache.org:
> > >
> > >
> > >
> >
> https://dist.apache.org/repos/dist/dev/incubator/paimon/paimon-0.4.0-incubating-rc5/
> > >
> > > This source release has been signed with a PGP available here:
> > >
> > > https://downloads.apache.org/incubator/paimon/KEYS
> > >
> > > All artifacts to be deployed to the Maven Central Repository:
> > >
> > >
> https://repository.apache.org/content/repositories/orgapachepaimon-1016/
> > >
> > > Git branch for the release:
> > >
> > >
> > >
> >
> https://github.com/apache/incubator-paimon-shade/tree/release-0.4.0-incubating-rc5
> > >
> > >
> >
> https://github.com/apache/incubator-paimon/tree/release-0.4.0-incubating-rc5
> > >
> > > Please download, verify, and test.
> > >
> > > The VOTE will pass after 3 binding approve.
> > >
> > > [ ] +1 approve
> > > [ ] +0 no opinion
> > > [ ] -1 disapprove with the reason
> > >
> > > To learn more about apache paimon, please see
> https://paimon.apache.org/
> > >
> > > Checklist for reference:
> > >
> > > [ ] Download links are valid.
> > > [ ] Checksums and signatures.
> > > [ ] LICENSE/NOTICE files exist
> > > [ ] No unexpected binary files
> > > [ ] All source files have ASF headers
> > > [ ] Can compile from source
> > >
> > > Best,
> > > Jingsong
> > >
> > > -
> > > To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org
> > > For additional commands, e-mail: general-h...@incubator.apache.org
> > >
> > >
> >
>


-- 

Best Regards



EricJoy2048
gaojun2...@gmail.com


Re: [VOTE] Release Apache Paimon(incubating) 0.4.0-incubating rc5

2023-05-17 Thread Lucifer Tyrant
+1 (non-binding)

I checked:

[x] Download links are valid
[x] Checksums and PGP signatures are valid
[x] DISCLAIMER is included
[x] Source code artifacts have correct names matching the current release
[x] LICENSE and NOTICE files are correct for each repo
[x] All files have license headers if necessary
[x] No compiled archives bundled in source archive

Best,
Chao Tian

JUN GAO  于2023年5月18日周四 14:34写道:

> +1 (non-binding)
> Download links are valid.
> Checksums and signatures.
> LICENSE/NOTICE files exist
> All source files have ASF headers
>
>
> Becket Qin  于2023年5月18日周四 14:22写道:
>
> > +1 (binding)
> >
> > - verified signature and checksum
> > - verified license in the source code
> > - locally built the source and ran all the tests. (Some of the tests are
> > occasionally failing due to testcontainer timeout, but does not seem a
> > blocker of release).
> >
> > Thanks,
> >
> > Jiangjie (Becket) Qin
> >
> >
> >
> > On Wed, May 17, 2023 at 10:33 AM Yu Li  wrote:
> >
> > > +1 (binding)
> > >
> > > - Checked release file name and location: *OK*
> > >
> > > - Checked sum and signatures: *OK*
> > >
> > > - Checked DISCLAIMER file exists: *OK*
> > >
> > > - Checked LICENSE and NOTICE files: *OK*
> > >
> > >* License of 3rd-party code contained correctly mentioned in
> LICENSE:
> > > *OK*
> > >
> > >* Included dependencies are mentioned in LICENSE: *OK*
> > >
> > >* Un-included software dependencies are not mentioned in LICENSE or
> > > NOTICE: *OK*
> > >
> > >* Relevant part of NOTICE files of referred/contained ASF codes
> added
> > > into NOTICE: *OK*
> > >
> > >* NOTICE year: *OK*
> > >
> > > - Checked no binary files in source package: *OK*
> > >
> > > - Checked compile from source: *OK* (JDK 8u181)
> > >
> > > - Checked UT could pass: *OK* (JDK 8u181)
> > >
> > > Best Regards,
> > > Yu
> > >
> > >
> > > On Mon, 15 May 2023 at 17:53, Jingsong Li 
> > wrote:
> > >
> > > > Hello Incubator PMC,
> > > >
> > > > The Apache Paimon community has voted and approved the release of
> > > > Apache Paimon(incubating) 0.4.0-incubating rc5. We now kindly request
> > > > the IPMC members review and vote for this release.
> > > >
> > > > Apache Paimon(incubating) is a streaming data lake platform that
> > > > supports high-speed data ingestion, change data tracking and
> efficient
> > > > real-time analytics.
> > > >
> > > > Paimon community vote thread:
> > > >
> > > > https://lists.apache.org/thread/wkqlokj752vm097wrqmks87mkl30bzoz
> > > >
> > > > Vote result thread:
> > > >
> > > > https://lists.apache.org/thread/1j7zd3fv11jcryy913d1rbpj84ysbx7b
> > > >
> > > > The official Apache source release to be deployed to dist.apache.org
> :
> > > >
> > > >
> > > >
> > >
> >
> https://dist.apache.org/repos/dist/dev/incubator/paimon/paimon-0.4.0-incubating-rc5/
> > > >
> > > > This source release has been signed with a PGP available here:
> > > >
> > > > https://downloads.apache.org/incubator/paimon/KEYS
> > > >
> > > > All artifacts to be deployed to the Maven Central Repository:
> > > >
> > > >
> > https://repository.apache.org/content/repositories/orgapachepaimon-1016/
> > > >
> > > > Git branch for the release:
> > > >
> > > >
> > > >
> > >
> >
> https://github.com/apache/incubator-paimon-shade/tree/release-0.4.0-incubating-rc5
> > > >
> > > >
> > >
> >
> https://github.com/apache/incubator-paimon/tree/release-0.4.0-incubating-rc5
> > > >
> > > > Please download, verify, and test.
> > > >
> > > > The VOTE will pass after 3 binding approve.
> > > >
> > > > [ ] +1 approve
> > > > [ ] +0 no opinion
> > > > [ ] -1 disapprove with the reason
> > > >
> > > > To learn more about apache paimon, please see
> > https://paimon.apache.org/
> > > >
> > > > Checklist for reference:
> > > >
> > > > [ ] Download links are valid.
> > > > [ ] Checksums and signatures.
> > > > [ ] LICENSE/NOTICE files exist
> > > > [ ] No unexpected binary files
> > > > [ ] All source files have ASF headers
> > > > [ ] Can compile from source
> > > >
> > > > Best,
> > > > Jingsong
> > > >
> > > > -
> > > > To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org
> > > > For additional commands, e-mail: general-h...@incubator.apache.org
> > > >
> > > >
> > >
> >
>
>
> --
>
> Best Regards
>
> 
>
> EricJoy2048
> gaojun2...@gmail.com
>


Re: [VOTE] Release Apache Paimon(incubating) 0.4.0-incubating rc5

2023-05-17 Thread Kent Yao
The NOTICE and the copy of LICENSE.scala in paimon-codegen are incorrect due to 
https://www.scala-lang.org/news/license-change.html

I am not sure if this is a blocker or not. 

Kent Yao

On 2023/05/18 06:21:09 Becket Qin wrote:
> +1 (binding)
> 
> - verified signature and checksum
> - verified license in the source code
> - locally built the source and ran all the tests. (Some of the tests are
> occasionally failing due to testcontainer timeout, but does not seem a
> blocker of release).
> 
> Thanks,
> 
> Jiangjie (Becket) Qin
> 
> 
> 
> On Wed, May 17, 2023 at 10:33 AM Yu Li  wrote:
> 
> > +1 (binding)
> >
> > - Checked release file name and location: *OK*
> >
> > - Checked sum and signatures: *OK*
> >
> > - Checked DISCLAIMER file exists: *OK*
> >
> > - Checked LICENSE and NOTICE files: *OK*
> >
> >* License of 3rd-party code contained correctly mentioned in LICENSE:
> > *OK*
> >
> >* Included dependencies are mentioned in LICENSE: *OK*
> >
> >* Un-included software dependencies are not mentioned in LICENSE or
> > NOTICE: *OK*
> >
> >* Relevant part of NOTICE files of referred/contained ASF codes added
> > into NOTICE: *OK*
> >
> >* NOTICE year: *OK*
> >
> > - Checked no binary files in source package: *OK*
> >
> > - Checked compile from source: *OK* (JDK 8u181)
> >
> > - Checked UT could pass: *OK* (JDK 8u181)
> >
> > Best Regards,
> > Yu
> >
> >
> > On Mon, 15 May 2023 at 17:53, Jingsong Li  wrote:
> >
> > > Hello Incubator PMC,
> > >
> > > The Apache Paimon community has voted and approved the release of
> > > Apache Paimon(incubating) 0.4.0-incubating rc5. We now kindly request
> > > the IPMC members review and vote for this release.
> > >
> > > Apache Paimon(incubating) is a streaming data lake platform that
> > > supports high-speed data ingestion, change data tracking and efficient
> > > real-time analytics.
> > >
> > > Paimon community vote thread:
> > >
> > > https://lists.apache.org/thread/wkqlokj752vm097wrqmks87mkl30bzoz
> > >
> > > Vote result thread:
> > >
> > > https://lists.apache.org/thread/1j7zd3fv11jcryy913d1rbpj84ysbx7b
> > >
> > > The official Apache source release to be deployed to dist.apache.org:
> > >
> > >
> > >
> > https://dist.apache.org/repos/dist/dev/incubator/paimon/paimon-0.4.0-incubating-rc5/
> > >
> > > This source release has been signed with a PGP available here:
> > >
> > > https://downloads.apache.org/incubator/paimon/KEYS
> > >
> > > All artifacts to be deployed to the Maven Central Repository:
> > >
> > > https://repository.apache.org/content/repositories/orgapachepaimon-1016/
> > >
> > > Git branch for the release:
> > >
> > >
> > >
> > https://github.com/apache/incubator-paimon-shade/tree/release-0.4.0-incubating-rc5
> > >
> > >
> > https://github.com/apache/incubator-paimon/tree/release-0.4.0-incubating-rc5
> > >
> > > Please download, verify, and test.
> > >
> > > The VOTE will pass after 3 binding approve.
> > >
> > > [ ] +1 approve
> > > [ ] +0 no opinion
> > > [ ] -1 disapprove with the reason
> > >
> > > To learn more about apache paimon, please see https://paimon.apache.org/
> > >
> > > Checklist for reference:
> > >
> > > [ ] Download links are valid.
> > > [ ] Checksums and signatures.
> > > [ ] LICENSE/NOTICE files exist
> > > [ ] No unexpected binary files
> > > [ ] All source files have ASF headers
> > > [ ] Can compile from source
> > >
> > > Best,
> > > Jingsong
> > >
> > > -
> > > To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org
> > > For additional commands, e-mail: general-h...@incubator.apache.org
> > >
> > >
> >
> 

-
To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org
For additional commands, e-mail: general-h...@incubator.apache.org



Re: [VOTE] Release Apache Paimon(incubating) 0.4.0-incubating rc5

2023-05-17 Thread Justin Mclean
HI,

> The NOTICE and the copy of LICENSE.scala in paimon-codegen are incorrect due 
> to https://www.scala-lang.org/news/license-change.html
> 
> I am not sure if this is a blocker or not. 

I think that can be fixed in a later release, both licenses are compatible with 
the Apache license so it more a documentation issue than a legal one.

Kind Regards,
Justin
-
To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org
For additional commands, e-mail: general-h...@incubator.apache.org



Re: [VOTE] Release Apache Paimon(incubating) 0.4.0-incubating rc5

2023-05-17 Thread Yu Li
Thanks for the note Kent. Scala has indeed changed to ALv2 today, but
before Dec. 2018 it used BSD 3-clause license, and the scala version
depended in Paimon is 2.12.7, which was released in Sep. 2018.

I also noticed this during review and commented on the PR [1], JFYI.

Please let us know if any further concerns. Thanks.

Best Regards,
Yu

[1]
https://github.com/apache/incubator-paimon/pull/1067#discussion_r1188058405


On Thu, 18 May 2023 at 14:43, Kent Yao  wrote:

> The NOTICE and the copy of LICENSE.scala in paimon-codegen are incorrect
> due to https://www.scala-lang.org/news/license-change.html
>
> I am not sure if this is a blocker or not.
>
> Kent Yao
>
> On 2023/05/18 06:21:09 Becket Qin wrote:
> > +1 (binding)
> >
> > - verified signature and checksum
> > - verified license in the source code
> > - locally built the source and ran all the tests. (Some of the tests are
> > occasionally failing due to testcontainer timeout, but does not seem a
> > blocker of release).
> >
> > Thanks,
> >
> > Jiangjie (Becket) Qin
> >
> >
> >
> > On Wed, May 17, 2023 at 10:33 AM Yu Li  wrote:
> >
> > > +1 (binding)
> > >
> > > - Checked release file name and location: *OK*
> > >
> > > - Checked sum and signatures: *OK*
> > >
> > > - Checked DISCLAIMER file exists: *OK*
> > >
> > > - Checked LICENSE and NOTICE files: *OK*
> > >
> > >* License of 3rd-party code contained correctly mentioned in
> LICENSE:
> > > *OK*
> > >
> > >* Included dependencies are mentioned in LICENSE: *OK*
> > >
> > >* Un-included software dependencies are not mentioned in LICENSE or
> > > NOTICE: *OK*
> > >
> > >* Relevant part of NOTICE files of referred/contained ASF codes
> added
> > > into NOTICE: *OK*
> > >
> > >* NOTICE year: *OK*
> > >
> > > - Checked no binary files in source package: *OK*
> > >
> > > - Checked compile from source: *OK* (JDK 8u181)
> > >
> > > - Checked UT could pass: *OK* (JDK 8u181)
> > >
> > > Best Regards,
> > > Yu
> > >
> > >
> > > On Mon, 15 May 2023 at 17:53, Jingsong Li 
> wrote:
> > >
> > > > Hello Incubator PMC,
> > > >
> > > > The Apache Paimon community has voted and approved the release of
> > > > Apache Paimon(incubating) 0.4.0-incubating rc5. We now kindly request
> > > > the IPMC members review and vote for this release.
> > > >
> > > > Apache Paimon(incubating) is a streaming data lake platform that
> > > > supports high-speed data ingestion, change data tracking and
> efficient
> > > > real-time analytics.
> > > >
> > > > Paimon community vote thread:
> > > >
> > > > https://lists.apache.org/thread/wkqlokj752vm097wrqmks87mkl30bzoz
> > > >
> > > > Vote result thread:
> > > >
> > > > https://lists.apache.org/thread/1j7zd3fv11jcryy913d1rbpj84ysbx7b
> > > >
> > > > The official Apache source release to be deployed to dist.apache.org
> :
> > > >
> > > >
> > > >
> > >
> https://dist.apache.org/repos/dist/dev/incubator/paimon/paimon-0.4.0-incubating-rc5/
> > > >
> > > > This source release has been signed with a PGP available here:
> > > >
> > > > https://downloads.apache.org/incubator/paimon/KEYS
> > > >
> > > > All artifacts to be deployed to the Maven Central Repository:
> > > >
> > > >
> https://repository.apache.org/content/repositories/orgapachepaimon-1016/
> > > >
> > > > Git branch for the release:
> > > >
> > > >
> > > >
> > >
> https://github.com/apache/incubator-paimon-shade/tree/release-0.4.0-incubating-rc5
> > > >
> > > >
> > >
> https://github.com/apache/incubator-paimon/tree/release-0.4.0-incubating-rc5
> > > >
> > > > Please download, verify, and test.
> > > >
> > > > The VOTE will pass after 3 binding approve.
> > > >
> > > > [ ] +1 approve
> > > > [ ] +0 no opinion
> > > > [ ] -1 disapprove with the reason
> > > >
> > > > To learn more about apache paimon, please see
> https://paimon.apache.org/
> > > >
> > > > Checklist for reference:
> > > >
> > > > [ ] Download links are valid.
> > > > [ ] Checksums and signatures.
> > > > [ ] LICENSE/NOTICE files exist
> > > > [ ] No unexpected binary files
> > > > [ ] All source files have ASF headers
> > > > [ ] Can compile from source
> > > >
> > > > Best,
> > > > Jingsong
> > > >
> > > > -
> > > > To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org
> > > > For additional commands, e-mail: general-h...@incubator.apache.org
> > > >
> > > >
> > >
> >
>
> -
> To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org
> For additional commands, e-mail: general-h...@incubator.apache.org
>
>


Re: [VOTE] Release Apache Paimon(incubating) 0.4.0-incubating rc5

2023-05-17 Thread Kent Yao
Hi Justin & Yu. Thanks for the explaination.

+1(non-binding)

Kent Yao


On 2023/05/18 06:49:14 Yu Li wrote:
> Thanks for the note Kent. Scala has indeed changed to ALv2 today, but
> before Dec. 2018 it used BSD 3-clause license, and the scala version
> depended in Paimon is 2.12.7, which was released in Sep. 2018.
> 
> I also noticed this during review and commented on the PR [1], JFYI.
> 
> Please let us know if any further concerns. Thanks.
> 
> Best Regards,
> Yu
> 
> [1]
> https://github.com/apache/incubator-paimon/pull/1067#discussion_r1188058405
> 
> 
> On Thu, 18 May 2023 at 14:43, Kent Yao  wrote:
> 
> > The NOTICE and the copy of LICENSE.scala in paimon-codegen are incorrect
> > due to https://www.scala-lang.org/news/license-change.html
> >
> > I am not sure if this is a blocker or not.
> >
> > Kent Yao
> >
> > On 2023/05/18 06:21:09 Becket Qin wrote:
> > > +1 (binding)
> > >
> > > - verified signature and checksum
> > > - verified license in the source code
> > > - locally built the source and ran all the tests. (Some of the tests are
> > > occasionally failing due to testcontainer timeout, but does not seem a
> > > blocker of release).
> > >
> > > Thanks,
> > >
> > > Jiangjie (Becket) Qin
> > >
> > >
> > >
> > > On Wed, May 17, 2023 at 10:33 AM Yu Li  wrote:
> > >
> > > > +1 (binding)
> > > >
> > > > - Checked release file name and location: *OK*
> > > >
> > > > - Checked sum and signatures: *OK*
> > > >
> > > > - Checked DISCLAIMER file exists: *OK*
> > > >
> > > > - Checked LICENSE and NOTICE files: *OK*
> > > >
> > > >* License of 3rd-party code contained correctly mentioned in
> > LICENSE:
> > > > *OK*
> > > >
> > > >* Included dependencies are mentioned in LICENSE: *OK*
> > > >
> > > >* Un-included software dependencies are not mentioned in LICENSE or
> > > > NOTICE: *OK*
> > > >
> > > >* Relevant part of NOTICE files of referred/contained ASF codes
> > added
> > > > into NOTICE: *OK*
> > > >
> > > >* NOTICE year: *OK*
> > > >
> > > > - Checked no binary files in source package: *OK*
> > > >
> > > > - Checked compile from source: *OK* (JDK 8u181)
> > > >
> > > > - Checked UT could pass: *OK* (JDK 8u181)
> > > >
> > > > Best Regards,
> > > > Yu
> > > >
> > > >
> > > > On Mon, 15 May 2023 at 17:53, Jingsong Li 
> > wrote:
> > > >
> > > > > Hello Incubator PMC,
> > > > >
> > > > > The Apache Paimon community has voted and approved the release of
> > > > > Apache Paimon(incubating) 0.4.0-incubating rc5. We now kindly request
> > > > > the IPMC members review and vote for this release.
> > > > >
> > > > > Apache Paimon(incubating) is a streaming data lake platform that
> > > > > supports high-speed data ingestion, change data tracking and
> > efficient
> > > > > real-time analytics.
> > > > >
> > > > > Paimon community vote thread:
> > > > >
> > > > > https://lists.apache.org/thread/wkqlokj752vm097wrqmks87mkl30bzoz
> > > > >
> > > > > Vote result thread:
> > > > >
> > > > > https://lists.apache.org/thread/1j7zd3fv11jcryy913d1rbpj84ysbx7b
> > > > >
> > > > > The official Apache source release to be deployed to dist.apache.org
> > :
> > > > >
> > > > >
> > > > >
> > > >
> > https://dist.apache.org/repos/dist/dev/incubator/paimon/paimon-0.4.0-incubating-rc5/
> > > > >
> > > > > This source release has been signed with a PGP available here:
> > > > >
> > > > > https://downloads.apache.org/incubator/paimon/KEYS
> > > > >
> > > > > All artifacts to be deployed to the Maven Central Repository:
> > > > >
> > > > >
> > https://repository.apache.org/content/repositories/orgapachepaimon-1016/
> > > > >
> > > > > Git branch for the release:
> > > > >
> > > > >
> > > > >
> > > >
> > https://github.com/apache/incubator-paimon-shade/tree/release-0.4.0-incubating-rc5
> > > > >
> > > > >
> > > >
> > https://github.com/apache/incubator-paimon/tree/release-0.4.0-incubating-rc5
> > > > >
> > > > > Please download, verify, and test.
> > > > >
> > > > > The VOTE will pass after 3 binding approve.
> > > > >
> > > > > [ ] +1 approve
> > > > > [ ] +0 no opinion
> > > > > [ ] -1 disapprove with the reason
> > > > >
> > > > > To learn more about apache paimon, please see
> > https://paimon.apache.org/
> > > > >
> > > > > Checklist for reference:
> > > > >
> > > > > [ ] Download links are valid.
> > > > > [ ] Checksums and signatures.
> > > > > [ ] LICENSE/NOTICE files exist
> > > > > [ ] No unexpected binary files
> > > > > [ ] All source files have ASF headers
> > > > > [ ] Can compile from source
> > > > >
> > > > > Best,
> > > > > Jingsong
> > > > >
> > > > > -
> > > > > To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org
> > > > > For additional commands, e-mail: general-h...@incubator.apache.org
> > > > >
> > > > >
> > > >
> > >
> >
> > -
> > To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org
> > For additional commands, e-mail: genera