Regressions on master at commit r15-5015 vs commit r15-5008 on Linux/x86_64
Regressions on master at commit r15-5015 vs commit r15-5008 on Linux/x86_64 New failures: New passes: FAIL: 30_threads/async/async.cc -std=gnu++17 execution test
Re: [r15-4988 Regression] FAIL: gcc.dg/gomp/max_vf-1.c scan-tree-dump-times ompexp "__builtin_GOMP_parallel_loop_nonmonotonic_dynamic \\(.*, 16, 0\\);" 1 on Linux/x86_64
On Thu, Nov 07, 2024 at 10:54:40AM +, Andrew Stubbs wrote:
> On 07/11/2024 00:37, haochen.jiang wrote:
> > d334f729e53867b838e867375b3f475ba793d96e is the first bad commit
> > commit d334f729e53867b838e867375b3f475ba793d96e
> > Author: Andrew Stubbs
> > Date: Wed Nov 6 12:26:08 2024 +
> >
> > openmp: Add testcases for omp_max_vf
> >
> > caused
> >
> > FAIL: gcc.dg/gomp/max_vf-1.c scan-tree-dump-times ompexp "\\+ 16" 1
> > FAIL: gcc.dg/gomp/max_vf-1.c scan-tree-dump-times ompexp "\\* 16" 2
> > FAIL: gcc.dg/gomp/max_vf-1.c scan-tree-dump-times ompexp
> > "__builtin_GOMP_parallel_loop_nonmonotonic_dynamic \\(.*, 16, 0\\);" 1
> >
> > with GCC configured with
> >
> > ../../gcc/configure
> > --prefix=/export/users/haochenj/src/gcc-bisect/master/master/r15-4988/usr
> > --enable-clocale=gnu --with-system-zlib --with-demangler-in-ld
> > --with-fpmath=sse --enable-languages=c,c++,fortran --enable-cet
> > --without-isl --enable-libmpx x86_64-linux --disable-bootstrap
> >
> > To reproduce:
> >
> > $ cd {build_dir}/gcc && make check
> > RUNTESTFLAGS="gomp.exp=gcc.dg/gomp/max_vf-1.c --target_board='unix{-m32\
> > -march=cascadelake}'"
> > $ cd {build_dir}/gcc && make check
> > RUNTESTFLAGS="gomp.exp=gcc.dg/gomp/max_vf-1.c --target_board='unix{-m64\
> > -march=cascadelake}'"
>
> This problem was supposed to be avoided by explicitly passing "-msse2" in
> the testcase. Apparently -march=cascadelake silently overrides that setting
> ... maybe don't do that?
What do yo mean by overrides?
-march=cascadelake -msse2
(or the other ordering too) certainly doesn't override the enabling of SSE2,
the -mISA and -mno-ISA flags take precedence over -march=; though other
flags can be set too from the -march= or its default set when configuring
the compiler.
So, if the testcase relies on SSE2 enabled and SSE3 not enabled, it should
use -msse2 -mno-sse3.
Seems the testcase actually relies on AVX not being enabled, so it should
use "-msse2 -mno-avx".
That will work fine even with -march=cascadelake, whether it is the default
or requested through --target_board.
Jakub
Re: [r15-4988 Regression] FAIL: gcc.dg/gomp/max_vf-1.c scan-tree-dump-times ompexp "__builtin_GOMP_parallel_loop_nonmonotonic_dynamic \\(.*, 16, 0\\);" 1 on Linux/x86_64
On Thu, Nov 07, 2024 at 11:31:17AM +, Andrew Stubbs wrote: > Anyway, I think the attached patch should fix it. It passes on my > configuration, but I don't have a Cascade Lake. You could have tested with whatever you have (if it has AVX) as -march= > OK? Yes, thanks. Jakub
Re: [r15-4988 Regression] FAIL: gcc.dg/gomp/max_vf-1.c scan-tree-dump-times ompexp "__builtin_GOMP_parallel_loop_nonmonotonic_dynamic \\(.*, 16, 0\\);" 1 on Linux/x86_64
On 07/11/2024 11:07, Jakub Jelinek wrote:
On Thu, Nov 07, 2024 at 10:54:40AM +, Andrew Stubbs wrote:
On 07/11/2024 00:37, haochen.jiang wrote:
d334f729e53867b838e867375b3f475ba793d96e is the first bad commit
commit d334f729e53867b838e867375b3f475ba793d96e
Author: Andrew Stubbs
Date: Wed Nov 6 12:26:08 2024 +
openmp: Add testcases for omp_max_vf
caused
FAIL: gcc.dg/gomp/max_vf-1.c scan-tree-dump-times ompexp "\\+ 16" 1
FAIL: gcc.dg/gomp/max_vf-1.c scan-tree-dump-times ompexp "\\* 16" 2
FAIL: gcc.dg/gomp/max_vf-1.c scan-tree-dump-times ompexp
"__builtin_GOMP_parallel_loop_nonmonotonic_dynamic \\(.*, 16, 0\\);" 1
with GCC configured with
../../gcc/configure
--prefix=/export/users/haochenj/src/gcc-bisect/master/master/r15-4988/usr
--enable-clocale=gnu --with-system-zlib --with-demangler-in-ld
--with-fpmath=sse --enable-languages=c,c++,fortran --enable-cet --without-isl
--enable-libmpx x86_64-linux --disable-bootstrap
To reproduce:
$ cd {build_dir}/gcc && make check RUNTESTFLAGS="gomp.exp=gcc.dg/gomp/max_vf-1.c
--target_board='unix{-m32\ -march=cascadelake}'"
$ cd {build_dir}/gcc && make check RUNTESTFLAGS="gomp.exp=gcc.dg/gomp/max_vf-1.c
--target_board='unix{-m64\ -march=cascadelake}'"
This problem was supposed to be avoided by explicitly passing "-msse2" in
the testcase. Apparently -march=cascadelake silently overrides that setting
... maybe don't do that?
What do yo mean by overrides?
-march=cascadelake -msse2
(or the other ordering too) certainly doesn't override the enabling of SSE2,
the -mISA and -mno-ISA flags take precedence over -march=; though other
flags can be set too from the -march= or its default set when configuring
the compiler.
So, if the testcase relies on SSE2 enabled and SSE3 not enabled, it should
use -msse2 -mno-sse3.
Seems the testcase actually relies on AVX not being enabled, so it should
use "-msse2 -mno-avx".
That will work fine even with -march=cascadelake, whether it is the default
or requested through --target_board.
Stupid me thought that those options were exclusive. The goal is to
make the vector size both predictable and not the same as amdgcn. It's
also good if it's sufficiently old that it works "everywhere".
Anyway, I think the attached patch should fix it. It passes on my
configuration, but I don't have a Cascade Lake.
OK?
AndrewFrom 180d89fb029d28f09fa318c593dbb01e4cedf746 Mon Sep 17 00:00:00 2001
From: Andrew Stubbs
Date: Thu, 7 Nov 2024 11:23:41 +
Subject: [PATCH] openmp: Fix max_vf testcases with -march=cascadelake
Apparently we need to explicitly disable AVX, not just enabled SSE, to
guarentee the 16-lane vectors we need for the pattern match.
libgomp/ChangeLog:
* testsuite/libgomp.c/max_vf-1.c: Add -mno-avx.
gcc/testsuite/ChangeLog:
* gcc.dg/gomp/max_vf-1.c: Add -mno-avx.
---
gcc/testsuite/gcc.dg/gomp/max_vf-1.c | 2 +-
libgomp/testsuite/libgomp.c/max_vf-1.c | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/gcc/testsuite/gcc.dg/gomp/max_vf-1.c b/gcc/testsuite/gcc.dg/gomp/max_vf-1.c
index 0513aae226c..d4617940eb2 100644
--- a/gcc/testsuite/gcc.dg/gomp/max_vf-1.c
+++ b/gcc/testsuite/gcc.dg/gomp/max_vf-1.c
@@ -5,7 +5,7 @@
/* { dg-options "-fopenmp -O2 -fdump-tree-ompexp" } */
/* Fix a max_vf size so we can scan for it.
-{ dg-additional-options "-msse2" { target { x86_64-*-* i?86-*-* } } } */
+{ dg-additional-options "-msse2 -mno-avx" { target { x86_64-*-* i?86-*-* } } } */
#define N 1024
int a[N], b[N], c[N];
diff --git a/libgomp/testsuite/libgomp.c/max_vf-1.c b/libgomp/testsuite/libgomp.c/max_vf-1.c
index be900c565a3..9c8d5dc0af9 100644
--- a/libgomp/testsuite/libgomp.c/max_vf-1.c
+++ b/libgomp/testsuite/libgomp.c/max_vf-1.c
@@ -7,7 +7,7 @@
/* { dg-options "-fopenmp -O2 -fdump-tree-ompexp -foffload=-fdump-tree-optimized" } */
/* Fix a max_vf size so we can scan for it.
-{ dg-additional-options "-msse2" { target { x86_64-*-* i?86-*-* } } } */
+{ dg-additional-options "-msse2 -mno-avx" { target { x86_64-*-* i?86-*-* } } } */
#define N 1024
int a[N], b[N], c[N];
--
2.46.0
Regressions on master at commit r15-5008 vs commit r15-5007 on Linux/x86_64
Regressions on master at commit r15-5008 vs commit r15-5007 on Linux/x86_64 New failures: FAIL: 30_threads/async/async.cc -std=gnu++17 execution test New passes:
Re: [r15-4988 Regression] FAIL: gcc.dg/gomp/max_vf-1.c scan-tree-dump-times ompexp "__builtin_GOMP_parallel_loop_nonmonotonic_dynamic \\(.*, 16, 0\\);" 1 on Linux/x86_64
On 07/11/2024 00:37, haochen.jiang wrote:
On Linux/x86_64,
d334f729e53867b838e867375b3f475ba793d96e is the first bad commit
commit d334f729e53867b838e867375b3f475ba793d96e
Author: Andrew Stubbs
Date: Wed Nov 6 12:26:08 2024 +
openmp: Add testcases for omp_max_vf
caused
FAIL: gcc.dg/gomp/max_vf-1.c scan-tree-dump-times ompexp "\\+ 16" 1
FAIL: gcc.dg/gomp/max_vf-1.c scan-tree-dump-times ompexp "\\* 16" 2
FAIL: gcc.dg/gomp/max_vf-1.c scan-tree-dump-times ompexp
"__builtin_GOMP_parallel_loop_nonmonotonic_dynamic \\(.*, 16, 0\\);" 1
with GCC configured with
../../gcc/configure
--prefix=/export/users/haochenj/src/gcc-bisect/master/master/r15-4988/usr
--enable-clocale=gnu --with-system-zlib --with-demangler-in-ld
--with-fpmath=sse --enable-languages=c,c++,fortran --enable-cet --without-isl
--enable-libmpx x86_64-linux --disable-bootstrap
To reproduce:
$ cd {build_dir}/gcc && make check RUNTESTFLAGS="gomp.exp=gcc.dg/gomp/max_vf-1.c
--target_board='unix{-m32\ -march=cascadelake}'"
$ cd {build_dir}/gcc && make check RUNTESTFLAGS="gomp.exp=gcc.dg/gomp/max_vf-1.c
--target_board='unix{-m64\ -march=cascadelake}'"
This problem was supposed to be avoided by explicitly passing "-msse2"
in the testcase. Apparently -march=cascadelake silently overrides that
setting ... maybe don't do that?
Is there an effective-target flag I can use for this?
Andrew
Regressions on native/master at commit r15-5015 vs commit r15-5009 on Linux/x86_64
Regressions on master at commit r15-5015 vs commit r15-5009 on Linux/x86_64 New failures: New passes: FAIL: gcc.dg/gomp/max_vf-1.c scan-tree-dump-times ompexp "\\+ 16" 1 FAIL: gcc.dg/gomp/max_vf-1.c scan-tree-dump-times ompexp "\\+ 16" 1 FAIL: gcc.dg/gomp/max_vf-1.c scan-tree-dump-times ompexp "\\* 16" 2 FAIL: gcc.dg/gomp/max_vf-1.c scan-tree-dump-times ompexp "\\* 16" 2 FAIL: gcc.dg/gomp/max_vf-1.c scan-tree-dump-times ompexp "__builtin_GOMP_parallel_loop_nonmonotonic_dynamic \\(.*, 16, 0\\);" 1 FAIL: gcc.dg/gomp/max_vf-1.c scan-tree-dump-times ompexp "__builtin_GOMP_parallel_loop_nonmonotonic_dynamic \\(.*, 16, 0\\);" 1 FAIL: gcc.target/i386/pr116725.c (test for excess errors) FAIL: gcc.target/i386/pr116725.c (test for excess errors)
Regressions on master at commit r15-5006 vs commit r15-4709 on Linux/i686
Regressions on master at commit r15-5006 vs commit r15-4709 on Linux/i686 New failures: FAIL: gcc.dg/vect/bb-slp-77.c -flto -ffat-lto-objects scan-tree-dump-times slp1 "optimized: basic block" 1 FAIL: gcc.dg/vect/bb-slp-77.c scan-tree-dump-times slp1 "optimized: basic block" 1 New passes: FAIL: 23_containers/vector/cons/from_range.cc -std=gnu++23 (test for excess errors) FAIL: 23_containers/vector/cons/from_range.cc -std=gnu++26 (test for excess errors) FAIL: gfortran.dg/pr115070.f90 -O (test for excess errors)
Regressions on releases/gcc-13 at commit r13-9174 vs commit r13-9147 on Linux/i686
Regressions on releases/gcc-13 at commit r13-9174 vs commit r13-9147 on Linux/i686 New failures: New passes: FAIL: gfortran.dg/pr113363.f90 -O0 (internal compiler error: Segmentation fault) FAIL: gfortran.dg/pr113363.f90 -O0 (test for excess errors) FAIL: gfortran.dg/pr113363.f90 -O1 (internal compiler error: Segmentation fault) FAIL: gfortran.dg/pr113363.f90 -O1 (test for excess errors) FAIL: gfortran.dg/pr113363.f90 -O2 (internal compiler error: Segmentation fault) FAIL: gfortran.dg/pr113363.f90 -O2 (test for excess errors) FAIL: gfortran.dg/pr113363.f90 -O3 -fomit-frame-pointer -funroll-loops -fpeel-loops -ftracer -finline-functions (internal compiler error: Segmentation fault) FAIL: gfortran.dg/pr113363.f90 -O3 -fomit-frame-pointer -funroll-loops -fpeel-loops -ftracer -finline-functions (test for excess errors) FAIL: gfortran.dg/pr113363.f90 -O3 -g (internal compiler error: Segmentation fault) FAIL: gfortran.dg/pr113363.f90 -O3 -g (test for excess errors) FAIL: gfortran.dg/pr113363.f90 -Os (internal compiler error: Segmentation fault) FAIL: gfortran.dg/pr113363.f90 -Os (test for excess errors)
[Linaro-TCWG-CI] gcc-15-4991-g69bd93c167fe: FAIL: 1 regressions on aarch64
Dear contributor, our automatic CI has detected problems related to your patch(es). Please find some details below. If you have any questions, please follow up on linaro-toolch...@lists.linaro.org mailing list, Libera's #linaro-tcwg channel, or ping your favourite Linaro toolchain developer on the usual project channel. We understand that it might be difficult to find the necessary logs or reproduce the issue locally. If you can't get what you need from our CI within minutes, let us know and we will be happy to help. We track this report status in https://linaro.atlassian.net/browse/GNU-1409 , please let us know if you are looking at the problem and/or when you have a fix. In master-aarch64 after: | commit gcc-15-4991-g69bd93c167fe | Author: Alexey Merzlyakov | Date: Wed Nov 6 14:39:30 2024 -0700 | | [PATCH v2] RISC-V: zero_extend(not) -> xor optimization [PR112398] | | This patch adds optimization of the following patterns: | | (zero_extend:M (subreg:N (not:O==M (X:Q==M -> | ... 32 lines of the commit log omitted. FAIL: 1 regressions regressions.sum: | === glibc tests === | | Running glibc:stdlib ... | FAIL: stdlib/tst-stdc_leading_ones | The configuration of this build is: *CI config* tcwg_gnu_native_check_glibc master-aarch64 *configure and test flags:* --target aarch64-linux-gnu You can find the failure logs in *.log.1.xz files in * https://ci.linaro.org/job/tcwg_gnu_native_check_glibc--master-aarch64-build/899/artifact/artifacts/00-sumfiles/ The full lists of regressions and improvements as well as configure and make commands are in * https://ci.linaro.org/job/tcwg_gnu_native_check_glibc--master-aarch64-build/899/artifact/artifacts/notify/ The list of [ignored] baseline and flaky failures are in * https://ci.linaro.org/job/tcwg_gnu_native_check_glibc--master-aarch64-build/899/artifact/artifacts/sumfiles/xfails.xfail The configuration of this build is: *CI config* tcwg_gnu_native_check_glibc master-aarch64 *configure and test flags:* --target aarch64-linux-gnu -8<--8<--8<-- The information below can be used to reproduce a debug environment: Current build : https://ci.linaro.org/job/tcwg_gnu_native_check_glibc--master-aarch64-build/899/artifact/artifacts Reference build : https://ci.linaro.org/job/tcwg_gnu_native_check_glibc--master-aarch64-build/898/artifact/artifacts Instruction to reproduce the build : https://git-us.linaro.org/toolchain/ci/interesting-commits.git/plain/gcc/sha1/69bd93c167fefbdff0cb88614275358b7a2b2941/tcwg_gnu_native_check_glibc/master-aarch64/reproduction_instructions.txt Full commit : https://gcc.gnu.org/git/?p=gcc.git;a=commitdiff;h=69bd93c167fefbdff0cb88614275358b7a2b2941
