ywgrit writes:
> I encountered one problem with loop-im pass.
> I compiled the program dhry2reg which belongs to
> unixbench(https://github.com/kdlucas/byte-unixbench).
>
> The gcc used
> gcc (GCC) 12.3.0
>
> The commands executed as following
> make
> ./Run -c -i 1 dhry2reg
>
> The results are shown below.
> Dhrystone 2 using register variables 0.1 lps (10.0 s, 1
> samples)
>
> System Benchmarks Partial Index BASELINE RESULTINDEX
> Dhrystone 2 using register variables 116700.0 0.1 0.0
>
> System Benchmarks Index Score (Partial Only) 10.0
>
> Obviously, the "INDEX" is abnormal.
> I wrote a demo named dhry.c based on the dhry2reg logic.
It's best to file a bug report so we can:
a) discuss the validity of the testcase, and
b) reference it in review of the commit & even once it is in
.. but that said, I thought this looked familiar, and I found PR117695
which is marked as INVALID.
> [...]
FWIW, all the analysis should go in the commit message, as well as
including a testcase in the commit itself. The commit message should
also have a ChangeLog. See these links:
* https://gcc.gnu.org/contribute.html
* https://gcc.gnu.org/codingconventions.html
But these are general remarks. I can't approve the patch (that is for
others) but I'm not sure if the testcase is valid anyway.
> [...]
thanks,
sam
