Re: Official GCC git repository
On Thu, 27 Mar 2008, Andreas Schwab wrote: >> I've been waiting until I had the time to rewrite my import with proper >> author names. Does anyone have a correspondence file mapping the login >> name to Author? > I have a list that is about 4 months old. Should be pretty complete. Cute. How about adding this to the GCC repository in some file parallel to our MAINTAINERS file? Something like MAINTAINERS.logins or so? On Thu, 27 Mar 2008, Samuel Tardieu wrote: > I also think adding the Real Name is nice. > > Maybe we should also consider adding the login as an additional field > in the MAINTAINERS file, as AFAIK every MAINTAINERS as a @gcc.gnu.org > address. That would be an alternative. It would increase the width of MATINAINERS above 80 characters, and I'm not sure how much of an issue that would be. Either way, having this information in one central place sounds like a good idea. Gerald
Re: Official GCC git repository
On Sun, Aug 17, 2008 at 06:30:57PM +0200, Gerald Pfeifer wrote: >On Thu, 27 Mar 2008, Andreas Schwab wrote: >>> I've been waiting until I had the time to rewrite my import with proper >>> author names. Does anyone have a correspondence file mapping the login >>> name to Author? >> I have a list that is about 4 months old. Should be pretty complete. > >Cute. How about adding this to the GCC repository in some file parallel >to our MAINTAINERS file? Something like MAINTAINERS.logins or so? > >On Thu, 27 Mar 2008, Samuel Tardieu wrote: >> I also think adding the Real Name is nice. >> >> Maybe we should also consider adding the login as an additional field >> in the MAINTAINERS file, as AFAIK every MAINTAINERS as a @gcc.gnu.org >> address. > >That would be an alternative. It would increase the width of MATINAINERS >above 80 characters, and I'm not sure how much of an issue that would be. I don't think adding YA place that has to be updated when things change is a good idea. If this is a script that runs on gcc.gnu.org then you should be able to get the full name with a minimal amount of effort using a getpw* function. cgf
Re: Please, do not use the merged revisions log as the commit message when merging
Christopher Faylor wrote: On Sat, Aug 16, 2008 at 02:35:08PM +0200, Manuel L?pez-Ib??ez wrote: Dear GCC devs, Please do *not* use the full logs of the merged revisions as the commit message of a merge. Apart from making the output of svn log useless, commits messages are parsed are tracked for PR numbers, the commit message is added to the bugzilla page of the PR and people subscribed to the relevant PR in bugzilla are notified of the commit. Therefore a single merge of many revisions would result in a flood of mails sent for no good reason and they make a mess of the bugzilla page. I am sure many of you have been hit by this recently. Please, let's try to avoid this. If that isn't a good enough reason, doing this completely swamps gcc.gnu.org as it valiantly attempts to send all of the above email. This resulted in a load average of 24 on the system last night and kept me awake until 2:30AM trying to stabilize things. cgf I'm just going to come out and admit that it was probably me who caused all this. I appreciate the anonymity afforded by everyone, and I apologize. I promise I will not make this mistake again. In my defense, I want to say that your reasons are good enough, but I did not know them beforehand. No one informed me of any commit policies when I was given subversion access. I thought that since I was working on a branch, I had free reign. Education would go a long way in preventing future errors. - John
Re: Please, do not use the merged revisions log as the commit message when merging
It's listed on the wiki that explains how to maintain branches :) On Sun, Aug 17, 2008 at 2:32 PM, John Freeman <[EMAIL PROTECTED]> wrote: > Christopher Faylor wrote: >> >> On Sat, Aug 16, 2008 at 02:35:08PM +0200, Manuel L?pez-Ib??ez wrote: >> >>> >>> Dear GCC devs, >>> >>> Please do *not* use the full logs of the merged revisions as the >>> commit message of a merge. Apart from making the output of svn log >>> useless, commits messages are parsed are tracked for PR numbers, the >>> commit message is added to the bugzilla page of the PR and people >>> subscribed to the relevant PR in bugzilla are notified of the commit. >>> Therefore a single merge of many revisions would result in a flood of >>> mails sent for no good reason and they make a mess of the bugzilla >>> page. >>> >>> I am sure many of you have been hit by this recently. Please, let's >>> try to avoid this. >>> >> >> If that isn't a good enough reason, doing this completely swamps >> gcc.gnu.org as it valiantly attempts to send all of the above email. >> This resulted in a load average of 24 on the system last night and kept >> me awake until 2:30AM trying to stabilize things. >> >> cgf >> > > I'm just going to come out and admit that it was probably me who caused all > this. I appreciate the anonymity afforded by everyone, and I apologize. I > promise I will not make this mistake again. In my defense, I want to say > that your reasons are good enough, but I did not know them beforehand. No > one informed me of any commit policies when I was given subversion access. > I thought that since I was working on a branch, I had free reign. > Education would go a long way in preventing future errors. > > - John >
Re: Please, do not use the merged revisions log as the commit message when merging
Daniel Berlin wrote: It's listed on the wiki that explains how to maintain branches :) I had no idea such a wiki even existed. It would really help future contributors, I'm sure, if, perhaps during copyright assignment, there were some sort of "introduction" process that clearly communicated policies. Thank you for the heads up. - John
Re: Please, do not use the merged revisions log as the commit message when merging
* Daniel Berlin wrote on Sun, Aug 17, 2008 at 09:18:01PM CEST: > It's listed on the wiki that explains how to maintain branches :) It should be on svnwrite.html, or at least a pointer to the wiki page should be. Cheers, Ralf
Re: Please, do not use the merged revisions log as the commit message when merging
On Sun, 17 Aug 2008, John Freeman wrote: > No one informed me of any commit policies when I was given subversion > access. I thought that since I was working on a branch, I had free > reign. Education would go a long way in preventing future errors. You are right. This is one of the weaknesses (mistakes) of our current systems. I really believe we should institute more of a mentor system where it will be the responsibility of the respective mentor/sponor to guide new contributors through the first commits. Gerald
Re: Official GCC git repository
On Sun, 17 Aug 2008, Christopher Faylor wrote: > I don't think adding YA place that has to be updated when things change > is a good idea. If this is a script that runs on gcc.gnu.org then you > should be able to get the full name with a minimal amount of effort > using a getpw* function. Okay, I'll hack up a script. It's not that simple as it might seem at first glance, since SVN has references to accounts which are not (or should not) be active any longer: NOfx NOchelf NOpbienst NObo NOgp NObbooth NOkargl Actually, there are a number of further problems, and I'll take those to overseers... Gerald
