[Bug 254884] [if_smsc] Add ability to disable "turbo_mode" (RX frames batching) similar to linux driver

2021-04-08 Thread bugzilla-noreply
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=254884

Bug ID: 254884
   Summary: [if_smsc] Add ability to disable "turbo_mode" (RX
frames batching) similar to linux driver
   Product: Base System
   Version: CURRENT
  Hardware: arm
OS: Any
Status: New
  Severity: Affects Only Me
  Priority: ---
 Component: usb
  Assignee: u...@freebsd.org
  Reporter: osidor...@gmail.com

Created attachment 223924
  --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=223924&action=edit
Patch to add ability to disable "turbo mode" in if_smsc

"turbo  mode" makes chip to wait a while before transferring the frame in case
there are some other frames. This increases both throughput and rtt.

Linux driver has module param to disable batching if necessary.

Attached patch adds similar flag to freebsd driver.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
freebsd-usb@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-usb
To unsubscribe, send any mail to "freebsd-usb-unsubscr...@freebsd.org"


[Bug 254884] [if_smsc] Add ability to disable "turbo_mode" (RX frames batching) similar to linux driver

2021-04-08 Thread bugzilla-noreply
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=254884

Hans Petter Selasky  changed:

   What|Removed |Added

 CC||hsela...@freebsd.org
 Status|New |In Progress

--- Comment #1 from Hans Petter Selasky  ---
Patch looks good. Do you have someone to commit it?

--HPS

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
freebsd-usb@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-usb
To unsubscribe, send any mail to "freebsd-usb-unsubscr...@freebsd.org"


[Bug 254884] [if_smsc] Add ability to disable "turbo_mode" (RX frames batching) similar to linux driver

2021-04-08 Thread bugzilla-noreply
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=254884

--- Comment #2 from Hans Petter Selasky  ---
Can you also post the numbers you see using iperf?

--HPS

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
freebsd-usb@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-usb
To unsubscribe, send any mail to "freebsd-usb-unsubscr...@freebsd.org"


[Bug 254884] [if_smsc] Add ability to disable "turbo_mode" (RX frames batching) similar to linux driver

2021-04-08 Thread bugzilla-noreply
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=254884

--- Comment #3 from Oleg Sidorkin  ---
(In reply to Hans Petter Selasky from comment #1)

No :)

(In reply to Hans Petter Selasky from comment #2)

Iperf3:
Turbo off:
[ ID] Interval   Transfer Bitrate Retr  Cwnd
[  5]   0.00-1.01   sec  1.80 MBytes  14.9 Mbits/sec   22   60.8 KBytes
[  5]   1.01-2.00   sec  4.27 MBytes  36.3 Mbits/sec   50   21.3 KBytes
[  5]   2.00-3.00   sec  4.31 MBytes  36.2 Mbits/sec   43   19.8 KBytes
[  5]   3.00-4.00   sec  2.36 MBytes  19.8 Mbits/sec   37   60.8 KBytes
[  5]   4.00-5.00   sec  1.44 MBytes  12.1 Mbits/sec   40   2.84 KBytes
[  5]   5.00-6.01   sec  1.91 MBytes  15.9 Mbits/sec   42   48.1 KBytes
[  5]   6.01-7.00   sec  3.08 MBytes  26.0 Mbits/sec   48   14.1 KBytes
[  5]   7.00-8.01   sec  3.59 MBytes  29.9 Mbits/sec   43   60.8 KBytes
[  5]   8.01-9.00   sec  2.62 MBytes  22.1 Mbits/sec   45   18.4 KBytes
[  5]   9.00-10.00  sec  1.89 MBytes  15.9 Mbits/sec   43   1.41 KBytes
- - - - - - - - - - - - - - - - - - - - - - - - -
[ ID] Interval   Transfer Bitrate Retr
[  5]   0.00-10.00  sec  27.3 MBytes  22.9 Mbits/sec  413 sender
[  5]   0.00-10.00  sec  27.2 MBytes  22.8 Mbits/sec  receiver


Turbo on:
[ ID] Interval   Transfer Bitrate Retr  Cwnd
[  5]   0.00-1.00   sec  7.27 MBytes  61.0 Mbits/sec   34   31.2 KBytes
[  5]   1.00-2.00   sec  7.54 MBytes  63.2 Mbits/sec   33   36.9 KBytes
[  5]   2.00-3.00   sec  7.53 MBytes  63.2 Mbits/sec   36   21.2 KBytes
[  5]   3.00-4.00   sec  7.57 MBytes  63.5 Mbits/sec   33   26.9 KBytes
[  5]   4.00-5.00   sec  7.49 MBytes  62.9 Mbits/sec   34   35.5 KBytes
[  5]   5.00-6.00   sec  7.48 MBytes  62.8 Mbits/sec   33   36.9 KBytes
[  5]   6.00-7.00   sec  7.46 MBytes  62.6 Mbits/sec   36   5.66 KBytes
[  5]   7.00-8.00   sec  7.56 MBytes  63.4 Mbits/sec   35   25.5 KBytes
[  5]   8.00-9.00   sec  7.53 MBytes  63.1 Mbits/sec   34   32.6 KBytes
[  5]   9.00-10.00  sec  7.44 MBytes  62.4 Mbits/sec   35   36.9 KBytes
- - - - - - - - - - - - - - - - - - - - - - - - -
[ ID] Interval   Transfer Bitrate Retr
[  5]   0.00-10.00  sec  74.9 MBytes  62.8 Mbits/sec  343 sender
[  5]   0.00-10.01  sec  74.8 MBytes  62.7 Mbits/sec  receiver

Ping:
Turbo off:
21 packets transmitted, 21 packets received, 0.0% packet loss
round-trip min/avg/max/stddev = 0.344/0.432/0.558/0.057 ms

Turbo on:
21 packets transmitted, 21 packets received, 0.0% packet loss
round-trip min/avg/max/stddev = 0.425/0.581/0.676/0.085 ms

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
freebsd-usb@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-usb
To unsubscribe, send any mail to "freebsd-usb-unsubscr...@freebsd.org"


[Bug 254884] [if_smsc] Add ability to disable "turbo_mode" (RX frames batching) similar to linux driver

2021-04-08 Thread bugzilla-noreply
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=254884

Bertrand Petit  changed:

   What|Removed |Added

 CC||bs...@phoe.frmug.org

--- Comment #4 from Bertrand Petit  ---
This contribution is very welcome, I foresee a positive impact on ntp servers:
it will improve jitter. Will it be applied to stable branches?

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
freebsd-usb@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-usb
To unsubscribe, send any mail to "freebsd-usb-unsubscr...@freebsd.org"


[Bug 254884] [if_smsc] Add ability to disable "turbo_mode" (RX frames batching) similar to linux driver

2021-04-08 Thread bugzilla-noreply
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=254884

--- Comment #5 from Hans Petter Selasky  ---
Yes, it can be MFC'ed from what I see.

I'll have a look at it tomorrow if nobody else grabs it :-)

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
freebsd-usb@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-usb
To unsubscribe, send any mail to "freebsd-usb-unsubscr...@freebsd.org"