[Bug 238821] lang/python35: Fix packaging on GCC architectures
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=238821 Kubilay Kocak changed: What|Removed |Added Status|New |Open Summary|lang/python35: fix |lang/python35: Fix |packaging on GCC|packaging on GCC |architectures |architectures Flags||merge-quarterly? Severity|Affects Only Me |Affects Some People Keywords||needs-qa --- Comment #1 from Kubilay Kocak --- (In reply to Piotr Kubaj from comment #0) Can you test (if you haven't already) and let us know if any other lang/python* versions are affected. I don't believe Python has changed its C coding standard for particular branches, so we may want to report this upstream too -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ freebsd-python@freebsd.org mailing list https://lists.freebsd.org/mailman/listinfo/freebsd-python To unsubscribe, send any mail to "freebsd-python-unsubscr...@freebsd.org"
[Bug 238821] lang/python35: Fix packaging on GCC architectures
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=238821 --- Comment #2 from Piotr Kubaj --- (In reply to Kubilay Kocak from comment #1) Here are successful build logs for other versions: https://talos.anongoth.pl/data/powerpc64-default/latest-per-pkg/python27-2.7.16_1.log https://talos.anongoth.pl/data/powerpc64-default/latest-per-pkg/python36-3.6.8_2.log https://talos.anongoth.pl/data/powerpc64-default/latest-per-pkg/python37-3.7.3_1.log Only python35 is broken and it's been that way for at least last 9 months (note that only builds with base GCC are broken, so that's why no one noticed). -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ freebsd-python@freebsd.org mailing list https://lists.freebsd.org/mailman/listinfo/freebsd-python To unsubscribe, send any mail to "freebsd-python-unsubscr...@freebsd.org"
[Bug 238821] lang/python35: Fix packaging on GCC architectures
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=238821 --- Comment #3 from Kubilay Kocak --- (In reply to Piotr Kubaj from comment #2) Thank you for following up Piotr In future, when providing logs please provide them as attachments as external URL references tend to go missing/stale over time. Given 3.5 is the only branch not affected, it may be worth perusing the upstream sources to identify potential commits that fixed the problem, but may not have been merged back to 3.5 (Python only bugfixes the latest branch + 2 previous) So, look at 3.6 for the failing code in question, compare it to 3.5. It's preferable to backport upstream changes where they exist, rather than switch the C standard across the board (in only one version) -- You are receiving this mail because: You are on the CC list for the bug. You are the assignee for the bug. ___ freebsd-python@freebsd.org mailing list https://lists.freebsd.org/mailman/listinfo/freebsd-python To unsubscribe, send any mail to "freebsd-python-unsubscr...@freebsd.org"
[Bug 238821] lang/python35: Fix packaging on GCC architectures
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=238821 --- Comment #6 from Piotr Kubaj --- (In reply to Piotr Kubaj from comment #4) -- You are receiving this mail because: You are on the CC list for the bug. You are the assignee for the bug. ___ freebsd-python@freebsd.org mailing list https://lists.freebsd.org/mailman/listinfo/freebsd-python To unsubscribe, send any mail to "freebsd-python-unsubscr...@freebsd.org"
[Bug 238821] lang/python35: Fix packaging on GCC architectures
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=238821 --- Comment #4 from Piotr Kubaj --- (In reply to Kubilay Kocak from comment #3) The patch that fixes build on 3.6 is here: https://github.com/python/cpython/commit/7490577f6a7debf35bd13adf0f00fa9b272e8f8c They later changed to gnu99: https://github.com/python/cpython/commit/7490577f6a7debf35bd13adf0f00fa9b272e8f8c But since they esentially add -std=gnu99, we could achieve the same with USE_CSTD=gnu99. -- You are receiving this mail because: You are on the CC list for the bug. You are the assignee for the bug. ___ freebsd-python@freebsd.org mailing list https://lists.freebsd.org/mailman/listinfo/freebsd-python To unsubscribe, send any mail to "freebsd-python-unsubscr...@freebsd.org"
maintainer-approval requested: [Bug 238821] lang/python35: Fix packaging on GCC architectures : [Attachment 205372] change to gnu99
Piotr Kubaj has asked freebsd-python mailing list for maintainer-approval: Bug 238821: lang/python35: Fix packaging on GCC architectures https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=238821 Attachment 205372: change to gnu99 https://bugs.freebsd.org/bugzilla/attachment.cgi?id=205372&action=edit --- Comment #5 from Piotr Kubaj --- Created attachment 205372 --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=205372&action=edit change to gnu99 ___ freebsd-python@freebsd.org mailing list https://lists.freebsd.org/mailman/listinfo/freebsd-python To unsubscribe, send any mail to "freebsd-python-unsubscr...@freebsd.org"
[Bug 238821] lang/python35: Fix packaging on GCC architectures
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=238821 Piotr Kubaj changed: What|Removed |Added Attachment #205349|0 |1 is obsolete|| Attachment #205349|maintainer-approval?(python | Flags|@FreeBSD.org) | Attachment #205372||maintainer-approval?(python Flags||@FreeBSD.org) --- Comment #5 from Piotr Kubaj --- Created attachment 205372 --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=205372&action=edit change to gnu99 -- You are receiving this mail because: You are on the CC list for the bug. You are the assignee for the bug. ___ freebsd-python@freebsd.org mailing list https://lists.freebsd.org/mailman/listinfo/freebsd-python To unsubscribe, send any mail to "freebsd-python-unsubscr...@freebsd.org"
[Bug 238821] lang/python35: Fix packaging on GCC architectures
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=238821 --- Comment #7 from Piotr Kubaj --- Sorry, the commit changing to gnu99 is here: https://github.com/python/cpython/commit/7f9eb6eda30398ea7a5b630856abce81f91591f6 -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ freebsd-python@freebsd.org mailing list https://lists.freebsd.org/mailman/listinfo/freebsd-python To unsubscribe, send any mail to "freebsd-python-unsubscr...@freebsd.org"
[Bug 238821] lang/python35: Fix packaging on GCC architectures
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=238821 Kubilay Kocak changed: What|Removed |Added Keywords||needs-patch --- Comment #8 from Kubilay Kocak --- Issue 28017 [1] shows that that commit was followed up by a subsequent commit: compile with -std=c99 instead of -std=gnu99; use kiddie-gloves with bluetooth/bluetooh.h https://hg.python.org/cpython/rev/91017e2202ae Changing just the cstd doesn't appear to be sufficient, we should backport 91017e22 incl. the bluetooth header check block too. FWIW, the bluetooth headers were fixed to compile with strict C in https://git.kernel.org/pub/scm/bluetooth/bluez.git/commit?id=cf52a40 So theoretically we could fix the root cause, but unless Python went down that track later (maybe they did?), its probably not best course of action to deviate from upstream code and carry the patch locally. [1] https://bugs.python.org/issue28017 -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ freebsd-python@freebsd.org mailing list https://lists.freebsd.org/mailman/listinfo/freebsd-python To unsubscribe, send any mail to "freebsd-python-unsubscr...@freebsd.org"
[Bug 238821] lang/python35: Fix packaging on GCC architectures
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=238821 --- Comment #9 from Piotr Kubaj --- (In reply to Kubilay Kocak from comment #8) This bug report says: PPC Fedora build bot is not able to build the _ssl and _socket module. It looks like bluetooth.h is not compatible with std=c99. It uses some GNU C extensions like __extension__, __attribute__((packed)) and __typeof__. The C99 variant -std=gnu99 should do the trick. But, i'm able to build on FreeBSD/powerpc64 (that's what I test on). So this bug is probably only present on Linux. -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ freebsd-python@freebsd.org mailing list https://lists.freebsd.org/mailman/listinfo/freebsd-python To unsubscribe, send any mail to "freebsd-python-unsubscr...@freebsd.org"
[Bug 238821] lang/python35: Fix packaging on GCC architectures
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=238821 --- Comment #10 from Kubilay Kocak --- Created attachment 205373 --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=205373&action=edit head-powerpc64-default-logs-python35-3.5.7_2.log Sorry, I completelty missed that it was an unrelated module. However, it (python35/powerpc) appears to be failing on our build cluster We need to identify why Python >= 3.6 is not failing in this manner, as that will be the likely best candidate resolution -- You are receiving this mail because: You are on the CC list for the bug. You are the assignee for the bug. ___ freebsd-python@freebsd.org mailing list https://lists.freebsd.org/mailman/listinfo/freebsd-python To unsubscribe, send any mail to "freebsd-python-unsubscr...@freebsd.org"
[Bug 238821] lang/python35: Fix packaging on GCC architectures
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=238821 --- Comment #11 from Piotr Kubaj --- (In reply to Kubilay Kocak from comment #10) Yes, it's failing because of the error in my 1st comment: /wrkdirs/usr/ports/lang/python35/work/Python-3.5.7/Modules/_pickle.c: In function 'PyMemoTable_Copy': /wrkdirs/usr/ports/lang/python35/work/Python-3.5.7/Modules/_pickle.c:677: error: 'for' loop initial declaration used outside C99 mode /wrkdirs/usr/ports/lang/python35/work/Python-3.5.7/Modules/_pickle.c: In function '_pickle_PicklerMemoProxy_copy_impl': /wrkdirs/usr/ports/lang/python35/work/Python-3.5.7/Modules/_pickle.c:4207: error: 'for' loop initial declaration used outside C99 mode /wrkdirs/usr/ports/lang/python35/work/Python-3.5.7/Modules/_pickle.c: In function 'Unpickler_set_memo': /wrkdirs/usr/ports/lang/python35/work/Python-3.5.7/Modules/_pickle.c:6794: error: 'for' loop initial declaration used outside C99 mode /wrkdirs/usr/ports/lang/python35/work/Python-3.5.7/Modules/_pickle.c:6842: error: 'for' loop initial declaration used outside C99 mode This is what my patch fixes. -- You are receiving this mail because: You are on the CC list for the bug. You are the assignee for the bug. ___ freebsd-python@freebsd.org mailing list https://lists.freebsd.org/mailman/listinfo/freebsd-python To unsubscribe, send any mail to "freebsd-python-unsubscr...@freebsd.org"
[Bug 238821] lang/python35: Fix packaging on GCC architectures
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=238821 --- Comment #12 from Piotr Kubaj --- (In reply to Kubilay Kocak from comment #10) Also, Python >= 3.6 doesn't fail, because it uses -std=gnu99. -- You are receiving this mail because: You are on the CC list for the bug. You are the assignee for the bug. ___ freebsd-python@freebsd.org mailing list https://lists.freebsd.org/mailman/listinfo/freebsd-python To unsubscribe, send any mail to "freebsd-python-unsubscr...@freebsd.org"
[Bug 238821] lang/python35: Fix packaging on GCC architectures
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=238821 Kubilay Kocak changed: What|Removed |Added Keywords|needs-patch, needs-qa | --- Comment #13 from Kubilay Kocak --- (In reply to Piotr Kubaj from comment #12) Sorry, brain tired, no workey :) But let's use std=c99 as originally submitted as that's what python36 uses -- You are receiving this mail because: You are on the CC list for the bug. You are the assignee for the bug. ___ freebsd-python@freebsd.org mailing list https://lists.freebsd.org/mailman/listinfo/freebsd-python To unsubscribe, send any mail to "freebsd-python-unsubscr...@freebsd.org"
[Bug 238821] lang/python35: Fix packaging on GCC architectures
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=238821 Kubilay Kocak changed: What|Removed |Added Attachment #205349|1 |0 is obsolete|| -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ freebsd-python@freebsd.org mailing list https://lists.freebsd.org/mailman/listinfo/freebsd-python To unsubscribe, send any mail to "freebsd-python-unsubscr...@freebsd.org"
[Bug 238821] lang/python35: Fix packaging on GCC architectures
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=238821 Kubilay Kocak changed: What|Removed |Added Attachment #205372|0 |1 is obsolete|| Attachment #205372|maintainer-approval?(python | Flags|@FreeBSD.org) | -- You are receiving this mail because: You are on the CC list for the bug. You are the assignee for the bug. ___ freebsd-python@freebsd.org mailing list https://lists.freebsd.org/mailman/listinfo/freebsd-python To unsubscribe, send any mail to "freebsd-python-unsubscr...@freebsd.org"
[Bug 238821] lang/python35: Fix packaging on GCC architectures
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=238821 Kubilay Kocak changed: What|Removed |Added Assignee|pyt...@freebsd.org |pku...@freebsd.org --- Comment #14 from Kubilay Kocak --- lang/python35: Use -std=c99 Python 3.5 is currently failing to build the pickle module on GCC-based architectures, with the following (several) errors: error: 'for' loop initial declaration used outside C99 mode This causes packaging to fail, as the pickle module filename changes on failure to build, so the plist ends up incorrect Python 3.6+ switched to using -std=c99 [1][2], but the changes were not backported to 3.5 [1] https://bugs.python.org/issue28017 [2] https://hg.python.org/cpython/rev/b5b2bb56d303 [3] https://hg.python.org/cpython/rev/91017e2202ae PR: 238821 Reviewed by: koobs (python) Approved by: koobs (python) MFH: 2019Q2 (blanket: build fix) -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ freebsd-python@freebsd.org mailing list https://lists.freebsd.org/mailman/listinfo/freebsd-python To unsubscribe, send any mail to "freebsd-python-unsubscr...@freebsd.org"
[Bug 238821] lang/python35: Fix packaging on GCC architectures
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=238821 Kubilay Kocak changed: What|Removed |Added Attachment #205349||maintainer-approval+ Flags|| --- Comment #15 from Kubilay Kocak --- Comment on attachment 205349 --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=205349 patch Approved by: koobs (python, maintainer) -- You are receiving this mail because: You are on the CC list for the bug. ___ freebsd-python@freebsd.org mailing list https://lists.freebsd.org/mailman/listinfo/freebsd-python To unsubscribe, send any mail to "freebsd-python-unsubscr...@freebsd.org"
[Bug 238821] lang/python35: Fix packaging on GCC architectures
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=238821 --- Comment #16 from Kubilay Kocak --- Over to you Piotr for commit/merge, thank you for the report, patch and putting up with me -- You are receiving this mail because: You are on the CC list for the bug. ___ freebsd-python@freebsd.org mailing list https://lists.freebsd.org/mailman/listinfo/freebsd-python To unsubscribe, send any mail to "freebsd-python-unsubscr...@freebsd.org"
[Bug 238821] lang/python35: Fix packaging on GCC architectures
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=238821 Kubilay Kocak changed: What|Removed |Added Hardware|Any |powerpc -- You are receiving this mail because: You are on the CC list for the bug. ___ freebsd-python@freebsd.org mailing list https://lists.freebsd.org/mailman/listinfo/freebsd-python To unsubscribe, send any mail to "freebsd-python-unsubscr...@freebsd.org"
[Bug 238821] lang/python35: Fix packaging on GCC architectures
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=238821 Kubilay Kocak changed: What|Removed |Added Flags|maintainer-feedback?(python |maintainer-feedback+ |@FreeBSD.org) | -- You are receiving this mail because: You are on the CC list for the bug. ___ freebsd-python@freebsd.org mailing list https://lists.freebsd.org/mailman/listinfo/freebsd-python To unsubscribe, send any mail to "freebsd-python-unsubscr...@freebsd.org"
[Bug 238821] lang/python35: Use -std=c99
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=238821 Kubilay Kocak changed: What|Removed |Added Summary|lang/python35: Fix |lang/python35: Use -std=c99 |packaging on GCC| |architectures | -- You are receiving this mail because: You are on the CC list for the bug. ___ freebsd-python@freebsd.org mailing list https://lists.freebsd.org/mailman/listinfo/freebsd-python To unsubscribe, send any mail to "freebsd-python-unsubscr...@freebsd.org"
[Bug 238821] lang/python35: Fix packaging on GCC architectures
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=238821 Piotr Kubaj changed: What|Removed |Added Summary|lang/python35: Use -std=c99 |lang/python35: Fix ||packaging on GCC ||architectures --- Comment #17 from Piotr Kubaj --- (In reply to Kubilay Kocak from comment #16) Just to be clear, it doesn't affect only powerpc, but also other GCC-based architectures (mips*, sparc64). -- You are receiving this mail because: You are on the CC list for the bug. ___ freebsd-python@freebsd.org mailing list https://lists.freebsd.org/mailman/listinfo/freebsd-python To unsubscribe, send any mail to "freebsd-python-unsubscr...@freebsd.org"
[Bug 238821] lang/python35: Use -std=c99
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=238821 Kubilay Kocak changed: What|Removed |Added Summary|lang/python35: Fix |lang/python35: Use -std=c99 |packaging on GCC| |architectures | --- Comment #18 from Kubilay Kocak --- That's fine, I set the arch for the initial report case, and we can't select multiple. I made sure the commit log message (please use it) did not imply it was ppc specific -- You are receiving this mail because: You are on the CC list for the bug. ___ freebsd-python@freebsd.org mailing list https://lists.freebsd.org/mailman/listinfo/freebsd-python To unsubscribe, send any mail to "freebsd-python-unsubscr...@freebsd.org"
[Bug 238821] lang/python35: Use -std=c99
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=238821 --- Comment #19 from commit-h...@freebsd.org --- A commit references this bug: Author: pkubaj Date: Thu Jun 27 17:12:59 UTC 2019 New revision: 505210 URL: https://svnweb.freebsd.org/changeset/ports/505210 Log: lang/python35: Use -std=c99 Python 3.5 is currently failing to build the pickle module on GCC-based architectures, with the following (several) errors: error: 'for' loop initial declaration used outside C99 mode This causes packaging to fail, as the pickle module filename changes on failure to build, so the plist ends up incorrect Python 3.6+ switched to using -std=c99 [1][2], but the changes were not backported to 3.5 [1] https://bugs.python.org/issue28017 [2] https://hg.python.org/cpython/rev/b5b2bb56d303 [3] https://hg.python.org/cpython/rev/91017e2202ae PR: 238821 Reviewed by: koobs (python) Approved by: koobs (python), mat (mentor) MFH: 2019Q2 (blanket: build fix) Differential Revision: https://reviews.freebsd.org/D20778 Changes: head/lang/python35/Makefile -- You are receiving this mail because: You are on the CC list for the bug. ___ freebsd-python@freebsd.org mailing list https://lists.freebsd.org/mailman/listinfo/freebsd-python To unsubscribe, send any mail to "freebsd-python-unsubscr...@freebsd.org"
[Bug 238724] textproc/asciidoc 8.6.10 requires python 2.7 in spite of make.conf DEFAULT_VERSIONS+=python=3.7
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=238724 --- Comment #5 from Dennis Clarke --- (In reply to Alexey Dokuchaev from comment #3) I think crafting a small patch is the best way forwards. At least for now. Thank you. -- You are receiving this mail because: You are on the CC list for the bug. ___ freebsd-python@freebsd.org mailing list https://lists.freebsd.org/mailman/listinfo/freebsd-python To unsubscribe, send any mail to "freebsd-python-unsubscr...@freebsd.org"
[Bug 229946] devel/py-pip: Update to 19.1.1
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=229946 Bug 229946 depends on bug 238792, which changed state. Bug 238792 Summary: devel/py-period: make compatible with compat with pip 19.1.1 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=238792 What|Removed |Added Status|New |Closed Resolution|--- |FIXED -- You are receiving this mail because: You are on the CC list for the bug. ___ freebsd-python@freebsd.org mailing list https://lists.freebsd.org/mailman/listinfo/freebsd-python To unsubscribe, send any mail to "freebsd-python-unsubscr...@freebsd.org"
[Bug 238724] textproc/asciidoc 8.6.10 requires python 2.7 in spite of make.conf DEFAULT_VERSIONS+=python=3.7
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=238724 --- Comment #6 from Kubilay Kocak --- (In reply to Dennis Clarke from comment #5) If adding Python 3.x support is going be a proposed change, these should be submitted upstream as a first course of action, as there are already open works in progress for Python 3 support This issue is closed as existing behaviour is not a bug (read: intended behaviour). Any proposals to backport upstream changes to improve or add Python support should take place in a separate/new issue, referencing this one in "See Also" if desirable. -- You are receiving this mail because: You are on the CC list for the bug. ___ freebsd-python@freebsd.org mailing list https://lists.freebsd.org/mailman/listinfo/freebsd-python To unsubscribe, send any mail to "freebsd-python-unsubscr...@freebsd.org"
