open-vm-tools fails on a recent sup to CURRENT
Has anyone started seeing failures of ports/emulators/open-vm-tools builds with a recent current? I csup-ed my source recently (as of 20080926), rebuilt world and my kernel, and open-vm-tools builds fail in the vmhgfs module with the following: ... /usr/bin/make -C "freebsd/vmhgfs" "/usr/share/mk/bsd.compat.mk", line 35: warning: NOMAN is deprecated in favour of NO_MAN Warning: Object directory not changed from original /usr/obj/ports/usr/ports/emulators/open-vm-tools-nox11/work/open-vm-tools-2008.07.01-102166/modules/freebsd/vmhgfs @ -> /usr/src/sys machine -> /usr/src/sys/i386/include awk -f @/tools/vnode_if.awk @/kern/vnode_if.src -p awk -f @/tools/vnode_if.awk @/kern/vnode_if.src -q awk -f @/tools/vnode_if.awk @/kern/vnode_if.src -h cc -Os -fno-strict-aliasing -pipe -march=pentium-mmx -Werror -D_KERNEL -DKLD_MODULE -std=c99 -nostdinc -I. -I@ -I@/contrib/altq -finline-limit=8000 --param inline-unit-growth=100 --param large-function-growth=1000 -fno-common -mno-align-long-strings -mpreferred-stack-boundary=2 -mno-mmx -mno-3dnow -mno-sse -mno-sse2 -mno-sse3 -ffreestanding -fstack-protector -fstack-protector -Wall -Werror -Wno-redundant-decls -Wnested-externs -Wstrict-prototypes -Wno-missing-prototypes -Wpointer-arith -Winline -Wcast-qual -c vnops.c cc -Os -fno-strict-aliasing -pipe -march=pentium-mmx -Werror -D_KERNEL -DKLD_MODULE -std=c99 -nostdinc -I. -I@ -I@/contrib/altq -finline-limit=8000 --param inline-unit-growth=100 --param large-function-growth=1000 -fno-common -mno-align-long-strings -mpreferred-stack-boundary=2 -mno-mmx -mno-3dnow -mno-sse -mno-sse2 -mno-sse3 -ffreestanding -fstack-protector -fstack-protector -Wall -Werror -Wno-redundant-decls -Wnested-externs -Wstrict-prototypes -Wno-missing-prototypes -Wpointer-arith -Winline -Wcast-qual -c vfsops.c cc1: warnings being treated as errors vfsops.c: In function 'HgfsVfsMount': vfsops.c:142: warning: implicit declaration of function 'suser' vfsops.c:142: warning: nested extern declaration of 'suser' *** Error code 1 Stop in /usr/obj/ports/usr/ports/emulators/open-vm-tools-nox11/work/open-vm-tools-2008.07.01-102166/modules/freebsd/vmhgfs. *** Error code 1 Stop in /usr/obj/ports/usr/ports/emulators/open-vm-tools-nox11/work/open-vm-tools-2008.07.01-102166/modules. *** Error code 1 Stop in /usr/obj/ports/usr/ports/emulators/open-vm-tools-nox11/work/open-vm-tools-2008.07.01-102166. *** Error code 1 I've tried setting CFLAGS optimizations to -Os (my default), -O, -O2 and no optimizations and it fails with the same error every time. Has anyone else using CURRENT in VMware seen this error recently? Any ideas? Thanks, Michael Proto ___ freebsd-ports@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-ports To unsubscribe, send any mail to "[EMAIL PROTECTED]"
Re: open-vm-tools fails on a recent sup to CURRENT
On Tue, Oct 21, 2008 at 5:36 AM, Alexey Shuvaev <
[EMAIL PROTECTED]> wrote:
> On Tue, Oct 14, 2008 at 07:17:29PM -0400, Michael Proto wrote:
> > Has anyone started seeing failures of ports/emulators/open-vm-tools
> builds
> > with a recent current? I csup-ed my source recently (as of 20080926),
> > rebuilt world and my kernel, and open-vm-tools builds fail in the vmhgfs
> > module with the following:
> >
> >
> > ...
> > cc1: warnings being treated as errors
> > vfsops.c: In function 'HgfsVfsMount':
> > vfsops.c:142: warning: implicit declaration of function 'suser'
> > vfsops.c:142: warning: nested extern declaration of 'suser'
> > *** Error code 1
> > ...
> >
> > I've tried setting CFLAGS optimizations to -Os (my default), -O, -O2 and
> no
> > optimizations and it fails with the same error every time. Has anyone
> else
> > using CURRENT in VMware seen this error recently? Any ideas?
> >
> This is due to API change suser() -> priv_check().
> Have a look at
> http://www.freebsd.org/cgi/cvsweb.cgi/ports/x11/nvidia-driver/Makefile
> (revision 1.81) for example.
> I am not sure about "PRIV_DRIVER" argument, but you can try to replace
> "suser(CURTHREAD)" to "priv_check(CURTHREAD, PRIV_DRIVER)"
> in the open-vm-tools sources.
>
> Alexey.
>
Thanks for that bit of information! With the following patch I was able to
get open-vm-tools to successfully compile:
--- modules/freebsd/vmhgfs/vfsops.c.old 2008-07-01 18:31:11.0 -0400
+++ modules/freebsd/vmhgfs/vfsops.c 2008-10-21 16:50:23.0 -0400
@@ -139,7 +139,7 @@
* Since Hgfs requires the caller to be root, only allow mount attempts
made
* by the superuser.
*/
- if ((ret = suser(td)) != 0) {
+ if ((ret = priv_check(td, PRIV_DRIVER)) != 0) {
return ret;
}
--- modules/freebsd/vmblock/vnops.c.old 2008-07-01 18:31:09.0 -0400
+++ modules/freebsd/vmblock/vnops.c 2008-10-21 19:32:27.0 -0400
@@ -723,7 +723,7 @@
* NB: Allowing only the superuser to open this directory breaks
* readdir() of the filesystem root for non-privileged users.
*/
- if ((retval = suser(ap->a_td)) == 0) {
+ if ((retval = priv_check(ap->a_td, PRIV_DRIVER)) == 0) {
#if __FreeBSD_version >= 70
fp = ap->a_fp;
#else
I cannot say if makes these modules work or not, as I don't use them (my
main reason for having open-vm-tools is for vmware-guestd and its ability to
sync the VM's clock to the host), but the port compiles cleanly with this.
Thanks very much!
-Proto
___
freebsd-ports@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-ports
To unsubscribe, send any mail to "[EMAIL PROTECTED]"
Re: [headsup] call for assistance with ports broken on -current
On Sun, Mar 1, 2009 at 7:45 PM, Mark Linimon wrote: > FYI, here's what I posted to ports@ yesterday. Any help fixing these > would be appreciated. (We've already knocked off several of the ones > I initially posted.) > > mcl > > - Forwarded message from Mark Linimon - > > From: Mark Linimon > To: po...@freebsd.org > Subject: [headsup] call for assistance with ports broken on -current > > With 8.0 coming up, it's time to take a look at the ports that have > been broken by some recent changes to freebsd-current. I have put > a list of these ports, categorized by which change, on the wiki at > http://wiki.freebsd.org/PortsBrokenOnCurrent. > > These changes are: tty changes, jail changes, import of strndup(3), > ARP v2, libusb20, and possibly VFS. (libusb20 has not yet been run > through pointyhat, and its list is probably incomplete.) > What about non-ports breakage, ie- /bin/sh read builtin failing after the tty changes :) http://www.freebsd.org/cgi/query-pr.cgi?pr=bin/129566 Thanks, Proto ___ freebsd-ports@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-ports To unsubscribe, send any mail to "freebsd-ports-unsubscr...@freebsd.org"
"Bus error" and crash with gtk-2.10.6_2
Hello, I recently upgraded gtk-2 to 2.10.6_2 on my FreeBSD 5.5 box so I could install an updated firefox (was running gtk-2.6.3 which would cause a build of firefox-2.0 to fail) and now whenever I try to access the vertical scroll bar on any GTK2 app, the program crashes with a "Bus error". If I try to use either the scroll bar or my wheel mouse (to scroll inside the vertical scroll window), I get the same failure. I can easily replicate the issue with any GTK2 app I have installed. As a result, I used portmanager and did a recursive rebuild of all ports that gtk-2.10.6_2 depends on (portmanager x11-toolkits/gtk2 -f) and I'm still seeing the same, consistent, crashes. I've also rebuilt my installed GTK2 themes to be sure they were not the issue. Since this occurs with many gtk apps, I'm using gtk-chtheme as my test application. I ran it inside of gdb and here's what I get when I try to use the scroll bar in a GTK2 application: Program received signal SIGBUS, Bus error. 0x282c10a8 in gtk_tree_view_get_fixed_height_mode () from /usr/local/lib/libgtk-x11-2.0.so.0 Any ideas? I've tried rebuilding gtk numerous times (with and without gcc optimizations) to see if anything will help but I cannot manage to kick this problem. Here are a list of my versions of dependent ports: Information for gtk-2.10.6_2: Depends on: Dependency: libdrm-2.0.2 Dependency: libiconv-1.9.2_2 Dependency: expat-2.0.0_1 Dependency: jpeg-6b_4 Dependency: gettext-0.14.5_2 Dependency: png-1.2.12_1 Dependency: pkg-config-0.21 Dependency: perl-5.8.8 Dependency: freetype2-2.2.1_1 Dependency: fontconfig-2.3.2_6,1 Dependency: glib-2.12.4 Dependency: xorg-libraries-6.9.0 Dependency: libXft-2.1.7_1 Dependency: tiff-3.8.2 Dependency: hicolor-icon-theme-0.9_2 Dependency: libxml2-2.6.26 Dependency: shared-mime-info-0.19 Dependency: xorg-fonts-encodings-6.9.0_1 Dependency: bitstream-vera-1.10_2 Dependency: xorg-fonts-truetype-6.9.0 Dependency: cairo-1.2.6 Dependency: pango-1.14.7 Dependency: atk-1.12.3 Please reply to me directly if possible, as I'm not subscribed to this list. I'll try to follow the thread via Mailman. Thanks, Proto ___ freebsd-ports@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-ports To unsubscribe, send any mail to "[EMAIL PROTECTED]"
Re: "Bus error" and crash with gtk-2.10.6_2
Michael Proto wrote: > Hello, > > I recently upgraded gtk-2 to 2.10.6_2 on my FreeBSD 5.5 box so I could > install an updated firefox (was running gtk-2.6.3 which would cause a > build of firefox-2.0 to fail) and now whenever I try to access the > vertical scroll bar on any GTK2 app, the program crashes with a "Bus > error". If I try to use either the scroll bar or my wheel mouse (to > scroll inside the vertical scroll window), I get the same failure. For the list, I fixed this myself by deinstalling and reinstalling gtk20 (again) and all forward and reverse-dependent ports. Next time I'll check /usr/ports/UPDATING first :) -Proto ___ freebsd-ports@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-ports To unsubscribe, send any mail to "[EMAIL PROTECTED]"
