[Differential] [Changed Subscribers] D1388: IP6: Turned on verbose logging for fragment handling code

[ae (Andrey V. Elsukov)]

ae added a subscriber: ae.
ae added a comment.

I think you need to adjust some comments in frag6_input().

REVISION DETAIL
  https://reviews.freebsd.org/D1388

To: kibab, bz
Cc: ae, freebsd-net
___
freebsd-net@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-net
To unsubscribe, send any mail to "freebsd-net-unsubscr...@freebsd.org"

[Differential] [Changed Subscribers] D1777: Associated fix for arp/nd6 timer usage.

[ae (Andrey V. Elsukov)]

ae added a subscriber: ae.
ae added a comment.

You said about some panics, do you have traces?

REVISION DETAIL
  https://reviews.freebsd.org/D1777

To: rrs, imp, sbruno, gnn, rwatson, lstewart, kostikbel, adrian, jhb, bz
Cc: ae, bz, emaste, hiren, julian, hselasky, freebsd-net
___
freebsd-net@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-net
To unsubscribe, send any mail to "freebsd-net-unsubscr...@freebsd.org"

[Differential] [Changed Subscribers] D1815: Evaluate packet size after the firewall had its chance

[ae (Andrey V. Elsukov)]

ae added a subscriber: ae.
ae added a comment.

Since you are in ip6_forward(), this means ip6_input() has already checked this 
packet and PFIL had a chance to handle this packet.
IPv6 router should not do reassembling fragmented packets and do new 
fragmentation of them, but if you want, I think your packet filter should track 
these fragments on input. How do you tested this patch?

REVISION DETAIL
  https://reviews.freebsd.org/D1815

To: kristof
Cc: ae, freebsd-net
___
freebsd-net@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-net
To unsubscribe, send any mail to "freebsd-net-unsubscr...@freebsd.org"

[Differential] [Accepted] D1764: Factor out ip6_deletefraghdr()

[ae (Andrey V. Elsukov)]

ae added a subscriber: ae.
ae accepted this revision.
ae added a reviewer: ae.
ae added a comment.

I have no objections against it, the code looks similar to previous 
implementation.

REVISION DETAIL
  https://reviews.freebsd.org/D1764

To: kristof, glebius, ae
Cc: ae, glebius, freebsd-net
___
freebsd-net@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-net
To unsubscribe, send any mail to "freebsd-net-unsubscr...@freebsd.org"

[Differential] [Changed Subscribers] D1986: Teach lagg(4) to change MTU

[ae (Andrey V. Elsukov)]

ae added a subscriber: ae.
ae added a comment.

Just a thought. Imagine two interfaces, one has maximum MTU 2200, another 1500. 
lagg0 has MTU 1400.
Two threads invokes changing MTU in the same time. One wants to change it to 
2000, another - to 1500.
It is possible, that when both threads will finish its job, one interface will 
have MTU 1400, but another - 1500.
I mean, that such changes should be done exclusively without possibility of 
races in the ioctl code.

REVISION DETAIL
  https://reviews.freebsd.org/D1986

To: rpokala-panasas.com, rstone
Cc: ae, freebsd-net
___
freebsd-net@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-net
To unsubscribe, send any mail to "freebsd-net-unsubscr...@freebsd.org"

[Differential] [Commented On] D1986: Teach lagg(4) to change MTU

[ae (Andrey V. Elsukov)]

ae added a comment.

>>! In D1986#7, @rstone wrote:
> RLOCK only gets a read lock.  You want WLOCK to get a write lock to ensure 
> serialization.

Also we can use another lock in the lagg_ioctl, that will prevent simultaneous 
MTU changing.

REVISION DETAIL
  https://reviews.freebsd.org/D1986

To: rpokala-panasas.com, rstone
Cc: emaste, ae, freebsd-net
___
freebsd-net@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-net
To unsubscribe, send any mail to "freebsd-net-unsubscr...@freebsd.org"

[Differential] D12457: Complete INADDR_HASH lock protection

[ae (Andrey V. Elsukov)]

ae added inline comments.

INLINE COMMENTS

> eugen_grosbein.net wrote in if_stf.c:383
> in_localip() may be better, I just wished to make the patch as clear as 
> possible minizing changes for first revision.

Using in_localip() is preferred, because INADDR_HASH is protected with rmlock 
only in head/ and stable/11. So if you plan to merge this into stable/10, you 
will need to do direct commit.

REPOSITORY
  rS FreeBSD src repository

REVISION DETAIL
  https://reviews.freebsd.org/D12457

EMAIL PREFERENCES
  https://reviews.freebsd.org/settings/panel/emailpreferences/

To: eugen_grosbein.net, ae, avg, mav, rwatson
Cc: bz, imp, freebsd-net-list
___
freebsd-net@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-net
To unsubscribe, send any mail to "freebsd-net-unsubscr...@freebsd.org"

[Differential] D8214: ifnet: Use if_link_state snapshot to invoke ifnet_link_event

[ae (Andrey V. Elsukov)]

ae accepted this revision.
ae added a reviewer: ae.
ae added a comment.
This revision has a positive review.


  Looks ok to me.

REVISION DETAIL
  https://reviews.freebsd.org/D8214

EMAIL PREFERENCES
  https://reviews.freebsd.org/settings/panel/emailpreferences/

To: sepherosa_gmail.com, glebius, adrian, gnn, bz, ae
Cc: ae, freebsd-net-list
___
freebsd-net@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-net
To unsubscribe, send any mail to "freebsd-net-unsubscr...@freebsd.org"

[Differential] D9451: Constrain IPv6 interface routes to each FIB

[ae (Andrey V. Elsukov)]

ae added a comment.


  Can you resubmit the patch with more context? You can make it using such 
arguments for svn diff "--diff-cmd=diff -x -U99" or similar arguments for 
your VCS. It produces a much large patches, but it is possible to see more 
context.

REPOSITORY
  rS FreeBSD src repository

REVISION DETAIL
  https://reviews.freebsd.org/D9451

EMAIL PREFERENCES
  https://reviews.freebsd.org/settings/panel/emailpreferences/

To: jhujhiti_adjectivism.org, #network, asomers
Cc: imp, ae, freebsd-net-list
___
freebsd-net@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-net
To unsubscribe, send any mail to "freebsd-net-unsubscr...@freebsd.org"

[Differential] D23737: nat64: Get the IPv4 address from a NAT64 address when comparing addresses in a ICMP translate

[ae (Andrey V. Elsukov)]

ae requested changes to this revision.
ae added a comment.
This revision now requires changes to proceed.


  The patch is not correct. IPv4 address can be embedded in different places 
depending from configuration.

REPOSITORY
  rS FreeBSD src repository

CHANGES SINCE LAST ACTION
  https://reviews.freebsd.org/D23737/new/

REVISION DETAIL
  https://reviews.freebsd.org/D23737

EMAIL PREFERENCES
  https://reviews.freebsd.org/settings/panel/emailpreferences/

To: neel_neelc.org, ae
Cc: imp, ae, melifaro, #contributor_reviews_base, freebsd-net-list, mmacy, 
kpraveen.lkml_gmail.com, marcnarc_gmail.com, simonvella_gmail.com, 
novice_techie.com, tommi.pernila_iki.fi
___
freebsd-net@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-net
To unsubscribe, send any mail to "freebsd-net-unsubscr...@freebsd.org"

[Differential] D23737: nat64: Get the IPv4 address from a NAT64 address when comparing addresses in a ICMP translate

[ae (Andrey V. Elsukov)]

ae added a comment.


  In D23737#521593 , @neel_neelc.org 
wrote:
  
  > Here, I also compare the destination addresses. Is this what you want?
  
  No, take a look at RFC 6052 p2.2. 
.

REPOSITORY
  rS FreeBSD src repository

CHANGES SINCE LAST ACTION
  https://reviews.freebsd.org/D23737/new/

REVISION DETAIL
  https://reviews.freebsd.org/D23737

EMAIL PREFERENCES
  https://reviews.freebsd.org/settings/panel/emailpreferences/

To: neel_neelc.org, ae
Cc: imp, ae, melifaro, #contributor_reviews_base, freebsd-net-list, mmacy, 
kpraveen.lkml_gmail.com, marcnarc_gmail.com, simonvella_gmail.com, 
novice_techie.com, tommi.pernila_iki.fi
___
freebsd-net@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-net
To unsubscribe, send any mail to "freebsd-net-unsubscr...@freebsd.org"

[Differential] D23737: nat64: Get the IPv4 address from a NAT64 address when comparing addresses in a ICMP translate

[ae (Andrey V. Elsukov)]

ae added a comment.


  Also, how did test your changes? :)
  NAT64 currently is not widely used, thus changes here can break something  
and you will know about breakage when it will be not so easy to fix, e.g. after 
release.

REPOSITORY
  rS FreeBSD src repository

CHANGES SINCE LAST ACTION
  https://reviews.freebsd.org/D23737/new/

REVISION DETAIL
  https://reviews.freebsd.org/D23737

EMAIL PREFERENCES
  https://reviews.freebsd.org/settings/panel/emailpreferences/

To: neel_neelc.org, ae
Cc: imp, ae, melifaro, #contributor_reviews_base, freebsd-net-list, mmacy, 
kpraveen.lkml_gmail.com, marcnarc_gmail.com, simonvella_gmail.com, 
novice_techie.com, tommi.pernila_iki.fi
___
freebsd-net@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-net
To unsubscribe, send any mail to "freebsd-net-unsubscr...@freebsd.org"

[Differential] D24061: Hyper-V socket implementation for FreeBSD guest

[ae (Andrey V. Elsukov)]

ae added a comment.


  Do you have performance test results for already existing linux 
implementation?
  From a quick look it seems to me there will be bottleneck regarding locking 
that seems can be reduced using CK and epoch. But this task can be done in 
future, if you plan support this code.

REPOSITORY
  rS FreeBSD src repository

CHANGES SINCE LAST ACTION
  https://reviews.freebsd.org/D24061/new/

REVISION DETAIL
  https://reviews.freebsd.org/D24061

EMAIL PREFERENCES
  https://reviews.freebsd.org/settings/panel/emailpreferences/

To: whu, decui_microsoft.com, freebsd-net-list
Cc: ae, greg_unrelenting.technology, imp
___
freebsd-net@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-net
To unsubscribe, send any mail to "freebsd-net-unsubscr...@freebsd.org"

[Differential] D24989: netinet: Generate a random RSS key on boot.

[ae (Andrey V. Elsukov)]

ae added a comment.


  In D24989#552576 , @avg wrote:
  
  > I have a vague memory, maybe wrong, that commonly used fixed RSS keys were 
selected because they had some property (-ies).
  > So, maybe just being random is not good enough?
  > I think that hypothetical `rss_isbadkey` was mentioned for a reason?
  
  I also have such feeling. For example, you have some server that handles some 
serious workload, but after reboot due to the new key it will not be able to 
handle the same workload.

REPOSITORY
  rS FreeBSD src repository

CHANGES SINCE LAST ACTION
  https://reviews.freebsd.org/D24989/new/

REVISION DETAIL
  https://reviews.freebsd.org/D24989

EMAIL PREFERENCES
  https://reviews.freebsd.org/settings/panel/emailpreferences/

To: neel_neelc.org, #csprng, markm
Cc: avg, markm, cem, #csprng, kevans, debdrup, rwatson, imp, ae, melifaro, 
#contributor_reviews_base, freebsd-net-list, mmacy, kpraveen.lkml_gmail.com, 
marcnarc_gmail.com, simonvella_gmail.com, novice_techie.com, 
tommi.pernila_iki.fi, krzysztof.galazka_intel.com
___
freebsd-net@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-net
To unsubscribe, send any mail to "freebsd-net-unsubscr...@freebsd.org"

[Differential] D26757: Fix to join AllHost mcast group again when adding an existing IP address

[ae (Andrey V. Elsukov)]

ae accepted this revision.
ae added a comment.
This revision is now accepted and ready to land.


  Looks correct to me.

REPOSITORY
  rS FreeBSD src repository

CHANGES SINCE LAST ACTION
  https://reviews.freebsd.org/D26757/new/

REVISION DETAIL
  https://reviews.freebsd.org/D26757

EMAIL PREFERENCES
  https://reviews.freebsd.org/settings/panel/emailpreferences/

To: yannis.planus_alstomgroup.com, #network, mw, ae
Cc: ae, imp, freebsd-net-list, melifaro, rscheff
___
freebsd-net@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-net
To unsubscribe, send any mail to "freebsd-net-unsubscr...@freebsd.org"

[Differential] D26757: Fix to join AllHost mcast group again when adding an existing IP address

[ae (Andrey V. Elsukov)]

This revision was automatically updated to reflect the committed changes.
Closed by commit rS366682: Join to AllHosts multicast group again when adding 
an existing IPv4 address. (authored by ae).

CHANGED PRIOR TO COMMIT
  https://reviews.freebsd.org/D26757?vs=78157&id=78184#toc

REPOSITORY
  rS FreeBSD src repository

CHANGES SINCE LAST UPDATE
  https://reviews.freebsd.org/D26757?vs=78157&id=78184

CHANGES SINCE LAST ACTION
  https://reviews.freebsd.org/D26757/new/

REVISION DETAIL
  https://reviews.freebsd.org/D26757

AFFECTED FILES
  head/sys/netinet/in.c

CHANGE DETAILS

diff --git a/head/sys/netinet/in.c b/head/sys/netinet/in.c
--- a/head/sys/netinet/in.c
+++ b/head/sys/netinet/in.c
@@ -377,10 +377,11 @@
continue;
 
it = (struct in_ifaddr *)ifa;
-   iaIsFirst = false;
if (it->ia_addr.sin_addr.s_addr == addr->sin_addr.s_addr &&
prison_check_ip4(td->td_ucred, &addr->sin_addr) == 0)
ia = it;
+   else
+   iaIsFirst = false;
}
NET_EPOCH_EXIT(et);
 



EMAIL PREFERENCES
  https://reviews.freebsd.org/settings/panel/emailpreferences/

To: yannis.planus_alstomgroup.com, #network, mw, ae, gnn
Cc: ae, imp, freebsd-net-list, melifaro, rscheff
diff --git a/head/sys/netinet/in.c b/head/sys/netinet/in.c
--- a/head/sys/netinet/in.c
+++ b/head/sys/netinet/in.c
@@ -377,10 +377,11 @@
 			continue;
 
 		it = (struct in_ifaddr *)ifa;
-		iaIsFirst = false;
 		if (it->ia_addr.sin_addr.s_addr == addr->sin_addr.s_addr &&
 		prison_check_ip4(td->td_ucred, &addr->sin_addr) == 0)
 			ia = it;
+		else
+			iaIsFirst = false;
 	}
 	NET_EPOCH_EXIT(et);
 

___
freebsd-net@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-net
To unsubscribe, send any mail to "freebsd-net-unsubscr...@freebsd.org"