Re: Request for Testing: TCP RACK

2024-01-04 Thread Herbert J. Skuhra
On Fri, 17 Nov 2023 14:31:02 +0100, "Herbert J. Skuhra" wrote:
> 
> Hi,
> 
> On Fri, 17 Nov 2023 00:15:13 +0100, tue...@freebsd.org wrote:
> > 
> > > On Nov 16, 2023, at 20:06, Herbert J. Skuhra  wrote:
> > > 
> > > On Thu, 16 Nov 2023 19:07:29 +0100, Olivier Cochard-Labbé wrote:
> > >> 
> > >> On Thu, Nov 16, 2023 at 5:10 PM Herbert J. Skuhra  
> > >> wrote:
> > >> 
> > >>> 
> > >>> OK, I am now running GENERIC-NODEBUG + "options TCPHPTS".
> > >>> 
> > >>> After setting "sysctl net.inet.tcp.functions_default=rack" git no
> > >>> longer works:
> > >>> 
> > >>> 
> > >> Are you using a fresh 15 head or a specific network setup ?
> > >> 
> > >> Because I'm not able to reproduce your problem on my system:
> > >> 
> > >> $ uname -a
> > >> FreeBSD bigone 15.0-CURRENT FreeBSD 15.0-CURRENT #0
> > >> main-n266452-070d9e3540e6: Thu Nov 16 17:53:15 CET 2023
> > >> root@bigone:/usr/obj/usr/src/amd64.amd64/sys/TCPHPTS
> > >> amd64
> > >> $ cat /usr/src/sys/amd64/conf/TCPHPTS
> > >> include GENERIC-NODEBUG
> > >> ident   TCPHPTS
> > >> options TCPHPTS
> > >> $ sysctl net.inet.tcp.functions_default
> > >> net.inet.tcp.functions_default: rack
> > >> $ git clone -q g...@github.com:freebsd/freebsd-src.git && echo working
> > >> working
> > >> $
> > > 
> > > OK, (g)it works if I disable pf. Do you use pf?
> > Can you share your pf config such that I can reproduce the problem locally?
> 
> 1. It even fails with a simple pf.conf:
>pass in all
>pass out all
> 
> 2. Fetching port distfiles also failed.
> 
> 3. If I disable rxcsum on the ethernet adapter (igb0) it works.

Disabling lro also resolves the issue.

Not OK:

igb0: flags=1008843 metric 0 
mtu 1500

options=4e527bb

OK:

igb0: flags=1008843 metric 0 
mtu 1500

options=4e523bb

--
Herbert



Re: Request for Testing: TCP RACK

2024-01-04 Thread Herbert J. Skuhra
On Thu, 04 Jan 2024 14:57:59 +0100, tue...@fh-muenster.de wrote:
> 
> > On Jan 4, 2024, at 11:40, Herbert J. Skuhra  wrote:
> > 
> > On Fri, 17 Nov 2023 14:31:02 +0100, "Herbert J. Skuhra" wrote:
> >> 
> >> Hi,
> >> 
> >> On Fri, 17 Nov 2023 00:15:13 +0100, tue...@freebsd.org wrote:
> >>> 
>  On Nov 16, 2023, at 20:06, Herbert J. Skuhra  wrote:
>  
>  On Thu, 16 Nov 2023 19:07:29 +0100, Olivier Cochard-Labbé wrote:
> > 
> > On Thu, Nov 16, 2023 at 5:10 PM Herbert J. Skuhra  
> > wrote:
> > 
> >> 
> >> OK, I am now running GENERIC-NODEBUG + "options TCPHPTS".
> >> 
> >> After setting "sysctl net.inet.tcp.functions_default=rack" git no
> >> longer works:
> >> 
> >> 
> > Are you using a fresh 15 head or a specific network setup ?
> > 
> > Because I'm not able to reproduce your problem on my system:
> > 
> > $ uname -a
> > FreeBSD bigone 15.0-CURRENT FreeBSD 15.0-CURRENT #0
> > main-n266452-070d9e3540e6: Thu Nov 16 17:53:15 CET 2023
> > root@bigone:/usr/obj/usr/src/amd64.amd64/sys/TCPHPTS
> > amd64
> > $ cat /usr/src/sys/amd64/conf/TCPHPTS
> > include GENERIC-NODEBUG
> > ident   TCPHPTS
> > options TCPHPTS
> > $ sysctl net.inet.tcp.functions_default
> > net.inet.tcp.functions_default: rack
> > $ git clone -q g...@github.com:freebsd/freebsd-src.git && echo working
> > working
> > $
>  
>  OK, (g)it works if I disable pf. Do you use pf?
> >>> Can you share your pf config such that I can reproduce the problem 
> >>> locally?
> >> 
> >> 1. It even fails with a simple pf.conf:
> >>   pass in all
> >>   pass out all
> >> 
> >> 2. Fetching port distfiles also failed.
> >> 
> >> 3. If I disable rxcsum on the ethernet adapter (igb0) it works.
> > 
> > Disabling lro also resolves the issue.
> > 
> > Not OK:
> > 
> > igb0: flags=1008843 metric 
> > 0 mtu 1500
> >
> > options=4e527bb
> > 
> > OK:
> > 
> > igb0: flags=1008843 metric 
> > 0 mtu 1500
> >
> > options=4e523bb
> What kind of NIC do you have? Can you post the output of
> dmesg | grep igb0

igb0:  port 0xf000-0xf01f mem 
0xfc20-0xfc27,0xfc28-0xfc283fff irq 28 at device 0.0 on pci3
igb0: EEPROM V3.16-0 eTrack 0x84d6
igb0: Using 1024 TX descriptors and 1024 RX descriptors
igb0: Using 4 RX queues 4 TX queues
igb0: Using MSI-X interrupts with 5 vectors
igb0: Ethernet address: aa:bb:cc:dd:ee:ff
igb0: netmap queues/slots: TX 4/1024, RX 4/1024
igb0: link state changed to UP
igb0: link state changed to DOWN
igb0: link state changed to UP

--
Herbert



Re: Request for Testing: TCP RACK

2024-01-04 Thread tuexen
> On Jan 4, 2024, at 11:40, Herbert J. Skuhra  wrote:
> 
> On Fri, 17 Nov 2023 14:31:02 +0100, "Herbert J. Skuhra" wrote:
>> 
>> Hi,
>> 
>> On Fri, 17 Nov 2023 00:15:13 +0100, tue...@freebsd.org wrote:
>>> 
 On Nov 16, 2023, at 20:06, Herbert J. Skuhra  wrote:
 
 On Thu, 16 Nov 2023 19:07:29 +0100, Olivier Cochard-Labbé wrote:
> 
> On Thu, Nov 16, 2023 at 5:10 PM Herbert J. Skuhra  
> wrote:
> 
>> 
>> OK, I am now running GENERIC-NODEBUG + "options TCPHPTS".
>> 
>> After setting "sysctl net.inet.tcp.functions_default=rack" git no
>> longer works:
>> 
>> 
> Are you using a fresh 15 head or a specific network setup ?
> 
> Because I'm not able to reproduce your problem on my system:
> 
> $ uname -a
> FreeBSD bigone 15.0-CURRENT FreeBSD 15.0-CURRENT #0
> main-n266452-070d9e3540e6: Thu Nov 16 17:53:15 CET 2023
> root@bigone:/usr/obj/usr/src/amd64.amd64/sys/TCPHPTS
> amd64
> $ cat /usr/src/sys/amd64/conf/TCPHPTS
> include GENERIC-NODEBUG
> ident   TCPHPTS
> options TCPHPTS
> $ sysctl net.inet.tcp.functions_default
> net.inet.tcp.functions_default: rack
> $ git clone -q g...@github.com:freebsd/freebsd-src.git && echo working
> working
> $
 
 OK, (g)it works if I disable pf. Do you use pf?
>>> Can you share your pf config such that I can reproduce the problem locally?
>> 
>> 1. It even fails with a simple pf.conf:
>> pass in all
>> pass out all
>> 
>> 2. Fetching port distfiles also failed.
>> 
>> 3. If I disable rxcsum on the ethernet adapter (igb0) it works.
> 
> Disabling lro also resolves the issue.
> 
> Not OK:
> 
> igb0: flags=1008843 metric 0 
> mtu 1500
>  
> options=4e527bb
> 
> OK:
> 
> igb0: flags=1008843 metric 0 
> mtu 1500
>  
> options=4e523bb
What kind of NIC do you have? Can you post the output of
dmesg | grep igb0

Best regards
Michael
> 
> --
> Herbert
> 




Re: Request for Testing: TCP RACK

2024-01-04 Thread tuexen
> On Jan 4, 2024, at 15:22, Herbert J. Skuhra  wrote:
> 
> On Thu, 04 Jan 2024 14:57:59 +0100, tue...@fh-muenster.de wrote:
>> 
>>> On Jan 4, 2024, at 11:40, Herbert J. Skuhra  wrote:
>>> 
>>> On Fri, 17 Nov 2023 14:31:02 +0100, "Herbert J. Skuhra" wrote:
 
 Hi,
 
 On Fri, 17 Nov 2023 00:15:13 +0100, tue...@freebsd.org wrote:
> 
>> On Nov 16, 2023, at 20:06, Herbert J. Skuhra  wrote:
>> 
>> On Thu, 16 Nov 2023 19:07:29 +0100, Olivier Cochard-Labbé wrote:
>>> 
>>> On Thu, Nov 16, 2023 at 5:10 PM Herbert J. Skuhra  
>>> wrote:
>>> 
 
 OK, I am now running GENERIC-NODEBUG + "options TCPHPTS".
 
 After setting "sysctl net.inet.tcp.functions_default=rack" git no
 longer works:
 
 
>>> Are you using a fresh 15 head or a specific network setup ?
>>> 
>>> Because I'm not able to reproduce your problem on my system:
>>> 
>>> $ uname -a
>>> FreeBSD bigone 15.0-CURRENT FreeBSD 15.0-CURRENT #0
>>> main-n266452-070d9e3540e6: Thu Nov 16 17:53:15 CET 2023
>>> root@bigone:/usr/obj/usr/src/amd64.amd64/sys/TCPHPTS
>>> amd64
>>> $ cat /usr/src/sys/amd64/conf/TCPHPTS
>>> include GENERIC-NODEBUG
>>> ident   TCPHPTS
>>> options TCPHPTS
>>> $ sysctl net.inet.tcp.functions_default
>>> net.inet.tcp.functions_default: rack
>>> $ git clone -q g...@github.com:freebsd/freebsd-src.git && echo working
>>> working
>>> $
>> 
>> OK, (g)it works if I disable pf. Do you use pf?
> Can you share your pf config such that I can reproduce the problem 
> locally?
 
 1. It even fails with a simple pf.conf:
 pass in all
 pass out all
 
 2. Fetching port distfiles also failed.
 
 3. If I disable rxcsum on the ethernet adapter (igb0) it works.
>>> 
>>> Disabling lro also resolves the issue.
>>> 
>>> Not OK:
>>> 
>>> igb0: flags=1008843 metric 
>>> 0 mtu 1500
>>>  
>>> options=4e527bb
>>> 
>>> OK:
>>> 
>>> igb0: flags=1008843 metric 
>>> 0 mtu 1500
>>>  
>>> options=4e523bb
>> What kind of NIC do you have? Can you post the output of
>> dmesg | grep igb0
> 
> igb0:  port 0xf000-0xf01f mem 
> 0xfc20-0xfc27,0xfc28-0xfc283fff irq 28 at device 0.0 on pci3
> igb0: EEPROM V3.16-0 eTrack 0x84d6
> igb0: Using 1024 TX descriptors and 1024 RX descriptors
> igb0: Using 4 RX queues 4 TX queues
> igb0: Using MSI-X interrupts with 5 vectors
> igb0: Ethernet address: aa:bb:cc:dd:ee:ff
> igb0: netmap queues/slots: TX 4/1024, RX 4/1024
> igb0: link state changed to UP
> igb0: link state changed to DOWN
> igb0: link state changed to UP
Hi Herbert,

thank you very much. I'll see if I have such a NIC in one of my test systems 
and will report back.

Best regards
Michael
> 
> --
> Herbert
> 




Re: Request for Testing: TCP RACK

2024-01-04 Thread Herbert J. Skuhra
On Thu, 04 Jan 2024 11:40:35 +0100, "Herbert J. Skuhra" wrote:
> 
> On Fri, 17 Nov 2023 14:31:02 +0100, "Herbert J. Skuhra" wrote:
> > 
> > Hi,
> > 
> > On Fri, 17 Nov 2023 00:15:13 +0100, tue...@freebsd.org wrote:
> > > 
> > > > On Nov 16, 2023, at 20:06, Herbert J. Skuhra  wrote:
> > > > 
> > > > On Thu, 16 Nov 2023 19:07:29 +0100, Olivier Cochard-Labbé wrote:
> > > >> 
> > > >> On Thu, Nov 16, 2023 at 5:10 PM Herbert J. Skuhra  
> > > >> wrote:
> > > >> 
> > > >>> 
> > > >>> OK, I am now running GENERIC-NODEBUG + "options TCPHPTS".
> > > >>> 
> > > >>> After setting "sysctl net.inet.tcp.functions_default=rack" git no
> > > >>> longer works:
> > > >>> 
> > > >>> 
> > > >> Are you using a fresh 15 head or a specific network setup ?
> > > >> 
> > > >> Because I'm not able to reproduce your problem on my system:
> > > >> 
> > > >> $ uname -a
> > > >> FreeBSD bigone 15.0-CURRENT FreeBSD 15.0-CURRENT #0
> > > >> main-n266452-070d9e3540e6: Thu Nov 16 17:53:15 CET 2023
> > > >> root@bigone:/usr/obj/usr/src/amd64.amd64/sys/TCPHPTS
> > > >> amd64
> > > >> $ cat /usr/src/sys/amd64/conf/TCPHPTS
> > > >> include GENERIC-NODEBUG
> > > >> ident   TCPHPTS
> > > >> options TCPHPTS
> > > >> $ sysctl net.inet.tcp.functions_default
> > > >> net.inet.tcp.functions_default: rack
> > > >> $ git clone -q g...@github.com:freebsd/freebsd-src.git && echo working
> > > >> working
> > > >> $
> > > > 
> > > > OK, (g)it works if I disable pf. Do you use pf?
> > > Can you share your pf config such that I can reproduce the problem 
> > > locally?
> > 
> > 1. It even fails with a simple pf.conf:
> >pass in all
> >pass out all
> > 
> > 2. Fetching port distfiles also failed.
> > 
> > 3. If I disable rxcsum on the ethernet adapter (igb0) it works.
> 
> Disabling lro also resolves the issue.

If I run "sysctl net.inet.tcp.rack.features.cmpack=0" I don't have to
disable rxcsum/tcxsum or lro on igb0. 

--
Herbert



Re: Request for Testing: TCP RACK

2024-01-04 Thread tuexen



> On Jan 4, 2024, at 18:52, Herbert J. Skuhra  wrote:
> 
> On Thu, 04 Jan 2024 11:40:35 +0100, "Herbert J. Skuhra" wrote:
>> 
>> On Fri, 17 Nov 2023 14:31:02 +0100, "Herbert J. Skuhra" wrote:
>>> 
>>> Hi,
>>> 
>>> On Fri, 17 Nov 2023 00:15:13 +0100, tue...@freebsd.org wrote:
 
> On Nov 16, 2023, at 20:06, Herbert J. Skuhra  wrote:
> 
> On Thu, 16 Nov 2023 19:07:29 +0100, Olivier Cochard-Labbé wrote:
>> 
>> On Thu, Nov 16, 2023 at 5:10 PM Herbert J. Skuhra  
>> wrote:
>> 
>>> 
>>> OK, I am now running GENERIC-NODEBUG + "options TCPHPTS".
>>> 
>>> After setting "sysctl net.inet.tcp.functions_default=rack" git no
>>> longer works:
>>> 
>>> 
>> Are you using a fresh 15 head or a specific network setup ?
>> 
>> Because I'm not able to reproduce your problem on my system:
>> 
>> $ uname -a
>> FreeBSD bigone 15.0-CURRENT FreeBSD 15.0-CURRENT #0
>> main-n266452-070d9e3540e6: Thu Nov 16 17:53:15 CET 2023
>> root@bigone:/usr/obj/usr/src/amd64.amd64/sys/TCPHPTS
>> amd64
>> $ cat /usr/src/sys/amd64/conf/TCPHPTS
>> include GENERIC-NODEBUG
>> ident   TCPHPTS
>> options TCPHPTS
>> $ sysctl net.inet.tcp.functions_default
>> net.inet.tcp.functions_default: rack
>> $ git clone -q g...@github.com:freebsd/freebsd-src.git && echo working
>> working
>> $
> 
> OK, (g)it works if I disable pf. Do you use pf?
 Can you share your pf config such that I can reproduce the problem locally?
>>> 
>>> 1. It even fails with a simple pf.conf:
>>>  pass in all
>>>  pass out all
>>> 
>>> 2. Fetching port distfiles also failed.
>>> 
>>> 3. If I disable rxcsum on the ethernet adapter (igb0) it works.
>> 
>> Disabling lro also resolves the issue.
> 
> If I run "sysctl net.inet.tcp.rack.features.cmpack=0" I don't have to
> disable rxcsum/tcxsum or lro on igb0.
Does the problem also goes away if you disable pf completely, but keep
compressed acks enabled?

Best regards
Michael
> 
> --
> Herbert
> 




Re: Request for Testing: TCP RACK

2024-01-04 Thread Herbert J. Skuhra
On Thu, 04 Jan 2024 21:22:22 +0100, tue...@freebsd.org wrote:
> 
> > On Jan 4, 2024, at 18:52, Herbert J. Skuhra  wrote:
> > 
> > On Thu, 04 Jan 2024 11:40:35 +0100, "Herbert J. Skuhra" wrote:
> >> 
> >> On Fri, 17 Nov 2023 14:31:02 +0100, "Herbert J. Skuhra" wrote:
> >>> 
> >>> Hi,
> >>> 
> >>> On Fri, 17 Nov 2023 00:15:13 +0100, tue...@freebsd.org wrote:
>  
> > On Nov 16, 2023, at 20:06, Herbert J. Skuhra  wrote:
> > 
> > On Thu, 16 Nov 2023 19:07:29 +0100, Olivier Cochard-Labbé wrote:
> >> 
> >> On Thu, Nov 16, 2023 at 5:10 PM Herbert J. Skuhra  
> >> wrote:
> >> 
> >>> 
> >>> OK, I am now running GENERIC-NODEBUG + "options TCPHPTS".
> >>> 
> >>> After setting "sysctl net.inet.tcp.functions_default=rack" git no
> >>> longer works:
> >>> 
> >>> 
> >> Are you using a fresh 15 head or a specific network setup ?
> >> 
> >> Because I'm not able to reproduce your problem on my system:
> >> 
> >> $ uname -a
> >> FreeBSD bigone 15.0-CURRENT FreeBSD 15.0-CURRENT #0
> >> main-n266452-070d9e3540e6: Thu Nov 16 17:53:15 CET 2023
> >> root@bigone:/usr/obj/usr/src/amd64.amd64/sys/TCPHPTS
> >> amd64
> >> $ cat /usr/src/sys/amd64/conf/TCPHPTS
> >> include GENERIC-NODEBUG
> >> ident   TCPHPTS
> >> options TCPHPTS
> >> $ sysctl net.inet.tcp.functions_default
> >> net.inet.tcp.functions_default: rack
> >> $ git clone -q g...@github.com:freebsd/freebsd-src.git && echo working
> >> working
> >> $
> > 
> > OK, (g)it works if I disable pf. Do you use pf?
>  Can you share your pf config such that I can reproduce the problem 
>  locally?
> >>> 
> >>> 1. It even fails with a simple pf.conf:
> >>>  pass in all
> >>>  pass out all
> >>> 
> >>> 2. Fetching port distfiles also failed.
> >>> 
> >>> 3. If I disable rxcsum on the ethernet adapter (igb0) it works.
> >> 
> >> Disabling lro also resolves the issue.
> > 
> > If I run "sysctl net.inet.tcp.rack.features.cmpack=0" I don't have to
> > disable rxcsum/tcxsum or lro on igb0.
> Does the problem also goes away if you disable pf completely, but keep
> compressed acks enabled?

Yes, it works with pf disabled and compressed acks enabled.

--
Herbert



[Bug 200321] [ip] [pf] pfSync generates demotion events to carp when not needed

2024-01-04 Thread bugzilla-noreply
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=200321

Mark Linimon  changed:

   What|Removed |Added

   Assignee|e...@freebsd.org |n...@freebsd.org
   Keywords|patch   |

--- Comment #1 from Mark Linimon  ---
^Triage: commit bit was taken in for safekeeping.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.


[Bug 241047] iflib: fail to compile kernel on FreeBSD 12.1-BETA2: Fatal error: ifdi_if.h file not found.

2024-01-04 Thread bugzilla-noreply
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=241047

Mark Linimon  changed:

   What|Removed |Added

 Status|Open|Closed
   Assignee|b...@freebsd.org|bugmeis...@freebsd.org
 Resolution|--- |Overcome By Events

--- Comment #10 from Mark Linimon  ---
^Triage: FreeBSD 12 is now out of support.

-- 
You are receiving this mail because:
You are on the CC list for the bug.


[Bug 241106] tun/ppp: panic: vm_fault: fault on nofault entry when bringing ppp interface down

2024-01-04 Thread bugzilla-noreply
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=241106

Mark Linimon  changed:

   What|Removed |Added

  Flags|mfc-stable12?   |

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.


Re: Request for Testing: TCP RACK

2024-01-04 Thread tuexen
> On Jan 4, 2024, at 21:39, Herbert J. Skuhra  wrote:
> 
> On Thu, 04 Jan 2024 21:22:22 +0100, tue...@freebsd.org wrote:
>> 
>>> On Jan 4, 2024, at 18:52, Herbert J. Skuhra  wrote:
>>> 
>>> On Thu, 04 Jan 2024 11:40:35 +0100, "Herbert J. Skuhra" wrote:
 
 On Fri, 17 Nov 2023 14:31:02 +0100, "Herbert J. Skuhra" wrote:
> 
> Hi,
> 
> On Fri, 17 Nov 2023 00:15:13 +0100, tue...@freebsd.org wrote:
>> 
>>> On Nov 16, 2023, at 20:06, Herbert J. Skuhra  wrote:
>>> 
>>> On Thu, 16 Nov 2023 19:07:29 +0100, Olivier Cochard-Labbé wrote:
 
 On Thu, Nov 16, 2023 at 5:10 PM Herbert J. Skuhra  
 wrote:
 
> 
> OK, I am now running GENERIC-NODEBUG + "options TCPHPTS".
> 
> After setting "sysctl net.inet.tcp.functions_default=rack" git no
> longer works:
> 
> 
 Are you using a fresh 15 head or a specific network setup ?
 
 Because I'm not able to reproduce your problem on my system:
 
 $ uname -a
 FreeBSD bigone 15.0-CURRENT FreeBSD 15.0-CURRENT #0
 main-n266452-070d9e3540e6: Thu Nov 16 17:53:15 CET 2023
 root@bigone:/usr/obj/usr/src/amd64.amd64/sys/TCPHPTS
 amd64
 $ cat /usr/src/sys/amd64/conf/TCPHPTS
 include GENERIC-NODEBUG
 ident   TCPHPTS
 options TCPHPTS
 $ sysctl net.inet.tcp.functions_default
 net.inet.tcp.functions_default: rack
 $ git clone -q g...@github.com:freebsd/freebsd-src.git && echo working
 working
 $
>>> 
>>> OK, (g)it works if I disable pf. Do you use pf?
>> Can you share your pf config such that I can reproduce the problem 
>> locally?
> 
> 1. It even fails with a simple pf.conf:
> pass in all
> pass out all
> 
> 2. Fetching port distfiles also failed.
> 
> 3. If I disable rxcsum on the ethernet adapter (igb0) it works.
 
 Disabling lro also resolves the issue.
>>> 
>>> If I run "sysctl net.inet.tcp.rack.features.cmpack=0" I don't have to
>>> disable rxcsum/tcxsum or lro on igb0.
>> Does the problem also goes away if you disable pf completely, but keep
>> compressed acks enabled?
> 
> Yes, it works with pf disabled and compressed acks enabled.
Thanks for the information!

Best regards
Michael
> 
> --
> Herbert