[Bug 243590] TCP ECN not adhering extremely strictly to RFC3168 can cause massive TCP perf issues
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=243590 --- Comment #1 from commit-h...@freebsd.org --- A commit references this bug: Author: rscheff Date: Sun May 24 17:51:14 UTC 2020 New revision: 361436 URL: https://svnweb.freebsd.org/changeset/base/361436 Log: MFC r361347: With RFC3168 ECN, CWR SHOULD only be sent with new data Overly conservative data receivers may ignore the CWR flag on other packets, and keep ECE latched. This can result in continous reduction of the congestion window, and very poor performance when ECN is enabled. This does NOT contain the merge of the change to RACK since at this time that code does not exist in stable/11, and there is no plan to merge RACK to stable/11. PR: 243590 Reviewed by: rgrimes (mentor), rrs Approved by: rgrimes (mentor), tuexen (mentor) MFC after:3 days Sponsored by: NetApp, Inc. Differential Revision:https://reviews.freebsd.org/D23364 Changes: _U stable/11/ stable/11/sys/netinet/tcp_input.c stable/11/sys/netinet/tcp_output.c -- You are receiving this mail because: You are the assignee for the bug. ___ freebsd-net@freebsd.org mailing list https://lists.freebsd.org/mailman/listinfo/freebsd-net To unsubscribe, send any mail to "freebsd-net-unsubscr...@freebsd.org"
[Bug 243590] TCP ECN not adhering extremely strictly to RFC3168 can cause massive TCP perf issues
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=243590 Richard Scheffenegger changed: What|Removed |Added Status|New |Closed Assignee|n...@freebsd.org |rsch...@freebsd.org Flags||maintainer-feedback-, ||mfc-stable12?, ||mfc-stable11+, ||mfc-stable10-, exp-run- Resolution|--- |FIXED --- Comment #2 from Richard Scheffenegger --- rS361347 fixes this issue in HEAD, scheduled for MFC to stable/12 soonish, after rS355273 has been MFC'd -- You are receiving this mail because: You are the assignee for the bug. ___ freebsd-net@freebsd.org mailing list https://lists.freebsd.org/mailman/listinfo/freebsd-net To unsubscribe, send any mail to "freebsd-net-unsubscr...@freebsd.org"
[Bug 174087] [tcp] Problems with ephemeral port selection
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=174087 Richard Scheffenegger changed: What|Removed |Added CC||rsch...@freebsd.org --- Comment #6 from Richard Scheffenegger --- I believe D24781 / rS361228 fixes this particular issue. -- You are receiving this mail because: You are the assignee for the bug. ___ freebsd-net@freebsd.org mailing list https://lists.freebsd.org/mailman/listinfo/freebsd-net To unsubscribe, send any mail to "freebsd-net-unsubscr...@freebsd.org"
[Bug 199287] Missing TCP retransmit timer reset
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=199287 Richard Scheffenegger changed: What|Removed |Added CC||rsch...@freebsd.org --- Comment #6 from Richard Scheffenegger --- Can this bug report closed as historic? -- You are receiving this mail because: You are the assignee for the bug. ___ freebsd-net@freebsd.org mailing list https://lists.freebsd.org/mailman/listinfo/freebsd-net To unsubscribe, send any mail to "freebsd-net-unsubscr...@freebsd.org"
[Bug 238478] TCP Cubic code bug in cubic_ack_received
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=238478 Richard Scheffenegger changed: What|Removed |Added Status|New |In Progress --- Comment #3 from Richard Scheffenegger --- Currently working to validate the fix in D24657 -- You are receiving this mail because: You are on the CC list for the bug. ___ freebsd-net@freebsd.org mailing list https://lists.freebsd.org/mailman/listinfo/freebsd-net To unsubscribe, send any mail to "freebsd-net-unsubscr...@freebsd.org"
[Differential] D24989: netinet: Generate a random RSS key on boot.
neel_neelc.org created this revision.
neel_neelc.org added a project: network.
Herald added subscribers: Contributor Reviews (base), melifaro, ae, imp.
neel_neelc.org requested review of this revision.
REVISION SUMMARY
netinet: Generate a random RSS key on boot.
Submitted by: Neel Chauhan
REPOSITORY
rS FreeBSD src repository
REVISION DETAIL
https://reviews.freebsd.org/D24989
AFFECTED FILES
sys/net/rss_config.c
EMAIL PREFERENCES
https://reviews.freebsd.org/settings/panel/emailpreferences/
To: neel_neelc.org
Cc: imp, ae, melifaro, #contributor_reviews_base, freebsd-net-list, mmacy,
kpraveen.lkml_gmail.com, marcnarc_gmail.com, simonvella_gmail.com,
novice_techie.com, tommi.pernila_iki.fi, krzysztof.galazka_intel.com
diff --git a/sys/net/rss_config.c b/sys/net/rss_config.c
--- a/sys/net/rss_config.c
+++ b/sys/net/rss_config.c
@@ -74,7 +74,6 @@
* - Synchronization for rss_key and other future-configurable parameters.
* - Event handler drivers can register to pick up RSS configuration changes.
* - Should we allow rss_basecpu to be configured?
- * - Randomize key on boot.
* - IPv6 support.
* - Statistics on how often there's a misalignment between hardware
* placement and pcbgroup expectations.
@@ -153,19 +152,8 @@
* RSS secret key, intended to prevent attacks on load-balancing. Its
* effectiveness may be limited by algorithm choice and available entropy
* during the boot.
- *
- * XXXRW: And that we don't randomize it yet!
- *
- * This is the default Microsoft RSS specification key which is also
- * the Chelsio T5 firmware default key.
*/
-static uint8_t rss_key[RSS_KEYSIZE] = {
- 0x6d, 0x5a, 0x56, 0xda, 0x25, 0x5b, 0x0e, 0xc2,
- 0x41, 0x67, 0x25, 0x3d, 0x43, 0xa3, 0x8f, 0xb0,
- 0xd0, 0xca, 0x2b, 0xcb, 0xae, 0x7b, 0x30, 0xb4,
- 0x77, 0xcb, 0x2d, 0xa3, 0x80, 0x30, 0xf2, 0x0c,
- 0x6a, 0x42, 0xb7, 0x3b, 0xbe, 0xac, 0x01, 0xfa,
-};
+uint8_t rss_key[RSS_KEYSIZE];
/*
* RSS hash->CPU table, which maps hashed packet headers to particular CPUs.
@@ -258,11 +246,9 @@
}
/*
- * Randomize rrs_key.
- *
- * XXXRW: Not yet. If nothing else, will require an rss_isbadkey()
- * loop to check for "bad" RSS keys.
+ * Randomize rss_key.
*/
+ arc4random_buf(&rss_key, RSS_KEYSIZE);
}
SYSINIT(rss_init, SI_SUB_SOFTINTR, SI_ORDER_SECOND, rss_init, NULL);
___
freebsd-net@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-net
To unsubscribe, send any mail to "freebsd-net-unsubscr...@freebsd.org"
Problem reports for n...@freebsd.org that need special attention
To view an individual PR, use: https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=(Bug Id). The following is a listing of current problems submitted by FreeBSD users, which need special attention. These represent problem reports covering all versions including experimental development code and obsolete releases. Status |Bug Id | Description +---+--- In Progress |221146 | [ixgbe] Problem with second laggport In Progress |235700 | oce(4) driver causes fatal trap 12 on boot with e New |204438 | setsockopt() handling of kern.ipc.maxsockbuf limi New |205592 | TCP processing in IPSec causes kernel panic New |213410 | [carp] service netif restart causes hang only whe Open| 7556 | ppp: sl_compress_init() will fail if called anyth Open|187835 | ngctl(8) strange behavior when adding more than 5 Open|193452 | Dell PowerEdge 210 II -- Kernel panic bce (broadc Open|194453 | dummynet(4): pipe config bw parameter limited to Open|200319 | Bridge+CARP crashes/freezes Open|202510 | [CARP] advertisements sourced from CARP IP cause Open|207261 | netmap: Doesn't do TX sync with kqueue Open|210726 | tcp connect() can return invalid EADDRINUSE (Eg: Open|73 | igb(4): Kernel panic (fatal trap 12) due to netwo Open|225438 | panic in6_unlink_ifa() due to race Open|227720 | Kernel panic in ppp server Open|230807 | if_alc(4): Driver not working for Killer Networki Open|235524 | igb(4): Ethernet interface loses active link stat Open|236888 | ppp daemon: Allow MTU to be overridden for PPPoE Open|236983 | bnxt(4) VLAN not operational unless explicit "ifc Open|237072 | netgraph(4): performance issue [on HardenedBSD]? Open|237840 | Removed dummynet dependency on ipfw Open|238324 | Add XG-C100C/AQtion AQC107 10GbE NIC driver Open|240530 | netgraph/ng_source: Allow ng_source to inject int Open|240944 | em(4): Crash with Intel 82571EB NIC with AMD Pile Open|240969 | netinet6: Neighbour reachability detection broken Open|241106 | tun/ppp: panic: vm_fault: fault on nofault entry Open|241162 | Panic in closefp() triggered by nginx (uwsgi with Open|243463 | ix0: Watchdog timeout Open|244066 | divert: Add sysctls for divert socket send and re Open|118111 | rc: network.subr Add MAC address based interface 31 problems total for which you should take action. ___ freebsd-net@freebsd.org mailing list https://lists.freebsd.org/mailman/listinfo/freebsd-net To unsubscribe, send any mail to "freebsd-net-unsubscr...@freebsd.org"
[Bug 246706] [netgraph] kernel panic due to corrupted memory
_add_hook (node=0xf80092840600, name=0xf800921e9978 "left2right",
hookp=0xfe012499f728) at /home/src/sys/netgraph/ng_base.c:1073
#11 0x80624a0c in ng_mkpeer (node=0xf8004f15fe00, name=,
name2=0xf800921e9978 "left2right", type=)
at /home/src/sys/netgraph/ng_base.c:1555
#12 0x80622d7f in ng_generic_msg (here=0xf8004f15fe00,
item=,
lasthook=) at /home/src/sys/netgraph/ng_base.c:2537
#13 ng_apply_item (node=0xf8004f15fe00, item=0xf800423b5c00, rw=1)
at /home/src/sys/netgraph/ng_base.c:2437
#14 0x8062278e in ng_snd_item (item=0xf800423b5c00, flags=0)
at /home/src/sys/netgraph/ng_base.c:2320
#15 0x806329b3 in ngc_send (so=, flags=,
m=0xf80006d01000, addr=, control=,
td=)
--Type for more, q to quit, c to continue without paging--
at /home/src/sys/netgraph/ng_socket.c:338
#16 0x805868ea in sosend_generic (so=0xf80006c0da38,
addr=0xf8004f6da9f0,
uio=0xfe012499f980, top=0xf80006d01000, control=,
flags=, td=0xf8004f56) at
/home/src/sys/kern/uipc_socket.c:1360
#17 0x8058d246 in kern_sendit (td=, s=2, mp=, flags=0,
control=0x0, segflg=UIO_USERSPACE) at
/home/src/sys/kern/uipc_syscalls.c:884
#18 0x8058d591 in sendit (td=0xf8004f56, s=2,
mp=0xfe012499fa80, flags=-1)
at /home/src/sys/kern/uipc_syscalls.c:804
#19 0x8058d3ed in sys_sendto (td=0xf80092840600, uap=)
at /home/src/sys/kern/uipc_syscalls.c:935
#20 0x80778f18 in syscallenter (td=0xf8004f56)
at /home/src/sys/amd64/amd64/../../kern/subr_syscall.c:132
#21 amd64_syscall (td=0xf8004f56, traced=0) at
/home/src/sys/amd64/amd64/trap.c:1014
#22
#23 0x00080279378a in ?? ()
Backtrace stopped: Cannot access memory at address 0x7fffdfffda08
Note that "node" structure seems to be corrupted to the moment of panic:
(kgdb) frame 12
#12 0x80622d7f in ng_generic_msg (here=0xf8004f15fe00,
item=,
lasthook=) at /home/src/sys/netgraph/ng_base.c:2537
2537error = ng_mkpeer(here, mkp->ourhook, mkp->peerhook,
mkp->type);
(kgdb) p *mkp
$1 = {type = "l858", '\000' ,
ourhook =
"Ю-$O\000ЬЪЪ\000\000\000\000\000\000\000\000\000кj\222\000ЬЪЪ\000Ч\025O\000ЬЪЪ",
peerhook = "\200]\a\222\000ЬЪЪюё\n\222\000ЬЪЪ", '\000' }
(kgdb) frame 10
#10 ng_add_hook (node=0xf80092840600, name=0xf800921e9978 "left2right",
hookp=0xfe012499f728) at /home/src/sys/netgraph/ng_base.c:1073
1073if (ng_findhook(node, name) != NULL) {
(kgdb) p *node
$2 = {nd_name = '\000' , nd_type = 0x0, nd_flags = 0,
nd_numhooks = 0,
nd_private = 0xf80092840600, nd_ID = 0, nd_hooks = {lh_first = 0x0},
nd_nodes = {
le_next = 0x0, le_prev = 0x0}, nd_idnodes = {le_next = 0x0, le_prev = 0x0},
nd_input_queue = {
q_flags = 0, q_flags2 = 0, q_mtx = {lock_object = {lo_name = 0x0, lo_flags
= 0, lo_data = 0,
lo_witness = 0x0}, mtx_lock = 0}, q_work = {stqe_next = 0x0}, queue =
{stqh_first = 0x0,
stqh_last = 0x0}}, nd_refs = 0, nd_vnet = 0x0}
(kgdb) frame 9
#9 0x80624dc0 in ng_findhook (node=0xf80092840600,
name=0xf800921e9978 "left2right") at
/home/src/sys/netgraph/ng_base.c:1128
1128if (node->nd_type->findhook != NULL)
(kgdb) p node->nd_type
$3 = (struct ng_type *) 0x0
Compressed crashdump and kernel.debug files are available here (101MB in
total):
http://www.grosbein.net/freebsd/crash/20200524/
--
You are receiving this mail because:
You are the assignee for the bug.
___
freebsd-net@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-net
To unsubscribe, send any mail to "freebsd-net-unsubscr...@freebsd.org"
[Differential] D24989: netinet: Generate a random RSS key on boot.
debdrup added subscribers: rwatson, debdrup. debdrup added a comment. Did you mean to add some reviewers for this too? :) Looks like @rwatson might have some thoughts on this :) REPOSITORY rS FreeBSD src repository CHANGES SINCE LAST ACTION https://reviews.freebsd.org/D24989/new/ REVISION DETAIL https://reviews.freebsd.org/D24989 EMAIL PREFERENCES https://reviews.freebsd.org/settings/panel/emailpreferences/ To: neel_neelc.org Cc: debdrup, rwatson, imp, ae, melifaro, #contributor_reviews_base, freebsd-net-list, mmacy, kpraveen.lkml_gmail.com, marcnarc_gmail.com, simonvella_gmail.com, novice_techie.com, tommi.pernila_iki.fi, krzysztof.galazka_intel.com ___ freebsd-net@freebsd.org mailing list https://lists.freebsd.org/mailman/listinfo/freebsd-net To unsubscribe, send any mail to "freebsd-net-unsubscr...@freebsd.org"
[Bug 246705] [re] RTL8111/8168/8411 PCI Express Gigabit Ethernet Controller (rev 04) dosesn't work
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=246705 Mark Linimon changed: What|Removed |Added Assignee|b...@freebsd.org|n...@freebsd.org -- You are receiving this mail because: You are the assignee for the bug. ___ freebsd-net@freebsd.org mailing list https://lists.freebsd.org/mailman/listinfo/freebsd-net To unsubscribe, send any mail to "freebsd-net-unsubscr...@freebsd.org"
[Differential] D24989: netinet: Generate a random RSS key on boot.
neel_neelc.org added a comment. Sure. REPOSITORY rS FreeBSD src repository CHANGES SINCE LAST ACTION https://reviews.freebsd.org/D24989/new/ REVISION DETAIL https://reviews.freebsd.org/D24989 EMAIL PREFERENCES https://reviews.freebsd.org/settings/panel/emailpreferences/ To: neel_neelc.org Cc: debdrup, rwatson, imp, ae, melifaro, #contributor_reviews_base, freebsd-net-list, mmacy, kpraveen.lkml_gmail.com, marcnarc_gmail.com, simonvella_gmail.com, novice_techie.com, tommi.pernila_iki.fi, krzysztof.galazka_intel.com ___ freebsd-net@freebsd.org mailing list https://lists.freebsd.org/mailman/listinfo/freebsd-net To unsubscribe, send any mail to "freebsd-net-unsubscr...@freebsd.org"
[Bug 246003] em(4) Intel I219-V6 on NUC8i5BEH randomly loses carrier or fails over to 100Mbit
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=246003 Mark Linimon changed: What|Removed |Added Keywords||IntelNetworking Assignee|b...@freebsd.org|n...@freebsd.org -- You are receiving this mail because: You are the assignee for the bug. ___ freebsd-net@freebsd.org mailing list https://lists.freebsd.org/mailman/listinfo/freebsd-net To unsubscribe, send any mail to "freebsd-net-unsubscr...@freebsd.org"
[Bug 245981] BCM57414 not initializing
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=245981 Mark Linimon changed: What|Removed |Added Assignee|b...@freebsd.org|n...@freebsd.org -- You are receiving this mail because: You are the assignee for the bug. ___ freebsd-net@freebsd.org mailing list https://lists.freebsd.org/mailman/listinfo/freebsd-net To unsubscribe, send any mail to "freebsd-net-unsubscr...@freebsd.org"
[Bug 245894] ixl(4) does not support more than 255 VLANs
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=245894 Mark Linimon changed: What|Removed |Added Assignee|b...@freebsd.org|n...@freebsd.org -- You are receiving this mail because: You are the assignee for the bug. ___ freebsd-net@freebsd.org mailing list https://lists.freebsd.org/mailman/listinfo/freebsd-net To unsubscribe, send any mail to "freebsd-net-unsubscr...@freebsd.org"
[Bug 245697] Page fault in frag6_slowtimo
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=245697 Mark Linimon changed: What|Removed |Added Assignee|b...@freebsd.org|n...@freebsd.org -- You are receiving this mail because: You are the assignee for the bug. ___ freebsd-net@freebsd.org mailing list https://lists.freebsd.org/mailman/listinfo/freebsd-net To unsubscribe, send any mail to "freebsd-net-unsubscr...@freebsd.org"
[Bug 245449] link down bge0 when bge_attach()
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=245449 Mark Linimon changed: What|Removed |Added Assignee|b...@freebsd.org|n...@freebsd.org Keywords||patch -- You are receiving this mail because: You are the assignee for the bug. ___ freebsd-net@freebsd.org mailing list https://lists.freebsd.org/mailman/listinfo/freebsd-net To unsubscribe, send any mail to "freebsd-net-unsubscr...@freebsd.org"
