[Bug 235700] oce(4) driver causes fatal trap 12 on boot with emulex 10gbe nic

2019-02-24 Thread bugzilla-noreply
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=235700

Kubilay Kocak  changed:

   What|Removed |Added

 Status|New |Open
  Flags||mfc-stable11?,
   ||mfc-stable12?
 CC||hsela...@freebsd.org,
   ||jpaet...@freebsd.org,
   ||venkatduvvuru...@gmail.com
   Keywords||crash, needs-qa, patch

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
freebsd-net@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-net
To unsubscribe, send any mail to "freebsd-net-unsubscr...@freebsd.org"


Re: Infiniband: Mellanox MT26418 in ethernet mode causes crash on shutdown

2019-02-24 Thread Hans Petter Selasky

On 2/24/19 1:23 AM, Andreas Kempe wrote:

Hello,

When running a Mellanox MT26418 in ethernet mode, the kernel crashes
with the following stack trace on system shutdown:


Fatal trap 12: page fault while in kernel mode
cpuid = 0; apic id = 00
fault virtual address   = 0x0
fault code  = supervisor read data, page not present
instruction pointer = 0x20:0x80e3f5f4
stack pointer   = 0x28:0xfe064abec6e0
frame pointer   = 0x28:0xfe064abec700
code segment= base 0x0, limit 0xf, type 0x1b
 = DPL 0, pres 1, long 1, def32 0, gran 1
processor eflags= interrupt enabled, resume, IOPL = 0
current process = 1 (init)
trap number = 12
panic: page fault
cpuid = 0
KDB: stack backtrace:
#0 0x80b4c5b7 at kdb_backtrace+0x67
#1 0x80b05b57 at vpanic+0x177
#2 0x80b059d3 at panic+0x43
#3 0x8106efdf at trap_fatal+0x35f
#4 0x8106f039 at trap_pfault+0x49
#5 0x8106e807 at trap+0x2c7
#6 0x8104f03c at calltrap+0x8
#7 0x80e3fae2 at mlx4_en_stop_port+0x3d2
#8 0x80e40ff6 at mlx4_en_destroy_netdev+0x1e6
#9 0x80e3e47d at mlx4_en_remove+0xcd
#10 0x80e1ab01 at mlx4_remove_device+0xb1
#11 0x80e1b0b8 at mlx4_unregister_device+0x98
#12 0x80e1c5c5 at mlx4_unload_one+0x85
#13 0x80e23543 at mlx4_shutdown+0x83
#14 0x80d6b6e9 at linux_pci_shutdown+0x39
#15 0x80b4004a at bus_generic_shutdown+0x5a
#16 0x80b4004a at bus_generic_shutdown+0x5a
#17 0x80b4004a at bus_generic_shutdown+0x5a


I've traced the issue to the following lines of code in
sys/dev/mlx4/mlx4_en/mlx4_en_netdev.c in mlx4_en_destroy_netdev():

 /* Unregister device - this will close the port if it was up */
 if (priv->registered) {
 mutex_lock(&mdev->state_lock);
 ether_ifdetach(dev);
 mutex_unlock(&mdev->state_lock);
}>> mutex_lock(&mdev->state_lock);
 mlx4_en_stop_port(dev);
 mutex_unlock(&mdev->state_lock);



The issue is that mlx4_en_stop_port() follows the fcall chain below and
tries to fetch the MAC address of the device in mlx4_en_put_qp.
mlx4_en_destroy_netdev->mlx4_en_stop_port->mlx4_en_put_qp

The sequence above causes the kernel to choke because the MAC address
was freed in the previous call to ether_ifdetach in if_detach_internal
with the following call chain:
mlx4_en_destroy_netdev->ether_ifdetach->if_detach->if_detach_internal

I've written a small workaround that works on our test machine, although
I suspect this could potentially cause issues as we're destroying the
port before we destroy the interface. Please see the attached patch for
the workaround.

Cordially,
Andreas Kempe
Lysator ACS


CC'ing FreeBSD-drivers at Mellanox.

Thank you for your patch. We'll have a look at it.

--HPS

___
freebsd-net@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-net
To unsubscribe, send any mail to "freebsd-net-unsubscr...@freebsd.org"


[Bug 235700] oce(4) driver causes fatal trap 12 on boot with emulex 10gbe nic

2019-02-24 Thread bugzilla-noreply
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=235700

--- Comment #5 from Ryan Moeller  ---
(In reply to Sajeev Ramasamy from comment #4)
Ah I see the confusion. Those lines are in stable/11, but not in 11.2-release.
https://github.com/freebsd/freebsd/blob/stable/11/sys/dev/oce/oce_if.c#L2392-L2395

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
freebsd-net@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-net
To unsubscribe, send any mail to "freebsd-net-unsubscr...@freebsd.org"


[Bug 219428] em network driver broken in current

2019-02-24 Thread bugzilla-noreply
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=219428

rob...@longwinters.org changed:

   What|Removed |Added

 CC||rob...@longwinters.org

--- Comment #18 from rob...@longwinters.org ---
Can confirm this is still a problem on 12.0-RELEASE-p3. Of note it is only
happening on em0 on my system, I use em1 for a cross connect and NFS. They're
both the built in on the motherboard.



em0@pci0:0:25:0: class=0x02 card=0x20378086 chip=0x15038086 rev=0x04
hdr=0x00
vendor = 'Intel Corporation'
device = '82579V Gigabit Network Connection'
class  = network
subclass   = ethernet


em1@pci0:3:0:0: class=0x02 card=0x20378086 chip=0x10d38086 rev=0x00
hdr=0x00
vendor = 'Intel Corporation'
device = '82574L Gigabit Network Connection'
class  = network
subclass   = ethernet

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
freebsd-net@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-net
To unsubscribe, send any mail to "freebsd-net-unsubscr...@freebsd.org"


[Bug 235700] oce(4) driver causes fatal trap 12 on boot with emulex 10gbe nic

2019-02-24 Thread bugzilla-noreply
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=235700

Josh Paetzel  changed:

   What|Removed |Added

 Status|Open|In Progress

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
freebsd-net@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-net
To unsubscribe, send any mail to "freebsd-net-unsubscr...@freebsd.org"


[Bug 235700] oce(4) driver causes fatal trap 12 on boot with emulex 10gbe nic

2019-02-24 Thread bugzilla-noreply
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=235700

--- Comment #4 from Sajeev Ramasamy  ---
(In reply to Ryan Moeller from comment #3)
Hey, sorry to bother you again, but i'm not able to find those lines in
11.2-RELEASE version.
https://github.com/freebsd/freebsd/blob/release/11.2.0/sys/dev/oce/oce_if.c

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
freebsd-net@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-net
To unsubscribe, send any mail to "freebsd-net-unsubscr...@freebsd.org"


Problem reports for n...@freebsd.org that need special attention

2019-02-24 Thread bugzilla-noreply
To view an individual PR, use:
  https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=(Bug Id).

The following is a listing of current problems submitted by FreeBSD users,
which need special attention. These represent problem reports covering
all versions including experimental development code and obsolete releases.

Status  |Bug Id | Description
+---+---
In Progress |221146 | [ixgbe] Problem with second laggport  
New |204438 | setsockopt() handling of kern.ipc.maxsockbuf limi 
New |205592 | TCP processing in IPSec causes kernel panic   
New |213410 | [carp] service netif restart causes hang only whe 
Open|193452 | Dell PowerEdge 210 II -- Kernel panic bce (broadc 
Open|200319 | Bridge+CARP crashes/freezes   
Open|202510 | [CARP] advertisements sourced from CARP IP cause  
Open|73 | igb(4): Kernel panic (fatal trap 12) due to netwo 
Open|227720 | Kernel panic in ppp server
Open|233952 | jme NICs non functional after 11.2 to 12.0 upgrad 

10 problems total for which you should take action.
___
freebsd-net@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-net
To unsubscribe, send any mail to "freebsd-net-unsubscr...@freebsd.org"


[Bug 235983] [firewire] external firewire drive does not create device node

2019-02-24 Thread bugzilla-noreply
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=235983

Mark Linimon  changed:

   What|Removed |Added

   Assignee|b...@freebsd.org|n...@freebsd.org

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
freebsd-net@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-net
To unsubscribe, send any mail to "freebsd-net-unsubscr...@freebsd.org"