[Bug 206721] FreeBSDs DHCP client(dhclient) does not support the interface-mtu option(option 26).

2018-06-07 Thread bugzilla-noreply
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=206721

--- Comment #26 from commit-h...@freebsd.org ---
A commit references this bug:

Author: marius
Date: Thu Jun  7 15:03:48 UTC 2018
New revision: 334787
URL: https://svnweb.freebsd.org/changeset/base/334787

Log:
  MFC: r334443 (by cem@)

  dhclient(8): allow to supersede interface-mtu option

  In some cases broken DHCP servers might send invalid MTU value, so allow to
  use 'supersede' in dhclient.conf to override this. When superseded value is
  0, MTU value is not updated at all.

  PR:   206721
  Submitted by: novel@
  Reported by:  
  Relnotes: yes (potentially surprising behavior change w/ broken dhcpd
mtu)
  Differential Revision:https://reviews.freebsd.org/D15484

Changes:
_U  stable/11/
  stable/11/sbin/dhclient/dhclient.c
  stable/11/sbin/dhclient/dhclient.conf.5

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
freebsd-net@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-net
To unsubscribe, send any mail to "freebsd-net-unsubscr...@freebsd.org"


[Bug 206721] FreeBSDs DHCP client(dhclient) does not support the interface-mtu option(option 26).

2018-06-07 Thread bugzilla-noreply
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=206721

--- Comment #27 from commit-h...@freebsd.org ---
A commit references this bug:

Author: marius
Date: Thu Jun  7 15:51:24 UTC 2018
New revision: 334789
URL: https://svnweb.freebsd.org/changeset/base/334789

Log:
  MFC: r334443 (by cem@) MF stable/11: r334787

  dhclient(8): allow to supersede interface-mtu option

  In some cases broken DHCP servers might send invalid MTU value, so allow to
  use 'supersede' in dhclient.conf to override this. When superseded value is
  0, MTU value is not updated at all.

  PR:   206721
  Submitted by: novel@
  Reported by:  
  Approved by:  re (gjb)
  Relnotes: yes (potentially surprising behavior change w/ broken dhcpd
mtu)
  Differential Revision:https://reviews.freebsd.org/D15484

Changes:
_U  releng/11.2/
  releng/11.2/sbin/dhclient/dhclient.c
  releng/11.2/sbin/dhclient/dhclient.conf.5

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
freebsd-net@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-net
To unsubscribe, send any mail to "freebsd-net-unsubscr...@freebsd.org"


alignment of ai_addr in struct addrinfo

2018-06-07 Thread Rick Macklem
I have been doing "make universe" for the first time in a long time and
I ran into an interesting one.
I had code that looked like:
struct sockaddr_in *sin;
struct addrinfo *res;

- did a getaddrinfo() and then after this I had:
   ...
   sin = (struct sockaddr_in *)res->ai_addr;

For mips, it complained that the alignment requirement for "struct sockaddr_in"
is different than "struct sockaddr" related to the type cast.

I've worked around this by:
   struct sockaddr_in sin;
   ...
   memcpy(&sin, res->ai_addr, sizeof(sin));

Is this a real problem or a compiler quirk?

If it is real, it seems to me it would be nice if the alignment requirement for
"struct sockaddr" was the same as "struct sockaddr_in" and "struct 
sockaddr_in6".
Is there a "trick" that could be applied to "struct sockaddr" to force good 
alignment?

rick
___
freebsd-net@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-net
To unsubscribe, send any mail to "freebsd-net-unsubscr...@freebsd.org"


[Bug 228804] LACP synchronization flag set incorrectly in lacp_sm_rx_record_pdu() in sys/net/ieee8023ad_lacp.c

2018-06-07 Thread bugzilla-noreply
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=228804

Mark Linimon  changed:

   What|Removed |Added

   Assignee|b...@freebsd.org|n...@freebsd.org
Summary|LACP synchronization flag   |LACP synchronization flag
   |set incorrectly in  |set incorrectly in
   |lacp_sm_rx_record_pdu() |lacp_sm_rx_record_pdu() in
   ||sys/net/ieee8023ad_lacp.c

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
freebsd-net@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-net
To unsubscribe, send any mail to "freebsd-net-unsubscr...@freebsd.org"