[Bug 220860] Double loading of the if_bridge module causes panic
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=220860 --- Comment #6 from commit-h...@freebsd.org --- A commit references this bug: Author: kp Date: Thu Sep 21 14:14:01 UTC 2017 New revision: 323864 URL: https://svnweb.freebsd.org/changeset/base/323864 Log: bridge: Set module version This ensures that the loader will not load the module if it's also built in to the kernel. PR: 220860 Submitted by: Eugene Grosbein Reported by: Marie Helene Kvello-Aune Changes: head/sys/net/if_bridge.c -- You are receiving this mail because: You are the assignee for the bug. ___ freebsd-net@freebsd.org mailing list https://lists.freebsd.org/mailman/listinfo/freebsd-net To unsubscribe, send any mail to "freebsd-net-unsubscr...@freebsd.org"
[Bug 220860] Double loading of the if_bridge module causes panic
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=220860 --- Comment #7 from Marie Helene Kvello-Aune --- I should probably point out the error in the commit message as I didn't submit the PR. But I did discuss it with kp at length in June. ;) -- You are receiving this mail because: You are the assignee for the bug. ___ freebsd-net@freebsd.org mailing list https://lists.freebsd.org/mailman/listinfo/freebsd-net To unsubscribe, send any mail to "freebsd-net-unsubscr...@freebsd.org"
[Bug 220076] [patch] [panic] [netgraph] repeatable kernel panic due to a race in ng_iface(4)
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=220076 --- Comment #11 from commit-h...@freebsd.org --- A commit references this bug: Author: eugen Date: Thu Sep 21 20:16:11 UTC 2017 New revision: 323873 URL: https://svnweb.freebsd.org/changeset/base/323873 Log: Unprotected modification of ng_iface(4) private data leads to kernel panic. Fix a race with per-node read-mostly lock and refcounting for a hook. PR: 220076 Tested by:peixoto.cassiano Approved by: avg (mentor), mav (mentor) MFC after:1 week Relnotes: yes Differential Revision:https://reviews.freebsd.org/D12435 Changes: head/sys/netgraph/ng_iface.c -- You are receiving this mail because: You are on the CC list for the bug. ___ freebsd-net@freebsd.org mailing list https://lists.freebsd.org/mailman/listinfo/freebsd-net To unsubscribe, send any mail to "freebsd-net-unsubscr...@freebsd.org"
[Bug 220076] [patch] [panic] [netgraph] repeatable kernel panic due to a race in ng_iface(4)
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=220076 Eugene Grosbein changed: What|Removed |Added Status|Open|In Progress -- You are receiving this mail because: You are on the CC list for the bug. ___ freebsd-net@freebsd.org mailing list https://lists.freebsd.org/mailman/listinfo/freebsd-net To unsubscribe, send any mail to "freebsd-net-unsubscr...@freebsd.org"
Re: RSS_UDP_IPV4_EX?
I found the source of the IPV4_EX. I think it's from e1000 82575 header, which contains IPv4_EX. However, it's not related to extension header, it means IPv4 header w/ IP options; while RSS never takes any bits from IP optons. And these macros in e1000 82575 header are actually _not_ RSS related. On Sat, Sep 2, 2017 at 6:11 PM, Robert N. M. Watson wrote: > My recollection here is (quite) hazy, as it's been a while, but it's likely > that this was a transcription error. The set of hash types was largely > modelled on what Chelsio offered in the T3 (if I recall), and also what was > documented in the Microsoft RSS white paper, so it may be worth taking a > look at those sources to see if something makes itself obvious. > > (There do seem to be some odd variations in hashing types supported by > various NICs -- e.g., hashing but with different hash algorithms in certain > generations of cards, etc, so it also wouldn't surprise me if it did > correspond to something real. Clearly the comment is not good enough to > explain that, if so!) > > Robert > > On 2 Sep 2017, at 00:43, Adrian Chadd wrote: > > Hi, > > I seem to recall it was something some chipsets supported? I forget the > details. > > > > -adrian > > > On 30 August 2017 at 00:07, Sepherosa Ziehau wrote: >> >> IPv4 UDP with extended headers o_O? Or it was just a mistake. >> >> Thanks, >> sephe >> >> -- >> Tomorrow Will Never Die > > > -- Tomorrow Will Never Die ___ freebsd-net@freebsd.org mailing list https://lists.freebsd.org/mailman/listinfo/freebsd-net To unsubscribe, send any mail to "freebsd-net-unsubscr...@freebsd.org"
[Differential] D12453: mbuf: Remove UDP_IPV4_EX, which is never defined.
sepherosa_gmail.com created this revision. REVISION SUMMARY Add comment to explain the IPV6_EX suffix. The confusion about these RSS hash type probably stems from the facts that they were never widely implemented by hardwares. REVISION DETAIL https://reviews.freebsd.org/D12453 AFFECTED FILES sys/sys/mbuf.h EMAIL PREFERENCES https://reviews.freebsd.org/settings/panel/emailpreferences/ To: sepherosa_gmail.com, rwatson, adrian, gallatin, freebsd-net-list, glebius diff --git a/sys/sys/mbuf.h b/sys/sys/mbuf.h --- a/sys/sys/mbuf.h +++ b/sys/sys/mbuf.h @@ -335,6 +335,16 @@ * for ordering and distribution without explicit affinity. Additionally, * M_HASHTYPE_OPAQUE_HASH indicates that the flow identifier has hash * properties. + * + * The meaning of the IPV6_EX suffix: + * "o Home address from the home address option in the IPv6 destination + * options header. If the extension header is not present, use the Source + * IPv6 Address. + * o IPv6 address that is contained in the Routing-Header-Type-2 from the + * associated extension header. If the extension header is not present, + * use the Destination IPv6 Address." + * Quoted from: + * https://docs.microsoft.com/en-us/windows-hardware/drivers/network/rss-hashing-types#ndishashipv6ex */ #define M_HASHTYPE_HASHPROP 0x80 /* has hash properties */ #define M_HASHTYPE_HASH(t) (M_HASHTYPE_HASHPROP | (t)) @@ -348,14 +358,12 @@ * ext hdrs */ #define M_HASHTYPE_RSS_TCP_IPV6_EX M_HASHTYPE_HASH(6) /* TCPv6 4-tuple + * ext hdrs */ -/* Non-standard RSS hash types */ #define M_HASHTYPE_RSS_UDP_IPV4 M_HASHTYPE_HASH(7) /* IPv4 UDP 4-tuple*/ -#define M_HASHTYPE_RSS_UDP_IPV4_EX M_HASHTYPE_HASH(8) /* IPv4 UDP 4-tuple + - * ext hdrs */ #define M_HASHTYPE_RSS_UDP_IPV6 M_HASHTYPE_HASH(9) /* IPv6 UDP 4-tuple*/ #define M_HASHTYPE_RSS_UDP_IPV6_EX M_HASHTYPE_HASH(10)/* IPv6 UDP 4-tuple + * ext hdrs */ +/* Non-standard RSS hash types */ #define M_HASHTYPE_OPAQUE 63 /* ordering, not affinity */ #define M_HASHTYPE_OPAQUE_HASH M_HASHTYPE_HASH(M_HASHTYPE_OPAQUE) /* ordering+hash, not affinity*/ ___ freebsd-net@freebsd.org mailing list https://lists.freebsd.org/mailman/listinfo/freebsd-net To unsubscribe, send any mail to "freebsd-net-unsubscr...@freebsd.org"
[Differential] D12455: rss: Remove never defined UDP_IPV4_EX
sepherosa_gmail.com created this revision. Herald added a subscriber: ae. REVISION DETAIL https://reviews.freebsd.org/D12455 AFFECTED FILES sys/net/rss_config.c sys/net/rss_config.h CHANGE DETAILS diff --git a/sys/net/rss_config.h b/sys/net/rss_config.h --- a/sys/net/rss_config.h +++ b/sys/net/rss_config.h @@ -66,7 +66,6 @@ #defineRSS_HASHTYPE_RSS_IPV6_EX(1 << 5)/* IPv6 2-tuple + ext hdrs */ #defineRSS_HASHTYPE_RSS_TCP_IPV6_EX(1 << 6)/* TCPv6 4-tiple + ext hdrs */ #defineRSS_HASHTYPE_RSS_UDP_IPV4 (1 << 7)/* IPv4 UDP 4-tuple */ -#defineRSS_HASHTYPE_RSS_UDP_IPV4_EX(1 << 8)/* IPv4 UDP 4-tuple + ext hdrs */ #defineRSS_HASHTYPE_RSS_UDP_IPV6 (1 << 9)/* IPv6 UDP 4-tuple */ #defineRSS_HASHTYPE_RSS_UDP_IPV6_EX(1 << 10) /* IPv6 UDP 4-tuple + ext hdrs */ diff --git a/sys/net/rss_config.c b/sys/net/rss_config.c --- a/sys/net/rss_config.c +++ b/sys/net/rss_config.c @@ -489,7 +489,6 @@ |RSS_HASHTYPE_RSS_TCP_IPV6_EX #if 0 |RSS_HASHTYPE_RSS_UDP_IPV4 - |RSS_HASHTYPE_RSS_UDP_IPV4_EX |RSS_HASHTYPE_RSS_UDP_IPV6 |RSS_HASHTYPE_RSS_UDP_IPV6_EX #endif EMAIL PREFERENCES https://reviews.freebsd.org/settings/panel/emailpreferences/ To: sepherosa_gmail.com, adrian, rwatson, gallatin, freebsd-net-list Cc: ae diff --git a/sys/net/rss_config.h b/sys/net/rss_config.h --- a/sys/net/rss_config.h +++ b/sys/net/rss_config.h @@ -66,7 +66,6 @@ #define RSS_HASHTYPE_RSS_IPV6_EX (1 << 5) /* IPv6 2-tuple + ext hdrs */ #define RSS_HASHTYPE_RSS_TCP_IPV6_EX (1 << 6) /* TCPv6 4-tiple + ext hdrs */ #define RSS_HASHTYPE_RSS_UDP_IPV4 (1 << 7) /* IPv4 UDP 4-tuple */ -#define RSS_HASHTYPE_RSS_UDP_IPV4_EX (1 << 8) /* IPv4 UDP 4-tuple + ext hdrs */ #define RSS_HASHTYPE_RSS_UDP_IPV6 (1 << 9) /* IPv6 UDP 4-tuple */ #define RSS_HASHTYPE_RSS_UDP_IPV6_EX (1 << 10) /* IPv6 UDP 4-tuple + ext hdrs */ diff --git a/sys/net/rss_config.c b/sys/net/rss_config.c --- a/sys/net/rss_config.c +++ b/sys/net/rss_config.c @@ -489,7 +489,6 @@ |RSS_HASHTYPE_RSS_TCP_IPV6_EX #if 0 |RSS_HASHTYPE_RSS_UDP_IPV4 - |RSS_HASHTYPE_RSS_UDP_IPV4_EX |RSS_HASHTYPE_RSS_UDP_IPV6 |RSS_HASHTYPE_RSS_UDP_IPV6_EX #endif ___ freebsd-net@freebsd.org mailing list https://lists.freebsd.org/mailman/listinfo/freebsd-net To unsubscribe, send any mail to "freebsd-net-unsubscr...@freebsd.org"
