[Bug 202510] [CARP] advertisements sourced from CARP IP cause double MASTER situations
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=202510 --- Comment #5 from d...@my.gd --- (In reply to Palle Girgensohn from comment #4) Hello Palle, Ah there may have been a small misunderstanding here. My statement was more meant as a "the patch is made by a novice to RC and network.subr, likely needs review/consensus from devs". It didn't mean I was going to seek consensus -from the MLs for example- . I thought someone from net@ would take the ticket, review the patch and ensure it doesn't introduce any regression. -- You are receiving this mail because: You are the assignee for the bug. ___ freebsd-net@freebsd.org mailing list https://lists.freebsd.org/mailman/listinfo/freebsd-net To unsubscribe, send any mail to "freebsd-net-unsubscr...@freebsd.org"
[Bug 202510] [CARP] advertisements sourced from CARP IP cause double MASTER situations
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=202510 --- Comment #6 from Palle Girgensohn --- Ah, OK. Good. So, hopefully someone will nurture this patch then. Any takers? -- You are receiving this mail because: You are the assignee for the bug. ___ freebsd-net@freebsd.org mailing list https://lists.freebsd.org/mailman/listinfo/freebsd-net To unsubscribe, send any mail to "freebsd-net-unsubscr...@freebsd.org"
[Bug 202510] [CARP] advertisements sourced from CARP IP cause double MASTER situations
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=202510 Kubilay Kocak changed: What|Removed |Added Keywords||easy, needs-qa, patch Flags||mfc-stable9?, ||mfc-stable10?, ||mfc-stable11? Status|New |Open --- Comment #7 from Kubilay Kocak --- (In reply to dam from comment #3) Presumably testing shows that both syntaxes now result in the correct (expected) behaviour. Can you confirm? -- You are receiving this mail because: You are the assignee for the bug. ___ freebsd-net@freebsd.org mailing list https://lists.freebsd.org/mailman/listinfo/freebsd-net To unsubscribe, send any mail to "freebsd-net-unsubscr...@freebsd.org"
[Differential] D8685: Fix a false positive in a buf_ring assert
rstone added a subscriber: freebsd-net-list. REVISION DETAIL https://reviews.freebsd.org/D8685 EMAIL PREFERENCES https://reviews.freebsd.org/settings/panel/emailpreferences/ To: rstone Cc: freebsd-net-list, emaste ___ freebsd-net@freebsd.org mailing list https://lists.freebsd.org/mailman/listinfo/freebsd-net To unsubscribe, send any mail to "freebsd-net-unsubscr...@freebsd.org"
[Differential] D8685: Fix a false positive in a buf_ring assert
hselasky added inline comments.
INLINE COMMENTS
> buf_ring.h:71
> + if (br->br_cons_head != br->br_prod_head) {
> + for (i = br->br_cons_head + 1; i != br->br_prod_head;
> + i = ((i + 1) & br->br_cons_mask))
should "br->br_cons_head + 1" be masked by br->br_cons_mask ??
REVISION DETAIL
https://reviews.freebsd.org/D8685
EMAIL PREFERENCES
https://reviews.freebsd.org/settings/panel/emailpreferences/
To: rstone
Cc: hselasky, freebsd-net-list, emaste
___
freebsd-net@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-net
To unsubscribe, send any mail to "freebsd-net-unsubscr...@freebsd.org"
[Differential] D8685: Fix a false positive in a buf_ring assert
rstone updated this revision to Diff 22633.
rstone added a comment.
Ensure we don't walk off the end of the ring
CHANGES SINCE LAST UPDATE
https://reviews.freebsd.org/D8685?vs=22631&id=22633
REVISION DETAIL
https://reviews.freebsd.org/D8685
AFFECTED FILES
sys/sys/buf_ring.h
CHANGE DETAILS
diff --git a/sys/sys/buf_ring.h b/sys/sys/buf_ring.h
--- a/sys/sys/buf_ring.h
+++ b/sys/sys/buf_ring.h
@@ -67,11 +67,13 @@
uint32_t prod_head, prod_next, cons_tail;
#ifdef DEBUG_BUFRING
int i;
- for (i = br->br_cons_head; i != br->br_prod_head;
-i = ((i + 1) & br->br_cons_mask))
- if(br->br_ring[i] == buf)
- panic("buf=%p already enqueue at %d prod=%d cons=%d",
- buf, i, br->br_prod_tail, br->br_cons_tail);
+ if (br->br_cons_head != br->br_prod_head) {
+ for (i = (br->br_cons_head + 1) & br->br_cons_mask; i !=
br->br_prod_head;
+ i = ((i + 1) & br->br_cons_mask))
+ if(br->br_ring[i] == buf)
+ panic("buf=%p already enqueue at %d prod=%d
cons=%d",
+ buf, i, br->br_prod_tail, br->br_cons_tail);
+ }
#endif
critical_enter();
do {
EMAIL PREFERENCES
https://reviews.freebsd.org/settings/panel/emailpreferences/
To: rstone
Cc: hselasky, freebsd-net-list, emaste
diff --git a/sys/sys/buf_ring.h b/sys/sys/buf_ring.h
--- a/sys/sys/buf_ring.h
+++ b/sys/sys/buf_ring.h
@@ -67,11 +67,13 @@
uint32_t prod_head, prod_next, cons_tail;
#ifdef DEBUG_BUFRING
int i;
- for (i = br->br_cons_head; i != br->br_prod_head;
- i = ((i + 1) & br->br_cons_mask))
- if(br->br_ring[i] == buf)
- panic("buf=%p already enqueue at %d prod=%d cons=%d",
- buf, i, br->br_prod_tail, br->br_cons_tail);
+ if (br->br_cons_head != br->br_prod_head) {
+ for (i = (br->br_cons_head + 1) & br->br_cons_mask; i != br->br_prod_head;
+ i = ((i + 1) & br->br_cons_mask))
+ if(br->br_ring[i] == buf)
+panic("buf=%p already enqueue at %d prod=%d cons=%d",
+buf, i, br->br_prod_tail, br->br_cons_tail);
+ }
#endif
critical_enter();
do {
___
freebsd-net@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-net
To unsubscribe, send any mail to "freebsd-net-unsubscr...@freebsd.org"
[Differential] D8685: Fix a false positive in a buf_ring assert
rstone marked an inline comment as done. rstone added inline comments. INLINE COMMENTS > hselasky wrote in buf_ring.h:71 > should "br->br_cons_head + 1" be masked by br->br_cons_mask ?? Absolutely correct. Nice catch, thank you REVISION DETAIL https://reviews.freebsd.org/D8685 EMAIL PREFERENCES https://reviews.freebsd.org/settings/panel/emailpreferences/ To: rstone Cc: hselasky, freebsd-net-list, emaste ___ freebsd-net@freebsd.org mailing list https://lists.freebsd.org/mailman/listinfo/freebsd-net To unsubscribe, send any mail to "freebsd-net-unsubscr...@freebsd.org"
Get Alerts for Asia’s Largest Event for Project Cargo & Breakbulk Industry
Breakbulk China, Asia's largest exhibition and conference for the project cargo and breakbulk industry, 13-16 March in Shanghai. Email not displaying correctly? View it in your browser http://go.pardot.com/webmail/272542/109867/c9fea37a3d9c14526b3540841abac1402a07b1ab828bb5c50c8e9fbc93bc8d22. Logistics is complicated. Finding new business doesn't have to be. The movement of project cargo and breakbulk goods involves complex logistics, months and even years of planning and multi-million dollar contracts. Yours is a complicated job and in this tight economy, finding new business is a top priority. We can help. From 13-16 March 2017, Asia’s largest exhibition and conference for the project cargo and breakbulk industry will bring together 6,000 industry professionals, 200 exhibitors and more than 300 shippers at Breakbulk China in Shanghai. Hear from shippers, forwarders and specialized transport providers, as well as astute analysts, as they share their experiences and identify areas of opportunity for new business and development. With a full exhibition hall, you will be able to fill the 2 days with appointments that meet your business objectives. Find out more about exhibitors, sponsors, speakers and VIP Shippers. Sign Up for Alerts - http://go.pardot.com/e/272542/l-272542-2016-11-28-92b/d8x/109867 Facebook - http://go.pardot.com/e/272542/l-272542-2016-11-23-5z6/d8z/109867 Twitter - http://go.pardot.com/e/272542/l-272542-2016-11-23-5z8/d92/109867 LinkedIn - http://go.pardot.com/e/272542/l-272542-2016-11-23-5zb/d94/109867 YouTube - http://go.pardot.com/e/272542/l-272542-2016-11-23-5zd/d96/109867 SoundCloud - http://go.pardot.com/e/272542/l-272542-2016-11-23-5zg/d98/109867 Instagram - http://go.pardot.com/e/272542/l-272542-2016-11-23-5zj/d9b/109867 Copyright © 2016, all rights reserved. Our mailing address is: Breakbulk Events & Media 2 Penn Plaza 12th Floor Newark, NJ 07105 unsubscribe from all emails http://go.pardot.com/unsubscribe/u/272542/c9fea37a3d9c14526b3540841abac1402a07b1ab828bb5c50c8e9fbc93bc8d22/109867 ___ freebsd-net@freebsd.org mailing list https://lists.freebsd.org/mailman/listinfo/freebsd-net To unsubscribe, send any mail to "freebsd-net-unsubscr...@freebsd.org"
