Re: RFC: removing redundant checks in ether_input_internal()
On Wednesday, May 22, 2013 10:53:29 am Andre Oppermann wrote:
> On 22.05.2013 14:58, Luigi Rizzo wrote:
> > if_ethersubr.c :: ether_input_internal() is only called as follows:
> >
> > static void
> > ether_nh_input(struct mbuf *m)
> > {
> >
> > ether_input_internal(m->m_pkthdr.rcvif, m);
> > }
> >
> > hence the following checks in the body are unnecessary:
> >
> > if (m->m_pkthdr.rcvif == NULL) {
> > if_printf(ifp, "discard frame w/o interface pointer\n");
> > ifp->if_ierrors++;
> > m_freem(m);
> > return;
> > }
> > #ifdef DIAGNOSTIC
> > if (m->m_pkthdr.rcvif != ifp) {
> > if_printf(ifp, "Warning, frame marked as received on
%s\n",
> > m->m_pkthdr.rcvif->if_xname);
> > }
> > #endif
> >
> > Any objection if i remove them ?
>
> No, but they should remain as KASSERTs. None of these should trigger in
> production and all of them are an indication that something is very wrong
> with the packet or the caller.
Eh, but if the only caller is ether_nh_input() then by definition you know
that m->m_pkthdr.rcvif == ifp.
--
John Baldwin
___
freebsd-net@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-net
To unsubscribe, send any mail to "freebsd-net-unsubscr...@freebsd.org"
Re: Create pkey on FreeBSD 9.1
On Thursday, May 23, 2013 2:36:25 pm Ryan Stone wrote: > On Thu, May 23, 2013 at 4:32 AM, Alex Liptsin wrote: > > > Hello. > > > > I have FreeBSD 9.1 installed. > > There is mellanox adapter inside. > > OFED support is already installed. > > > > I try to add pkeys on ib0 port. > > > > Usually in Linux I did: > > > > echo 0x800c > /sys/class/net/ib0/create_child > > > > ifconfig -a > > To Make sure you see a new interface: ib0.800c > > > > How can I do it on FreeBSD? There is no "/sys/class/net/ib0/create_child" > > directory. > > > > Regards, > > Alex Liptsin > > > > ___ > > freebsd-net@freebsd.org mailing list > > http://lists.freebsd.org/mailman/listinfo/freebsd-net > > To unsubscribe, send any mail to "freebsd-net-unsubscr...@freebsd.org" > > > > From reading the source it looks like this is done by attaching a vlan > interface to the interface. So try: > > ifconfig vlan create vlandev ib0 vlan 0xc > > This will create a new vlanX interface (ifconfig will its precise name with > its unit number to stdout). Simpler though is just 'ifconfig ib0.12 create' (and how most folks expect subinterfaces to be named). -- John Baldwin ___ freebsd-net@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-net To unsubscribe, send any mail to "freebsd-net-unsubscr...@freebsd.org"
Re: How to switch Datgram/Connected mtu modes?
On Sunday, May 26, 2013 7:43:29 am Alex Liptsin wrote: > Hello. > > I work with FreeBSD 9.1 and Mellanox devices. > > How can I configure MTU in connected mode on FreeBSD 9.1? > In Linux to enable connected mode for interface ib0, I enter: > >echo connected > /sys/class/net/ib0/mode > > > > Switching between CM and UD mode can be done in run time: > >echo datagram > /sys/class/net/ib0/mode sets the mode of ib0 to UD > >echo connected > /sys/class/net/ib0/mode sets the mode ib0 to CM > > There is no such directories at FreeBSD. Wat shall I do? Have you tried looking for dev.ib.0 sysctls? It looks like the OFED bits in FreeBSD map Linux sysfs entries to sysctl nodes, but I don't have a box with IB handy to see what it looks like at runtime. -- John Baldwin ___ freebsd-net@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-net To unsubscribe, send any mail to "freebsd-net-unsubscr...@freebsd.org"
ixgbe driver with VLANs in 8.3
Hello, I am trying to install pfsense on Dell R620 with Intel X520 10Gb DP card. Default ixgbe driver (2.4.5 or 2.5.0) sporadically holds and buffers packets for 40-70 seconds. I compiled ixgbe driver version 2.5.8 from Intel web site. It works much better now, but does not receive anything on non-default VLAN. Though the packets are coming out and I can see them on another host. Any help is appreciated. Thank you, -- Ivan Gostev ___ freebsd-net@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-net To unsubscribe, send any mail to "freebsd-net-unsubscr...@freebsd.org"
Re: misc/179033: [dc] dc ethernet driver seems to have issues with some multiport card and mother board combinations
Synopsis: [dc] dc ethernet driver seems to have issues with some multiport card and mother board combinations State-Changed-From-To: open->feedback State-Changed-By: yongari State-Changed-When: Thu May 30 01:11:55 UTC 2013 State-Changed-Why: The information you gave looks confusing to me. If you're using pfSense on Atom D510MO and seeing the issue I'm afraid I'm not able to help that. pfSense may have some local changes and I'm not familiar with that. Did you try stock FreeBSD 9.1-RELEASE on Atom D510MO? If you still see the same issue with stock FreeBSD 9.1-REELASE, could you setup remote debugging environment mentioned in the following URL? http://people.freebsd.org/~yongari/remote_debugging.txt Given that dc(4) works fine with Dell machines I guess the issue may be in pci(4) which can't correctly handle device sits behind PCI-PCI bridge. Note, Holland Consulting's document does not apply to FreeBSD. dc(4) can handle multiple instances of dc(4) and should be able to support dual/quad port dc(4) controllers. Responsible-Changed-From-To: freebsd-net->yongari Responsible-Changed-By: yongari Responsible-Changed-When: Thu May 30 01:11:55 UTC 2013 Responsible-Changed-Why: Grab. http://www.freebsd.org/cgi/query-pr.cgi?pr=179033 ___ freebsd-net@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-net To unsubscribe, send any mail to "freebsd-net-unsubscr...@freebsd.org"
Re: misc/179033: [dc] dc ethernet driver seems to have issues with some multiport card and mother board combinations
Sorry for the confusion Pyun, I started looking at it in the context of pfsense, but they rejected my bug report which was understandable because it's an upstream issue. They suggested I resubmit it to you guys if I could reproduce it. So I booted FreeBSD and lo and behold the same two ports failed in exactly the same way. I didn't see the point in re-running all the tests because I was assuming that FreeBSD would work as well as pfsense for the ports that worked, and there were no further tests I could think of for the dead ports. This Atom board only has serial headers not a DB9 on the back, so I have to look for the proper back panel adapter for that. Otherwise I should be able to set up that test environment. Though it might take me a couple of days, sorry it's crunch time for me on a volunteer project. One which I would like to deploy routers like this on. :-) Thanks, Clif yong...@freebsd.org wrote: Synopsis: [dc] dc ethernet driver seems to have issues with some multiport card and mother board combinations State-Changed-From-To: open->feedback State-Changed-By: yongari State-Changed-When: Thu May 30 01:11:55 UTC 2013 State-Changed-Why: The information you gave looks confusing to me. If you're using pfSense on Atom D510MO and seeing the issue I'm afraid I'm not able to help that. pfSense may have some local changes and I'm not familiar with that. Did you try stock FreeBSD 9.1-RELEASE on Atom D510MO? If you still see the same issue with stock FreeBSD 9.1-REELASE, could you setup remote debugging environment mentioned in the following URL? http://people.freebsd.org/~yongari/remote_debugging.txt Given that dc(4) works fine with Dell machines I guess the issue may be in pci(4) which can't correctly handle device sits behind PCI-PCI bridge. Note, Holland Consulting's document does not apply to FreeBSD. dc(4) can handle multiple instances of dc(4) and should be able to support dual/quad port dc(4) controllers. Responsible-Changed-From-To: freebsd-net->yongari Responsible-Changed-By: yongari Responsible-Changed-When: Thu May 30 01:11:55 UTC 2013 Responsible-Changed-Why: Grab. http://www.freebsd.org/cgi/query-pr.cgi?pr=179033 ___ freebsd-net@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-net To unsubscribe, send any mail to "freebsd-net-unsubscr...@freebsd.org"
Re: misc/179033: [dc] dc ethernet driver seems to have issues with some multiport card and mother board combinations
On Wed, May 29, 2013 at 08:58:10PM -0700, Mr. Clif wrote: > Sorry for the confusion Pyun, > > I started looking at it in the context of pfsense, but they rejected my > bug report which was understandable because it's an upstream issue. They > suggested I resubmit it to you guys if I could reproduce it. So I booted > FreeBSD and lo and behold the same two ports failed in exactly the same Ok, I'd like to fix that. > way. I didn't see the point in re-running all the tests because I was > assuming that FreeBSD would work as well as pfsense for the ports that > worked, and there were no further tests I could think of for the dead ports. > There are too many different dc(4) controllers out there and each controller will require different hack to make it work. > This Atom board only has serial headers not a DB9 on the back, so I have > to look for the proper back panel adapter for that. Otherwise I should > be able to set up that test environment. Though it might take me a If you can't setup two systems, attach USB etherent controller to the box and let me know login information to the box. That wouldn't be enough configuration for remote debugging but probably I can experiment some basic things with your help. > couple of days, sorry it's crunch time for me on a volunteer project. > One which I would like to deploy routers like this on. :-) > > Thanks, > Clif > > yong...@freebsd.org wrote: > >Synopsis: [dc] dc ethernet driver seems to have issues with some multiport > >card and mother board combinations > > > >State-Changed-From-To: open->feedback > >State-Changed-By: yongari > >State-Changed-When: Thu May 30 01:11:55 UTC 2013 > >State-Changed-Why: > >The information you gave looks confusing to me. > >If you're using pfSense on Atom D510MO and seeing the issue I'm > >afraid I'm not able to help that. pfSense may have some local > >changes and I'm not familiar with that. > >Did you try stock FreeBSD 9.1-RELEASE on Atom D510MO? > >If you still see the same issue with stock FreeBSD 9.1-REELASE, > >could you setup remote debugging environment mentioned in the > >following URL? > >http://people.freebsd.org/~yongari/remote_debugging.txt > > > >Given that dc(4) works fine with Dell machines I guess the issue > >may be in pci(4) which can't correctly handle device sits behind > >PCI-PCI bridge. > > > >Note, Holland Consulting's document does not apply to FreeBSD. > >dc(4) can handle multiple instances of dc(4) and should be able to > >support dual/quad port dc(4) controllers. > > > > > >Responsible-Changed-From-To: freebsd-net->yongari > >Responsible-Changed-By: yongari > >Responsible-Changed-When: Thu May 30 01:11:55 UTC 2013 > >Responsible-Changed-Why: > >Grab. > > > >http://www.freebsd.org/cgi/query-pr.cgi?pr=179033 > ___ freebsd-net@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-net To unsubscribe, send any mail to "freebsd-net-unsubscr...@freebsd.org"
