Re: net.inet6.icmp6.nd6_useloopback - what is it supposed to do?

2012-11-25 Thread Hiroki Sato
Garrett Cooper  wrote
  in :

ya> Hi,
ya> I've been TAHI testing FreeBSD 7.x sources for the past couple
ya> months and over the course of my testing via the TAHI IPv6 conformance
ya> test, I changed the knob value from net.inet6.icmp6.nd6_useloopback=1
ya> -> net.inet6.icmp6.nd6_useloopback=0 and ran into a slew of errors
ya> with the addr.p2 phase-1 TAHI tests.
ya> I was wondering if someone could describe what the beforementioned
ya> sysctl is supposed to do from a functional perspective, how it might
ya> tie into other IPv6 RFCs (if applicable), and if disabled how it would
ya> affect a system with IPv6 enabled.

 It is for whether a loopback address (::1) is used as the destination
 for traffic toward one of the locally-configured IPv6 addresses.  In
 the original implementation it is in rtrequest(), but the current
 FreeBSD's one it just means if a loopback route will be installed or
 not upon the lo0 interface initialization, not in RTM_RESOLVE.  So,
 if setting nd6_useloopback to 0, no loopback route will be installed
 and some THAI test will fail, I think.

-- Hiroki


pgpgyi4VdowHF.pgp
Description: PGP signature


A small patch for sys/netinet6/in6_src.c

2012-11-25 Thread Vijay Singh
Really trivial change.

/u/vijay/bsd/CODE/cur# svn diff sys/netinet6/in6_src.c
Index: sys/netinet6/in6_src.c
===
--- sys/netinet6/in6_src.c  (revision 243309)
+++ sys/netinet6/in6_src.c  (working copy)
@@ -597,11 +597,6 @@
if (ron->ro_rt == NULL) {
in6_rtalloc(ron, fibnum); /* multi path case? */
if (ron->ro_rt == NULL) {
-   /* XXX-BZ WT.? */
-   if (ron->ro_rt) {
-   RTFREE(ron->ro_rt);
-   ron->ro_rt = NULL;
-   }
error = EHOSTUNREACH;
goto done;
}
___
freebsd-net@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-net
To unsubscribe, send any mail to "freebsd-net-unsubscr...@freebsd.org"


Re: LOR in rtsock/ifnet

2012-11-25 Thread Adrian Chadd
DO we know which commit triggered this?



Adrian


On 21 November 2012 16:31, Rui Paulo  wrote:
> I just started seeing this on r243286.
>
> lock order reversal:
>  1st 0xfe0001b40400 if_addr_lock (if_addr_lock) @ 
> /usr/home/rpaulo/freebsd/head/sys/net/rtsock.c:1818
>  2nd 0x80c693f8 ifnet_rw (ifnet_rw) @ 
> /usr/home/rpaulo/freebsd/head/sys/net/if.c:241
> KDB: stack backtrace:
> db_trace_self_wrapper() at db_trace_self_wrapper+0x2b
> kdb_backtrace() at kdb_backtrace+0x39
> witness_checkorder() at witness_checkorder+0xc37
> __rw_rlock() at __rw_rlock+0x8c
> ifnet_byindex() at ifnet_byindex+0x22
> sa6_recoverscope() at sa6_recoverscope+0x7b
> rt_msg2() at rt_msg2+0x1a2
> sysctl_rtsock() at sysctl_rtsock+0x68c
> sysctl_root() at sysctl_root+0x1d7
> userland_sysctl() at userland_sysctl+0x192
> sys___sysctl() at sys___sysctl+0x74
> amd64_syscall() at amd64_syscall+0x265
> Xfast_syscall() at Xfast_syscall+0xfb
> --- syscall (202, FreeBSD ELF64, sys___sysctl), rip = 0x8011813ea, rsp = 
> 0x7fffd408, rbp = 0x7fffd440 ---
>
> Regards,
> --
> Rui Paulo
>
> ___
> freebsd-net@freebsd.org mailing list
> http://lists.freebsd.org/mailman/listinfo/freebsd-net
> To unsubscribe, send any mail to "freebsd-net-unsubscr...@freebsd.org"
___
freebsd-net@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-net
To unsubscribe, send any mail to "freebsd-net-unsubscr...@freebsd.org"


Re: LOR in rtsock/ifnet

2012-11-25 Thread Rui Paulo
On 25 Nov 2012, at 23:35, Adrian Chadd  wrote:

> DO we know which commit triggered this?


I haven't bisected.

Regards,
--
Rui Paulo

___
freebsd-net@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-net
To unsubscribe, send any mail to "freebsd-net-unsubscr...@freebsd.org"


Re: LOR in rtsock/ifnet

2012-11-25 Thread Hiroki Sato
Rui Paulo  wrote
  in <63c19ad8-ea8d-49a8-9e98-4235c4745...@freebsd.org>:

rp> On 25 Nov 2012, at 23:35, Adrian Chadd  wrote:
rp>
rp> > DO we know which commit triggered this?
rp>
rp>
rp> I haven't bisected.

 I do not think my commit triggered it because it occurred in
 rt_msg2().  Andrey, can you take a look at this?

-- Hiroki


pgp4Ar9nzPqy3.pgp
Description: PGP signature