Re: kern/165863: [panic] [netinet] [patch] in_lltable_prefix_free() races with lla_lookup() and arptimer()

2012-08-03 Thread glebius
Synopsis: [panic] [netinet] [patch] in_lltable_prefix_free() races with 
lla_lookup() and arptimer()

State-Changed-From-To: open->patched
State-Changed-By: glebius
State-Changed-When: Fri Aug 3 08:01:48 UTC 2012
State-Changed-Why: 
Fix committed to head/.


Responsible-Changed-From-To: freebsd-net->glebius
Responsible-Changed-By: glebius
Responsible-Changed-When: Fri Aug 3 08:01:48 UTC 2012
Responsible-Changed-Why: 
Fix committed to head/.

http://www.freebsd.org/cgi/query-pr.cgi?pr=165863
___
freebsd-net@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-net
To unsubscribe, send any mail to "freebsd-net-unsubscr...@freebsd.org"


question in ixgbe_legacy_irq

2012-08-03 Thread Vijay Singh
Folks, the ixgbe_legacy_irq() interrupt handler kicks the taskqueue if
there is more rx or tx.


1440 if (more_rx || more_tx)
1441 taskqueue_enqueue(que->tq, &que->que_task);

But then it enables interrupts unconditionally:

1454
1455 ixgbe_enable_intr(adapter);

Is this correct?

-vijay
___
freebsd-net@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-net
To unsubscribe, send any mail to "freebsd-net-unsubscr...@freebsd.org"


Re: question in ixgbe_legacy_irq

2012-08-03 Thread Jack Vogel
No, that's probably wrong, but was not noticed because the legacy interrupt
path has been unused. The only time I've ever used it was during initial
development
and debug :)  I'm taking the day off, but I'll take a closer look at the
code shortly.

Jack


On Fri, Aug 3, 2012 at 9:19 AM, Vijay Singh  wrote:

> Folks, the ixgbe_legacy_irq() interrupt handler kicks the taskqueue if
> there is more rx or tx.
>
>
> 1440 if (more_rx || more_tx)
> 1441 taskqueue_enqueue(que->tq, &que->que_task);
>
> But then it enables interrupts unconditionally:
>
> 1454
> 1455 ixgbe_enable_intr(adapter);
>
> Is this correct?
>
> -vijay
> ___
> freebsd-net@freebsd.org mailing list
> http://lists.freebsd.org/mailman/listinfo/freebsd-net
> To unsubscribe, send any mail to "freebsd-net-unsubscr...@freebsd.org"
>
___
freebsd-net@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-net
To unsubscribe, send any mail to "freebsd-net-unsubscr...@freebsd.org"