[Bug 263979] [meta] UFS / FFS / GEOM crash (panic) tracking

2022-05-27 Thread bugzilla-noreply
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=263979

--- Comment #6 from commit-h...@freebsd.org ---
A commit in branch main references this bug:

URL:
https://cgit.FreeBSD.org/src/commit/?id=076002f24d35962f0d21f44bfddd34ee4d7f015d

commit 076002f24d35962f0d21f44bfddd34ee4d7f015d
Author: Kirk McKusick 
AuthorDate: 2022-05-27 19:21:11 +
Commit: Kirk McKusick 
CommitDate: 2022-05-27 19:22:07 +

Do comprehensive UFS/FFS superblock integrity checks when reading a
superblock.

Historically only minimal checks were made of a superblock when it
was read in as it was assumed that fsck would have been run to
correct any errors before attempting to use the filesystem. Recently
several bug reports have been submitted reporting kernel panics
that can be triggered by deliberately corrupting filesystem superblocks,
see Bug 263979 - [meta] UFS / FFS / GEOM crash (panic) tracking
which is tracking the reported corruption bugs.

This change upgrades the checks that are performed. These additional
checks should prevent panics from a corrupted superblock. Although
it appears in only one place, the new code will apply to the kernel
modules and (through libufs) user applications that read in superblocks.

Reported by:  Robert Morris and Neeraj
Reviewed by:  kib
Tested by:Peter Holm
PR:   263979
MFC after:1 month
Differential Revision: https://reviews.freebsd.org/D35219

 sys/ufs/ffs/ffs_subr.c | 163 +++--
 1 file changed, 146 insertions(+), 17 deletions(-)

-- 
You are receiving this mail because:
You are on the CC list for the bug.


[Bug 257557] geom(4): Garbage on disk (or USB memory stick) can cause GEOM taste ffs_sbget() to crash via g_label_ufs_taste_common: panic: vm_fault_lookup: fault on nofault entry, addr: 0xfffffe000940

2022-05-27 Thread bugzilla-noreply
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=257557

--- Comment #4 from Kirk McKusick  ---
Fixed by https://reviews.freebsd.org/D35219

Will close when MFC'ed to 13.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.