Re: Old bug in patch-src_VBox_Additions_freebsd_vboxvfs_vboxvfs__vfsops.c
I don’t know - the compiler only warned about the bzero :-) But you may be right - and the module never worked for me anyway... -- Sent from mobile device, please, pardon shorthand. > 23 черв. 2020 р. о 14:47 Martin Simmons пише: > > Is the memcpy wrong too? It looks like fsinfo.serial is a single uint32_t > (i.e. 32 bits), but mp->mnt_stat.f_fsid is a pair of int32_t (i.e. 64 bits), > so copying this pair from fsinfo.serial is wrong. > > __Martin > > >> On Mon, 22 Jun 2020 14:22:05 -0400, Mikhail T said: >> >> Gentlemen! >> >> An old bug in the patch is causing compiler-warnings, and leads to >> erroneous behavior where pointers are bigger than 32-bit. >> >> Moreover, given the memcpy right after it, the bzero is simply not >> needed at all. Instead of removing the bogus ampersand, the entire line >> should be deleted. (I would've replaced the memcpy with an assignment >> too, but that's not as pressing.) >> >> Can I commit this? >> >>Index: files/patch-src_VBox_Additions_freebsd_vboxvfs_vboxvfs__vfsops.c >>=== >>--- files/patch-src_VBox_Additions_freebsd_vboxvfs_vboxvfs__vfsops.c >>(revision 539883) >>+++ files/patch-src_VBox_Additions_freebsd_vboxvfs_vboxvfs__vfsops.c >>(working copy) >>@@ -11,7 +11,7 @@ >>* >>* This file is part of VirtualBox Open Source Edition (OSE), as >>* available from http://www.virtualbox.org. This file is free >>software; >>-@@ -14,245 +9,479 @@ >>+@@ -14,245 +9,478 @@ >>* VirtualBox OSE distribution. VirtualBox OSE is distributed in the >>* hope that it will be useful, but WITHOUT ANY WARRANTY of any kind. >>*/ >>@@ -466,7 +466,6 @@ >> + >> + MNT_ILOCK(mp); >> + mp->mnt_data = vboxfsmp; >>*-+ bzero(&mp->mnt_stat.f_fsid, sizeof(&mp->mnt_stat.f_fsid));* >> + /* f_fsid is int32_t but serial is uint32_t, convert */ >> + memcpy(&mp->mnt_stat.f_fsid, &fsinfo.serial, >>sizeof(mp->mnt_stat.f_fsid)); >> + mp->mnt_flag |= MNT_LOCAL; >> >> Thanks. Yours, >> >>-mi >> >> ___ >> freebsd-emulation@freebsd.org mailing list >> https://lists.freebsd.org/mailman/listinfo/freebsd-emulation >> To unsubscribe, send any mail to "freebsd-emulation-unsubscr...@freebsd.org" >> ___ freebsd-emulation@freebsd.org mailing list https://lists.freebsd.org/mailman/listinfo/freebsd-emulation To unsubscribe, send any mail to "freebsd-emulation-unsubscr...@freebsd.org"
[Bug 234878] emulators/virtualbox-ose: Update to 6.1
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=234878 --- Comment #96 from Mario Lobo --- I finally managed to get VBox into gdb. Starting program: /Vmachines/ports/emulators/virtualbox-ose.6110/work/VirtualBox-6.1.10/out/freebsd.amd64/debug/bin/VBoxHeadless --startvm Debian Oracle VM VirtualBox Headless Interface 6.1.10 (C) 2008-2020 Oracle Corporation All rights reserved. Type Manifest File: /root/.VirtualBox/xpti.dat [New LWP 101112 of process 13360] [New LWP 101131 of process 13360] [New LWP 101141 of process 13360] nsNativeComponentLoader: autoregistering begins. nsNativeComponentLoader: autoregistering succeeded nNCL: registering deferred (0) ^C Thread 2 received signal SIGINT, Interrupt. [Switching to LWP 101112 of process 13360] _umtx_op_err () at /usr/src/lib/libthr/arch/amd64/amd64/_umtx_op_err.S:40 40 RSYSCALL_ERR(_umtx_op) = Starting program: /Vmachines/ports/emulators/virtualbox-ose.6110/work/VirtualBox-6.1.10/out/freebsd.amd64/debug/bin/VBoxSDL --startvm Debian Oracle VM VirtualBox SDL GUI version 6.1.10 (C) 2005-2020 Oracle Corporation All rights reserved. Type Manifest File: /root/.VirtualBox/xpti.dat [New LWP 101168 of process 13409] [New LWP 101169 of process 13409] [New LWP 101173 of process 13409] nsNativeComponentLoader: autoregistering begins. nsNativeComponentLoader: autoregistering succeeded nNCL: registering deferred (0) ^C Thread 2 received signal SIGINT, Interrupt. [Switching to LWP 101168 of process 13409] _umtx_op_err () at /usr/src/lib/libthr/arch/amd64/amd64/_umtx_op_err.S:40 40 RSYSCALL_ERR(_umtx_op) = Starting program: /Vmachines/ports/emulators/virtualbox-ose.6110/work/VirtualBox-6.1.10/out/freebsd.amd64/debug/bin/VirtualBoxVM --startvm Debian [New LWP 101200 of process 13489] [New LWP 101201 of process 13489] ^C Thread 1 received signal SIGINT, Interrupt. _umtx_op_err () at /usr/src/lib/libthr/arch/amd64/amd64/_umtx_op_err.S:40 40 RSYSCALL_ERR(_umtx_op) They all get stuck on the same line. -- You are receiving this mail because: You are on the CC list for the bug. You are the assignee for the bug. ___ freebsd-emulation@freebsd.org mailing list https://lists.freebsd.org/mailman/listinfo/freebsd-emulation To unsubscribe, send any mail to "freebsd-emulation-unsubscr...@freebsd.org"
[Bug 234878] emulators/virtualbox-ose: Update to 6.1
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=234878 --- Comment #97 from Samy Mahmoudi --- (In reply to Mario Lobo from comment #96) > I finally managed to get VBox into gdb. How did you do so? -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ freebsd-emulation@freebsd.org mailing list https://lists.freebsd.org/mailman/listinfo/freebsd-emulation To unsubscribe, send any mail to "freebsd-emulation-unsubscr...@freebsd.org"
[Bug 234878] emulators/virtualbox-ose: Update to 6.1
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=234878 --- Comment #98 from Mario Lobo --- By compiling with the Debug option, and running the binaries directly from the port's work directory. I.E. gdb --args /usr/ports/emulators/virtualbox-ose/work/VirtualBox-6.1.10/out/freebsd.amd64/debug/bin/VBoxSDL --startvm Debian Doing this way, gdb finds the debug symbols and sources. -- You are receiving this mail because: You are on the CC list for the bug. You are the assignee for the bug. ___ freebsd-emulation@freebsd.org mailing list https://lists.freebsd.org/mailman/listinfo/freebsd-emulation To unsubscribe, send any mail to "freebsd-emulation-unsubscr...@freebsd.org"
[Bug 234878] emulators/virtualbox-ose: Update to 6.1
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=234878 --- Comment #99 from Samy Mahmoudi --- (In reply to Mario Lobo from comment #98) Thank you for the explanation Mario. -- You are receiving this mail because: You are on the CC list for the bug. You are the assignee for the bug. ___ freebsd-emulation@freebsd.org mailing list https://lists.freebsd.org/mailman/listinfo/freebsd-emulation To unsubscribe, send any mail to "freebsd-emulation-unsubscr...@freebsd.org"
