[Bug 247430] Linux ports install too much
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=247430 --- Comment #3 from Tijl Coosemans --- (In reply to Mikhail Teterin from comment #2) >> even for non-GPL code it may be wise to have our own copy of the source code > I don't understand this part at all. Might be wise _for whom_? Have _where_? Like I said: "you never know." It's not a bad idea to make sure we have access to the source (even if upstream disappears). For instance, it could be useful for debugging some problem. The SRPMs are available under http://distcache.freebsd.org/ports-distfiles/centos/. -- You are receiving this mail because: You are the assignee for the bug. ___ freebsd-emulation@freebsd.org mailing list https://lists.freebsd.org/mailman/listinfo/freebsd-emulation To unsubscribe, send any mail to "freebsd-emulation-unsubscr...@freebsd.org"
[Bug 234878] emulators/virtualbox-ose: Update to 6.1
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=234878 --- Comment #92 from Mikhail Teterin --- (In reply to Mario Lobo from comment #89) > we are lagging so far behind on the hosting side (ose and ose-kmod) that I > think people that are trying to upgrade it aren't even thinking about the > guest-additions port. We are, obviously, lagging on _both_ sides -- and the "not thinking" is mutual. Most people interested in -- and capable of -- upgrading one side, aren't using the other, and must rely on others for testing their changes. This leads to delays... Delays so high, people lose interest, and Oracle manages to make several releases in between -- obsoleting the original work. That the work is happening in little GitHub repos is not helping either :( This ticket is old, and has 90+ comments and lots of attachments -- our problem is not lack of interest or expertise, it is organizational. I'd like to expand my proposal (from comment #88) with this plan: 1. Leave the current virtualbox-* ports be (or upgrade them to the latest 5.x). 2. Repo-copy each virtualbox-foo to the ...foo6. 3. Disconnect the new virtualbox-ose-additions6 (guest) from the new virtualbox-ose6 (host) by: a) giving the guest its own files/ (for patches) and distinfo; b) moving the guest-only patches from the host's files/ into the guest's; c) enumerate the few -- if any -- patches necessary to both sides as EXTRAPATCHES in the guest -- or even just copy them over. 4. Assign the sides to different maintainers. If no one objects to these steps in principle -- and no one volunteers to do it -- I'll perform the copying/moving myself. I can also take up maintainership of the new virtualbox-ose-additions6, if there is no better candidate (my own usage is limited to a FreeBSD-11.x/i386 PAE guest inside a Windows 10 desktop). Based on one of the many attachments here, I can also upgrade the new hosting virtualbox-ose6 port (once), but I will not be able to test it beyond "it compiles". -- You are receiving this mail because: You are on the CC list for the bug. You are the assignee for the bug. ___ freebsd-emulation@freebsd.org mailing list https://lists.freebsd.org/mailman/listinfo/freebsd-emulation To unsubscribe, send any mail to "freebsd-emulation-unsubscr...@freebsd.org"
[Bug 234878] emulators/virtualbox-ose: Update to 6.1
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=234878 --- Comment #93 from Mario Lobo --- Would anyone know how to set up a debug build of the VBox port? -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ freebsd-emulation@freebsd.org mailing list https://lists.freebsd.org/mailman/listinfo/freebsd-emulation To unsubscribe, send any mail to "freebsd-emulation-unsubscr...@freebsd.org"
[Bug 234878] emulators/virtualbox-ose: Update to 6.1
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=234878 --- Comment #94 from Li-Wen Hsu --- (In reply to Mario Lobo from comment #93) There is a "DEBUG" option. I just checked my very old log (2016), need to check if when this option enabled, it still correctly passes BUILD_TYPE=debug to LocalConfig.kmk file. -- You are receiving this mail because: You are on the CC list for the bug. You are the assignee for the bug. ___ freebsd-emulation@freebsd.org mailing list https://lists.freebsd.org/mailman/listinfo/freebsd-emulation To unsubscribe, send any mail to "freebsd-emulation-unsubscr...@freebsd.org"
Re: Old bug in patch-src_VBox_Additions_freebsd_vboxvfs_vboxvfs__vfsops.c
Is the memcpy wrong too? It looks like fsinfo.serial is a single uint32_t (i.e. 32 bits), but mp->mnt_stat.f_fsid is a pair of int32_t (i.e. 64 bits), so copying this pair from fsinfo.serial is wrong. __Martin > On Mon, 22 Jun 2020 14:22:05 -0400, Mikhail T said: > > Gentlemen! > > An old bug in the patch is causing compiler-warnings, and leads to > erroneous behavior where pointers are bigger than 32-bit. > > Moreover, given the memcpy right after it, the bzero is simply not > needed at all. Instead of removing the bogus ampersand, the entire line > should be deleted. (I would've replaced the memcpy with an assignment > too, but that's not as pressing.) > > Can I commit this? > > Index: files/patch-src_VBox_Additions_freebsd_vboxvfs_vboxvfs__vfsops.c > === > --- files/patch-src_VBox_Additions_freebsd_vboxvfs_vboxvfs__vfsops.c > (revision 539883) > +++ files/patch-src_VBox_Additions_freebsd_vboxvfs_vboxvfs__vfsops.c > (working copy) > @@ -11,7 +11,7 @@ > * > * This file is part of VirtualBox Open Source Edition (OSE), as > * available from http://www.virtualbox.org. This file is free > software; > -@@ -14,245 +9,479 @@ > +@@ -14,245 +9,478 @@ > * VirtualBox OSE distribution. VirtualBox OSE is distributed in the > * hope that it will be useful, but WITHOUT ANY WARRANTY of any kind. > */ > @@ -466,7 +466,6 @@ > + > + MNT_ILOCK(mp); > + mp->mnt_data = vboxfsmp; > *-+ bzero(&mp->mnt_stat.f_fsid, sizeof(&mp->mnt_stat.f_fsid));* > + /* f_fsid is int32_t but serial is uint32_t, convert */ > + memcpy(&mp->mnt_stat.f_fsid, &fsinfo.serial, > sizeof(mp->mnt_stat.f_fsid)); > + mp->mnt_flag |= MNT_LOCAL; > > Thanks. Yours, > > -mi > > ___ > freebsd-emulation@freebsd.org mailing list > https://lists.freebsd.org/mailman/listinfo/freebsd-emulation > To unsubscribe, send any mail to "freebsd-emulation-unsubscr...@freebsd.org" > ___ freebsd-emulation@freebsd.org mailing list https://lists.freebsd.org/mailman/listinfo/freebsd-emulation To unsubscribe, send any mail to "freebsd-emulation-unsubscr...@freebsd.org"
[Bug 234878] emulators/virtualbox-ose: Update to 6.1
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=234878 --- Comment #95 from Mario Lobo --- Marking the Debug option does not produce debug symbols for any of the VBox executables. -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ freebsd-emulation@freebsd.org mailing list https://lists.freebsd.org/mailman/listinfo/freebsd-emulation To unsubscribe, send any mail to "freebsd-emulation-unsubscr...@freebsd.org"
