[Bug 275914] www/webkit2-gtk{3,4}: Flavorize?: Deal with 4.0, 4.1 and 6.0 SONAMEs

2024-08-23 Thread bugzilla-noreply
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=275914

--- Comment #40 from Nuno Teixeira  ---
(In reply to shamaz.mazum from comment #36)

I have patched devel/llvm16. Results from llvm 16 and 18 are the same:

% clang++18 check.cc
% ./a.out
std::pair copy constructor is non-trivial

% rm a.out
% clang++16 check.cc
% ./a.out
std::pair copy constructor is non-trivial

Patch used:
(devel/llvm16/files/patch-libcxx_include_config)

--- libcxx/include/__config.orig2024-08-23 10:54:26 UTC
+++ libcxx/include/__config
@@ -162,9 +162,9 @@
 #endif
 // Feature macros for disabling pre ABI v1 features. All of these options
 // are deprecated.
-#if defined(__FreeBSD__)
-#  define _LIBCPP_DEPRECATED_ABI_DISABLE_PAIR_TRIVIAL_COPY_CTOR
-#endif
+//#if defined(__FreeBSD__)
+//#  define _LIBCPP_DEPRECATED_ABI_DISABLE_PAIR_TRIVIAL_COPY_CTOR
+//#endif
 #  endif

 #  if defined(_LIBCPP_BUILDING_LIBRARY) || _LIBCPP_ABI_VERSION >= 2

-- 
You are receiving this mail because:
You are the assignee for the bug.


[Bug 275914] www/webkit2-gtk{3,4}: Flavorize?: Deal with 4.0, 4.1 and 6.0 SONAMEs

2024-08-23 Thread bugzilla-noreply
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=275914

--- Comment #41 from shamaz.ma...@gmail.com ---
(In reply to Nuno Teixeira from comment #40)

I have no idea. Today i've upgraded to FreeBSD 14.1, so this is what I have now
with that patch applied to the base:

vasily@vonbraun:~/test % c++ --version
FreeBSD clang version 18.1.5 (https://github.com/llvm/llvm-project.git
llvmorg-18.1.5-0-g617a15a9eac9)
Target: x86_64-unknown-freebsd14.1
Thread model: posix
InstalledDir: /usr/bin
vasily@vonbraun:~/test % c++ -o test test.cpp
vasily@vonbraun:~/test % ./test
std::pair copy constructor is trivial

and to the port:

vasily@vonbraun:~/test % clang++15 --version
clang version 15.0.7
Target: x86_64-portbld-freebsd14.0
Thread model: posix
InstalledDir: /usr/local/llvm15/bin
vasily@vonbraun:~/test % clang++15 -o test test.cpp
vasily@vonbraun:~/test % ./test
std::pair copy constructor is trivial

I don't know how it's even possible that it works for me and not for you.

-- 
You are receiving this mail because:
You are the assignee for the bug.


[Bug 275914] www/webkit2-gtk{3,4}: Flavorize?: Deal with 4.0, 4.1 and 6.0 SONAMEs

2024-08-23 Thread bugzilla-noreply
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=275914

--- Comment #42 from shamaz.ma...@gmail.com ---
(In reply to Nuno Teixeira from comment #40)

I hate to ask, but can you apply this patch to the base, as it's recommended in
my instruction. I mean, apply this patch in /usr/src, build the world with
`make buildworld` and install it to a separate jail. Then try to compile and
run that program in that jail.

May be a waste of time, but who knows, maybe it will work this way.

-- 
You are receiving this mail because:
You are the assignee for the bug.


[Bug 275914] www/webkit2-gtk{3,4}: Flavorize?: Deal with 4.0, 4.1 and 6.0 SONAMEs

2024-08-23 Thread bugzilla-noreply
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=275914

--- Comment #43 from shamaz.ma...@gmail.com ---
(In reply to Nuno Teixeira from comment #40)

Wait! LLVM from ports does not install the headers. It uses
/usr/include/c++/v1/__utility/pair.h for #include . Please, patch the
base (you can install the world to a jail then). Then it will work.

As you can see, my patch cannot be applied only to a port :(

-- 
You are receiving this mail because:
You are the assignee for the bug.


[Bug 275914] www/webkit2-gtk{3,4}: Flavorize?: Deal with 4.0, 4.1 and 6.0 SONAMEs

2024-08-23 Thread bugzilla-noreply
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=275914

--- Comment #44 from Nuno Teixeira  ---
(In reply to shamaz.mazum from comment #42)

It seems that patching llvm from ports isn't enough. Patching base compiler is
a exccessive measure that will be dificult to test.

As I said in this PR when I've found you patched tree, is that this is a proof
that your workaround works. Now we need to get expert opinion on this matter on
why it is fixed by it.

A better solution should be found that not implies patching base or ports
compilers.

-- 
You are receiving this mail because:
You are the assignee for the bug.


[Bug 275914] www/webkit2-gtk{3,4}: Flavorize?: Deal with 4.0, 4.1 and 6.0 SONAMEs

2024-08-23 Thread bugzilla-noreply
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=275914

--- Comment #45 from shamaz.ma...@gmail.com ---
(In reply to Nuno Teixeira from comment #44)

Yes, you are right. This is more like a solution for one person, namely me, as
removing those lines from LLVM will lead to a standard library binary
incompatible with previously built C++ programs. It will make an upgrade a
painful experience.

Unfortunately, I know no other option. Just if somebody desperately needs
webkit, he will know what to do ;) And like we have not enough promblems,
WebKit developers have broken WebGL support in the most recent version (it now
requires that DMABUF shit) ;)

-- 
You are receiving this mail because:
You are the assignee for the bug.