netinet compile broken

2000-08-01 Thread James Johnson

sys/netinet/ip_fil.c appears to be busted. Trying to recompile kernel
modules breaks as follows:

===> ipfilter


cc -O -pipe -DIPFILTER=1 -DIPFILTER_LKM -DIPFILTER_LOG  -D_KERNEL -Wall -Wre
dundant-decls -Wnested-externs -Wstrict-prototypes  -Wmissing-prototypes -Wp
ointer-arith -Winline -Wcast-qual  -fformat-extensions -ansi -DKLD_MODULE -n
ostdinc -I-  -I. -I@ -I@/../include  -mpreferred-stack-boundary=2 -c
/usr/src/sys/modules/ipfilter/../../netinet/ip_fil.c
/usr/src/sys/modules/ipfilter/../../netinet/ip_fil.c: In function
`iplattach':
/usr/src/sys/modules/ipfilter/../../netinet/ip_fil.c:272: too few arguments
to function `pfil_add_hook'
/usr/src/sys/modules/ipfilter/../../netinet/ip_fil.c: In function
`ipldetach':
/usr/src/sys/modules/ipfilter/../../netinet/ip_fil.c:384: too few arguments
to function `pfil_remove_hook'
*** Error code 1

Looks like two else statements were commented out. This simple diff fixes it

--- ip_fil.cTue Aug  1 00:04:24 2000
+++ ip_fil.bak  Tue Aug  1 03:18:08 2000
@@ -268,7 +268,7 @@
return error;
 #   endif
}
-#  else
+  else
pfil_add_hook((void *)fr_check, PFIL_IN|PFIL_OUT);
 #  endif
 #  ifdef USE_INET6
@@ -380,7 +380,7 @@
 &inetsw[ip_protox[IPPROTO_IP]].pr_pfh);
if (error)
return error;
-#  else
+ else
pfil_remove_hook((void *)fr_check, PFIL_IN|PFIL_OUT);
 #  endif
 #  ifdef USE_INET6





To Unsubscribe: send mail to [EMAIL PROTECTED]
with "unsubscribe freebsd-current" in the body of the message



break in usr.bin/kdump

2000-08-26 Thread James Johnson

Hello,

I've been tracking -CURRENT for a while.. Whenever I attempt to build the
world I get the following break:

# make buildworld



===> usr.bin/kdump

cc -O -pipe -I/usr/src/usr.bin/kdump/../ktrace -I/usr/src/usr.bin/kdump/../.
.   -I/usr/obj/usr/src/i386/usr/include -c  /usr/src/usr.bin/kdump/kdump.c
sh /usr/src/usr.bin/kdump/mkioctls /usr/obj/usr/src/i386/usr/include >
ioctl.c
In file included from :67:
/usr/obj/usr/src/i386/usr/include/sys/memrange.h:18: warning: `MDF_ACTIVE'
redefined
/usr/obj/usr/src/i386/usr/include/pccard/cardinfo.h:80: warning: this is
the location of the previous definition

cc -O -pipe -I/usr/src/usr.bin/kdump/../ktrace -I/usr/src/usr.bin/kdump/../.
.   -I/usr/obj/usr/src/i386/usr/include -c ioctl.c
In file included from ioctl.c:97:
/usr/obj/usr/src/i386/usr/include/sys/memrange.h:18: warning: `MDF_ACTIVE'
redefined
/usr/obj/usr/src/i386/usr/include/pccard/cardinfo.h:80: warning: this is
the location of the previous definition
In file included from ioctl.c:37:
/usr/obj/usr/src/i386/usr/include/dev/usb/rio500_usb.h:35: redefinition of
`struct RioCommand'
*** Error code 1

Stop in /usr/src/usr.bin/kdump.
*** Error code 1

#

I do own one of the rio500 devices and have installed the rio500 audio
package in the past (have since cleaned it..) I usually just comment out
struct RioCommand from include/dev/usb/rio500_usb.h this goes away, feeling
this was a common break but since it has been reoccuring I feel that I
should mention it. Anyone have ideas to figure out why this is occuring on
only this box?

Thanks
--
James







To Unsubscribe: send mail to [EMAIL PROTECTED]
with "unsubscribe freebsd-current" in the body of the message



Installkernel

2000-08-27 Thread James Johnson

Just a little usability observation(or I am too lazy to script_my_own_tools
and want to whine!)

The method of building and installing a kernel to me seems a bit off.. Both
the buildworld and installworld targets default to GENERIC, yet GENERIC is a
file checked into the -CURRENT CVS repository.. Any changes to this file
will get blown away if whenever you update the sources unless you explicity
exclude this file. No one I know runs BSD with a GENERIC kernel, they have
specific requirements for the hardware in their machines. Having to specify
which kernel to build with the KERNEL= parameter seems to indicate that
people should be running GENERIC kernels all the time as it is the default.
This just doesnt seem right.

I know a script could easily be written to grab a filename out of something
like /boot/loader.conf to get which kernel config file you want to use by
default.. Are there any plans to change this or is this method final?







To Unsubscribe: send mail to [EMAIL PROTECTED]
with "unsubscribe freebsd-current" in the body of the message



Questions about PRE_SMPNG (Was PRE_SMPNG snap)

2000-09-16 Thread James Johnson

Can someone explain why we have a PRE_SMPNG tag? Sure there may be some
issues with SMP in -CURRENT right now, however simply avoiding running the
code is not going to get those issues fixed.

-Original Message-
From: [EMAIL PROTECTED]
[mailto:[EMAIL PROTECTED]]On Behalf Of Brandon D.
Valentine
Sent: Saturday, September 16, 2000 10:04 AM
To: [EMAIL PROTECTED]
Subject: PRE_SMPNG snap


I would like to request that someone with access to
ftp://current.freebsd.org build a snapshot release based entirely on the
PRE_SMPNG CVS branch so those of us wishing to install current will have
a better starting point.  The snaps currently being built come directly
from HEAD and hence are ridden with the instability inherent in current
at the moment.  It would be nice if there was one snap built directly
from the branch point and put in
ftp://current.freebsd.org/pub/FreeBSD/snapshots/i386/PRE_SMPNG or
something to that effect.

Brandon D. Valentine
--
bandix at looksharp.net  |  bandix at structbio.vanderbilt.edu
"Truth suffers from too much analysis." -- Ancient Fremen Saying



To Unsubscribe: send mail to [EMAIL PROTECTED]
with "unsubscribe freebsd-current" in the body of the message




To Unsubscribe: send mail to [EMAIL PROTECTED]
with "unsubscribe freebsd-current" in the body of the message