Re: ipv6_ipfilter_rules= is obsolete ?
On Thu, 9 Jul 2020 10:27:02 +0800 Marcelo Araujo wrote: > Em qui., 9 de jul. de 2020 __s 07:34, Rodney W. Grimes < > freebsd-...@gndrsh.dnsmgr.net> escreveu: > > > > In /etc/defaults/rc.conf I see this > > > > > > ipv6_ipfilter_rules="/etc/ipf6.rules" > > > # rules definition file for ipfilter, > > > # see /usr/src/contrib/ipfilter/rules for examples > > > > > > man 8 ipf says > > > > > > ipf -6 ipv4 and ipv6 rules are stored in a single table and can be read > > > from a single file. This option is no longer required to load ipv6 rules. > > > > > > I interrupt this to mean that the ipv6_ipfilter_rules="/etc/ipf6.rules" > > >line in /etc/defaults/rc.conf is obsolete and should be removed > > > before RELEASE 13.0 is published for users to use. > > > > Interesting, though I would not remove it. It should be marked as > > depricated and the /etc/rc.d/ipfilter shell script updated to emit > > a warning that it is depricated, but it should still be processed > > to retain backwards compatibility and NOT lock someone out of a > > system who has just done an upgrade to a newer version. > > > > Do you mean deprecated or depricated? > Got confused here! Sorry English is hard for non-native speakers. > It's a typo - he meant deprecated. -- Gary Jennejohn ___ freebsd-current@freebsd.org mailing list https://lists.freebsd.org/mailman/listinfo/freebsd-current To unsubscribe, send any mail to "freebsd-current-unsubscr...@freebsd.org"
Re: SVN r363032 - portmaster|portupgrade now fails
Reverting SVN r363031 works around it,
imb
On 7/8/20 8:42 PM, Manfred Antar wrote:
> Same error here, Even trying to build a port fails:
> (src)5023}cd /usr/ports/shells/bash
> (bash)5024}make
> make: "/usr/ports/Mk/bsd.port.mk" line 2096: warning: String comparison
> operator should be either == or !=
> make: "/usr/ports/Mk/bsd.port.mk" line 2096: Malformed conditional
> (defined(MAKE_JOBS_NUMBER_LIMIT) && ( ${MAKE_JOBS_NUMBER_LIMIT} <
> ${_MAKE_JOBS_NUMBER} ))
> make: Fatal errors encountered -- cannot continue
> make: stopped in /usr/ports/shells/bash
> (bash)5025}
>
>> On Jul 8, 2020, at 5:33 PM, Michael Butler
>> wrote:
>>
>> Did the bmake update break the updating of ports or something else?
>>
>> # sudo -E portmaster -a
>> ===>>> Gathering distinfo list for installed ports
>>
>> ===>>> Starting check of installed ports for available updates
>> make: "/usr/ports/Mk/Uses/python.mk" line 384: warning: String
>> comparison operator should be either == or !=
>> make: "/usr/ports/Mk/Uses/python.mk" line 384: Malformed conditional
>> (!(!empty(_PYTHON_VERSION_MINIMUM) && ( ${__VER} <
>> ${_PYTHON_VERSION_MINIMUM})) && !(!empty(_PYTHON_VERSION_MAXIMUM) && (
>> ${__VER} > ${_PYTHON_VERSION_MAXIMUM})))
___
freebsd-current@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-current
To unsubscribe, send any mail to "freebsd-current-unsubscr...@freebsd.org"
Re: svn commit: r363031 - in head: contrib/bmake contrib/bmake/lst.lib contrib/bmake/mk contrib/bmake/mk/sys contrib/bmake/unit-tests usr.bin/bmake (make now broken)
Mark Millard wrote:
> [External Email. Be cautious of content]
>
>
> This seems to have broken doing buildworld buildkernel and
> other things using make:
Ouch sorry I saw this at one point but couldn't reproduce while trying
to work out what it was complaining about.
The line numbers did/do not appear correct.
Will revert if I cannot work it out.
>
> make[2]: "/usr/src/share/mk/bsd.compiler.mk" line 197: warning: String
> comparison operator should be either == or !=
> make[2]: "/usr/src/share/mk/bsd.compiler.mk" line 197: warning: String
> comparison operator should be either == or !=
> . . .
> make[3]: "/usr/src/share/mk/bsd.sys.mk" line 100: warning: String comparison
> operator should be either == or !=
> . . .
> make[3]: "/usr/src/share/mk/bsd.sys.mk" line 81: warning: String comparison
> operator should be either == or !=
> . . .
>
> Using -d c shows the likes of:
>
> . . .
> lhs = "clang", rhs = "clang", op = ==
> lhs = "${${:UCOMPILER_TYPE}__${${:U${_empty_var_}}_cc_hash}}", rhs = "gcc",
> op = ==
> make[2]: "/usr/src/share/mk/bsd.compiler.mk" line 197: warning: String
> comparison operator should be either == or !=
> lhs = "clang", rhs = "clang", op = ==
> lhs = "LD", rhs = "LD", op = ==
> . . .
> left = 6.00, right = 2.00, op = <=
> left = 6.00, right = 1.00, op = <=
> lhs = "${${:UCOMPILER_TYPE}__${${:U${_empty_var_}}_cc_hash}}", rhs = "clang",
> op = ==
> make[3]: "/usr/src/share/mk/bsd.sys.mk" line 100: warning: String comparison
> operator should be either == or !=
> lhs = "${${:UCOMPILER_TYPE}__${${:U${_empty_var_}}_cc_hash}}", rhs = "gcc",
> op = ==
> lhs = "clang", rhs = "gcc", op = ==
> . . .
> left = 0.00, right = 6.00, op = <=
> left = 0.00, right = 3.00, op = <=
> lhs = "clang", rhs = "gcc", op = ==
> make[3]: "/usr/src/share/mk/bsd.sys.mk" line 81: warning: String comparison
> operator should be either == or !=
> lhs = "clang", rhs = "clang", op = ==
> left = 11.00, right = 7.00, op = >=
> lhs = "amd64", rhs = "arm", op = ==
>
> (Now I just need to figure out how to get back to a working context.)
>
> ===
> Mark Millard
> marklmi at yahoo.com
> ( dsl-only.net went
> away in early 2018-Mar)
___
freebsd-current@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-current
To unsubscribe, send any mail to "freebsd-current-unsubscr...@freebsd.org"
Re: svn commit: r363031 - in head: contrib/bmake contrib/bmake/lst.lib contrib/bmake/mk contrib/bmake/mk/sys contrib/bmake/unit-tests usr.bin/bmake (make now broken)
On 2020-Jul-8, at 20:35, Yuri Pankov wrote:
> Mark Millard wrote:
>> This seems to have broken doing buildworld buildkernel and
>> other things using make:
>> make[2]: "/usr/src/share/mk/bsd.compiler.mk" line 197: warning: String
>> comparison operator should be either == or !=
>> make[2]: "/usr/src/share/mk/bsd.compiler.mk" line 197: warning: String
>> comparison operator should be either == or !=
>> . . .
>> make[3]: "/usr/src/share/mk/bsd.sys.mk" line 100: warning: String comparison
>> operator should be either == or !=
>> . . .
>> make[3]: "/usr/src/share/mk/bsd.sys.mk" line 81: warning: String comparison
>> operator should be either == or !=
>> . . .
>> Using -d c shows the likes of:
>> . . .
>> lhs = "clang", rhs = "clang", op = ==
>> lhs = "${${:UCOMPILER_TYPE}__${${:U${_empty_var_}}_cc_hash}}", rhs = "gcc",
>> op = ==
>> make[2]: "/usr/src/share/mk/bsd.compiler.mk" line 197: warning: String
>> comparison operator should be either == or !=
>> lhs = "clang", rhs = "clang", op = ==
>> lhs = "LD", rhs = "LD", op = ==
>> . . .
>> left = 6.00, right = 2.00, op = <=
>> left = 6.00, right = 1.00, op = <=
>> lhs = "${${:UCOMPILER_TYPE}__${${:U${_empty_var_}}_cc_hash}}", rhs =
>> "clang", op = ==
>> make[3]: "/usr/src/share/mk/bsd.sys.mk" line 100: warning: String comparison
>> operator should be either == or !=
>> lhs = "${${:UCOMPILER_TYPE}__${${:U${_empty_var_}}_cc_hash}}", rhs = "gcc",
>> op = ==
>> lhs = "clang", rhs = "gcc", op = ==
>> . . .
>> left = 0.00, right = 6.00, op = <=
>> left = 0.00, right = 3.00, op = <=
>> lhs = "clang", rhs = "gcc", op = ==
>> make[3]: "/usr/src/share/mk/bsd.sys.mk" line 81: warning: String comparison
>> operator should be either == or !=
>> lhs = "clang", rhs = "clang", op = ==
>> left = 11.00, right = 7.00, op = >=
>> lhs = "amd64", rhs = "arm", op = ==
>> (Now I just need to figure out how to get back to a working context.)
>
> For me, buildworld/buildkernel produced only warnings,
But, looking at the code in bmake, the expression is also
evaluated differently/incorrectly when it is classified as
having the problem of having a incorrect operator. In other
words: the behavior in make changes via misevaluated
expressions.
> though the one in ports is real issue:
>
> $ make config
> make: "/usr/ports/Mk/bsd.port.mk" line 2096: warning: String comparison
> operator should be either == or !=
> make: "/usr/ports/Mk/bsd.port.mk" line 2096: Malformed conditional
> (defined(MAKE_JOBS_NUMBER_LIMIT) && ( ${MAKE_JOBS_NUMBER_LIMIT} <
> ${_MAKE_JOBS_NUMBER} ))
> make: Fatal errors encountered -- cannot continue
> make: stopped in /usr/ports/devel/subversion
Not the only "real issue", I'm afraid.
===
Mark Millard
marklmi at yahoo.com
( dsl-only.net went
away in early 2018-Mar)
___
freebsd-current@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-current
To unsubscribe, send any mail to "freebsd-current-unsubscr...@freebsd.org"
Re: ipv6_ipfilter_rules= is obsolete ?
Gary Jennejohn wrote: On Thu, 9 Jul 2020 10:27:02 +0800 Marcelo Araujo wrote: Em qui., 9 de jul. de 2020 __s 07:34, Rodney W. Grimes < freebsd-...@gndrsh.dnsmgr.net> escreveu: In /etc/defaults/rc.conf I see this ipv6_ipfilter_rules="/etc/ipf6.rules" # rules definition file for ipfilter, # see /usr/src/contrib/ipfilter/rules for examples man 8 ipf says ipf -6 ipv4 and ipv6 rules are stored in a single table and can be read from a single file. This option is no longer required to load ipv6 rules. I interrupt this to mean that the ipv6_ipfilter_rules="/etc/ipf6.rules" line in /etc/defaults/rc.conf is obsolete and should be removed before RELEASE 13.0 is published for users to use. Interesting, though I would not remove it. It should be marked as depricated and the /etc/rc.d/ipfilter shell script updated to emit a warning that it is depricated, but it should still be processed to retain backwards compatibility and NOT lock someone out of a system who has just done an upgrade to a newer version. Do you mean deprecated or depricated? Got confused here! Sorry English is hard for non-native speakers. It's a typo - he meant deprecated. This "retain backwards compatibility stuff" can be taken too far backwards. I think ipfilter first can out with NO ipv6 support, then ipv6 was added using 2 rule files, and later yet it was redesigned to use a single rules file. Talking about way back around RELEASE 4.0. Now ipfilter does not work with 2 rules files for a very long time. It's now time to clean up the old ipv6 only stuff so the documentation and /etc/rc.d/ipfilter boot script reflects how it works today. And another thing to point out is the ipfilter source code has been forked and is now under Freebsd maintainership. ___ freebsd-current@freebsd.org mailing list https://lists.freebsd.org/mailman/listinfo/freebsd-current To unsubscribe, send any mail to "freebsd-current-unsubscr...@freebsd.org"
Re: ipv6_ipfilter_rules= is obsolete ?
Gary Jennejohn wrote: On Thu, 9 Jul 2020 10:27:02 +0800 Marcelo Araujo wrote: Em qui., 9 de jul. de 2020 __s 07:34, Rodney W. Grimes < freebsd-...@gndrsh.dnsmgr.net> escreveu: In /etc/defaults/rc.conf I see this ipv6_ipfilter_rules="/etc/ipf6.rules" # rules definition file for ipfilter, # see /usr/src/contrib/ipfilter/rules for examples man 8 ipf says ipf -6 ipv4 and ipv6 rules are stored in a single table and can be read from a single file. This option is no longer required to load ipv6 rules. I interrupt this to mean that the ipv6_ipfilter_rules="/etc/ipf6.rules" line in /etc/defaults/rc.conf is obsolete and should be removed before RELEASE 13.0 is published for users to use. Interesting, though I would not remove it. It should be marked as depricated and the /etc/rc.d/ipfilter shell script updated to emit a warning that it is depricated, but it should still be processed to retain backwards compatibility and NOT lock someone out of a system who has just done an upgrade to a newer version. Do you mean deprecated or depricated? Got confused here! Sorry English is hard for non-native speakers. It's a typo - he meant deprecated. This "retain backwards compatibility stuff" can be taken too far backwards. I think ipfilter first can out with NO ipv6 support, then ipv6 was added using 2 rule files, and later yet it was redesigned to use a single rules file. Talking about way back around RELEASE 4.0. Now ipfilter does not work with 2 rules files for a very long time. It's now time to clean up the old ipv6 only stuff so the documentation and /etc/rc.d/ipfilter boot script reflects how it works today. And another thing to point out is the ipfilter source code has been forked and is now under Freebsd maintainership. ___ freebsd-current@freebsd.org mailing list https://lists.freebsd.org/mailman/listinfo/freebsd-current To unsubscribe, send any mail to "freebsd-current-unsubscr...@freebsd.org"
Re: svn commit: r363031 - in head: contrib/bmake contrib/bmake/lst.lib contrib/bmake/mk contrib/bmake/mk/sys contrib/bmake/unit-tests usr.bin/bmake (make now broken)
Mark Millard wrote:
> > though the one in ports is real issue:
> >
> > $ make config
> > make: "/usr/ports/Mk/bsd.port.mk" line 2096: warning: String comparison
> > operator should be either == or !=
> > make: "/usr/ports/Mk/bsd.port.mk" line 2096: Malformed conditional
> > (defined(MAKE_JOBS_NUMBER_LIMIT) && ( ${MAKE_JOBS_NUMBER_LIMIT} <
> > ${_MAKE_JOBS_NUMBER} ))
The above should be equivalent to
V42 = 42
.if defined(V69) && ( ${V69} < ${V42} )
.endif
which in a unit-test works just fine.
Same goes for the warnings in bsd.compiler.mk ;-(
___
freebsd-current@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-current
To unsubscribe, send any mail to "freebsd-current-unsubscr...@freebsd.org"
