[Bug 279308] mdmfs does not work as documented

2024-10-03 Thread bugzilla-noreply
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=279308

--- Comment #17 from Michael Proto  ---
Thank you Kirk and Colin for squashing this, it is much appreciated here!

-- 
You are receiving this mail because:
You are the assignee for the bug.


[Bug 281740] [stand/cd9660] Paths including "." or ".." are not resolved (w/LOADER_VERIEXEC)

2024-10-03 Thread bugzilla-noreply
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=281740

--- Comment #2 from Simon J. Gerraty  ---
I guess there could be an issue specific to cd9660, it certainly works with
ufs:

verify_prep:
caller=pfopen,fd=2,name='/packages/sets/active/boot/os-crypto/loader.conf',off=0,dev=363234709,ino=310
is_verified: dev=363234709,ino=310,status=-42
looking for /packages/sets/active/boot/os-crypto/manifest
looking for /packages/sets/active/boot/os-crypto/../manifest
is_verified: dev=363234709,ino=303,status=-42
verify_signed: /packages/sets/active/boot/os-crypto/../manifest.esig
verify_sig: /packages/sets/active/boot/os-crypto/../manifest.esig
verify_signer: 5 certs in chain
verify_signer: 1 trust anchors
Verified /packages/sets/active/boot/os-crypto/../manifest signed by
PackageDevelopmentECP256_2024
inserted 36 /packages/sets/active/boot/os-crypto before 20 /boot/loader-support
add_verify_status: dev=363234709,ino=303,status=1
loaded: /packages/sets/active/boot/os-crypto/../manifest
/packages/sets/active/boot/os-crypto boot
looking for /packages/sets/active/boot/os-crypto 36 loader.conf
at 36 /packages/sets/active/boot/os-crypto
checking prefix=/packages/sets/active/boot/os-crypto
lookup: 'boot/loader.conf'
found boot/loader.conf
sha256=f196bb30c5418c074f2ef87c1179eac8abf3298e7b5b5e7ebdd1ee
add_verify_status: dev=363234709,ino=310,status=1


that's with VE_DEBUG_LEVEL=5 fwiw

-- 
You are receiving this mail because:
You are the assignee for the bug.


[Bug 281740] [stand/cd9660] Paths including "." or ".." are not resolved (w/LOADER_VERIEXEC)

2024-10-03 Thread bugzilla-noreply
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=281740

--- Comment #3 from Simon J. Gerraty  ---
cd9660 handling of ".." looks funky - would not be at all surprised if it does
not work

cd9660_stat() will certainly need work for LOADER_VERIEXEC to work.
Like most *_stat() calls in libsa it only poulates the absolute mininum of
struct stat
which is not enough for LOADER_VERIEXEC
If you look at ufs_stat() you can see I added setting of st_dev, st_ino and
st_mtime

So as is, I would not expect cd9660 to work.

-- 
You are receiving this mail because:
You are the assignee for the bug.


[Bug 281740] [stand/cd9660] Paths including "." or ".." are not resolved (w/LOADER_VERIEXEC)

2024-10-03 Thread bugzilla-noreply
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=281740

Ed Maste  changed:

   What|Removed |Added

Summary|[stand/cd9660] Paths|[stand/cd9660] Paths
   |including "." or ".." are   |including "." or ".." are
   |not resolved|not resolved
   ||(w/LOADER_VERIEXEC)

-- 
You are receiving this mail because:
You are the assignee for the bug.


[Bug 201052] [sctp] capsicum: propagate rights on sctp_peeloff

2024-10-03 Thread bugzilla-noreply
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=201052

Mark Linimon  changed:

   What|Removed |Added

 CC|bugmeis...@freebsd.org  |

--- Comment #11 from Mark Linimon  ---
^Triage: feedback received.  Apparently this bug is still relevant.

-- 
You are receiving this mail because:
You are the assignee for the bug.


[Bug 223470] freebsd-update: Cannot identify running kernel (/boot removed from jails)

2024-10-03 Thread bugzilla-noreply
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=223470

--- Comment #11 from Dan Langille  ---
FWIW, I have seen it recently (i.e. on 14.1).

-- 
You are receiving this mail because:
You are the assignee for the bug.


[Bug 201052] [sctp] capsicum: propagate rights on sctp_peeloff

2024-10-03 Thread bugzilla-noreply
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=201052

--- Comment #9 from Ed Maste  ---
The change should be similar to the one for accept(), i.e.
https://github.com/freebsd/freebsd-src/commit/85b0f9de11c3988f53f899cd171b685037da03a8

getsock_cap gained a new arg `struct filecaps *havecapsp` which is not used in
most cases but in kern_accept4() we pass fcaps to get the existing
capabilities, and then pass that to falloc_caps to obtain the new fd.

I think the diff would look like:

diff --git a/sys/netinet/sctp_syscalls.c b/sys/netinet/sctp_syscalls.c
index d67e260b6f99..1bd6f2707d5d 100644
--- a/sys/netinet/sctp_syscalls.c
+++ b/sys/netinet/sctp_syscalls.c
@@ -141,13 +141,14 @@ sys_sctp_peeloff(struct thread *td, struct
sctp_peeloff_args *uap)
 {
struct file *headfp, *nfp = NULL;
struct socket *head, *so;
+   struct filecaps fcaps;
cap_rights_t rights;
u_int fflag;
int error, fd;

AUDIT_ARG_FD(uap->sd);
-   error = getsock(td, uap->sd, cap_rights_init_one(&rights, CAP_PEELOFF),
-   &headfp);
+   error = getsock_cap(td, uap->sd,
+   cap_rights_init_one(&rights, CAP_PEELOFF), &headfp, NULL, &fcaps);
if (error != 0)
goto done2;
fflag = atomic_load_int(&headfp->f_flag);
@@ -165,7 +166,7 @@ sys_sctp_peeloff(struct thread *td, struct
sctp_peeloff_args *uap)
 * but that is ok.
 */

-   error = falloc(td, &nfp, &fd, 0);
+   error = falloc_cap(td, &nfp, &fd, 0, &fcaps);
if (error != 0)
goto done;
td->td_retval[0] = fd;

-- 
You are receiving this mail because:
You are the assignee for the bug.


[Bug 201052] [sctp] capsicum: propagate rights on sctp_peeloff

2024-10-03 Thread bugzilla-noreply
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=201052

--- Comment #10 from Ed Maste  ---
(In reply to Ed Maste from comment #9)
I've put this change in https://reviews.freebsd.org/D46884. It's not yet even
build-tested. When I have time I'll see if we can add/modify capsicum-test
tests to cover this.

-- 
You are receiving this mail because:
You are the assignee for the bug.


[Bug 201788] UEFI boot1.efi doesn't honor GPT bootme/bootonce flags

2024-10-03 Thread bugzilla-noreply
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=201788

--- Comment #6 from hol...@freyther.de ---
The code seems to have moved into stand/efi/boot1 and does not seem to have
bootme/bootonce support.

-- 
You are receiving this mail because:
You are the assignee for the bug.


[Bug 202362] ntp: restore refclocks selection (10.2-RELEASE regression)

2024-10-03 Thread bugzilla-noreply
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=202362

Christian Weisgerber  changed:

   What|Removed |Added

 Status|New |Closed
 Resolution|--- |FIXED

--- Comment #2 from Christian Weisgerber  ---
Fixed by

  commit 9bf168600cd727a3f6594a6201a1e85bb0aa6221
  Author: Cy Schubert 
  Date:   Fri Sep 4 16:59:01 2015 +

Turn on RAWDCF by default.

-- 
You are receiving this mail because:
You are the assignee for the bug.


[Bug 262301] [ctl] Cannot "kldunload ctl"

2024-10-03 Thread bugzilla-noreply
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=262301

--- Comment #4 from Zhenlei Huang  ---
(In reply to BB Lister from comment #3)
> $ kldstat
> Id Refs AddressSize Name
> 152 0x83243cf88 ctl.ko
> 161 0x8327d000 7528 cfiscsi.ko
> 171 0x83285000 f24c iscsi.ko

The `kldstat` shows clearly that ctl.ko has extra dependants ( see the Refs
column) . It probably would be `cfiscsi.ko` or `iscsi.ko`.

So you may want to unload iscsi.ko and / or cfiscsi.ko modules firstly, and
then the turn of ctl.ko .

-- 
You are receiving this mail because:
You are the assignee for the bug.


[Bug 262301] [ctl] Cannot "kldunload ctl"

2024-10-03 Thread bugzilla-noreply
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=262301

--- Comment #5 from Alan Somers  ---
Unloading cfiscsi first works _if_ ctld shut down cleanly.  What originally
tripped me up was the case where ctld did not shut down cleanly, leaving iSCSI
targets configured in the kernel.  In that case, the iscsi and cfiscsi kernel
modules cannot be unloaded.

Eventually I discovered an undocumented command that can manually remove iSCSI
ports.  It looks like this:

ctladm port -d iscsi -r -p DONTCARE -O cfiscsi_portal_group_tag=TAG -O
cfiscsi_target=TARGET

On FreeBSD 15+, the "-p DONTCARE" option can be omitted.  The TAG is what's
displayed on the "pp" column of "ctladm portlist", and the TARGET is displayed
on the last column (but leave out any part after the comma, like ",t,0x0101".

-- 
You are receiving this mail because:
You are the assignee for the bug.


[Bug 279308] mdmfs does not work as documented

2024-10-03 Thread bugzilla-noreply
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=279308

--- Comment #13 from commit-h...@freebsd.org ---
A commit in branch main references this bug:

URL:
https://cgit.FreeBSD.org/src/commit/?id=5b21d4ad060acb06c72e0458daebec9bcbf0cefd

commit 5b21d4ad060acb06c72e0458daebec9bcbf0cefd
Author: Kirk McKusick 
AuthorDate: 2024-10-03 15:05:42 +
Commit: Kirk McKusick 
CommitDate: 2024-10-03 15:06:28 +

Ensure that soft updates are not enabled by default when using mdmfs(8)

When soft updates began being enabled by default that change carried
over to mdmfs(8) which does not want or need them. This fix ensures
that they are only enabled in mdmfs(8) when requested with the -U flag.

Reported by: Ivan Rozhuk
Tested by:   Ivan Rozhuk
PR:  279308
MFC after:   1 week

 include/paths.h| 3 +++
 sbin/mdmfs/mdmfs.c | 9 -
 2 files changed, 11 insertions(+), 1 deletion(-)

-- 
You are receiving this mail because:
You are the assignee for the bug.


[Bug 279308] mdmfs does not work as documented

2024-10-03 Thread bugzilla-noreply
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=279308

Kirk McKusick  changed:

   What|Removed |Added

 Status|New |In Progress

--- Comment #14 from Kirk McKusick  ---
(In reply to Colin Percival from comment #8)
Now committed. Sorry for the delay. I am on a river-boat on the Nile with
really minimal Internet connectivity. Will MFC to 14 in a week.

-- 
You are receiving this mail because:
You are the assignee for the bug.


[Bug 279308] mdmfs does not work as documented

2024-10-03 Thread bugzilla-noreply
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=279308

--- Comment #15 from Kirk McKusick  ---
(In reply to Ivan Rozhuk from comment #9)
This bug report is about not enabling soft-updates by default. If you want to
have a discussion about adding TRIM by default that should be in a new
phabricator review or a new bug report.

-- 
You are receiving this mail because:
You are the assignee for the bug.


[Bug 279308] mdmfs does not work as documented

2024-10-03 Thread bugzilla-noreply
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=279308

--- Comment #16 from Colin Percival  ---
(In reply to Kirk McKusick from comment #14)
Thanks!  Yeah I knew you were AFK so I wasn't too worried about the delay.

-- 
You are receiving this mail because:
You are the assignee for the bug.


[Bug 281828] gets_s(3) manpage needs to mention about __STDC_WANT_LIB_EXT1__

2024-10-03 Thread bugzilla-noreply
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=281828

Graham Percival  changed:

   What|Removed |Added

 CC||gperc...@tarsnap.com

--- Comment #1 from Graham Percival  ---
To be pedantic, the gets_s prototype was hidden in  when it was first
introduced:
 
https://github.com/freebsd/freebsd-src/commit/c13559d31e90a8c405771be36ab9ccfa41d4ebd6#diff-5e1f2789f2dc0618ffb77ce98c2fab185eaedd0897a0326180f0fb4db794e0b3R273

The "un-hiding" was in , which was introduced much later, in
  https://reviews.freebsd.org/D45679

So the missing mention of __STDC_WANT_LIB_EXT1__ in the man page was a problem
since 2018-04-03, not a new problem on 2024-10-02.

-- 
You are receiving this mail because:
You are the assignee for the bug.


[Bug 212608] sockstat(1) and lsof(8) can not identity the owner of listening UDP ports when it is the kernel

2024-10-03 Thread bugzilla-noreply
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=212608

Mark Linimon  changed:

   What|Removed |Added

 CC||bugmeis...@freebsd.org
  Flags|mfc-stable12?,  |
   |mfc-stable11?   |

--- Comment #7 from Mark Linimon  ---
^Triage: clear stale flags.

To submitter: is this aging PR still relevant?

-- 
You are receiving this mail because:
You are the assignee for the bug.


[Bug 233578] Unprivileged local user can prevent other users logging in by locking utx.active

2024-10-03 Thread bugzilla-noreply
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=233578

Mark Linimon  changed:

   What|Removed |Added

   Keywords|patch   |
  Flags|mfc-stable12?,  |
   |mfc-stable11?   |

-- 
You are receiving this mail because:
You are the assignee for the bug.


[Bug 231810] [build] release always fails with "mkimg: partition 2: No space left on device"

2024-10-03 Thread bugzilla-noreply
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=231810

Mark Linimon  changed:

   What|Removed |Added

 CC||bugmeis...@freebsd.org
  Flags|mfc-stable11?   |

--- Comment #14 from Mark Linimon  ---
^Triage: clear stale flags.

To submitter: is this aging PR still relevant?

-- 
You are receiving this mail because:
You are the assignee for the bug.


[Bug 237287] moused(8) ignores button release events in virtual scroll mode

2024-10-03 Thread bugzilla-noreply
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=237287

Mark Linimon  changed:

   What|Removed |Added

  Flags|mfc-stable12?,  |
   |mfc-stable11?   |

--- Comment #2 from Mark Linimon  ---
^Triage: clear stale flags.

-- 
You are receiving this mail because:
You are the assignee for the bug.


[Bug 230620] "install -d" issue

2024-10-03 Thread bugzilla-noreply
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=230620

Mark Linimon  changed:

   What|Removed |Added

 CC|i...@freebsd.org |bugmeis...@freebsd.org
  Flags|mfc-stable11?   |

--- Comment #4 from Mark Linimon  ---
^Triage: clear stale flags.

To submitter: is this aging PR still relevant?

-- 
You are receiving this mail because:
You are the assignee for the bug.


[Bug 221305] Mouse cursor loss when moving cursor while loading Dtrace modules

2024-10-03 Thread bugzilla-noreply
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=221305

Mark Linimon  changed:

   What|Removed |Added

  Flags|mfc-stable11?   |
   Keywords|patch   |
 CC||bugmeis...@freebsd.org

--- Comment #1 from Mark Linimon  ---
^Triage: clear stale flags.

To submitter: is this aging PR still relevant?

-- 
You are receiving this mail because:
You are the assignee for the bug.


[Bug 201052] [sctp] capsicum: propagate rights on sctp_peeloff

2024-10-03 Thread bugzilla-noreply
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=201052

--- Comment #8 from Michael Tuexen  ---
(In reply to Mark Linimon from comment #7)
I guess so. Unfortunately, I have no knowledge about capsicum.

-- 
You are receiving this mail because:
You are the assignee for the bug.


[Bug 46441] sh(1): Does not support PS1, PS2, PS4 parameter expansion

2024-10-03 Thread bugzilla-noreply
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=46441

Mark Linimon  changed:

   What|Removed |Added

  Flags|mfc-stable12?   |

--- Comment #16 from Mark Linimon  ---
^Triage: clear stale flags.

-- 
You are receiving this mail because:
You are the assignee for the bug.


[Bug 262764] After DVD1 13.0-R install with ports tree, portsnap auto doesn't remove old directories for renamed ports

2024-10-03 Thread bugzilla-noreply
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=262764

Mark Linimon  changed:

   What|Removed |Added

 Status|New |Closed
 Resolution|--- |Overcome By Events
   Assignee|b...@freebsd.org|lini...@freebsd.org

--- Comment #2 from Mark Linimon  ---
^Triage: close as OBE.

portsnap is being deprecated; see
https://forums.freebsd.org/threads/portsnap.93608/

-- 
You are receiving this mail because:
You are the assignee for the bug.


[Bug 281825] SDT tracepoints are not cleaned up when a module is unloaded

2024-10-03 Thread bugzilla-noreply
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=281825

--- Comment #1 from John Baldwin  ---
This seems to reproduce the original panic reported to me:

kldload nvmft
kldload dtraceall
kldunload nvmft
kldload ctl
kldload nvmft

Fatal trap 12: page fault while in kernel mode
cpuid = 11; apic id = 0b
fault virtual address   = 0x8281d078
fault code  = supervisor write data, protection violation
instruction pointer = 0x20:0x828f4761
stack pointer   = 0x28:0xfe00dc30b8f0
frame pointer   = 0x28:0xfe00dc30ba80
code segment= base 0x0, limit 0xf, type 0x1b
= DPL 0, pres 1, long 1, def32 0, gran 1
processor eflags= interrupt enabled, resume, IOPL = 0
current process = 1084 (kldload)
rdi: 8285e70e rsi: 8285ed86 rdx: 
rcx: 8281d078  r8: 0004  r9: 
rax: 82865018 rbx: 82865000 rbp: fe00dc30ba80
r10: 0001 r11: 0001 r12: f80008085c00
r13: f8013dd2a220 r14: f8003cee6628 r15: f80003f37000
trap number = 12
panic: page fault
cpuid = 11
time = 1727978657
KDB: stack backtrace:
db_trace_self_wrapper() at db_trace_self_wrapper+0x2b/frame 0xfe00dc30b5c0
vpanic() at vpanic+0x13f/frame 0xfe00dc30b6f0
panic() at panic+0x43/frame 0xfe00dc30b750
trap_fatal() at trap_fatal+0x40b/frame 0xfe00dc30b7b0
trap_pfault() at trap_pfault+0xa0/frame 0xfe00dc30b820
calltrap() at calltrap+0x8/frame 0xfe00dc30b820
--- trap 0xc, rip = 0x828f4761, rsp = 0xfe00dc30b8f0, rbp =
0xfe00dc30ba80 ---
sdt_kld_load_probes() at sdt_kld_load_probes+0x3c1/frame 0xfe00dc30ba80
linker_load_module() at linker_load_module+0xe90/frame 0xfe00dc30bd80
kern_kldload() at kern_kldload+0x16e/frame 0xfe00dc30bdd0
sys_kldload() at sys_kldload+0x5c/frame 0xfe00dc30be00
amd64_syscall() at amd64_syscall+0x158/frame 0xfe00dc30bf30
fast_syscall_common() at fast_syscall_common+0xf8/frame 0xfe00dc30bf30
--- syscall (304, FreeBSD ELF64, kldload), rip = 0x1085b13898da, rsp =
0x1085aeefe008, rbp = 0x1085aeefe580 ---

-- 
You are receiving this mail because:
You are the assignee for the bug.


[Bug 281653] [PATCH] manuals: Fix "skipping end of block" syntax errors

2024-10-03 Thread bugzilla-noreply
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=281653

Graham Percival  changed:

   What|Removed |Added

 Status|New |Closed
 Resolution|--- |FIXED

--- Comment #1 from Graham Percival  ---
Merged in 4f2ef756a404df70272b79c16fa7b1689cb0118b.

-- 
You are receiving this mail because:
You are the assignee for the bug.


[Bug 281825] SDT tracepoints are not cleaned up when a module is unloaded

2024-10-03 Thread bugzilla-noreply
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=281825

John Baldwin  changed:

   What|Removed |Added

   Assignee|b...@freebsd.org|j...@freebsd.org
 Status|New |Open
URL||https://reviews.freebsd.org
   ||/D46890

--- Comment #2 from John Baldwin  ---
Patch at review fixes both panics for me.

-- 
You are receiving this mail because:
You are the assignee for the bug.


[Bug 281654] [PATCH] stats.3: Fix "skipping end of block" syntax errors

2024-10-03 Thread bugzilla-noreply
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=281654

Graham Percival  changed:

   What|Removed |Added

 Status|New |Closed
 Resolution|--- |FIXED

--- Comment #1 from Graham Percival  ---
Merged in 2d69f02c5745a89c01bcd76389d53fd2a4189f02.

-- 
You are receiving this mail because:
You are the assignee for the bug.


[Bug 281621] [PATCH] manuals: Fix typos in -offset for .Bd and .Bl

2024-10-03 Thread bugzilla-noreply
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=281621

Graham Percival  changed:

   What|Removed |Added

 Resolution|--- |FIXED
 Status|In Progress |Closed

--- Comment #1 from Graham Percival  ---
Merged in c013ca2cf772194de340aeb452a6ccfe7e1cecd8.

-- 
You are receiving this mail because:
You are the assignee for the bug.