[Bug 281155] [PATCH] mfi: Correct a struct member name
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=281155 WHR changed: What|Removed |Added Attachment #253202|0 |1 is obsolete|| --- Comment #1 from WHR --- Created attachment 253210 --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=253210&action=edit proposed fix -- You are receiving this mail because: You are the assignee for the bug.
[Bug 281153] [PATCH] mfiutil: Fix malformed error messages in 'ctrlprop rebuild' and 'ctrlprop alarm' subcommands
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=281153 WHR changed: What|Removed |Added URL||https://sourceforge.net/p/m ||fiutil/code/ci/f2f111f10173 ||57052ef0c17ea216dede13329bb ||2/ -- You are receiving this mail because: You are the assignee for the bug.
[Bug 281177] 13.2 works, 13.3 and 14.x installers panic on older qlogic isp card
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=281177 Bug ID: 281177 Summary: 13.2 works, 13.3 and 14.x installers panic on older qlogic isp card Product: Base System Version: 13.3-RELEASE Hardware: amd64 OS: Any Status: New Severity: Affects Some People Priority: --- Component: kern Assignee: b...@freebsd.org Reporter: cheek...@gmx.com The 13.3 and 14.x install images panic when booting, then reboot on 13.3 and 14.x releases. 13.2 works. We can make 13.3 and 14.x work by breaking to the loader on boot, unloading the kernel, loading it again, and loading ispfw.ko, then booting. Adding 'ispfw_load="YES"' to /boot/loader.conf keeps the system working after installation. https://mail-archive.freebsd.org/cgi/getmsg.cgi?fetch=75207+0+archive/2024/freebsd-current/20240722.freebsd-current https://mail-archive.freebsd.org/cgi/getmsg.cgi?fetch=371870+0+archive/2024/freebsd-current/20240805.freebsd-current sorry for html. an older system with two qlogic isp cards, isp0 and isp1, nothing attached to them, and it panics on boot with 13.3 and 14.x images. 13.2 works Autoloading module: ichsmb ichsmb0:port 0x300-0x31f irq 22 at device 31.3 on pci0 smbus0: on ichsmb0 isp1: port 0x9c00-0x9cff mem 0xfcbfc000-0xfcbf irq 18 at device 0.0 on pci9 isp1: FLT[DEF]: Invalid length=0x(65535) panic: vm_fault_lookup: fault on nofault entry, addr: 0xfe0127d22000 cpuid = 6 time = 1721060956 KDB: stack backtrace: Uptime: 17s Dumping 936 out of 24532 MB:..2%..11%..21%..31%..42%..52%..62%..71%..81%..91% 13.2: grep ^isp 13.2-dmesg isp0: port 0x6c00-0x6cff mem 0xfc4fc000-0xfc4f irq 16 at device 0.0 on pci3 isp0: Mailbox Command (0x8) Timeout (500us) (isp_reset:439) isp0: Mailbox Command 'ABOUT FIRMWARE' failed (TIMEOUT) isp0: isp_reinit: cannot reset card isp0: See the ispfw(4) man page on how to load known good firmware at boot time isp0: port 0x9c00-0x9cff mem 0xfcbfc000-0xfcbf irq 18 at device 0.0 on pci9 isp0: Mailbox Command (0x8) Timeout (500us) (isp_reset:439) isp0: Mailbox Command 'ABOUT FIRMWARE' failed (TIMEOUT) isp0: isp_reinit: cannot reset card isp0: See the ispfw(4) man page on how to load known good firmware at boot time isp0: port 0x6c00-0x6cff mem 0xfc4fc000-0xfc4f irq 16 at device 0.0 on pci3 isp_2400: could not load firmware image, error 6 isp0: Mailbox Command (0x8) Timeout (500us) (isp_reset:439) isp0: Mailbox Command 'ABOUT FIRMWARE' failed (TIMEOUT) isp0: isp_reinit: cannot reset card isp0: See the ispfw(4) man page on how to load known good firmware at boot time isp0: port 0x9c00-0x9cff mem 0xfcbfc000-0xfcbf irq 18 at device 0.0 on pci9 isp_2400: could not load firmware image, error 6 isp0: Mailbox Command (0x8) Timeout (500us) (isp_reset:439) isp0: Mailbox Command 'ABOUT FIRMWARE' failed (TIMEOUT) isp0: isp_reinit: cannot reset card isp0: See the ispfw(4) man page on how to load known good firmware at boot time isp0: port 0x6c00-0x6cff mem 0xfc4fc000-0xfc4f irq 16 at device 0.0 on pci3 isp1: port 0x9c00-0x9cff mem 0xfcbfc000-0xfcbf irq 18 at device 0.0 on pci9 working 13.3 dmesg with ispfw loaded in loader.conf grep ^isp 13.3-dmesg isp0: port 0x6c00-0x6cff mem 0xfc4fc000-0xfc4f irq 16 at device 0.0 on pci3 isp0: FLT[DEF]: Invalid length=0x(65535) isp0: invalid NVRAM header (55 aa 56) isp0: invalid NVRAM header (55 aa 56) isp0: bad frame length (0) from NVRAM - using 1024 isp1: port 0x9c00-0x9cff mem 0xfcbfc000-0xfcbf irq 18 at device 0.0 on pci9 isp1: FLT[DEF]: Invalid length=0x(65535) isp1: invalid NVRAM header (55 aa 56) isp1: invalid NVRAM header (55 aa 56) isp1: bad frame length (0) from NVRAM - using 1024 maybe 279381 is related. -- You are receiving this mail because: You are the assignee for the bug.
[Bug 281157] [PATCH] mfiutil: man page: Fix missing 'Ar' macro for some lines
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=281157 WHR changed: What|Removed |Added Component|kern|bin -- You are receiving this mail because: You are the assignee for the bug.
[Bug 281155] [PATCH] mfi: Correct a struct member name
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=281155 Bug ID: 281155 Summary: [PATCH] mfi: Correct a struct member name Product: Base System Version: 15.0-CURRENT Hardware: Any OS: Any Status: New Severity: Affects Only Me Priority: --- Component: kern Assignee: b...@freebsd.org Reporter: msl023...@gmail.com Created attachment 253202 --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=253202&action=edit proposed fix This 'struct mfi_evt_pd' typed member should be named 'pd' instead of 'ld'. I didn't found any use of the improper name, so this change shouldn't break anything. -- You are receiving this mail because: You are the assignee for the bug.
[Bug 281156] [PATCH] mfiutil: Fix incorrect accesses of an union member in 'struct mfi_evt_detail'
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=281156 WHR changed: What|Removed |Added URL||https://sourceforge.net/p/m ||fiutil/code/ci/d4d66777e468 ||5813cdc501669275bb7853a3208 ||8/ -- You are receiving this mail because: You are the assignee for the bug.
[Bug 281156] [PATCH] mfiutil: Fix incorrect accesses of an union member in 'struct mfi_evt_detail'
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=281156 Bug ID: 281156 Summary: [PATCH] mfiutil: Fix incorrect accesses of an union member in 'struct mfi_evt_detail' Product: Base System Version: 15.0-CURRENT Hardware: Any OS: Any Status: New Severity: Affects Only Me Priority: --- Component: bin Assignee: b...@freebsd.org Reporter: msl023...@gmail.com Created attachment 253203 --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=253203&action=edit proposed fix This patch requires bug #281155 be fixed. -- You are receiving this mail because: You are the assignee for the bug.
[Bug 281159] [PATCH] mfiutil: Fix potential buffer overflow and truncation issues
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=281159 Bug ID: 281159 Summary: [PATCH] mfiutil: Fix potential buffer overflow and truncation issues Product: Base System Version: 15.0-CURRENT Hardware: Any OS: Any Status: New Severity: Affects Only Me Priority: --- Component: bin Assignee: b...@freebsd.org Reporter: msl023...@gmail.com Created attachment 253206 --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=253206&action=edit proposed fix The fix in mfi_volume.c is particularly important; since it uses sprintf(3), if 'state' is too big, an overflow instead of string truncation, will occur. This change fixes the following warnings emitted by gcc(1): mfi_drive.c: In function 'mfi_pdstate': mfi_drive.c:155:40: warning: '%04x' directive writing between 4 and 8 bytes into a region of size 7 [-Wformat-overflow=] In function 'mfi_pdstate', inlined from 'mfi_pdstate' at /usr/src/usr.sbin/mfiutil/mfi_drive.c:131:1: /usr/src/usr.sbin/mfiutil/mfi_drive.c:155:30: note: directive argument in the range [3, 4294967295] mfi_drive.c:155:17: note: 'sprintf' output between 14 and 18 bytes into a destination of size 16 mfi_drive.c: In function 'mfi_pd_inq_string': mfi_drive.c:375:57: warning: ' ' directive output may be truncated writing 1 byte into a region of size between 0 and 62 [-Wformat-truncation=] mfi_drive.c:375:9: note: 'snprintf' output 14 or more bytes (assuming 110) into a destination of size 64 mfi_drive.c:358:65: warning: ' serial=' directive output may be truncated writing 8 bytes into a region of size between 0 and 62 [-Wformat-truncation=] mfi_drive.c:358:17: note: 'snprintf' output between 17 and 98 bytes into a destination of size 64 mfi_evt.c: In function 'pdrive_location': mfi_evt.c:350:64: warning: 'snprintf' output may be truncated before the last format character [-Wformat-truncation=] mfi_evt.c:350:17: note: 'snprintf' output between 10 and 17 bytes into a destination of size 16 mfi_volume.c: In function 'mfi_ldstate': mfi_volume.c:60:40: warning: '%02x' directive writing between 2 and 8 bytes into a region of size 7 [-Wformat-overflow=] mfi_volume.c:60:30: note: directive argument in the range [4, 4294967295] mfi_volume.c:60:17: note: 'sprintf' output between 12 and 18 bytes into a destination of size 16 -- You are receiving this mail because: You are the assignee for the bug.
[Bug 281159] [PATCH] mfiutil: Fix potential buffer overflow and truncation issues
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=281159 WHR changed: What|Removed |Added URL||https://sourceforge.net/p/m ||fiutil/code/ci/cb9c94b77e2c ||6433e706dde79ab4716f2d8e73b ||3/ -- You are receiving this mail because: You are the assignee for the bug.
[Bug 281151] [patch] source upgrade path broken for stable/12 to stable/13 due to bmake
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=281151 --- Comment #1 from Simon J. Gerraty --- I don't see how HAS_TESTS is relevant? Absent that, this change would be easy to make. -- You are receiving this mail because: You are the assignee for the bug.
[Bug 281155] [PATCH] mfi: Correct a struct member name
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=281155 WHR changed: What|Removed |Added Blocks||281156 Referenced Bugs: https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=281156 [Bug 281156] [PATCH] mfiutil: Fix incorrect accesses of an union member in 'struct mfi_evt_detail' -- You are receiving this mail because: You are the assignee for the bug.
[Bug 281153] [PATCH] mfiutil: Fix malformed error messages in 'ctrlprop rebuild' and 'ctrlprop alarm' subcommands
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=281153 WHR changed: What|Removed |Added Attachment #253201|0 |1 is obsolete|| --- Comment #1 from WHR --- Created attachment 253208 --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=253208&action=edit proposed fix -- You are receiving this mail because: You are the assignee for the bug.
[Bug 281153] [PATCH] mfiutil: Fix malformed error messages in 'ctrlprop rebuild' and 'ctrlprop alarm' subcommands
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=281153 Bug ID: 281153 Summary: [PATCH] mfiutil: Fix malformed error messages in 'ctrlprop rebuild' and 'ctrlprop alarm' subcommands Product: Base System Version: 15.0-CURRENT Hardware: Any OS: Any Status: New Severity: Affects Only Me Priority: --- Component: bin Assignee: b...@freebsd.org Reporter: msl023...@gmail.com Created attachment 253201 --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=253201&action=edit mfiutil-f2f111f.diff Reporting usage error shouldn't use warn(3) because the 'errno' isn't relevant here. -- You are receiving this mail because: You are the assignee for the bug.
[Bug 281156] [PATCH] mfiutil: Fix incorrect accesses of an union member in 'struct mfi_evt_detail'
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=281156 WHR changed: What|Removed |Added Attachment #253203|0 |1 is obsolete|| --- Comment #1 from WHR --- Created attachment 253211 --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=253211&action=edit proposed fix -- You are receiving this mail because: You are the assignee for the bug.
[Bug 281158] [PATCH] mfiutil: Handle potential ioctl(2) failures in mfi_flash.c
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=281158 Bug ID: 281158 Summary: [PATCH] mfiutil: Handle potential ioctl(2) failures in mfi_flash.c Product: Base System Version: 15.0-CURRENT Hardware: Any OS: Any Status: New Severity: Affects Only Me Priority: --- Component: bin Assignee: b...@freebsd.org Reporter: msl023...@gmail.com Created attachment 253205 --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=253205&action=edit proposed fix The return value of function 'mfi_dcmd_command' should always be checked for the potential ioctl(2) failure. -- You are receiving this mail because: You are the assignee for the bug.
[Bug 281157] [PATCH] mfiutil: man page: Fix missing 'Ar' macro for some lines
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=281157 Bug ID: 281157 Summary: [PATCH] mfiutil: man page: Fix missing 'Ar' macro for some lines Product: Base System Version: 15.0-CURRENT Hardware: Any OS: Any Status: New Severity: Affects Only Me Priority: --- Component: kern Assignee: b...@freebsd.org Reporter: msl023...@gmail.com Created attachment 253204 --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=253204&action=edit proposed fix -- You are receiving this mail because: You are the assignee for the bug.
[Bug 281157] [PATCH] mfiutil: man page: Fix missing 'Ar' macro for some lines
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=281157 WHR changed: What|Removed |Added URL||https://sourceforge.net/p/m ||fiutil/code/ci/860078510dd5 ||ef655d13bfa218aadfc9cb81d12 ||7/ -- You are receiving this mail because: You are the assignee for the bug.
[Bug 281160] [PATCH] mfiutil: Fix unsafe assumptions of snprintf(3) return value in function 'mfi_autolearn_period'
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=281160 WHR changed: What|Removed |Added URL||https://sourceforge.net/p/m ||fiutil/code/ci/8ee7bd9112fa ||b7bdf28188fa595f8a8a59cced4 ||8/ -- You are receiving this mail because: You are the assignee for the bug.
[Bug 281158] [PATCH] mfiutil: Handle potential ioctl(2) failures in mfi_flash.c
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=281158 WHR changed: What|Removed |Added URL||https://sourceforge.net/p/m ||fiutil/code/ci/e956d4a6218e ||1e965d1cac2666dfda4215211a6 ||9/ -- You are receiving this mail because: You are the assignee for the bug.
[Bug 281152] [PATCH] mfiutil: Don't use term 'JBOD' for non-RAID SYSTEM physical drives, as it has a different meaning in this program
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=281152 WHR changed: What|Removed |Added URL||https://sourceforge.net/p/m ||fiutil/code/ci/b53c417e8e63 ||2c15e52164de2b564271da00a76 ||7/ -- You are receiving this mail because: You are the assignee for the bug.
[Bug 281151] [patch] source upgrade path broken for stable/12 to stable/13 due to bmake
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=281151
Bug ID: 281151
Summary: [patch] source upgrade path broken for stable/12 to
stable/13 due to bmake
Product: Base System
Version: 13.4-STABLE
Hardware: Any
OS: Any
Status: New
Keywords: easy, patch-ready
Severity: Affects Some People
Priority: ---
Component: bin
Assignee: b...@freebsd.org
Reporter: eu...@freebsd.org
CC: s...@freebsd.org
I've just tried to "make builworld WITHOUT_TESTS=" with stable/12 system to
upgrade it to stable/13 and it failed:
===> usr.bin/bmake (obj)
===> usr.bin/bmake/unit-tests (obj)
make[6]: "/usr/src/usr.bin/bmake/unit-tests/Makefile" line 445: Malformed
conditional (${.SHELL:T}
== "ksh")
make[6]: "/usr/src/usr.bin/bmake/unit-tests/Makefile" line 774: Malformed
conditional (${.SHELL:T}
== "ksh")
make[6]: Fatal errors encountered -- cannot continue
Please consider something like the following change to respect WITHOUT_TESTS:
--- usr.bin/bmake/Makefile.orig 2024-08-31 08:37:49.762012000 +
+++ usr.bin/bmake/Makefile2024-08-31 09:38:30.24428 +
@@ -87,7 +87,8 @@
.PATH: ${srcdir}
.if make(obj) || make(clean)
-SUBDIR+= unit-tests
+HAS_TESTS=
+SUBDIR.${MK_TESTS}+= unit-tests
.endif
--
You are receiving this mail because:
You are the assignee for the bug.
[Bug 281159] [PATCH] mfiutil: Fix potential buffer overflow and truncation issues
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=281159 WHR changed: What|Removed |Added Attachment #253206|0 |1 is obsolete|| --- Comment #1 from WHR --- Created attachment 253215 --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=253215&action=edit proposed fix -- You are receiving this mail because: You are the assignee for the bug.
[Bug 281156] [PATCH] mfiutil: Fix incorrect accesses of an union member in 'struct mfi_evt_detail'
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=281156 WHR changed: What|Removed |Added Depends on||281155 Referenced Bugs: https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=281155 [Bug 281155] [PATCH] mfi: Correct a struct member name -- You are receiving this mail because: You are the assignee for the bug.
[Bug 281158] [PATCH] mfiutil: Handle potential ioctl(2) failures in mfi_flash.c
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=281158 WHR changed: What|Removed |Added Attachment #253205|0 |1 is obsolete|| --- Comment #1 from WHR --- Created attachment 253214 --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=253214&action=edit proposed fix -- You are receiving this mail because: You are the assignee for the bug.
[Bug 281155] [PATCH] mfi: Correct a struct member name
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=281155 WHR changed: What|Removed |Added URL||https://sourceforge.net/p/m ||fiutil/code/ci/d4d66777e468 ||5813cdc501669275bb7853a3208 ||8/ -- You are receiving this mail because: You are the assignee for the bug.
[Bug 281152] [PATCH] mfiutil: Don't use term 'JBOD' for non-RAID SYSTEM physical drives, as it has a different meaning in this program
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=281152 Bug ID: 281152 Summary: [PATCH] mfiutil: Don't use term 'JBOD' for non-RAID SYSTEM physical drives, as it has a different meaning in this program Product: Base System Version: CURRENT Hardware: Any OS: Any Status: New Severity: Affects Only Me Priority: --- Component: bin Assignee: b...@freebsd.org Reporter: msl023...@gmail.com Created attachment 253200 --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=253200&action=edit mfiutil-b53c417.diff In terms used by mfiutil(8), 'JBOD' means logical volumes backed by RAID-0 arrays of single physical drives. Take the example of creating JBOD volumes from the man page: Configure the first three disks on a controller as JBOD: mfiutil create jbod 0 1 2 This creates logical volumes. In contrast to: Reconfigure a disk as a SYSPD block device with no RAID mfiutil syspd 0 This makes specified physical drive directly accessible. For consistency, mfiutil(8) should this drive state as 'SYSTEM' or 'SYSPD'. -- You are receiving this mail because: You are the assignee for the bug.
[Bug 281160] [PATCH] mfiutil: Fix unsafe assumptions of snprintf(3) return value in function 'mfi_autolearn_period'
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=281160 Bug ID: 281160 Summary: [PATCH] mfiutil: Fix unsafe assumptions of snprintf(3) return value in function 'mfi_autolearn_period' Product: Base System Version: 15.0-CURRENT Hardware: Any OS: Any Status: New Severity: Affects Only Me Priority: --- Component: bin Assignee: b...@freebsd.org Reporter: msl023...@gmail.com Created attachment 253207 --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=253207&action=edit mfiutil-8ee7bd9.diff The snprintf(3) returns the number of characters that **would have been written** if size is enough for the result. However the code in question dangerously assumed that truncation would never happen, by adjusting the pointer 'tmp' and size 'sz' using snprintf(3) return value, without first checking whether a truncation happend. (why use snprintf(3) in first place if a truncation will never happen?) -- You are receiving this mail because: You are the assignee for the bug.
[Bug 281151] [patch] source upgrade path broken for stable/12 to stable/13 due to bmake
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=281151 --- Comment #2 from commit-h...@freebsd.org --- A commit in branch stable/13 references this bug: URL: https://cgit.FreeBSD.org/src/commit/?id=2d203f534baef0568989555ebd26278134ef4c6b commit 2d203f534baef0568989555ebd26278134ef4c6b Author: Simon J. Gerraty AuthorDate: 2024-09-01 06:29:19 + Commit: Simon J. Gerraty CommitDate: 2024-09-01 06:29:19 + bmake/unit-tests/Makefile use _shell Set _shell like later versions of bmake so that .SHELL does not appear in conditionals. This avoids errors when an older version of bmake parses this makefile such as when doing src upgrade from stable/12 or older. Direct commit to stable/13 since this is the only branch where this issue arrises. PR: 281151 usr.bin/bmake/unit-tests/Makefile | 11 ++- 1 file changed, 6 insertions(+), 5 deletions(-) -- You are receiving this mail because: You are the assignee for the bug.
[Bug 281157] [PATCH] mfiutil: man page: Fix missing 'Ar' macro for some lines
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=281157 WHR changed: What|Removed |Added Attachment #253204|0 |1 is obsolete|| --- Comment #1 from WHR --- Created attachment 253212 --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=253212&action=edit proposed fix -- You are receiving this mail because: You are the assignee for the bug.
