[Bug 277959] Refactor of usr.sbin/daemon caused regression in restart parameter

2024-08-26 Thread bugzilla-noreply
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=277959

--- Comment #7 from Rudolph  ---
Any news on this issue?

-- 
You are receiving this mail because:
You are on the CC list for the bug.


[Bug 280950] DMAR (hw.dmar.enable=1) breaks resume

2024-08-26 Thread bugzilla-noreply
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=280950

Ed Maste  changed:

   What|Removed |Added

 Resolution|--- |DUPLICATE
 Status|New |Closed

--- Comment #1 from Ed Maste  ---


*** This bug has been marked as a duplicate of bug 237357 ***

-- 
You are receiving this mail because:
You are the assignee for the bug.


[Bug 237357] Not resuming from suspend with IOMMU DMAR enabled

2024-08-26 Thread bugzilla-noreply
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=237357

--- Comment #4 from Ed Maste  ---
*** Bug 280950 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are the assignee for the bug.


[Bug 237357] Not resuming from suspend with IOMMU DMAR enabled

2024-08-26 Thread bugzilla-noreply
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=237357

Ed Maste  changed:

   What|Removed |Added

   See Also||https://bugs.freebsd.org/bu
   ||gzilla/show_bug.cgi?id=2809
   ||52,
   ||https://bugs.freebsd.org/bu
   ||gzilla/show_bug.cgi?id=2808
   ||17

-- 
You are receiving this mail because:
You are the assignee for the bug.


[Bug 280952] DMAR (hw.dmar.enable=1) incompatible with bhyve passthrough

2024-08-26 Thread bugzilla-noreply
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=280952

Ed Maste  changed:

   What|Removed |Added

   See Also||https://bugs.freebsd.org/bu
   ||gzilla/show_bug.cgi?id=2373
   ||57

-- 
You are receiving this mail because:
You are the assignee for the bug.


[Bug 280817] With DMAR enabled, my laptop panics

2024-08-26 Thread bugzilla-noreply
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=280817

Ed Maste  changed:

   What|Removed |Added

   See Also||https://bugs.freebsd.org/bu
   ||gzilla/show_bug.cgi?id=2373
   ||57

-- 
You are receiving this mail because:
You are the assignee for the bug.


[Bug 280099] adduser not respecting home directory mode

2024-08-26 Thread bugzilla-noreply
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=280099

Graham Perrin  changed:

   What|Removed |Added

 CC||grahamper...@gmail.com

--- Comment #6 from Graham Perrin  ---
Duplicate of bug 150988.

-- 
You are receiving this mail because:
You are the assignee for the bug.


[Bug 280099] adduser not respecting home directory mode

2024-08-26 Thread bugzilla-noreply
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=280099

--- Comment #7 from Graham Perrin  ---
… maybe not a duplicate. Apologies for the noise.

-- 
You are receiving this mail because:
You are the assignee for the bug.


[Bug 280099] adduser not respecting home directory mode

2024-08-26 Thread bugzilla-noreply
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=280099

Kyle Evans  changed:

   What|Removed |Added

 CC||kev...@freebsd.org

--- Comment #8 from Kyle Evans  ---
(In reply to Daniel Li from comment #5)

Not mounted filesystem specific, it just won't change the mode of an existing
directory period.  The mode is used for mkdirat(2) and files created within.

-- 
You are receiving this mail because:
You are the assignee for the bug.


[Bug 280099] adduser not respecting home directory mode

2024-08-26 Thread bugzilla-noreply
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=280099

--- Comment #9 from Kyle Evans  ---
pw(8) probably should have been doing this all along:

diff --git a/usr.sbin/pw/cpdir.c b/usr.sbin/pw/cpdir.c
index 504933ab88af..856ab95ee781 100644
--- a/usr.sbin/pw/cpdir.c
+++ b/usr.sbin/pw/cpdir.c
@@ -49,9 +49,13 @@ copymkdir(int rootfd, char const * dir, int skelfd, mode_t
mode, uid_t uid,
if (*dir == '/')
dir++;

-   if (mkdirat(rootfd, dir, mode) != 0 && errno != EEXIST) {
-   warn("mkdir(%s)", dir);
-   return;
+   if (mkdirat(rootfd, dir, mode) != 0) {
+   if (errno != EEXIST) {
+   warn("mkdir(%s)", dir);
+   return;
+   }
+
+   (void)fchmodat(rootfd, dir, mode, AT_SYMLINK_NOFOLLOW);
}
fchownat(rootfd, dir, uid, gid, AT_SYMLINK_NOFOLLOW);
if (flags > 0)

-- 
You are receiving this mail because:
You are the assignee for the bug.


[Bug 280913] [patch] Unexpected state of vnet-jails with ifconfig_DEFAULT="DHCP" in rc.conf(5)

2024-08-26 Thread bugzilla-noreply
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=280913

--- Comment #3 from cr...@rlwinm.de ---
Interface names can contain any null terminated string e.g. `$'💩
𓂸\n\t\377\10\10\10'` (including the NUL byte). They're unsafe (splitting,
trimming, globbing), to expand in shell scripts outside of a double quoted
strings e.g. `dhcpif $1`

-- 
You are receiving this mail because:
You are the assignee for the bug.


[Bug 280809] jail_attach(2) fails to document reason for EPERM

2024-08-26 Thread bugzilla-noreply
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=280809

--- Comment #4 from Karlo Miličević  ---
(In reply to Olivier Certner from comment #1)

Ah! I totally missed that paragraph. I guess I should read more carefully.

(In reply to crest from comment #3)

Could you add "root vnode pointer" to every directory FD to limit their scope?
That way, when you reference ".." you would check whether the directory FD
equals that pointer and if so, not go above.
Also, O_RESOLVE_BENEATH would then just mean that when you open that directory
FD you would make the directory itself be the "root vnode pointer" instead of
its jail/chroot root directory.
Opening directories with openat copies the "root vnode pointer" unless
overriden by something like O_RESOLVE_BENEATH.

((I have no experience with VFS code, so take this idea with a grain of salt!))

This reminds me slightly of how sockets have vnet pointers.


Should I close this issue or does someone else do that?
The reason is documented already, as stated by Olivier Cartner.

-- 
You are receiving this mail because:
You are the assignee for the bug.


[Bug 280913] [patch] Unexpected state of vnet-jails with ifconfig_DEFAULT="DHCP" in rc.conf(5)

2024-08-26 Thread bugzilla-noreply
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=280913

--- Comment #4 from Harald Schmalzbauer  ---
(In reply to crest from comment #3)
Good point.  But this patch for syncdhcpif() of /etc/network.subr is not really
affected, since $1 in syncdhcpif() was passed unquoted from ifconfig_up() which
in turn got it from ifn_start() as unquoted parameter ${ifn}.

get_if_var() uses ltr() to normalize IF.  From a quick look, only IFNAME
consisting of the four ".-/+" punctuation characters are valid, which are
unconditionally replaced by the underscore character.  rc(8) would break far
earlier if somebody manually renamed the interface to anything allowed by the
core struct (if not prevented by ifconfig(8)) and tries to non-maually attach
dhclient to it.

For consistency reasons I'd prefer to keep it unquoted since I see no
possibility that $1 can ever be anything else than shell variable characters
(get_if_var() would fail to return any of the DHCP pseudo-args, so syncdhcpif()
wouldn't be called).  The wrong whitespace indention bothers me more ;-)

Thanks for looking at it!

-- 
You are receiving this mail because:
You are the assignee for the bug.


[Bug 281082] sys/netgraph/ng_ipfw.c: Using 32bit cookies breaks ipfw ngtee

2024-08-26 Thread bugzilla-noreply
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=281082

Bug ID: 281082
   Summary: sys/netgraph/ng_ipfw.c: Using 32bit cookies breaks
ipfw ngtee
   Product: Base System
   Version: Unspecified
  Hardware: Any
OS: Any
Status: New
  Severity: Affects Some People
  Priority: ---
 Component: kern
  Assignee: b...@freebsd.org
  Reporter: ru...@verweg.com

The MFC’ed commit 20e1f207cc789a28783344614d6d1d1c639c5797
(https://cgit.freebsd.org/src/commit/?id=20e1f207cc789a28783344614d6d1d1c639c5797)
MFC’ed to 14.1 as dadf64c5586e5fa5e1018a3d8a02c9873b1121b8 and to 13.3 as
0b9242dea68c44dc630921d3802f3f80f4d84b48 breaks ipfw_netflow.

Reversing the patch restores functionality.

This might be due to 
* sys/netinet/ip_fw.h’s ipfw_insn->arg1 still sit at u_int16_t, perhaps
truncating one or another so that it remains invisible for ng_ipfw and the rest
of netgraph
* sbin/ipfw/ipfw2.c chkarg in case TOK_NGTEE poses a limit of IP_FW_TABLEARG
(65535) on the ngtee parameter.

Tested on 13.3 with ipfw_netflow and a packetcapture on the receiving port /
sudo flowctl netflow: show human

Reversing the patch seems less impacting than to figure out where arg1 handling
needs to be adjusted for full 32bit operation.

-- 
You are receiving this mail because:
You are the assignee for the bug.


[Bug 280099] adduser not respecting home directory mode

2024-08-26 Thread bugzilla-noreply
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=280099

Kyle Evans  changed:

   What|Removed |Added

URL||https://reviews.freebsd.org
   ||/D46443

-- 
You are receiving this mail because:
You are the assignee for the bug.


[Bug 281082] sys/netgraph/ng_ipfw.c: Using 32bit cookies breaks ipfw ngtee

2024-08-26 Thread bugzilla-noreply
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=281082

Mark Linimon  changed:

   What|Removed |Added

   Assignee|b...@freebsd.org|eu...@freebsd.org
   Keywords||regression

--- Comment #1 from Mark Linimon  ---
Triage: over to committer of 20e1f207cc789a28783344614d6d1d1c639c5797.

-- 
You are receiving this mail because:
You are the assignee for the bug.