[Bug 269994] build options have different kernel and userland defaults
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=269994
Bug ID: 269994
Summary: build options have different kernel and userland
defaults
Product: Base System
Version: CURRENT
Hardware: Any
OS: Any
Status: New
Severity: Affects Only Me
Priority: ---
Component: misc
Assignee: b...@freebsd.org
Reporter: ema...@freebsd.org
Options EFI and FDT have different defaults in src.opts.mk and kern.conf.mk,
prompting warnings from makeman:
amd64/amd64: ignoring duplicate option FDT
arm/armv6: ignoring duplicate option FDT
arm/armv7: ignoring duplicate option FDT
arm64/aarch64: ignoring duplicate option FDT
i386/i386: ignoring duplicate option FDT
powerpc/powerpc: ignoring duplicate option EFI
powerpc/powerpc: ignoring duplicate option FDT
powerpc/powerpc64: ignoring duplicate option EFI
powerpc/powerpc64: ignoring duplicate option FDT
powerpc/powerpc64le: ignoring duplicate option EFI
powerpc/powerpc64le: ignoring duplicate option FDT
riscv/riscv64: ignoring duplicate option FDT
riscv/riscv64sf: ignoring duplicate option FDT
Both are in src.conf.mk __DEFAULT_YES_OPTIONS, but EFI also has:
# EFI doesn't exist on powerpc (well, officially)
.if ${__T:Mpowerpc*}
BROKEN_OPTIONS+=EFI
.endif
kern.opts.mk has EFI in __DEFAULT_YES_OPTIONS, but:
# EFI doesn't exist on powerpc, or riscv
.if ${MACHINE:Mpowerpc} || ${MACHINE:Mriscv}
BROKEN_OPTIONS+=EFI
.endif
while for FDT it has:
.if ${MACHINE_CPUARCH} == "i386" || ${MACHINE_CPUARCH} == "amd64"
__DEFAULT_NO_OPTIONS += FDT
.else
__DEFAULT_YES_OPTIONS += FDT
.endif
--
You are receiving this mail because:
You are the assignee for the bug.
[Bug 269994] build options have different kernel and userland defaults
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=269994
--- Comment #1 from Ed Maste ---
As far as I can tell the ${MACHINE*} tests in kern.opts.mk do not work, at
least for `make showconfig`. When I run `make TARGET=powerpc
TARGET_ARCH=powerpc64
showconfig` on my laptop MACHINE is `amd64` within kern.opts.mk.
--
You are receiving this mail because:
You are the assignee for the bug.
[Bug 268400] Page fault kernel panic with KTLS enabled
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=268400 --- Comment #3 from Daniel Ponte --- My interface configuration and pf policy are rather large and complex and it would take some time to sanitize them. Could I send directly to someone? That said, I can confirm this is still happening in 13.2-STABLE FreeBSD 13.2-STABLE #17 stable/13-n254582-c0e7e1848360: Thu Feb 16 15:19:52 EST 2023. Digging deeper, the panic appears to be caused by a pf rule with route-to/reply-to rerouting to an IPv6 gif(4) interface with MTU of only 1280. It is caused by KTLS trying to send a packet that gets rerouted by pf (likely by reply-to) that results in ICMPv6 type 2 (Packet Too Big). -- You are receiving this mail because: You are the assignee for the bug.
[Bug 268400] Page fault kernel panic with KTLS enabled
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=268400 Zhenlei Huang changed: What|Removed |Added CC||k...@freebsd.org --- Comment #4 from Zhenlei Huang --- (In reply to Daniel Ponte from comment #3) It is best to have a minimal setup (pf rules / interfaces) so that it will be easy to reproduce and debug. If it is production usage, then you may want to send privately. >From what you describe I suspect it may be a coner case, a combination of KTLS / pf route-to / reduced MTU. I'll CC @kp to see if he has any insights. You can send to me z...@freebsd.org . -- You are receiving this mail because: You are the assignee for the bug.
[Bug 268400] Page fault kernel panic with KTLS enabled
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=268400 --- Comment #5 from Daniel Ponte --- Yes, the entire issue is the complexity of the setup, which is a production setup, and is bringing out a corner case. I do not need to use kTLS but I figured the project would be interested in fixing this panic, and I am happy to avail myself to the degree I am able. -- You are receiving this mail because: You are the assignee for the bug.
[Bug 268400] Page fault kernel panic with KTLS enabled
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=268400 Kristof Provost changed: What|Removed |Added CC||ma...@freebsd.org --- Comment #6 from Kristof Provost --- It looks like this happens while we're computing the checksum for the icmp6 header, and that we're dereferencing a NULL pointer. I'm relatively confident that we're processing an unmapped mbuf, and that's why we're panicing here. Mark taught in_cksum_skip() to handle those, but I think in6_cksum() doesn't handle them. So we either need to insert an mb_unmapped_to_ext() call in in6_cksum(), or we need to teach in6_cksum() to deal with unmapped mbufs. -- You are receiving this mail because: You are the assignee for the bug.
[Bug 268400] Page fault kernel panic with KTLS enabled
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=268400 --- Comment #7 from Mark Johnston --- (In reply to Kristof Provost from comment #6) I think you're right. I thought there was a reason for not converting the in6_cksum() routines to use m_apply(), but I can't find it. -- You are receiving this mail because: You are the assignee for the bug.
[Bug 229689] freebsd-update shouldn't add system breaking comments to config files
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=229689 --- Comment #10 from Ed Maste --- (In reply to Graham Perrin from comment #9) It wouldn't hurt, but also is probably not going to be that useful to people upgrading *to* 13.2, who are upgrading *from* a FreeBSD version where freebsd-update does not yet have this change. -- You are receiving this mail because: You are the assignee for the bug.
[Bug 164281] bsdinstall(8): please allow sysinstall as installer option
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=164281 Ed Maste changed: What|Removed |Added Resolution|--- |Overcome By Events Status|Open|Closed --- Comment #14 from Ed Maste --- sysinstall has been removed so cannot be made available. If there are open issues in bsdinstall please submit new PRs for them. -- You are receiving this mail because: You are the assignee for the bug.
[Bug 144325] [libpcap] tcpdump compiles complex expression to incorrect BPF code
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=144325 --- Comment #7 from Archit Shah --- Upstream pull request is here: https://github.com/the-tcpdump-group/libpcap/pull/976 -- You are receiving this mail because: You are the assignee for the bug.
[Bug 265248] bectl warns twice when the user tries once to create an existing environment (boot environment name already taken)
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=265248 John Grafton changed: What|Removed |Added CC||john.graf...@runbox.com --- Comment #1 from John Grafton --- Bug is in libbe. Seems two functions are printing the error in their return path. Pull request: https://github.com/freebsd/freebsd-src/pull/685 -- You are receiving this mail because: You are the assignee for the bug.
[Bug 269994] build options have different kernel and userland defaults
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=269994 --- Comment #2 from commit-h...@freebsd.org --- A commit in branch main references this bug: URL: https://cgit.FreeBSD.org/src/commit/?id=d7a491dd3037030a09e579225899cd0617a5ef4f commit d7a491dd3037030a09e579225899cd0617a5ef4f Author: Ed Maste AuthorDate: 2023-03-06 15:56:13 + Commit: Ed Maste CommitDate: 2023-03-06 21:03:22 + make showconfig: set MACHINE and MACHINE_ARCH Previously these were not set for the showconfig target, so took the host's value rather than the target. As a result some machine-dependent kernel options were not reported with correct defaults in the src.conf manpage. PR: 269994 Reviewed by:imp Sponsored by: The FreeBSD Foundation Differential Revision: https://reviews.freebsd.org/D38926 Makefile.inc1 | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- You are receiving this mail because: You are the assignee for the bug.
[Bug 269994] build options have different kernel and userland defaults
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=269994 --- Comment #3 from commit-h...@freebsd.org --- A commit in branch main references this bug: URL: https://cgit.FreeBSD.org/src/commit/?id=3f9c1b2cae5d6a223d9306194d72d86b6baadacd commit 3f9c1b2cae5d6a223d9306194d72d86b6baadacd Author: Ed Maste AuthorDate: 2023-03-06 21:07:38 + Commit: Ed Maste CommitDate: 2023-03-06 21:08:56 + src.conf: regen after d7a491dd3037 Machine-dependent kernel options are now detected correctly. PR: 269994 Sponsored by: The FreeBSD Foundation share/man/man5/src.conf.5 | 30 +++--- 1 file changed, 27 insertions(+), 3 deletions(-) -- You are receiving this mail because: You are the assignee for the bug.
[Bug 269994] build options have different kernel and userland defaults
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=269994 --- Comment #4 from Ed Maste --- Mismatches are now (sorted by option): amd64/amd64: ignoring duplicate option FDT i386/i386: ignoring duplicate option FDT arm/armv6: ignoring duplicate option OFED arm/armv7: ignoring duplicate option OFED arm64/aarch64: ignoring duplicate option OFED powerpc/powerpc: ignoring duplicate option OFED riscv/riscv64: ignoring duplicate option OFED riscv/riscv64sf: ignoring duplicate option OFED arm/armv6: ignoring duplicate option PIE arm/armv7: ignoring duplicate option PIE i386/i386: ignoring duplicate option PIE powerpc/powerpc: ignoring duplicate option PIE riscv/riscv64: ignoring duplicate option EFI riscv/riscv64sf: ignoring duplicate option EFI powerpc/powerpc: ignoring duplicate option ZFS -- You are receiving this mail because: You are the assignee for the bug.
[Bug 269994] build options have different kernel and userland defaults
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=269994 --- Comment #5 from commit-h...@freebsd.org --- A commit in branch main references this bug: URL: https://cgit.FreeBSD.org/src/commit/?id=6e0a1438d8f296583beec36fa2fbdc94b69560e0 commit 6e0a1438d8f296583beec36fa2fbdc94b69560e0 Author: Ed Maste AuthorDate: 2023-03-06 21:47:36 + Commit: Ed Maste CommitDate: 2023-03-07 01:34:02 + src.opts.mk: mark ZFS broken on powerpc, matching kern.opts.mk Where options exist in both src.opts.mk and kern.opts.mk they should be kept in sync. PR: 269994 Reviewed by:imp Sponsored by: The FreeBSD Foundation Differential Revision: https://reviews.freebsd.org/D38935 share/mk/src.opts.mk | 4 1 file changed, 4 insertions(+) -- You are receiving this mail because: You are the assignee for the bug.
