[Bug 224615] [PATCH] kevent: EVFILT_READ returns EV_EOF on named pipe when it should not

2020-05-11 Thread bugzilla-noreply
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=224615

--- Comment #7 from commit-h...@freebsd.org ---
A commit references this bug:

Author: markj
Date: Mon May 11 15:20:41 UTC 2020
New revision: 360897
URL: https://svnweb.freebsd.org/changeset/base/360897

Log:
  MFC r360380:
  Fix handling of EV_EOF for named pipes.

  PR:   203366, 224615, 246350

Changes:
_U  stable/12/
  stable/12/lib/libc/sys/kqueue.2
  stable/12/sys/kern/sys_pipe.c

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
freebsd-bugs@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-bugs
To unsubscribe, send any mail to "freebsd-bugs-unsubscr...@freebsd.org"


[Bug 224615] [PATCH] kevent: EVFILT_READ returns EV_EOF on named pipe when it should not

2020-05-11 Thread bugzilla-noreply
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=224615

Mark Johnston  changed:

   What|Removed |Added

   Assignee|kev...@freebsd.org  |ma...@freebsd.org
 Status|In Progress |Closed
 Resolution|--- |FIXED

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
freebsd-bugs@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-bugs
To unsubscribe, send any mail to "freebsd-bugs-unsubscr...@freebsd.org"


[Bug 245630] sysutils/bastille: Update to 0.6.20200414

2020-05-11 Thread bugzilla-noreply
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=245630

--- Comment #6 from Kyle Evans  ---
Ping @koobs

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
freebsd-bugs@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-bugs
To unsubscribe, send any mail to "freebsd-bugs-unsubscr...@freebsd.org"


[Bug 229046] [meta] GNU objdump removal tracking PR

2020-05-11 Thread bugzilla-noreply
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=229046
Bug 229046 depends on bug 212319, which changed state.

Bug 212319 Summary: [exp-run] test build without /usr/bin/objdump
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=212319

   What|Removed |Added

 Status|In Progress |Closed
 Resolution|--- |FIXED

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
freebsd-bugs@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-bugs
To unsubscribe, send any mail to "freebsd-bugs-unsubscr...@freebsd.org"


[Bug 246385] SIGCHLD dropped if generated while blocked in sigfastblock

2020-05-11 Thread bugzilla-noreply
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=246385

Bug ID: 246385
   Summary: SIGCHLD dropped if generated while blocked in
sigfastblock
   Product: Base System
   Version: CURRENT
  Hardware: Any
OS: Any
Status: New
  Severity: Affects Only Me
  Priority: ---
 Component: kern
  Assignee: b...@freebsd.org
  Reporter: corydo...@ridiculousfish.com
 Attachment #214394 text/plain
 mime type:

Created attachment 214394
  --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=214394&action=edit
reduced test case, see description for how to compile

fish-shell is observing a hang under FreeBSD CURRENT which I believe to be a
regression in FreeBSD signal handling, relative to 12.1.

Originally reported as https://github.com/fish-shell/fish-shell/issues/6919

High level: if a process forks and the child exits before fork is complete in
the parent, then SIGCHLD will not be delivered.

Details: fork() will block signals using sigfastblock. If the child dies before
signals are unblocked, the SIGCHLD will be marked as pending via the
sigfastblock word. In this case fork() will issue a syscall to
`sigfastblock(SIGFASTBLOCK_UNBLOCK)`; however SIGCHLD will NOT be delivered.

Reduced test case attached as `demo.c`. This test case uses a loop which
creates a child and waits for SIGCHLD to be delivered via the self-pipe trick.
It counts every 256 iterations.

To reproduce:

clang demo.c ; ./a.out # this does not hang

clang -lpthread demo.c ; ./a.out # this hangs on FreeBSD CURRENT only


ktrace output:

Good iteration (SIGCHLD generated while signals NOT blocked):
 27181 a.outCALL  fork
 27181 a.outRET   fork 27581/0x6bbd
 27181 a.outCALL  read(0x3,0x7fffe8e0,0x200)
 27181 a.outRET   read RESTART
 27181 a.outPSIG  SIGCHLD caught handler=0x800258dd0 mask=0x0
code=CLD_EXITED
 27181 a.outCALL  sigprocmask(SIG_SETMASK,0x7fffe24c,0)
 27181 a.outRET   sigprocmask 0
 27181 a.outCALL  write(0x4,0x7fffde6b,0x1)
 27181 a.outGIO   fd 4 wrote 1 byte
 27181 a.outRET   write 1
 27181 a.outCALL  sigreturn(0x7fffde80)
 27181 a.outRET   sigreturn JUSTRETURN
 27181 a.outCALL  read(0x3,0x7fffe8e0,0x200)
 27181 a.outGIO   fd 3 read 1 byte


Hanging iteration (SIGCHLD generated while signals ARE blocked):

 27181 a.outRET   read 1
 27181 a.outCALL  wait4(0x6bbd,0x7fffe8d4,0x6,0)
 27181 a.outRET   wait4 27581/0x6bbd
 27181 a.outCALL  fork
 27181 a.outRET   fork 27582/0x6bbe
 27181 a.outCALL  sigfastblock(0x2,0)
 27181 a.outRET   sigfastblock 0
 27181 a.outCALL  read(0x3,0x7fffe8e0,0x200)

Note the call to sigfastblock(0x2) (pending signal) but PSIG  SIGCHLD is not
generated.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
freebsd-bugs@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-bugs
To unsubscribe, send any mail to "freebsd-bugs-unsubscr...@freebsd.org"


[Bug 246385] SIGCHLD dropped if generated while blocked in sigfastblock

2020-05-11 Thread bugzilla-noreply
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=246385

corydo...@ridiculousfish.com changed:

   What|Removed |Added

   Severity|Affects Only Me |Affects Many People

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
freebsd-bugs@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-bugs
To unsubscribe, send any mail to "freebsd-bugs-unsubscr...@freebsd.org"


[Bug 237664] [patch] systat -zarc to display cumulative rate and round down large numbers by SI units

2020-05-11 Thread bugzilla-noreply
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=237664

--- Comment #4 from commit-h...@freebsd.org ---
A commit references this bug:

Author: mr
Date: Mon May 11 20:34:53 UTC 2020
New revision: 360919
URL: https://svnweb.freebsd.org/changeset/base/360919

Log:
  Patch systat -zarc to display cumulative rate and round down large numbers by
SI units

  PR:   237664
  Submitted by: o...@j.email.ne.jp
  MFC after:2 weeks

Changes:
  head/usr.bin/systat/Makefile
  head/usr.bin/systat/extern.h
  head/usr.bin/systat/main.c
  head/usr.bin/systat/zarc.c

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
freebsd-bugs@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-bugs
To unsubscribe, send any mail to "freebsd-bugs-unsubscr...@freebsd.org"


[Bug 237664] [patch] systat -zarc to display cumulative rate and round down large numbers by SI units

2020-05-11 Thread bugzilla-noreply
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=237664

Michael Reifenberger  changed:

   What|Removed |Added

 Status|New |In Progress

--- Comment #5 from Michael Reifenberger  ---
Hi,
committed to -current.

Thanks for providing!

greetings
---
mike

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
freebsd-bugs@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-bugs
To unsubscribe, send any mail to "freebsd-bugs-unsubscr...@freebsd.org"


[Bug 237664] [patch] systat -zarc to display cumulative rate and round down large numbers by SI units

2020-05-11 Thread bugzilla-noreply
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=237664

--- Comment #6 from commit-h...@freebsd.org ---
A commit references this bug:

Author: mr
Date: Mon May 11 21:22:16 UTC 2020
New revision: 360929
URL: https://svnweb.freebsd.org/changeset/base/360929

Log:
  Add missing sysput.c

  PR:   237664
  Submitted by: o...@j.email.ne.jp
  Reported by:  imb, cy

Changes:
  head/usr.bin/systat/sysput.c

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
freebsd-bugs@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-bugs
To unsubscribe, send any mail to "freebsd-bugs-unsubscr...@freebsd.org"


[Bug 246385] SIGCHLD dropped if generated while blocked in sigfastblock

2020-05-11 Thread bugzilla-noreply
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=246385

--- Comment #1 from commit-h...@freebsd.org ---
A commit references this bug:

Author: kib
Date: Mon May 11 22:38:32 UTC 2020
New revision: 360940
URL: https://svnweb.freebsd.org/changeset/base/360940

Log:
  sigfastblock: fix delivery of the pending signals in single-threaded
processes.

  If single-threaded process receives a signal during critical section
  established by sigfastblock(2) word, unblock did not caused signal
  delivery because sigfastblock(SIGFASTBLOCK_UNBLOCK) failed to request
  ast handling of the pending signals.

  Set TDF_ASTPENDING | TDF_NEEDSIGCHK on unblock or when kernel forces
  end of sigfastblock critical section, to cause syscall exit to recheck
  and deliver any signal pending.

  Reported by:  corydo...@ridiculousfish.com
  PR:   246385
  Sponsored by: The FreeBSD Foundation

Changes:
  head/sys/kern/kern_sig.c

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
freebsd-bugs@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-bugs
To unsubscribe, send any mail to "freebsd-bugs-unsubscr...@freebsd.org"


[Bug 246385] SIGCHLD dropped if generated while blocked in sigfastblock

2020-05-11 Thread bugzilla-noreply
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=246385

--- Comment #2 from Alan Somers  ---
Wow, fast work Kib!  Does this change need to be MFCed?

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
freebsd-bugs@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-bugs
To unsubscribe, send any mail to "freebsd-bugs-unsubscr...@freebsd.org"


[Bug 246385] SIGCHLD dropped if generated while blocked in sigfastblock

2020-05-11 Thread bugzilla-noreply
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=246385

--- Comment #3 from Conrad Meyer  ---
I don't believe fastblock is in any stable/.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
freebsd-bugs@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-bugs
To unsubscribe, send any mail to "freebsd-bugs-unsubscr...@freebsd.org"


[Bug 246215] [rtld] fails for i386 on amd64 if auxv does not contain PAGESIZES

2020-05-11 Thread bugzilla-noreply
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=246215

Ed Maste  changed:

   What|Removed |Added

 Status|New |In Progress

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
freebsd-bugs@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-bugs
To unsubscribe, send any mail to "freebsd-bugs-unsubscr...@freebsd.org"


[Bug 224436] vt: CONS_CLRHIST (vidcontrol -C) not implemented

2020-05-11 Thread bugzilla-noreply
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=224436

Jason A. Harmening  changed:

   What|Removed |Added

 CC||j...@freebsd.org
   Assignee|b...@freebsd.org|j...@freebsd.org

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
freebsd-bugs@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-bugs
To unsubscribe, send any mail to "freebsd-bugs-unsubscr...@freebsd.org"


[Bug 246412] Return EISDIR when reading a directory

2020-05-11 Thread bugzilla-noreply
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=246412

Xin LI  changed:

   What|Removed |Added

 CC||standa...@freebsd.org
   Assignee|b...@freebsd.org|delp...@freebsd.org

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
freebsd-bugs@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-bugs
To unsubscribe, send any mail to "freebsd-bugs-unsubscr...@freebsd.org"


[Bug 246412] Return EISDIR when reading a directory

2020-05-11 Thread bugzilla-noreply
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=246412

Bug ID: 246412
   Summary: Return EISDIR when reading a directory
   Product: Base System
   Version: CURRENT
  Hardware: Any
OS: Any
Status: New
  Severity: Affects Only Me
  Priority: ---
 Component: kern
  Assignee: b...@freebsd.org
  Reporter: delp...@freebsd.org

FreeBSD have shipped with readdir() and allowing read() on directories is not
very useful.

Other POSIX compliant operating systems like macOS returns EISDIR when
read()ing a directory too, it is allowed in the specification:

Quote https://pubs.opengroup.org/onlinepubs/009695399/functions/read.html :

EISDIR

[XSI] The fildes argument refers to a directory and the implementation does not
allow the directory to be read using read() or pread(). The readdir() function
should be used instead.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
freebsd-bugs@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-bugs
To unsubscribe, send any mail to "freebsd-bugs-unsubscr...@freebsd.org"


[Bug 246413] boot from 12.1 DVD iso as MBR causes panic zfree wild pointer

2020-05-11 Thread bugzilla-noreply
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=246413

Bug ID: 246413
   Summary: boot from 12.1 DVD iso as MBR causes panic zfree wild
pointer
   Product: Base System
   Version: 12.1-RELEASE
  Hardware: amd64
OS: Any
Status: New
  Severity: Affects Some People
  Priority: ---
 Component: kern
  Assignee: b...@freebsd.org
  Reporter: jmill...@sprynet.com

This is related to 242106. My W520 lenovo thinkpad tries MBR boot before UEFI
boot from DVD. Booting as MBR causes the panic. If I change the BIOS to try
UEFI before MBR it works fine. The workaround for 242106 is to tell the VM to
boot UEFI first.

The text of the panic is:

CD Loader 1.2

Building the boot loader arguments
Looking up /BOOT/LOADER... found
Relocating the loader and BTX
Starting the BTX loader

BTX loader 1.00 BTX version is 1.02
Consoles: internal video/keyboard
BIOS CD is cd0
BIOS drive C: is disk0
BIOS 630kb/3125884kb available memory

FreeBSD/x86 bootstrap loader, Revision 1.1
panic: zfree(90xbd69c6b0,8224): wild pointer
--> Press a key on the console to reboot <--

I reproduced this with disk and dvd ISO's

The code should probably sanity check the startup environment. This is not high
priority as the work-around is easy. This bug will serve to document the
problem and the work-around.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
freebsd-bugs@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-bugs
To unsubscribe, send any mail to "freebsd-bugs-unsubscr...@freebsd.org"