[Bug 243287] "make -C /usr/src/release OSRELEASE=something release" gives errors on stable/12 amd64

2020-01-16 Thread bugzilla-noreply
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=243287

trond.endres...@ximalas.info changed:

   What|Removed |Added

 Status|Closed  |Open
 Resolution|FIXED   |---

--- Comment #4 from trond.endres...@ximalas.info ---
Still, something is not right.

First, I ran:

# make -C /usr/src/release -D NO_INSTALLEXTRAKERNELS NODOC=1 NOPORTS=1 NOSRC=1
disc1.iso memstick.img

Next, I ran:

# make -C /usr/src/release -D NO_INSTALLEXTRAKERNELS NODOC=1 NOPORTS=1 NOSRC=1
OSRELEASE=`hostname`-`uname -s`-`uname -r`-`uname -p` disc1.iso memstick.img

The latter command gave this output:

Building /usr/obj/usr/src/amd64.amd64/release/disc1.iso
200+0 records in
200+0 records out
819200 bytes transferred in 0.004640 secs (176549289 bytes/sec)
newfs_msdos: cannot get number of sectors per track: Operation not supported
newfs_msdos: cannot get number of heads: Operation not supported
/dev/md0: 1557 sectors in 1557 FAT12 clusters (512 bytes/cluster)
BytesPerSec=512 SecPerClust=1 ResSectors=1 FATs=2 RootDirEnts=512 Sectors=1600
Media=0xf8 FATsecs=5 SecPerTrack=63 Heads=1 HiddenSecs=0
1+0 records in
1+0 records out
32768 bytes transferred in 0.000188 secs (173858602 bytes/sec)
`memstick.img' is up to date.

I was expecting filenames such as

enterprise.ximalas.info-FreeBSD-12.1-STABLE-amd64disc1.iso
and
enterprise.ximalas.info-FreeBSD-12.1-STABLE-amd64memstick.img

or preferably

enterprise.ximalas.info-FreeBSD-12.1-STABLE-amd64-disc1.iso
and
enterprise.ximalas.info-FreeBSD-12.1-STABLE-amd64-memstick.img

Or is OSRELEASE only relevant when doing "make -C /usr/src/release ...
install"?

Maybe changing release(7) is in order. It states near the end:

 OSRELEASEOptional base name for generated media images (e.g.,
  FreeBSD-9.0-RC2-amd64).  Defaults to the output of
  `uname -s`-`uname -r`-`uname -p` within the chroot.

As far as I can tell, the last statement is false unless it relates to
release.sh, in which case it should be moved nearer to the description of
release.sh.

My source tree is pretty much up-to-date:

# svn info /usr/src
Path: /usr/src
Working Copy Root Path: /usr/src
URL: svn://svn.ximalas.info/freebsd/base/stable/12
Relative URL: ^/stable/12
Repository Root: svn://svn.ximalas.info/freebsd/base
Repository UUID: ccf9f872-aa2e-dd11-9fc8-001c23d0bc1f
Revision: 356777
Node Kind: directory
Schedule: normal
Last Changed Author: dim
Last Changed Rev: 356777
Last Changed Date: 2020-01-16 08:02:09 +0100 (Thu, 16 Jan 2020)

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
freebsd-bugs@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-bugs
To unsubscribe, send any mail to "freebsd-bugs-unsubscr...@freebsd.org"


[Bug 237463] aacraid(4) doesn't work on powerpc64

2020-01-16 Thread bugzilla-noreply
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=237463

--- Comment #2 from Leandro Lupori  ---
The main issue is that the controller expects FIBs in little-endian (LE) format
and the driver assumes host is LE, performing no endianness conversion.

There are several structures that a FIB may carry, and all of their fields
would need to be converted: to LE when going to controller and to big-endian
(BE) when coming from the controller.

So far, after converting device info FIBs, the driver is able to show correct
device information.
I'll convert the other structures, and test if the driver can then start to
perform disk I/O.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
freebsd-bugs@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-bugs
To unsubscribe, send any mail to "freebsd-bugs-unsubscr...@freebsd.org"


[Bug 224415] 460.status-mail-rejects and 520.pfdenied appear broken

2020-01-16 Thread bugzilla-noreply
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=224415

p...@hedeland.org changed:

   What|Removed |Added

 CC||p...@hedeland.org

--- Comment #3 from p...@hedeland.org ---
(In reply to sigsys from comment #2)
Agreed, this is a regression in base r301226, still present in 12.1-RELEASE.
Agreed on the fix too.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
freebsd-bugs@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-bugs
To unsubscribe, send any mail to "freebsd-bugs-unsubscr...@freebsd.org"


[Bug 243392] vmx driver input buffer corruption

2020-01-16 Thread bugzilla-noreply
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=243392

Bug ID: 243392
   Summary: vmx driver input buffer corruption
   Product: Base System
   Version: 12.1-RELEASE
  Hardware: Any
OS: Any
Status: New
  Severity: Affects Some People
  Priority: ---
 Component: kern
  Assignee: b...@freebsd.org
  Reporter: alexandr.oleyni...@gmail.com

Tested on 12.1-Release, 12.1-Release-p1 and with patch regarding tso from
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=236999

All VM running on the same host with VMware ESXi, 6.7.0, 15160138 
 1 VM - FreeBSD 12.1
 2 VM - Any OS (tested with different, second one is irellevant)

After some network load packets in the interface queue being to get stuck

Reproduce in differents enviroment with different netowrk load
Easiest way to reproduce - copy large file from second VM to FreeBSD using
samba or ftp.
Some output examples:
172.31.255.2 - FreeBSD
172.31.255.3 - second VM

Ping:
8008 bytes from 172.31.255.3: icmp_seq=321 ttl=128 time=0.375 ms
8008 bytes from 172.31.255.3: icmp_seq=322 ttl=128 time=0.229 ms
8008 bytes from 172.31.255.3: icmp_seq=323 ttl=128 time=0.179 ms
8008 bytes from 172.31.255.3: icmp_seq=324 ttl=128 time=0.203 ms
8008 bytes from 172.31.255.3: icmp_seq=325 ttl=128 time=0.278 ms
8008 bytes from 172.31.255.3: icmp_seq=326 ttl=128 time=0.178 ms
8008 bytes from 172.31.255.3: icmp_seq=327 ttl=128 time=2.204 ms
8008 bytes from 172.31.255.3: icmp_seq=328 ttl=128 time=0.226 ms
8008 bytes from 172.31.255.3: icmp_seq=329 ttl=128 time=0.221 ms
8008 bytes from 172.31.255.3: icmp_seq=330 ttl=128 time=0.466 ms
8008 bytes from 172.31.255.3: icmp_seq=331 ttl=128 time=0.253 ms   
8008 bytes from 172.31.255.3: icmp_seq=350 ttl=128 time=1020.494 ms  <-- start
file copy
8008 bytes from 172.31.255.3: icmp_seq=362 ttl=128 time=1037.839 ms
8008 bytes from 172.31.255.3: icmp_seq=381 ttl=128 time=4162.085 ms
8008 bytes from 172.31.255.3: icmp_seq=382 ttl=128 time=5202.940 ms
8008 bytes from 172.31.255.3: icmp_seq=383 ttl=128 time=6200.121 ms
8008 bytes from 172.31.255.3: icmp_seq=385 ttl=128 time=7261.939 ms
8008 bytes from 172.31.255.3: icmp_seq=386 ttl=128 time=7200.745 ms
8008 bytes from 172.31.255.3: icmp_seq=390 ttl=128 time=4100.259 ms


tcpdump after propblem appear:

# tcpdump -i vmx1 icmp
tcpdump: verbose output suppressed, use -v or -vv for full protocol decode
listening on vmx1, link-type EN10MB (Ethernet), capture size 262144 bytes
16:09:41.700833 IP 172.31.255.2 > 172.31.255.3: ICMP echo request, id 23149,
seq 0, length 8008
16:09:42.727307 IP 172.31.255.2 > 172.31.255.3: ICMP echo request, id 23149,
seq 1, length 8008
16:09:43.761866 IP 172.31.255.2 > 172.31.255.3: ICMP echo request, id 23149,
seq 2, length 8008
16:09:43.762117 IP 172.31.255.3 > 172.31.255.2: ICMP echo reply, id 23149, seq
0, length 8008
16:09:44.771901 IP 172.31.255.2 > 172.31.255.3: ICMP echo request, id 23149,
seq 3, length 8008
16:09:44.978178 IP truncated-ip - 7810 bytes missing! 172.31.255.3 >
172.31.255.2: ICMP echo reply, id 23149, seq 1, length 8008
16:09:45.788996 IP 172.31.255.2 > 172.31.255.3: ICMP echo request, id 23149,
seq 4, length 8008
16:09:46.039983 IP truncated-ip - 7928 bytes missing! 172.31.255.3 >
172.31.255.2: ICMP echo reply, id 23149, seq 2, length 8008
16:09:46.290583 IP truncated-ip - 7928 bytes missing! 172.31.255.3 >
172.31.255.2: ICMP echo reply, id 23149, seq 3, length 8008
16:09:46.801911 IP 172.31.255.2 > 172.31.255.3: ICMP echo request, id 23149,
seq 5, length 8008
16:09:47.861870 IP 172.31.255.2 > 172.31.255.3: ICMP echo request, id 23149,
seq 6, length 8008
16:09:48.071886 IP truncated-ip - 7822 bytes missing! 172.31.255.3 >
172.31.255.2: ICMP echo reply, id 23149, seq 4, length 8008
16:09:48.871905 IP 172.31.255.2 > 172.31.255.3: ICMP echo request, id 23149,
seq 7, length 8008
16:09:49.802033 IP truncated-ip - 7928 bytes missing! 172.31.255.3 >
172.31.255.2: ICMP echo reply, id 23149, seq 5, length 8008
16:09:49.891036 IP 172.31.255.2 > 172.31.255.3: ICMP echo request, id 23149,
seq 8, length 8008
16:09:50.802001 IP truncated-ip - 7928 bytes missing! 172.31.255.3 >
172.31.255.2: ICMP echo reply, id 23149, seq 6, length 8008
16:09:50.901923 IP 172.31.255.2 > 172.31.255.3: ICMP echo request, id 23149,
seq 9, length 8008
16:09:51.961848 IP 172.31.255.2 > 172.31.255.3: ICMP echo request, id 23149,
seq 10, length 8008

Seems like new arrived packets pushed out old packets from the queue

After some time even more than 40 seconds gap can exist between sending and
receiving packet.

tcpdump running on the same time on second VM shows sending a response
immediately after receiving request.

Disabling/enabling any driver features like tso, csum, etc, changing mtu
irrelevant to the problem.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
freebsd-bugs@freebsd.org mailing list
https

[Bug 243287] "make -C /usr/src/release OSRELEASE=something release" gives errors on stable/12 amd64

2020-01-16 Thread bugzilla-noreply
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=243287

--- Comment #5 from Glen Barber  ---
OSRELEASE is only relevant with the install target.

323 install:release-install vm-install
324
325 release-install:
326 .if defined(DESTDIR) && !empty(DESTDIR)
327 mkdir -p ${DESTDIR}
328 .endif

330 .for I in ${IMAGES}
331 cp -p ${I} ${DESTDIR}/${OSRELEASE}-${I}

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
freebsd-bugs@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-bugs
To unsubscribe, send any mail to "freebsd-bugs-unsubscr...@freebsd.org"


[Bug 243393] [ath] Array can be accessed out of bounds

2020-01-16 Thread bugzilla-noreply
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=243393

Bug ID: 243393
   Summary: [ath] Array can be accessed out of bounds
   Product: Base System
   Version: CURRENT
  Hardware: Any
OS: Any
Status: New
  Severity: Affects Some People
  Priority: ---
 Component: kern
  Assignee: b...@freebsd.org
  Reporter: ghuckri...@blackberry.com

Overview:

Through code inspection it was discovered that some 'for' loops in the ath
module can cause an array to go out of bounds. 

See the following files for reference:
https://svnweb.freebsd.org/base/head/sys/dev/ath/ath_hal/ah_eeprom_v4k.c?annotate=326695
https://svnweb.freebsd.org/base/head/sys/dev/ath/ath_hal/ah_eeprom_v4k.h?annotate=326695
Similar issue with the following 2 files:
https://svnweb.freebsd.org/base/head/sys/dev/ath/ath_hal/ah_eeprom_9287.c?annotate=326695
https://svnweb.freebsd.org/base/head/sys/dev/ath/ath_hal/ah_eeprom_9287.h?annotate=326695

Details:
In the 'for' loop at ah_eeprom_v4k.c:243, ctlEdges is accesses with index 'j'
in the second dimension at ah_eeprom_v4k.c:253 and ah_eeprom_v4k.c:254.  'j' is
looped up to 8 times (NUM_EDGES is defined as 8 at ah_eeprom_v4k.h:178) but
ctlEdges is declared with 4 indices in the second dimension (ctrEdges declared
at ah_eeprom_v4k.h:153 with  AR5416_4K_NUM_BAND_EDGES which is defined as 4 at
ah_eeprom_v4k.h:50).

Perhaps the 'for' loop should only iterate AR5416_4K_NUM_BAND_EDGES times? Or
not use 'j' for the ctlEdges index?


Steps to Reproduce: n.a. (code inspection)

Actual Results: n.a. (code inspection)

Expected Results: n.a. (code inspection)

Build Date & Hardware:
svn r326695

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
freebsd-bugs@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-bugs
To unsubscribe, send any mail to "freebsd-bugs-unsubscr...@freebsd.org"


[Bug 243287] "make -C /usr/src/release OSRELEASE=something release" gives errors on stable/12 amd64

2020-01-16 Thread bugzilla-noreply
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=243287

--- Comment #6 from commit-h...@freebsd.org ---
A commit references this bug:

Author: gjb
Date: Thu Jan 16 15:07:52 UTC 2020
New revision: 356792
URL: https://svnweb.freebsd.org/changeset/base/356792

Log:
  Update release(7) to note OSRELEASE is only relevant when the
  'install' target is invoked.

  While here, bump the sample output version name, and explicitly
  add the 'obj' target to avoid polluting the src checkout.

  Submitted by: Trond Endrestol
  PR:   243287 (related)
  MFC after:3 days
  Sponsored by: Rubicon Communications, LLC (netgate.com)

Changes:
  head/share/man/man7/release.7

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
freebsd-bugs@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-bugs
To unsubscribe, send any mail to "freebsd-bugs-unsubscr...@freebsd.org"


[Bug 243287] "make -C /usr/src/release OSRELEASE=something release" gives errors on stable/12 amd64

2020-01-16 Thread bugzilla-noreply
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=243287

Glen Barber  changed:

   What|Removed |Added

 Status|Open|In Progress

--- Comment #7 from Glen Barber  ---
(In reply to Glen Barber from comment #5)

I have updated the release(7) manual page to reflect such.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
freebsd-bugs@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-bugs
To unsubscribe, send any mail to "freebsd-bugs-unsubscr...@freebsd.org"


[Bug 243394] zone1970.tab file is missing from /usr/share/zoneinfo/

2020-01-16 Thread bugzilla-noreply
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=243394

Bug ID: 243394
   Summary: zone1970.tab file is missing from /usr/share/zoneinfo/
   Product: Base System
   Version: 12.1-RELEASE
  Hardware: Any
OS: Any
Status: New
  Severity: Affects Only Me
  Priority: ---
 Component: misc
  Assignee: b...@freebsd.org
  Reporter: rodr...@freebsd.org

The tz zone description file zone1970.tab who replaces the old zone.tab file,
is not present in fresh 12.1 installations even if the file is present in the
svn repository (freebsd/contrib/tzdata/zone1970.tab).

Only the zone.tab file, who is required for compatibility purposes is currently
available.

This table is intended as an aid for users, to help them select time zone data
appropriate for their practical needs

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
freebsd-bugs@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-bugs
To unsubscribe, send any mail to "freebsd-bugs-unsubscr...@freebsd.org"


[Bug 227285] File descriptor passing does not work reliably on SMP system

2020-01-16 Thread bugzilla-noreply
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=227285

Jason A. Harmening  changed:

   What|Removed |Added

 CC||j...@freebsd.org
   Assignee|b...@freebsd.org|j...@freebsd.org

--- Comment #10 from Jason A. Harmening  ---
Modified version of patch for review at https://reviews.freebsd.org/D23142

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
freebsd-bugs@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-bugs
To unsubscribe, send any mail to "freebsd-bugs-unsubscr...@freebsd.org"


[Bug 239803] Problem with concurrent transfer of file descriptors

2020-01-16 Thread bugzilla-noreply
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=239803

Jason A. Harmening  changed:

   What|Removed |Added

 Resolution|--- |DUPLICATE
 Status|New |Closed

--- Comment #3 from Jason A. Harmening  ---


*** This bug has been marked as a duplicate of bug 227285 ***

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
freebsd-bugs@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-bugs
To unsubscribe, send any mail to "freebsd-bugs-unsubscr...@freebsd.org"


[Bug 243396] pkgbase: non-svn tree results in "FreeBSD GENERIC kernel rUnversioned directory" pkg comment

2020-01-16 Thread bugzilla-noreply
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=243396

Bug ID: 243396
   Summary: pkgbase: non-svn tree results in "FreeBSD GENERIC
kernel rUnversioned directory" pkg comment
   Product: Base System
   Version: CURRENT
  Hardware: Any
OS: Any
Status: New
  Severity: Affects Only Me
  Priority: ---
 Component: misc
  Assignee: b...@freebsd.org
  Reporter: ema...@freebsd.org

>From the log:

===> Creating FreeBSD-kernel-generic-13.0.s20200116164028
FreeBSD GENERIC kernel rUnversioned directory

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
freebsd-bugs@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-bugs
To unsubscribe, send any mail to "freebsd-bugs-unsubscr...@freebsd.org"


[Bug 243057] wrong mbuf passed to key_sendup_mbuf by key_spdacquire

2020-01-16 Thread bugzilla-noreply
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=243057

--- Comment #2 from Mark Johnston  ---
(In reply to Masse Nicolas from comment #0)
How did you notice the problem?

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
freebsd-bugs@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-bugs
To unsubscribe, send any mail to "freebsd-bugs-unsubscr...@freebsd.org"


[Bug 243392] vmx driver input buffer corruption

2020-01-16 Thread bugzilla-noreply
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=243392

Andriy Gapon  changed:

   What|Removed |Added

 CC||pkel...@freebsd.org
   Assignee|b...@freebsd.org|n...@freebsd.org

--- Comment #1 from Andriy Gapon  ---
I am seeing a somewhat similar problem.
When scp-ing a large file from a hardware host to a VM with vmxnet3 interface,
I see that the copy starts very fast at first, but then it stalls for many
seconds and then suddenly it becomes fast again and the copy completes.
If a file is very large, then the stall+recovery can happen a few times before
the copy is complete.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
freebsd-bugs@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-bugs
To unsubscribe, send any mail to "freebsd-bugs-unsubscr...@freebsd.org"


[Bug 243321] pmcannotate depends on objdump

2020-01-16 Thread bugzilla-noreply
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=243321

--- Comment #3 from Ed Maste  ---
Mark also found tools/tools/shlib-compat/shlib-compat.py using objdump

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
freebsd-bugs@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-bugs
To unsubscribe, send any mail to "freebsd-bugs-unsubscr...@freebsd.org"


[Bug 243321] pmcannotate depends on objdump

2020-01-16 Thread bugzilla-noreply
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=243321

--- Comment #4 from Conrad Meyer  ---
tools/tools also contains, e.g., scripts that use Python, which is clearly not
in base.  Is shlib-compat something that should be moved out of tools/tools? 
If not, I think its dependency on objdump can safely be ignored.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
freebsd-bugs@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-bugs
To unsubscribe, send any mail to "freebsd-bugs-unsubscr...@freebsd.org"


[Bug 243321] pmcannotate depends on objdump

2020-01-16 Thread bugzilla-noreply
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=243321

--- Comment #5 from Ed Maste  ---
(In reply to Conrad Meyer from comment #4)
Yes for stuff in tools/ I think it's fair for the user to install both python
and GNU binutils

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
freebsd-bugs@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-bugs
To unsubscribe, send any mail to "freebsd-bugs-unsubscr...@freebsd.org"


[Bug 224415] 460.status-mail-rejects and 520.pfdenied appear broken

2020-01-16 Thread bugzilla-noreply
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=224415

--- Comment #4 from sig...@gmail.com ---
(In reply to per from comment #3)
BTW I've been using that fix on two hosts running pf (including one with
blacklistd running) and the periodic reports are still fine whenever I look at
them (on 11.3 and recent 12-STABLE).

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
freebsd-bugs@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-bugs
To unsubscribe, send any mail to "freebsd-bugs-unsubscr...@freebsd.org"


[Bug 224415] 460.status-mail-rejects and 520.pfdenied appear broken

2020-01-16 Thread bugzilla-noreply
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=224415

--- Comment #5 from p...@hedeland.org ---
(In reply to sigsys from comment #4)
Yes, both the bug and the fix should be pretty obvious to anyone with a
reasonable knowledge of shell scripting (clearly the intent is that the "" in
the 'for' list should result in the first loop round executing the equivalent
of 'pfctl -a "" -sr -v -z' to get the statistics for the "default anchor" /
"main ruleset" - but since an unquoted variable set to "nothing" doesn't cause
an argument to be passed, the resulting command is instead effectively 'pfctl
-a -sr -v -z', which doesn't produce any statistics).

I have to wonder why your fix hasn't been applied in over a year's time - do we
need to create a separate bug report for 520.pfdenied, so as to not be
"blocked" by the challenged and unconfirmed report for 460.status-mail-rejects
here? (FWIW, it has always worked fine for me, and still does in 12.1-RELEASE.)

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
freebsd-bugs@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-bugs
To unsubscribe, send any mail to "freebsd-bugs-unsubscr...@freebsd.org"


[Bug 243393] [ath] Array can be accessed out of bounds

2020-01-16 Thread bugzilla-noreply
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=243393

Mark Linimon  changed:

   What|Removed |Added

   Assignee|b...@freebsd.org|wirel...@freebsd.org

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
freebsd-bugs@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-bugs
To unsubscribe, send any mail to "freebsd-bugs-unsubscr...@freebsd.org"


[Bug 243400] diskinfo json output

2020-01-16 Thread bugzilla-noreply
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=243400

Bug ID: 243400
   Summary: diskinfo json output
   Product: Base System
   Version: 12.1-STABLE
  Hardware: Any
OS: Any
Status: New
  Severity: Affects Only Me
  Priority: ---
 Component: bin
  Assignee: b...@freebsd.org
  Reporter: harri...@glsan.com

Created attachment 210803
  --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=210803&action=edit
diff from head to provide json output

it would be nice to have the option to have diskinfo output json in addition to
the correct text output.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
freebsd-bugs@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-bugs
To unsubscribe, send any mail to "freebsd-bugs-unsubscr...@freebsd.org"


[Bug 243400] diskinfo json output

2020-01-16 Thread bugzilla-noreply
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=243400

harri...@glsan.com changed:

   What|Removed |Added

   Severity|Affects Only Me |Affects Many People
 CC||harri...@glsan.com

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
freebsd-bugs@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-bugs
To unsubscribe, send any mail to "freebsd-bugs-unsubscr...@freebsd.org"


[Bug 243401] ahci driver problems with Marvell 88SE9230 (Dell BOSS-S1)

2020-01-16 Thread bugzilla-noreply
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=243401

Bug ID: 243401
   Summary: ahci driver problems with Marvell 88SE9230 (Dell
BOSS-S1)
   Product: Base System
   Version: 11.3-RELEASE
  Hardware: Any
OS: Any
Status: New
  Severity: Affects Some People
  Priority: ---
 Component: kern
  Assignee: b...@freebsd.org
  Reporter: p...@lysator.liu.se

This feels more like a firmware problem than a driver problem but since it
apparently works in Windows and Linux, but not in FreeBSD I figured I'd report
it here anyway... 

(Probably not meaningful to try to report it to Dell since FreeBSD isn't
officially supported by them)


Dell BOSS-S1 (Marvell 88SE9230 based) M.2 "RAID" cards running Dells latest
firmware (2.5.13.3022 A06 or 2.5.13.3022 A05) does something strange - when the
kernel has loaded (from the drives on this card) it fails to detect the disks
("unconfigured" disks, non-RAID setup) and then root fs mounting fails...

(We have two M.2 SSDs connected to that controller)


With firmware 2.5.13.3016 A04 it gives a couple of errors at kernel boot time,
but does detect the disks and the system boots.

With firmware 2.5.13.3011 A03, 2.5.13.2009 A02 or 2.5.13.2008 A01 no errors are
printed and the disks are found just fine.

(But there are bugs fixed in the later releases that probably would be nice to
have.. I have had M.2 drive go "offline" for me at 2008/A01-firmware so that's
why I tried the later versions...


A summary of the (Dell) firmware fixes and my test results:

2.5.13.3022 A06
  Fixes: None
  Enhancement: Added support for 15G platforms

2.5.13.3020 A05
  Status:
  - Does not work, gives errors:
- 'ahcich16: stopping AHCI engine failed'
  - Detects a 'pass23', but no disk devices:
  pass23 at ahcich16 bus 0 scbus19 target 0 lun 0
  pass23:  Removable Processor SCSI device
  pass23: Serial Number HKDP221516WL
  pass23: 150.000MB/s transfers (SATA 1.x, UDMA4, ATAPI 12bytes, PIO
8192bytes)
  Fixes:
  - Fixed an issue where system will hang during
Boot when PERC is in HBA mode with BOSS-S1
  - When CLI is running, default temporary file
directory & permission in Linux and ESXi Operating
systems are changed as appropriate
  Enhancement: N/A

2.5.13.3016 A04
  Status:
  - Works and detects all disks, but gives errors about:
- 'ahcich14: stopping AHCI engine failed'
- 'ahcich15: stopping AHCI engine failed'
- 'ahcich16: stopping AHCI engine failed'
  Fixes:
  - Fixed a behavior of BOSS-S1 firmware incorrectly marking M.2 drive
offline/failed
  - Fixed a behavior where ESXi Host goes unresponsive
  - Fixed a behavior where BOSS-S1 Management path will not respond to
Management commands
  - Fixed a behavior where BOSS-S1 boot partition becomes inaccessible
  - Fixed a behavior where ESXi host results in PSOD due to unexpected I/O
timeout
  - Fixed a behavior where rebuild will not be proceed during error handling
condition
  Enhancement:
  - Enhanced/ Added MVCLI events for command timeout
  - Added SLES15 Support

2.5.13.3011 A03
  Status:
  - Works
  Fixes:
  - Fixed M.2 disk failure when medium error is present
  Enhancement:
  - Enhanced medium error handling

2.5.13.2009 A02
  Status:
  - Works
  Fixes:
  - Fixed Sideband functionality issue
  Enhancement:
  - Added support for Rollback of Controller Firmware through iDRAC/LC

2.5.13.2008 A01
  Status:
  - Works
  Initial release


Kernel boot output (the relevant parts) from a firmware 3016 A04 boot:

ahci2:  port
0x8028-0x802f,0x8034-0x8037,0x8020-0x8027,0x8030-0x8033,0x8\
000-0x801f mem 0xb880-0xb88007ff at device 0.0 numa-domain 0 on pci9
ahci2: AHCI v1.20 with 3 6Gbps ports, Port Multiplier not supported
ahci2: quirks=0x900
ahcich14:  at channel 0 on ahci2
ahcich15:  at channel 1 on ahci2
ahcich16:  at channel 2 on ahci2
...
ahcich16: stopping AHCI engine failed
ahcich16: stopping AHCI engine failed
...
ahcich16: stopping AHCI engine failed
ahcich15: stopping AHCI engine failed
ada0 at ahcich14 bus 0 scbus17 target 0 lun 0
ada0:  ACS-3 ATA SATA 3.x device
ada0: Serial Number PHDW817002Z4150A
ada0: 600.000MB/s transfers (SATA 3.x, UDMA6, PIO 512bytes)
ada0: Command Queueing enabled
ada0: 114473MB (234441648 512 byte sectors)
ada1 at ahcich15 bus 0 scbus18 target 0 lun 0
ada1:  ACS-3 ATA SATA 3.x device
ada1: Serial Number PHDW817002WC150A
ada1: 600.000MB/s transfers (SATA 3.x, UDMA6, PIO 512bytes)
ada1: Command Queueing enabled
ada1: 114473MB (234441648 512 byte sectors)
pass25 at ahcich16 bus 0 scbus19 target 0 lun 0
pass25:  Removable Processor SCSI device
pass25: Serial Number HKDP221516WL
pass25: 150.000MB/s transfers (SATA 1.x, UDMA4, ATAPI 12bytes, PIO 8192bytes)


On 3022 the ada0 and ada1 devices never get detected, and it only complains
about not being able to stop ahcich16, nothing about 14 & 15.

-- 
You are receiving this mail because:
You are the as

[Bug 224415] 460.status-mail-rejects and 520.pfdenied appear broken

2020-01-16 Thread bugzilla-noreply
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=224415

--- Comment #6 from sig...@gmail.com ---
(In reply to per from comment #5)
Everyone's too busy and/or that isn't their part of the tree. Also it's not a
very serious bug tbf.

Dunno if just bumping the PR even helps much, maybe it should be mailed to
whoever played with that script last.  It's probably the people mentioned in
that commit you found.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
freebsd-bugs@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-bugs
To unsubscribe, send any mail to "freebsd-bugs-unsubscr...@freebsd.org"


[Bug 243400] add json output to diskinfo(8)

2020-01-16 Thread bugzilla-noreply
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=243400

Mark Linimon  changed:

   What|Removed |Added

Summary|diskinfo json output|add json output to
   ||diskinfo(8)
   Keywords||patch

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
freebsd-bugs@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-bugs
To unsubscribe, send any mail to "freebsd-bugs-unsubscr...@freebsd.org"


[Bug 243400] add json output to diskinfo(8)

2020-01-16 Thread bugzilla-noreply
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=243400

--- Comment #1 from Conrad Meyer  ---
Usually this kind of thing is done with libxo -- rather than open-coding json,
the program creates some structured output stream and the user can invoke the
program and elect an output format (json, xml, etc).  I'm not an advocate for
libxo (I think it's terrible) but if you want json from this binary, that seems
to be the prevailing pattern.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
freebsd-bugs@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-bugs
To unsubscribe, send any mail to "freebsd-bugs-unsubscr...@freebsd.org"


[Bug 224415] 460.status-mail-rejects and 520.pfdenied appear broken

2020-01-16 Thread bugzilla-noreply
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=224415

--- Comment #7 from commit-h...@freebsd.org ---
A commit references this bug:

Author: kp
Date: Thu Jan 16 22:08:05 UTC 2020
New revision: 356816
URL: https://svnweb.freebsd.org/changeset/base/356816

Log:
  Fix pfdenied not returning any results

  When _a is empty we end up with an invalid invocation of pfctl, and no
output.
  We must add quotes to make it clear to pfctl that we're passing an empty
anchor
  name.

  PR:   224415
  Submitted by: sigsys AT gmail.com
  MFC after:2 weeks

Changes:
  head/usr.sbin/periodic/etc/security/520.pfdenied

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
freebsd-bugs@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-bugs
To unsubscribe, send any mail to "freebsd-bugs-unsubscr...@freebsd.org"


[Bug 224415] 460.status-mail-rejects and 520.pfdenied appear broken

2020-01-16 Thread bugzilla-noreply
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=224415

--- Comment #8 from p...@hedeland.org ---
(In reply to commit-hook from comment #7)
Thanks! (So whining in the PR does help.:-)

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
freebsd-bugs@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-bugs
To unsubscribe, send any mail to "freebsd-bugs-unsubscr...@freebsd.org"


[Bug 224415] 460.status-mail-rejects and 520.pfdenied appear broken

2020-01-16 Thread bugzilla-noreply
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=224415

--- Comment #9 from sig...@gmail.com ---
(In reply to commit-hook from comment #7)
Great. Thanks!

I checked a bit for the other problem in this PR while at it, and the periodic
file after 460.status-mail-rejects is 480.leapfile-ntpd, which does call fetch
(via the rc.d/ntpd script) to update the leap-seconds file. There were a lot of
commits to it since then, so the problem might not even be there anymore.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
freebsd-bugs@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-bugs
To unsubscribe, send any mail to "freebsd-bugs-unsubscr...@freebsd.org"


[Bug 237011] bsnmp fails to start with begemotSnmpdModulePath."pf"

2020-01-16 Thread bugzilla-noreply
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=237011

David Siebörger  changed:

   What|Removed |Added

 CC||drs-free...@sieborger.nom.z
   ||a

--- Comment #2 from David Siebörger  ---
We've run into this problem.  The patch that's been committed to HEAD fixes the
bug.

Would someone MFC it, please?  This bug has been present in 12.0-RELEASE and
12.1-RELEASE; it'd be great to have it fixed before 12.2-RELEASE.

Thanks.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
freebsd-bugs@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-bugs
To unsubscribe, send any mail to "freebsd-bugs-unsubscr...@freebsd.org"