[Bug 237940] struct nvme_health_information_page{} @ /usr/include/dev/nvme/nvme.h has alignment issues.
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=237940
Bug ID: 237940
Summary: struct nvme_health_information_page{} @
/usr/include/dev/nvme/nvme.h has alignment issues.
Product: Base System
Version: 12.0-RELEASE
Hardware: Any
OS: Any
Status: New
Severity: Affects Only Me
Priority: ---
Component: kern
Assignee: b...@freebsd.org
Reporter: root+free...@linuxpedia.pl
struct nvme_health_information_page {
uint8_t critical_warning;
uint16_ttemperature;
uint8_t available_spare;
/* ... */
} __packed __aligned(4);
has issues with alignment: `temperature` field can't be properly aligned on any
current architecture which seems to defeat the `__aligned(4)` hint.
What has bitten me today is that it confuses some code-generating tools, like
Rust's bindgen. I already filed a bug to them, as they treat __packed
__aligned(4) as __packed(4) - which has a *totally* different meaning - but it
would be nice to have some BSD compiler guru took a glimpse at this particular
structure and shed some light on whether __aligned(4) is OK here.
And yes, I know this structure layout is not BSD's idea ¯\_(ツ)_/¯
--
You are receiving this mail because:
You are the assignee for the bug.
___
freebsd-bugs@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-bugs
To unsubscribe, send any mail to "freebsd-bugs-unsubscr...@freebsd.org"
[Bug 234793] Failed unknown for $USER in sshd logs even if I got authenticated
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=234793 Vincent Bentley changed: What|Removed |Added CC||vi...@vincentbentley.co.uk --- Comment #16 from Vincent Bentley --- Issue still present on 12.0-RELEASE-p5 -- You are receiving this mail because: You are the assignee for the bug. ___ freebsd-bugs@freebsd.org mailing list https://lists.freebsd.org/mailman/listinfo/freebsd-bugs To unsubscribe, send any mail to "freebsd-bugs-unsubscr...@freebsd.org"
[Bug 187015] [panic] make_dev_credv: bad si_name (error=17, si_name=agpgart)
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=187015 Kurt Jaeger changed: What|Removed |Added Version|10.0-STABLE |12.0-RELEASE -- You are receiving this mail because: You are the assignee for the bug. ___ freebsd-bugs@freebsd.org mailing list https://lists.freebsd.org/mailman/listinfo/freebsd-bugs To unsubscribe, send any mail to "freebsd-bugs-unsubscr...@freebsd.org"
[Bug 187015] [panic] make_dev_credv: bad si_name (error=17, si_name=agpgart)
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=187015 --- Comment #18 from Kurt Jaeger --- (In reply to fred+freebsdbugzilla from comment #6) https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=136327 discusses the xpt issue. -- You are receiving this mail because: You are the assignee for the bug. ___ freebsd-bugs@freebsd.org mailing list https://lists.freebsd.org/mailman/listinfo/freebsd-bugs To unsubscribe, send any mail to "freebsd-bugs-unsubscr...@freebsd.org"
[Bug 237940] struct nvme_health_information_page{} @ /usr/include/dev/nvme/nvme.h has alignment issues.
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=237940 Conrad Meyer changed: What|Removed |Added CC||c...@freebsd.org --- Comment #1 from Conrad Meyer --- Yes, the temperature field is inherently misaligned. The __aligned(4) was added in r240671 as a hack for printing out the nvme_controller_data and nvme_namespace_data pages as 32-bit hex values with a naive cast -- avoiding a -Wcast-align warning. At the time, nvme_health_information_page wasn't used by nvmecontrol -- it was probably just added at the same time because it was also __packed. Today we mostly print the page using a specialized printer, print_log_health, rather than any uint32 cast hex hack. print_hex -> print_dwords still uses this hack for the log page data if -x flag is specified, but print functions take the raw void* buffer pointer rather than a structure pointer, so we can probably drop the __aligned attribute. Additionally, get_log_buffer() allocates the buffer using plain malloc() with the log page size. This implicitly provides 4-byte alignment because FreeBSD only supports 32-bit and 64-bit architectures, and the log page is >4 bytes in size, so any standard C compliant malloc must provide 4-byte alignment on any platform FreeBSD runs on. It might be more clear to use aligned_alloc() to provide that guarantee explicitly instead, but I don't feel strongly about it. Tl;dr: I think we can drop the __aligned(4) attribute now, and probably on the other structures as well. -- You are receiving this mail because: You are the assignee for the bug. ___ freebsd-bugs@freebsd.org mailing list https://lists.freebsd.org/mailman/listinfo/freebsd-bugs To unsubscribe, send any mail to "freebsd-bugs-unsubscr...@freebsd.org"
[Bug 237940] struct nvme_health_information_page{} @ /usr/include/dev/nvme/nvme.h has alignment issues.
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=237940 Conrad Meyer changed: What|Removed |Added Assignee|b...@freebsd.org|s...@freebsd.org CC||i...@freebsd.org -- You are receiving this mail because: You are the assignee for the bug. ___ freebsd-bugs@freebsd.org mailing list https://lists.freebsd.org/mailman/listinfo/freebsd-bugs To unsubscribe, send any mail to "freebsd-bugs-unsubscr...@freebsd.org"
[Bug 237954] /usr/bin/hexdump fails with capabilities error when used with -s option
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=237954 Bug ID: 237954 Summary: /usr/bin/hexdump fails with capabilities error when used with -s option Product: Base System Version: 12.0-STABLE Hardware: Any OS: Any Status: New Severity: Affects Only Me Priority: --- Component: bin Assignee: b...@freebsd.org Reporter: a...@freebsd.org Not sure if you're the right person, but you're the last who touched hexdump -s option's logic, so it's worth a shot. The hexdump on FreeBSD 12.0 fails with capabilities error when used with -s option: $hexdump -s 1 -n 1 -e '"%c""\n"' /etc/rc hexdump: /etc/rc: Capabilities insufficient It seems that it misses CAP_SEEK_TELL right. -- You are receiving this mail because: You are the assignee for the bug. ___ freebsd-bugs@freebsd.org mailing list https://lists.freebsd.org/mailman/listinfo/freebsd-bugs To unsubscribe, send any mail to "freebsd-bugs-unsubscr...@freebsd.org"
[Bug 237954] /usr/bin/hexdump fails with capabilities error when used with -s option
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=237954 Alex Kozlov changed: What|Removed |Added Assignee|b...@freebsd.org|kev...@freebsd.org -- You are receiving this mail because: You are the assignee for the bug. ___ freebsd-bugs@freebsd.org mailing list https://lists.freebsd.org/mailman/listinfo/freebsd-bugs To unsubscribe, send any mail to "freebsd-bugs-unsubscr...@freebsd.org"
[Bug 187015] [panic] make_dev_credv: bad si_name (error=17, si_name=agpgart)
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=187015 --- Comment #19 from Kubilay Kocak --- Created attachment 204441 --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=204441&action=edit Panic screenshot: 10.1 RC33 Intel 855GME Attach screenshot from comment 6 in case it goes away -- You are receiving this mail because: You are the assignee for the bug. ___ freebsd-bugs@freebsd.org mailing list https://lists.freebsd.org/mailman/listinfo/freebsd-bugs To unsubscribe, send any mail to "freebsd-bugs-unsubscr...@freebsd.org"
[Bug 136327] [sbp] [boot] Asus M3N78-EM motherboard cannot boot with generic kernel.
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=136327 Kubilay Kocak changed: What|Removed |Added See Also||https://bugs.freebsd.org/bu ||gzilla/show_bug.cgi?id=1870 ||15 -- You are receiving this mail because: You are the assignee for the bug. ___ freebsd-bugs@freebsd.org mailing list https://lists.freebsd.org/mailman/listinfo/freebsd-bugs To unsubscribe, send any mail to "freebsd-bugs-unsubscr...@freebsd.org"
[Bug 187015] agpgart: Panic make_dev_credv: bad si_name (error=17, si_name=agpgart)
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=187015 Kubilay Kocak changed: What|Removed |Added Flags||mfc-stable11?, ||mfc-stable12? Summary|[panic] make_dev_credv: bad |agpgart: Panic |si_name (error=17, |make_dev_credv: bad si_name |si_name=agpgart)|(error=17, si_name=agpgart) See Also||https://bugs.freebsd.org/bu ||gzilla/show_bug.cgi?id=1363 ||27 Keywords|patch |crash, needs-qa Severity|Affects Only Me |Affects Some People CC||dumbb...@freebsd.org, ||k...@freebsd.org --- Comment #20 from Kubilay Kocak --- We need an updated patch against latest CURRENT confirmed to resolve the issue dumbbell and kib may be able to help given graphics expertise and (not quite so recent) commits to this area of the tree. -- You are receiving this mail because: You are the assignee for the bug. ___ freebsd-bugs@freebsd.org mailing list https://lists.freebsd.org/mailman/listinfo/freebsd-bugs To unsubscribe, send any mail to "freebsd-bugs-unsubscr...@freebsd.org"
[Bug 219399] System panics after several hours of 14-threads-compilation orgies using poudriere on AMD Ryzen...
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=219399 Atif Aslam changed: What|Removed |Added CC||isongsoundtr...@gmail.com --- Comment #282 from Atif Aslam --- I hope she stays healthy https://isongsoundtrack.com/ fine and prettier. -- You are receiving this mail because: You are the assignee for the bug. ___ freebsd-bugs@freebsd.org mailing list https://lists.freebsd.org/mailman/listinfo/freebsd-bugs To unsubscribe, send any mail to "freebsd-bugs-unsubscr...@freebsd.org"
