[Bug 218980] dhclient incorrectly handles very long lease times, setting expiry in the past

2017-05-01 Thread bugzilla-noreply
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=218980

--- Comment #1 from Conrad Meyer  ---
Are you using 386 (ia32) or ppc32, by any chance?

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
freebsd-bugs@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-bugs
To unsubscribe, send any mail to "freebsd-bugs-unsubscr...@freebsd.org"


[Bug 218980] dhclient incorrectly handles very long lease times, setting expiry in the past

2017-05-01 Thread bugzilla-noreply
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=218980

--- Comment #2 from Conrad Meyer  ---
The DHCP lease time is a uint32, but expiry is stored as a time_t.  On 32-bit
Intel and PPC platforms, time_t is a (signed) int32.  That (or a 32-bit int) is
probably involved somewhere.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
freebsd-bugs@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-bugs
To unsubscribe, send any mail to "freebsd-bugs-unsubscr...@freebsd.org"


[Bug 218986] random harvesting on older i386 causing boot failure

2017-05-01 Thread bugzilla-noreply
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=218986

Bug ID: 218986
   Summary: random harvesting on older i386 causing boot failure
   Product: Base System
   Version: 11.0-STABLE
  Hardware: i386
OS: Any
Status: New
  Severity: Affects Some People
  Priority: ---
 Component: kern
  Assignee: freebsd-bugs@FreeBSD.org
  Reporter: dewa...@heuristicsystems.com.au

Created attachment 182205
  --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=182205&action=edit
VIA C3 dmesg.boot verbose

Using a build process that is successful on amd64 and i386 boxes with 
FreeBSD  11.0-STABLE FreeBSD 11.0-STABLE #0 r317498M: Fri Apr 28 03:52:30 AEST
2017 root@hathor:/110007/P/C3/sys   i386 1100512 1100512

The same usb drive was inserted into VIA C7 (i386) processor and booted as
expected.  With the older VIA C3 boxes the system stopped somewhere between
kernel and init.

The sequence of booting: bios, da0 was recognised, loader, kernel were
successful and the memory filesystem was loaded.  However, the harvestor is
unable to complete its work and impacts the recognition of da0 (usb), refer
enclosed dmesg.  Around the 300-310 second mark, the "random: unblocking
device" kicked in.  

Ultimately this is a workaround, in loader.conf
kern.cam.boot_delay="32"

It seems that 
random: harvesting attach, 8 bytes (4 bits) from umass0
causes the booting sequence to block.  Without the delay, the usb is loaded but
can't proceed with the handover from the kernel.  My guess is that init isn't
started (I've placed logging into /etc/rc to see if that starts, it doesn't).

I know that kern.random.harvest.mask is picked up via sysctl.conf, the value
there is 256, for SWI and CACHED; however we also tried a value of 0 in
loader.conf.  This didn't help :(  

>From the verbose boot log, it seems that very many devices (all?) are harvested
for entropy during the boot.  Unfortunately the umass device doesn't seem to
want to play.  

This is a slow 800MHz system with 1G memory which acts as a firewall device. 
It is a reliable old plug (workhorse) and we test it last, as its been the
least problematic.

I've included a "boot -v" log as it may shed further light.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
freebsd-bugs@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-bugs
To unsubscribe, send any mail to "freebsd-bugs-unsubscr...@freebsd.org"


[Bug 218987] [patch][linux] panic in linux_sys_futex() with FUTEX_WAKE_OP

2017-05-01 Thread bugzilla-noreply
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=218987

Bug ID: 218987
   Summary: [patch][linux] panic in linux_sys_futex() with
FUTEX_WAKE_OP
   Product: Base System
   Version: CURRENT
  Hardware: Any
OS: Any
Status: New
  Keywords: patch
  Severity: Affects Only Me
  Priority: ---
 Component: kern
  Assignee: freebsd-bugs@FreeBSD.org
  Reporter: luke...@gmail.com
  Keywords: patch

Created attachment 182207
  --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=182207&action=edit
patch for linux_sys_futex()

In linux compat layer, the syscall futex does not handle FUTEX_WAKE_OP well
when using the same address for arguments uaddr and uaddr2. 

The following linux program can result in kernel panic.

#define _GNU_SOURCE
#include 
#include 
#include 
#include 
#include 
#include 
#include 

#include 
#include 

static int
futex(int *uaddr, int futex_op, int val,
int val2, int *uaddr2, int val3)
{
return syscall(SYS_futex, uaddr, futex_op, val,
val2, uaddr, val3);
}

int main(void){
int ret;
int addr;

ret = futex(&addr, FUTEX_WAKE_OP, 1, 1, &addr, 2);
printf("ret: %d\n", ret);
}

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
freebsd-bugs@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-bugs
To unsubscribe, send any mail to "freebsd-bugs-unsubscr...@freebsd.org"


[Bug 218980] dhclient incorrectly handles very long lease times, setting expiry in the past

2017-05-01 Thread bugzilla-noreply
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=218980

b...@eager.cx changed:

   What|Removed |Added

   Hardware|Any |i386

--- Comment #3 from b...@eager.cx ---
Confirmed that this is on 386 (ia32).

This worked correctly in 11.0-RELEASE, but yesterday I updated to 11-STABLE and
it broke. Looks like the recent change to handle large values - didn't!

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
freebsd-bugs@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-bugs
To unsubscribe, send any mail to "freebsd-bugs-unsubscr...@freebsd.org"


[Bug 218987] [patch][linux] panic in linux_sys_futex() with FUTEX_WAKE_OP

2017-05-01 Thread bugzilla-noreply
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=218987

Dmitry Chagin  changed:

   What|Removed |Added

 CC||dcha...@freebsd.org
   Assignee|freebsd-bugs@FreeBSD.org|dcha...@freebsd.org
 Status|New |In Progress

--- Comment #1 from Dmitry Chagin  ---
take

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
freebsd-bugs@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-bugs
To unsubscribe, send any mail to "freebsd-bugs-unsubscr...@freebsd.org"


[Bug 210507] Linux compat function needed

2017-05-01 Thread bugzilla-noreply
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=210507

Dmitry Chagin  changed:

   What|Removed |Added

 Status|New |In Progress
   Assignee|freebsd-bugs@FreeBSD.org|dcha...@freebsd.org

--- Comment #9 from Dmitry Chagin  ---
take

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
freebsd-bugs@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-bugs
To unsubscribe, send any mail to "freebsd-bugs-unsubscr...@freebsd.org"


[Bug 218993] [patch] [ipfw] ipfw(8) may fail to remove rules

2017-05-01 Thread bugzilla-noreply
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=218993

Bug ID: 218993
   Summary: [patch] [ipfw] ipfw(8) may fail to remove rules
   Product: Base System
   Version: 11.0-STABLE
  Hardware: Any
OS: Any
Status: New
  Keywords: patch
  Severity: Affects Some People
  Priority: ---
 Component: bin
  Assignee: freebsd-bugs@FreeBSD.org
  Reporter: eu...@freebsd.org
  Keywords: patch

Created attachment 18
  --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=18&action=edit
clean structures before reusing

Let's try this in a shell:

# n=32
# for i in $(jot $n 1); do
> ipfw -q add 1 count ip from any to any
> ipfw -q add 2 count ip from any to any
> done
# ipfw delete 1 2
ipfw: rule 2: setsockopt(IP_FW_XDEL): Invalid argument

Rules numbered 1 got deleted, rules numbered 2 do not.
Note that problem does not manifest if n<32.

A bug is in /sbin/ipfw's ipfw_delete() function that fails to clean "rt"
structure before each iteration. ipfw_zero() function has similar problem.

Attached patch fixes this.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
freebsd-bugs@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-bugs
To unsubscribe, send any mail to "freebsd-bugs-unsubscr...@freebsd.org"


[Bug 219000] Integer underflow in efipart_realstrategy when I/O starts after end of disk

2017-05-01 Thread bugzilla-noreply
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=219000

Bug ID: 219000
   Summary: Integer underflow in efipart_realstrategy when I/O
starts after end of disk
   Product: Base System
   Version: CURRENT
  Hardware: Any
OS: Any
Status: New
  Severity: Affects Some People
  Priority: ---
 Component: kern
  Assignee: freebsd-bugs@FreeBSD.org
  Reporter: e...@metricspace.net

The efipart_realstrategy function (which performs I/O in the UEFI boot loader)
has an integer underflow when the I/O operation starts after the end of the
disk.  

This normally causes a crash.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
freebsd-bugs@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-bugs
To unsubscribe, send any mail to "freebsd-bugs-unsubscr...@freebsd.org"


[Bug 219000] Integer underflow in efipart_realstrategy when I/O starts after end of disk

2017-05-01 Thread bugzilla-noreply
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=219000

--- Comment #1 from Eric McCorkle  ---
Created attachment 182226
  --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=182226&action=edit
Patch to fix the problem

Review for fix: https://reviews.freebsd.org/D10559

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
freebsd-bugs@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-bugs
To unsubscribe, send any mail to "freebsd-bugs-unsubscr...@freebsd.org"


[Bug 219000] [patch] Integer underflow in efipart_realstrategy when I/O starts after end of disk

2017-05-01 Thread bugzilla-noreply
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=219000

Conrad Meyer  changed:

   What|Removed |Added

Summary|Integer underflow in|[patch] Integer underflow
   |efipart_realstrategy when   |in efipart_realstrategy
   |I/O starts after end of |when I/O starts after end
   |disk|of disk

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
freebsd-bugs@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-bugs
To unsubscribe, send any mail to "freebsd-bugs-unsubscr...@freebsd.org"


[Bug 218980] dhclient incorrectly handles very long lease times, setting expiry in the past

2017-05-01 Thread bugzilla-noreply
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=218980

Nick Hibma  changed:

   What|Removed |Added

 CC||n...@van-laarhoven.org

--- Comment #4 from Nick Hibma  ---
Bob, thanks for including me. I've touched that code path, so I'll check
tonight what's up with this.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
freebsd-bugs@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-bugs
To unsubscribe, send any mail to "freebsd-bugs-unsubscr...@freebsd.org"


[Bug 218980] dhclient incorrectly handles very long lease times, setting expiry in the past

2017-05-01 Thread bugzilla-noreply
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=218980

Nick Hibma  changed:

   What|Removed |Added

 Status|New |In Progress
   Assignee|freebsd-bugs@FreeBSD.org|n_hi...@freebsd.org

--- Comment #5 from Nick Hibma  ---
I'll take this one.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
freebsd-bugs@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-bugs
To unsubscribe, send any mail to "freebsd-bugs-unsubscr...@freebsd.org"


[Bug 219001] Installer Auto (ZFS) Partitioning creates pools with out-of-order disks

2017-05-01 Thread bugzilla-noreply
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=219001

Bug ID: 219001
   Summary: Installer Auto (ZFS) Partitioning creates pools with
out-of-order disks
   Product: Base System
   Version: 11.0-RELEASE
  Hardware: Any
OS: Any
Status: New
  Severity: Affects Some People
  Priority: ---
 Component: bin
  Assignee: freebsd-bugs@FreeBSD.org
  Reporter: ppa...@gmail.com

When doing a Auto ZFS Partitioning in the installer, disks are added to the
pool in alphabetical order instead of numerical order. This is an issue when
using more than 10 disks. For example, this is the order of disks chosen by the
installer with 16 disks:

da0
da1
da10
da11
da12
da13
da14
da15
da16
da2
da3
da4
da5
da6
da7
da8
da9

The zpool is also created in this order which may cause problems or confusion
for the system administrator. 

The Auto (UFS) code does not suffer from this problem. 

Tested on VMware, AMD64 with 16 100GB drives.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
freebsd-bugs@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-bugs
To unsubscribe, send any mail to "freebsd-bugs-unsubscr...@freebsd.org"


[Bug 219001] Installer Auto (ZFS) Partitioning creates pools with out-of-order disks

2017-05-01 Thread bugzilla-noreply
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=219001

--- Comment #1 from Peter Pauly  ---
Sorry, not da16, only 0-15 for 16 drives.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
freebsd-bugs@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-bugs
To unsubscribe, send any mail to "freebsd-bugs-unsubscr...@freebsd.org"


[Bug 218944] i915kms panics the kernel

2017-05-01 Thread bugzilla-noreply
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=218944

Domagoj Stolfa  changed:

   What|Removed |Added

 Resolution|--- |FIXED
 Status|New |Closed

--- Comment #1 from Domagoj Stolfa  ---
As indicated, this is fixed by r317561. Tested both CPUs. Furthermore, reports
on the mailing lists indicate that the problem is resolved.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
freebsd-bugs@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-bugs
To unsubscribe, send any mail to "freebsd-bugs-unsubscr...@freebsd.org"


[Bug 219001] Installer Auto (ZFS) Partitioning creates pools with out-of-order disks

2017-05-01 Thread bugzilla-noreply
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=219001

--- Comment #2 from Peter Pauly  ---
Tested with RAIDZ2 on VMware ESXi-5.5.0.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
freebsd-bugs@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-bugs
To unsubscribe, send any mail to "freebsd-bugs-unsubscr...@freebsd.org"


[Bug 219007] Installer Auto (ZFS) Partitioning creates unbootable system if more than 10 drives with RAIDZ2

2017-05-01 Thread bugzilla-noreply
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=219007

Bug ID: 219007
   Summary: Installer Auto (ZFS) Partitioning creates unbootable
system if more than 10 drives with RAIDZ2
   Product: Base System
   Version: 11.0-RELEASE
  Hardware: Any
OS: Any
Status: New
  Severity: Affects Some People
  Priority: ---
 Component: bin
  Assignee: freebsd-bugs@FreeBSD.org
  Reporter: ppa...@gmail.com

Please also see another bug which may be related (219001)

When using the installer and the Auto (ZFS) partitioning option and selecting
more than 10 drives and the RAIDZ2 option (possibly others too), the resulting
system installs fine but does not boot. The following error is given:

zfs I/O error - all block copies unavailable

Building a system with 10 or less drives works fine. Building a system with 11
or more drives fails to boot. 

Tested on VMware ESXi-5.5.0  AMD64.  2 Processors, 32GB memory. Dual LSI Logic
SAS SCSI controllers.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
freebsd-bugs@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-bugs
To unsubscribe, send any mail to "freebsd-bugs-unsubscr...@freebsd.org"


[Bug 219007] Installer Auto (ZFS) Partitioning creates unbootable system if more than 10 drives with RAIDZ2

2017-05-01 Thread bugzilla-noreply
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=219007

Peter Pauly  changed:

   What|Removed |Added

   See Also||https://bugs.freebsd.org/bu
   ||gzilla/show_bug.cgi?id=2190
   ||01

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
freebsd-bugs@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-bugs
To unsubscribe, send any mail to "freebsd-bugs-unsubscr...@freebsd.org"


[Bug 219001] Installer Auto (ZFS) Partitioning creates pools with out-of-order disks

2017-05-01 Thread bugzilla-noreply
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=219001

Peter Pauly  changed:

   What|Removed |Added

   See Also||https://bugs.freebsd.org/bu
   ||gzilla/show_bug.cgi?id=2190
   ||07

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
freebsd-bugs@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-bugs
To unsubscribe, send any mail to "freebsd-bugs-unsubscr...@freebsd.org"


[Bug 218907] tcpmd5 kernel module on STABLE/11 doesn't work with vultr bgp via bird

2017-05-01 Thread bugzilla-noreply
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=218907

Andrey V. Elsukov  changed:

   What|Removed |Added

 CC||melif...@freebsd.org

--- Comment #5 from Andrey V. Elsukov  ---
(In reply to Joseph Mulloy from comment #4)
> (In reply to Andrey V. Elsukov from comment #3)
> Thanks for the patch to bird. It's working for the IPv4 version of bird but
> I'm still having trouble with the IPv6 version, bird6. The bird6 package is
> a subordinate package so it should get the same patches, correct?

Yes, bird6 uses the same patches, but you still need to rebuild it too.

> I'm curious why this wasn't an issue with the old kernel code, but I'm glad
> it's working. Now that I'm getting a better understanding of how this works
> it seems I could have also used the setkey utility instead of having bird
> handle the md5 signature stuff.

The behavior was unintended changed in the r313330, now TCP-MD5 requires
correct SA for both direction, since both are used.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
freebsd-bugs@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-bugs
To unsubscribe, send any mail to "freebsd-bugs-unsubscr...@freebsd.org"


[Bug 218993] [patch] [ipfw] ipfw(8) may fail to remove rules

2017-05-01 Thread bugzilla-noreply
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=218993

--- Comment #1 from commit-h...@freebsd.org ---
A commit references this bug:

Author: ae
Date: Tue May  2 01:03:59 UTC 2017
New revision: 317663
URL: https://svnweb.freebsd.org/changeset/base/317663

Log:
  Properly initialize ipfw_range_tlv variable to fix possible EINVAL
  in case when ipfw delete/zero/resetlog command issued for several rules
  in the loop. Also reorder some variables by size.

  PR:   218993
  MFC after:1 week

Changes:
  head/sbin/ipfw/ipfw2.c

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
freebsd-bugs@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-bugs
To unsubscribe, send any mail to "freebsd-bugs-unsubscr...@freebsd.org"


[Bug 218811] graphics/libglapi: fails to build with bsdgrep

2017-05-01 Thread bugzilla-noreply
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=218811

--- Comment #10 from commit-h...@freebsd.org ---
A commit references this bug:

Author: emaste
Date: Tue May  2 02:32:10 UTC 2017
New revision: 317665
URL: https://svnweb.freebsd.org/changeset/base/317665

Log:
  bsdgrep: fix -w -v matching improperly with certain patterns

  -w and -v flag matching was mostly functional but had some minor
  problems:

  1. -w flag processing only allowed one iteration through pattern
 matching on a line. This was problematic if one pattern could match
 more than once, or if there were multiple patterns and the earliest/
 longest match was not the most ideal, and

  2. Previous work "fixed" things to not further process a line if the
 first iteration through patterns produced no matches. This is clearly
 wrong if we're dealing with the more restrictive -w matching.

  #2 breakage could have also occurred before recent broad rewrites, but
  it would be more arbitrary based on input patterns as to whether or not
  it actually affected things.

  Fix both of these by forcing a retry of the patterns after advancing
  just past the start of the first match if we're doing more restrictive
  -w matching and we didn't get any hits to start with. Also move -v flag
  processing outside of the loop so that we have a greater change to match
  in the more restrictive cases. This wasn't strictly wrong, but it could
  be a little more error prone.

  While here, introduce some regressions tests for this behavior and fix
  some excessive wrapping nearby that hindered readability. GNU grep
  passes these new tests.

  PR:   218467, 218811
  Submitted by: Kyle Evans 
  Reviewed by:  cem, ngie
  Differential Revision:https://reviews.freebsd.org/D10329

Changes:
  head/contrib/netbsd-tests/usr.bin/grep/t_grep.sh
  head/usr.bin/grep/util.c

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
freebsd-bugs@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-bugs
To unsubscribe, send any mail to "freebsd-bugs-unsubscr...@freebsd.org"


[Bug 218467] bug in grep -v -w

2017-05-01 Thread bugzilla-noreply
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=218467

--- Comment #4 from commit-h...@freebsd.org ---
A commit references this bug:

Author: emaste
Date: Tue May  2 02:32:10 UTC 2017
New revision: 317665
URL: https://svnweb.freebsd.org/changeset/base/317665

Log:
  bsdgrep: fix -w -v matching improperly with certain patterns

  -w and -v flag matching was mostly functional but had some minor
  problems:

  1. -w flag processing only allowed one iteration through pattern
 matching on a line. This was problematic if one pattern could match
 more than once, or if there were multiple patterns and the earliest/
 longest match was not the most ideal, and

  2. Previous work "fixed" things to not further process a line if the
 first iteration through patterns produced no matches. This is clearly
 wrong if we're dealing with the more restrictive -w matching.

  #2 breakage could have also occurred before recent broad rewrites, but
  it would be more arbitrary based on input patterns as to whether or not
  it actually affected things.

  Fix both of these by forcing a retry of the patterns after advancing
  just past the start of the first match if we're doing more restrictive
  -w matching and we didn't get any hits to start with. Also move -v flag
  processing outside of the loop so that we have a greater change to match
  in the more restrictive cases. This wasn't strictly wrong, but it could
  be a little more error prone.

  While here, introduce some regressions tests for this behavior and fix
  some excessive wrapping nearby that hindered readability. GNU grep
  passes these new tests.

  PR:   218467, 218811
  Submitted by: Kyle Evans 
  Reviewed by:  cem, ngie
  Differential Revision:https://reviews.freebsd.org/D10329

Changes:
  head/contrib/netbsd-tests/usr.bin/grep/t_grep.sh
  head/usr.bin/grep/util.c

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
freebsd-bugs@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-bugs
To unsubscribe, send any mail to "freebsd-bugs-unsubscr...@freebsd.org"


[Bug 217841] ipfw table add/list causes kernel panic on custom kernel with VNET

2017-05-01 Thread bugzilla-noreply
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=217841

Andrey V. Elsukov  changed:

   What|Removed |Added

 Status|New |Closed
 Resolution|--- |FIXED

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
freebsd-bugs@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-bugs
To unsubscribe, send any mail to "freebsd-bugs-unsubscr...@freebsd.org"


[Bug 202297] usr/src/sys/netpfil/ipfw/ip_fw_sockopt.c:2837: bad if test ?

2017-05-01 Thread bugzilla-noreply
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=202297

Andrey V. Elsukov  changed:

   What|Removed |Added

 CC||a...@freebsd.org
 Resolution|--- |FIXED
 Status|New |Closed

--- Comment #1 from Andrey V. Elsukov  ---
Fixed in r295766.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
freebsd-bugs@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-bugs
To unsubscribe, send any mail to "freebsd-bugs-unsubscr...@freebsd.org"


[Bug 202295] usr/src/sbin/ipfw/dummynet.c:1306: bad if test ?

2017-05-01 Thread bugzilla-noreply
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=202295

--- Comment #1 from commit-h...@freebsd.org ---
A commit references this bug:

Author: ae
Date: Tue May  2 05:20:55 UTC 2017
New revision: 317667
URL: https://svnweb.freebsd.org/changeset/base/317667

Log:
  In parse_range() validate both range values instead of checking
  the top  value twice.

  PR:   202295
  MFC after:1 week

Changes:
  head/sbin/ipfw/dummynet.c

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
freebsd-bugs@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-bugs
To unsubscribe, send any mail to "freebsd-bugs-unsubscr...@freebsd.org"