[Bug 217606] Bridge stops working after some days

2017-03-07 Thread bugzilla-noreply
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=217606

Bug ID: 217606
   Summary: Bridge stops working after some days
   Product: Base System
   Version: 11.0-RELEASE
  Hardware: amd64
OS: Any
Status: New
  Severity: Affects Some People
  Priority: ---
 Component: kern
  Assignee: freebsd-bugs@FreeBSD.org
  Reporter: a...@torrentkino.de

Hello,

we recently upgraded our Bridging FWs from 10.1-RELEASE-pxx to 11.0-RELEASE-p8.
And since then they stop passing through traffic after some time. In this case
after ~4 days. One of them stopped yesterday evening. (We have a failover
mechanism to reduce the impact.)

$ uptime
9:26AM  up 4 days, 19:22, 2 users, load averages: 0.12, 0.06, 0.01

bridge0 consists of ix0/ix1:

ix0:  port
0xecc0-0xecdf mem 0xd9e8-0xd9ef,0xd9ff8000-0xd9ffbfff irq 48 at device
0.0 numa-domain 0 on pci2
ix1:  port
0xece0-0xecff mem 0xd9f0-0xd9f7,0xd9ffc000-0xd9ff irq 52 at device
0.1 numa-domain 0 on pci2

In case of error I see the following for IPv4. The bridge does IPv6 as well.
Same problem.

ix0: A load balancer is asking for its default GW. No reply...

$ tcpdump -i ix0 \( arp \)
09:37:47.330361 ARP, Request who-has A.A.A.A tell B.B.B.B, length 46

ix1: The default GW actually sends a reply. I can see it on ix1.

$ tcpdump -i ix1 \( arp \)
09:38:59.328956 ARP, Request who-has A.A.A.A tell B.B.B.B, length 46
09:38:59.329374 ARP, Reply A.A.A.A is-at 00:00:0a:0b:0c:0d (oui Cisco), length
46

A tcpdump for bridge0 show the same as ix1.

Some numbers of the currently not working system:

$ netstat -m
82409/6901/89310 mbufs in use (current/cache/total)
38692/4094/42786/1015426 mbuf clusters in use (current/cache/total/max)
38692/4065 mbuf+clusters out of packet secondary zone in use (current/cache)
0/192/192/507713 4k (page size) jumbo clusters in use (current/cache/total/max)
0/0/0/150433 9k jumbo clusters in use (current/cache/total/max)
0/0/0/84618 16k jumbo clusters in use (current/cache/total/max)
97986K/10681K/108667K bytes allocated to network (current/cache/total)
0/0/0 requests for mbufs denied (mbufs/clusters/mbuf+clusters)
0/0/0 requests for mbufs delayed (mbufs/clusters/mbuf+clusters)
0/0/0 requests for jumbo clusters delayed (4k/9k/16k)
0/0/0 requests for jumbo clusters denied (4k/9k/16k)
0 sendfile syscalls
0 sendfile syscalls completed without I/O request
0 requests for I/O initiated by sendfile
0 pages read by sendfile as part of a request
0 pages were valid at time of a sendfile request
0 pages were requested for read ahead by applications
0 pages were read ahead by sendfile
0 times sendfile encountered an already busy page
0 requests for sfbufs denied
0 requests for sfbufs delayed

$ netstat -b -d -h -i bridge0
NameMtu Network   Address  Ipkts Ierrs Idrop Ibytes   
Opkts Oerrs Obytes  Coll  Drop
ix01.5K   00:00:00:00:00:0a  12G 0 011T
7.9G 0   1.1T 0  335k
ix11.5K   00:00:00:00:00:0b 7.9G 0 0   1.2T
 12G 011T 0 0
bridg  1.5K   00:00:00:00:00:0c  20G 0 012T
 20G  335k12T 0 0

What I did so far:

# Disable Ethernet Flow-Control
# https://wiki.freebsd.org/10gFreeBSD/Router
dev.ix.0.fc=0
dev.ix.1.fc=0

# Disable TSO
cloned_interfaces="bridge0"
ifconfig_bridge0="addm ix0 addm ix1 up"
ifconfig_ix0="up -tso"
ifconfig_ix1="up -tso"

I found the following bug reports:
2004: https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=185633
2016: https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=212749

And since this system uses PF and Scrubbing. I applied this patch manually:
https://reviews.freebsd.org/D7780

But I have no success so far.

Shutting down ix0/ix1 and bringing them up makes brigde0 responsive again. But
time now works against me. Netstat after that procedure:

$ netstat -m
33281/56284/89565 mbufs in use (current/cache/total)
33280/9756/43036/2015426 mbuf clusters in use (current/cache/total/max)
33280/9730 mbuf+clusters out of packet secondary zone in use (current/cache)
0/192/192/507713 4k (page size) jumbo clusters in use (current/cache/total/max)
0/0/0/150433 9k jumbo clusters in use (current/cache/total/max)
0/0/0/84618 16k jumbo clusters in use (current/cache/total/max)
74880K/34351K/109231K bytes allocated to network (current/cache/total)
0/0/0 requests for mbufs denied (mbufs/clusters/mbuf+clusters)
0/0/0 requests for mbufs delayed (mbufs/clusters/mbuf+clusters)
0/0/0 requests for jumbo clusters delayed (4k/9k/16k)
0/0/0 requests for jumbo clusters denied (4k/9k/16k)
0 sendfile syscalls
0 sendfile syscalls completed without I/O request
0 requests for I/O initiated by sendfile
0 pages read by sendfile as part of a request
0 pages were valid at time of a sendfile request
0 pages were requested for read ahead by applications
0 pages were read ahead by sendfile
0 times sendfile e

[Bug 217607] ng_cisco flow control messages and IPv6

2017-03-07 Thread bugzilla-noreply
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=217607

Bug ID: 217607
   Summary: ng_cisco flow control messages and IPv6
   Product: Base System
   Version: 11.0-STABLE
  Hardware: Any
OS: Any
Status: New
  Severity: Affects Some People
  Priority: ---
 Component: kern
  Assignee: freebsd-bugs@FreeBSD.org
  Reporter: lukasz.woj...@zoho.com

Created attachment 180593
  --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=180593&action=edit
sketch of a patch fixing the issue

ng_cisco's cisco_notify() routine only sends flow control messages to nodes
connected via 'inet' hook, completely ignoring those connected via 'inet6'.
This poses some problem if peer node relies on link status information passed
from ng_cisco. I'd therefore like to suggest a patch (perhaps something similar
to what I attached). All it does is to make ng_cisco node pass flow control
messages to *both* 'inet' and 'inet6' peers. It seems to me that it is both
possible and sensible to expect both mentioned hooks to be connected at the
same time.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
freebsd-bugs@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-bugs
To unsubscribe, send any mail to "freebsd-bugs-unsubscr...@freebsd.org"


[Bug 207747] sysutils/runit: fix to allow send logs via UDP

2017-03-07 Thread bugzilla-noreply
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=207747

--- Comment #1 from commit-h...@freebsd.org ---
A commit references this bug:

Author: danfe
Date: Tue Mar  7 11:45:34 UTC 2017
New revision: 435595
URL: https://svnweb.freebsd.org/changeset/ports/435595

Log:
  - Add a patch to allow sending logs via UDP [1]
  - Convert to option helper target and optimize
away ``.for'' loop in its recipe while here

  PR:   207747 [1]

Changes:
  head/sysutils/runit/Makefile
  head/sysutils/runit/files/patch-src_svlogd.c

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
freebsd-bugs@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-bugs
To unsubscribe, send any mail to "freebsd-bugs-unsubscr...@freebsd.org"


[Bug 207747] sysutils/runit: fix to allow send logs via UDP

2017-03-07 Thread bugzilla-noreply
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=207747

Alexey Dokuchaev  changed:

   What|Removed |Added

 Status|New |Closed
 Resolution|--- |FIXED
 CC||da...@freebsd.org

--- Comment #2 from Alexey Dokuchaev  ---
The port is patched as of ports r435595, thank you!

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
freebsd-bugs@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-bugs
To unsubscribe, send any mail to "freebsd-bugs-unsubscr...@freebsd.org"


[Bug 217610] ELF loader should have a special case for program headers with p_filesz == 0

2017-03-07 Thread bugzilla-noreply
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=217610

Bug ID: 217610
   Summary: ELF loader should have a special case for program
headers with p_filesz == 0
   Product: Base System
   Version: 11.0-RELEASE
  Hardware: Any
OS: Any
Status: New
  Severity: Affects Only Me
  Priority: ---
 Component: kern
  Assignee: freebsd-bugs@FreeBSD.org
  Reporter: f...@fuz.su

The ELF loader in imgact_elf.c contains the following code to verify a program
header before loading it:

/*
 * It's necessary to fail if the filsz + offset taken from the
 * header is greater than the actual file pager object's size.
 * If we were to allow this, then the vm_map_find() below would
 * walk right off the end of the file object and into the ether.
 *
 * While I'm here, might as well check for something else that
 * is invalid: filsz cannot be greater than memsz.
 */
if ((off_t)filsz + offset > imgp->attr->va_size || filsz > memsz) {
uprintf("elf_load_section: truncated ELF file\n");
return (ENOEXEC);
}

However, this code is incorrect. If a program header corresponds to sections
that are all marked NOBITS, GNU ld generates a program header with p_filesz ==
0 and p_offset at the next aligned offset just past the end of the file. This
is fine as no bytes are actually ever read from the binary. However, FreeBSD
refuses to load such a valid ELF binary. I request to amend this verification
procedure to add a special case for program headers with p_filesz == 0:

if (filesz > memsz || filesz > 0 && (off_t)filesz + offset >
imgp->attr->va_size)

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
freebsd-bugs@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-bugs
To unsubscribe, send any mail to "freebsd-bugs-unsubscr...@freebsd.org"


[Bug 217610] ELF loader should have a special case for program headers with p_filesz == 0

2017-03-07 Thread bugzilla-noreply
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=217610

--- Comment #1 from Robert Clausecker  ---
As an example, save the following file in test.S and type

cc -c test.S
ld -o test test.o
./test

on an amd64 machine to reproduce the problem. test.S:

#include 
.bss
.align 4096
x:  .space 16

.text
.globl _start
_start:
mov $SYS_exit,%eax
xor %edi,%edi
syscall

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
freebsd-bugs@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-bugs
To unsubscribe, send any mail to "freebsd-bugs-unsubscr...@freebsd.org"


[Bug 168298] VirtualBox using AIO on a zvol crashes

2017-03-07 Thread bugzilla-noreply
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=168298

mar...@sugioarto.com changed:

   What|Removed |Added

 CC||mar...@sugioarto.com

--- Comment #7 from mar...@sugioarto.com ---
Hi,

I would like to confirm that the aio sysctl settings in comment #3 fix crashes
(causing SIGILL in VBoxSDL) and broken guest filesystems on
virtualbox-ose-5.1.14_2 (FreeBSD 11.0). I've tried different guest operating
systems and all fail mostly with HDD problems during initial installation.

I am using simple VDI files, by the way, not any ZVOL and no compression. My
host CPU is a bit slow (AMD  Athlon II X3 460), it is only capable to emulate
32-bit guests.

I've used these sysctl settings (probably still overdimensioned):

vfs.aio.max_aio_queue=8192
vfs.aio.max_aio_queue_per_proc=8192
vfs.aio.max_aio_per_proc=4096
vfs.aio.max_buf_aio=4096

Thank you.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
freebsd-bugs@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-bugs
To unsubscribe, send any mail to "freebsd-bugs-unsubscr...@freebsd.org"


[Bug 217613] FreeBSD make -- local variable $(.PREFIX) does not strip preceding directory components

2017-03-07 Thread bugzilla-noreply
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=217613

Bug ID: 217613
   Summary: FreeBSD make -- local variable $(.PREFIX) does not
strip preceding directory components
   Product: Base System
   Version: 11.0-RELEASE
  Hardware: Any
OS: Any
Status: New
  Severity: Affects Only Me
  Priority: ---
 Component: bin
  Assignee: freebsd-bugs@FreeBSD.org
  Reporter: e...@nordstroem.no

Created attachment 180603
  --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=180603&action=edit
BSDmakefile

From the make(1) man page:

  Local variables are all built in and their values vary magically from
  target to target.  It is not currently possible to define new local
  variables.  The seven local variables are as follows:

  [...]

.PREFIX   The file prefix of the target, containing only the file
  portion, no suffix or preceding directory components;
  also known as ‘*’.  The suffix must be one of the known
  suffixes declared with .SUFFIXES or it will not be
  recognized.

However, it seems that preceding directory components are not actually
stripped.

$ mkdir -p ~/tmp/hello
$ cd ~/tmp/hello/

Place the attached BSDmakefile in this directory and after you've done that,
create the hello world program in src/main.c.

$ mkdir src
$ cat > src/hello.c <
int main()
{
   printf("Hello, World!");
}
EOF

$ make
make: don't know how to make src/build/hello.c. Stop

make: stopped in /usr/home/erikn/tmp/hello

As you can see from the output above when I attempt to run make, the prefix was
not stripped of preceding directory components.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
freebsd-bugs@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-bugs
To unsubscribe, send any mail to "freebsd-bugs-unsubscr...@freebsd.org"

[Bug 217613] FreeBSD make -- local variable $(.PREFIX) does not strip preceding directory components

2017-03-07 Thread bugzilla-noreply
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=217613

--- Comment #1 from Erik Nordstrøm  ---
Furthermore, even if making the paths absolute by replacing

BINDIR = bin
OBJDIR = build

in the BSDmakefile with

BINDIR = $(PWD)/bin
OBJDIR = $(PWD)/build

the prefix is still not stripped of the preceding directory.

$ make
make: don't know how to make src//usr/home/erikn/tmp/hello/build/hello.c. Stop

make: stopped in /usr/home/erikn/tmp/hello

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
freebsd-bugs@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-bugs
To unsubscribe, send any mail to "freebsd-bugs-unsubscr...@freebsd.org"

[Bug 217613] FreeBSD make -- local variable $(.PREFIX) does not strip preceding directory components

2017-03-07 Thread bugzilla-noreply
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=217613

--- Comment #2 from Erik Nordstrøm  ---
In the original message I meant to say "create the hello world program in
src/hello.c", not "create the hello world program in src/main.c", and also, the
line in the BSDmakefile that reads

$(CC) $(.ALLSRC) -O $(.TARGET)

was supposed to say

$(CC) $(.ALLSRC) -o $(.TARGET)

Attaching a new version of the BSDmakefile with the typo fixed.

Aside from these couple of mistakes, the problem itself is as described.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
freebsd-bugs@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-bugs
To unsubscribe, send any mail to "freebsd-bugs-unsubscr...@freebsd.org"

[Bug 217613] FreeBSD make -- local variable $(.PREFIX) does not strip preceding directory components

2017-03-07 Thread bugzilla-noreply
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=217613

Erik Nordstrøm  changed:

   What|Removed |Added

 Attachment #180603|0   |1
is obsolete||

--- Comment #3 from Erik Nordstrøm  ---
Created attachment 180605
  --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=180605&action=edit
BSDmakefile with typo fixed

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
freebsd-bugs@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-bugs
To unsubscribe, send any mail to "freebsd-bugs-unsubscr...@freebsd.org"

[Bug 217221] contrib/libpcap installs internal header files in /usr/include

2017-03-07 Thread bugzilla-noreply
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=217221

Xin LI  changed:

   What|Removed |Added

   Assignee|freebsd-bugs@FreeBSD.org|delp...@freebsd.org

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
freebsd-bugs@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-bugs
To unsubscribe, send any mail to "freebsd-bugs-unsubscr...@freebsd.org"


[Bug 217610] ELF loader should have a special case for program headers with p_filesz == 0

2017-03-07 Thread bugzilla-noreply
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=217610

Conrad Meyer  changed:

   What|Removed |Added

 CC||c...@freebsd.org

--- Comment #2 from Conrad Meyer  ---
So essentially, objects with no non-zero static data can't be loaded?

Is this an issue in practice?  I'd guess crt0 adds some initialized data, so
most programs will not run into this?

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
freebsd-bugs@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-bugs
To unsubscribe, send any mail to "freebsd-bugs-unsubscr...@freebsd.org"


[Bug 168298] VirtualBox using AIO on a zvol crashes

2017-03-07 Thread bugzilla-noreply
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=168298

--- Comment #8 from rkober...@gmail.com ---
I have done some experimentation and havebeen able to modify these settings to
less extreme values and still get VB to run without failing.
vfs.aio.max_aio_queue: 8192
vfs.aio.max_aio_queue_per_proc: 1024
vfs.aio.max_aio_per_proc: 128
vfs.aio.max_buf_aio: 64

I will admit that I have not tried tweaking these values for some time and I
suspect come are still allowing the consumption of more resources than needed,
but these are safer than those I first proposed.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
freebsd-bugs@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-bugs
To unsubscribe, send any mail to "freebsd-bugs-unsubscr...@freebsd.org"


[Bug 217610] ELF loader should have a special case for program headers with p_filesz == 0

2017-03-07 Thread bugzilla-noreply
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=217610

--- Comment #3 from Robert Clausecker  ---
You are correct in both observations. Programs linked against crt0.o should
never trigger this bug, which is probably how it went undiscovered for so long.
If there is interest, I can write and test a patch.

This issue can affect programs that do not link against the libc and that do
not use initialized data either.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
freebsd-bugs@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-bugs
To unsubscribe, send any mail to "freebsd-bugs-unsubscr...@freebsd.org"


[Bug 217610] ELF loader should have a special case for program headers with p_filesz == 0

2017-03-07 Thread bugzilla-noreply
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=217610

--- Comment #4 from Konstantin Belousov  ---
Created attachment 180607
  --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=180607&action=edit
Handle filsz == 0.

Attached is the proposed patch.  Note that it is somewhat more involved that
just passing the filsz == 0 in the initial ENOEXEC check, because I do not want
even think what happens when offset is not multiple of the page size.  I just
force any file-backed COW mappings to be avoided if filesz == 0.

Also the patch contains some style cleanup, which I split for actual commit.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
freebsd-bugs@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-bugs
To unsubscribe, send any mail to "freebsd-bugs-unsubscr...@freebsd.org"


[Bug 217610] ELF loader should have a special case for program headers with p_filesz == 0

2017-03-07 Thread bugzilla-noreply
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=217610

Konstantin Belousov  changed:

   What|Removed |Added

 Attachment #180607|0   |1
is obsolete||

--- Comment #5 from Konstantin Belousov  ---
Created attachment 180608
  --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=180608&action=edit
Handle filsz == 0.

Correctly handle the memsz/filsz staircase (forgot else).

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
freebsd-bugs@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-bugs
To unsubscribe, send any mail to "freebsd-bugs-unsubscr...@freebsd.org"


[Bug 217617] Typo in ip_fw_table.c

2017-03-07 Thread bugzilla-noreply
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=217617

Bug ID: 217617
   Summary: Typo in ip_fw_table.c
   Product: Base System
   Version: 11.0-STABLE
  Hardware: Any
OS: Any
Status: New
  Severity: Affects Only Me
  Priority: ---
 Component: kern
  Assignee: freebsd-bugs@FreeBSD.org
  Reporter: l...@donnerhacke.de

Line numbers might be off, there are other modifications in this file

--- sys/netpfil/ipfw/ip_fw_table.c  (revision 314807)
+++ sys/netpfil/ipfw/ip_fw_table.c  (working copy)
@@ -405,7 +405,7 @@
error = 0;
ta_buf_sz = ta->ta_buf_size;
if (count == 1) {
-   /* Sigle add/delete, use on-stack buffer */
+   /* Single add/delete, use on-stack buffer */
memset(*ta_buf, 0, TA_BUF_SZ);
ta_buf_m = *ta_buf;
} else {

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
freebsd-bugs@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-bugs
To unsubscribe, send any mail to "freebsd-bugs-unsubscr...@freebsd.org"


[Bug 217618] Enhance hash function in ip_fw_table_algo.c for flow:hash

2017-03-07 Thread bugzilla-noreply
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=217618

Bug ID: 217618
   Summary: Enhance hash function in ip_fw_table_algo.c for
flow:hash
   Product: Base System
   Version: 11.0-STABLE
  Hardware: Any
OS: Any
Status: New
  Severity: Affects Some People
  Priority: ---
 Component: kern
  Assignee: freebsd-bugs@FreeBSD.org
  Reporter: l...@donnerhacke.de

While experimenting with some extentions for flow tables, I noticed, that the
hash function does not separate distinct entries clearly enough. Larger flows
tables do reflect external structures and tend to heavily cluster the entries
on a few hash values (i.e. src-ip and dst-ip are varied both within a network).
Current code does not even include the protocol number.

So I propose to reuse the existing crc32 function for this small amount of
data. The probability to have a uniform distributed hash key increases
dramatically and overall the lookup is faster than step through a list of
entries having the same key.

Note: This code depends on a zeroed struct fhashentry*, because it does not
select the individual fields. All functions despite ta_prepare_del_fhash do
clean the structure. I'm not sure, if this is can cause a problem.

--- sys/netpfil/ipfw/ip_fw_table_algo.c (revision 314807)
+++ sys/netpfil/ipfw/ip_fw_table_algo.c (working copy)
@@ -3163,7 +3176,7 @@
 {
uint32_t i;

-   i = (f->dip.s_addr) ^ (f->sip.s_addr) ^ (f->e.dport) ^ (f->e.sport);
+   i = crc32(f, sizeof(*f));

return (i % (hsize - 1));
 }
@@ -3173,11 +3186,7 @@
 {
uint32_t i;

-   i = (f->dip6.__u6_addr.__u6_addr32[2]) ^
-   (f->dip6.__u6_addr.__u6_addr32[3]) ^
-   (f->sip6.__u6_addr.__u6_addr32[2]) ^
-   (f->sip6.__u6_addr.__u6_addr32[3]) ^
-   (f->e.dport) ^ (f->e.sport);
+   i = crc32(f, sizeof(*f));

return (i % (hsize - 1));
 }

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
freebsd-bugs@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-bugs
To unsubscribe, send any mail to "freebsd-bugs-unsubscr...@freebsd.org"


[Bug 217618] Enhance hash function in ip_fw_table_algo.c for flow:hash

2017-03-07 Thread bugzilla-noreply
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=217618

Conrad Meyer  changed:

   What|Removed |Added

 CC||c...@freebsd.org

--- Comment #1 from Conrad Meyer  ---
I would suggest maybe using crc32c() instead of crc32() — the former is the
ISCSI polynomial with hardware support on recent amd64 CPUs.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
freebsd-bugs@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-bugs
To unsubscribe, send any mail to "freebsd-bugs-unsubscr...@freebsd.org"

[Bug 217620] ipfw flow specification parsing

2017-03-07 Thread bugzilla-noreply
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=217620

Bug ID: 217620
   Summary: ipfw flow specification parsing
   Product: Base System
   Version: 11.0-STABLE
  Hardware: Any
OS: Any
Status: New
  Severity: Affects Only Me
  Priority: ---
 Component: bin
  Assignee: freebsd-bugs@FreeBSD.org
  Reporter: l...@donnerhacke.de

Parsing of port-numbers explicitly set to "0" does not work.
BTW: The whole code is broken for parsing named ports.

How to repeat:
root@server:~ # ipfw table test create type
flow:src-ip,src-port,dst-ip,dst-port,proto
root@server:~ # ipfw table all info
--- table(test), set(0) ---
 kindex: 1, type: flow:src-ip,proto,src-port,dst-ip,dst-port
 references: 0, valtype: legacy
 algorithm: flow:hash
 items: 0, size: 296
root@server:~ # ipfw table test add 0.0.0.0,0,0,0.0.0.0,0
ipfw: Unknown service: 0

After the patch:
root@server:~ # ipfw table test add 0.0.0.0,0,0,0.0.0.0,0
added: 0.0.0.0,0,0,0.0.0.0,0 0
root@server:~ # ipfw table test list
--- table(test), set(0) ---
0.0.0.0,0,0,0.0.0.0,0 0

--- sbin/ipfw/ipfw2.h   (revision 314807)
+++ sbin/ipfw/ipfw2.h   (working copy)
@@ -1236,12 +1269,11 @@
if ((p = strchr(arg, ',')) != NULL)
*p++ = '\0';

-   if ((port = htons(strtol(arg, NULL, 10))) == 0) {
+   port = htons(strtol(arg, &pp, 10));
+   if(*pp != '\0') {
if ((sent = getservbyname(arg, NULL)) == NULL)
-   errx(EX_DATAERR, "Unknown service: %s",
-   arg);
-   else
-   key = sent->s_port;
+   errx(EX_DATAERR, "Unknown service: %s",
arg);
+   port = sent->s_port;
}

tfe->sport = port;
@@ -1280,12 +1312,11 @@
if ((p = strchr(arg, ',')) != NULL)
*p++ = '\0';

-   if ((port = htons(strtol(arg, NULL, 10))) == 0) {
+   port = htons(strtol(arg, &pp, 10));
+   if (*pp != '\0') {
if ((sent = getservbyname(arg, NULL)) == NULL)
-   errx(EX_DATAERR, "Unknown service: %s",
-   arg);
-   else
-   key = sent->s_port;
+   errx(EX_DATAERR, "Unknown service: %s",
arg);
+   port = sent->s_port;
}

tfe->dport = port;

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
freebsd-bugs@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-bugs
To unsubscribe, send any mail to "freebsd-bugs-unsubscr...@freebsd.org"


[Bug 217600] Gateway enable not working

2017-03-07 Thread bugzilla-noreply
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=217600

l...@donnerhacke.de changed:

   What|Removed |Added

 CC||l...@donnerhacke.de

--- Comment #1 from l...@donnerhacke.de ---
Please provide the output of the following commands on both machines
# netstat -rn
# sysctl net.inet.ip.forwarding

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
freebsd-bugs@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-bugs
To unsubscribe, send any mail to "freebsd-bugs-unsubscr...@freebsd.org"


[Bug 174236] [modules] "kldunload ipdivert" corrupts kernel

2017-03-07 Thread bugzilla-noreply
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=174236

l...@donnerhacke.de changed:

   What|Removed |Added

 Status|In Progress |Closed
 Resolution|--- |Feedback Timeout

--- Comment #3 from l...@donnerhacke.de ---
Situation does not occur any more.
Time changed.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
freebsd-bugs@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-bugs
To unsubscribe, send any mail to "freebsd-bugs-unsubscr...@freebsd.org"


[Bug 217618] Enhance hash function in ip_fw_table_algo.c for flow:hash

2017-03-07 Thread bugzilla-noreply
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=217618

--- Comment #2 from l...@donnerhacke.de ---
Please choose the most appropriate call, you can find.
My choice was driven by minimal impact considerations.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
freebsd-bugs@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-bugs
To unsubscribe, send any mail to "freebsd-bugs-unsubscr...@freebsd.org"


[Bug 217622] 1-line patch for daily/800.scrub_zfs to fix interval calculation

2017-03-07 Thread bugzilla-noreply
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=217622

Bug ID: 217622
   Summary: 1-line patch for daily/800.scrub_zfs to fix interval
calculation
   Product: Base System
   Version: 11.0-RELEASE
  Hardware: Any
OS: Any
Status: New
  Severity: Affects Many People
  Priority: ---
 Component: misc
  Assignee: freebsd-bugs@FreeBSD.org
  Reporter: w...@psr.com

Created attachment 180615
  --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=180615&action=edit
1-line patch to line 73 of 800.scrub-zfs to add " -v -70M"

The enclosed patch improves the time-since-last-scrub calculation.
In general, for, say, the default interval of 35 days, the old code treats
34d 23h 59m 59s as 34 days and defers scrubbing to the next day, making the
actual interval 36 days.  In addition, there are two typical causes of being
a few seconds (or minutes) shy of a full day:
1) a few seconds pass between the date test and the actual starting of a scrub;
and 2) when 410.pkg-audit is run before 800.scrub-zfs, a random interval of up
to 1 hour is introduced.

Adding " -v 70M" to the date command effectively rounds up anything within 70
minutes of a full day to the next full day.

This affects everyone using periodic daily/800.scrub-zfs.
 -WBE

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
freebsd-bugs@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-bugs
To unsubscribe, send any mail to "freebsd-bugs-unsubscr...@freebsd.org"


[Bug 217620] ipfw flow specification parsing

2017-03-07 Thread bugzilla-noreply
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=217620

Mark Linimon  changed:

   What|Removed |Added

   Assignee|freebsd-bugs@FreeBSD.org|freebsd-i...@freebsd.org
   Keywords||patch

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
freebsd-bugs@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-bugs
To unsubscribe, send any mail to "freebsd-bugs-unsubscr...@freebsd.org"


[Bug 217618] Enhance hash function in ip_fw_table_algo.c for flow:hash

2017-03-07 Thread bugzilla-noreply
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=217618

Mark Linimon  changed:

   What|Removed |Added

   Keywords||patch

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
freebsd-bugs@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-bugs
To unsubscribe, send any mail to "freebsd-bugs-unsubscr...@freebsd.org"


[Bug 217622] 1-line patch for daily/800.scrub_zfs to fix interval calculation

2017-03-07 Thread bugzilla-noreply
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=217622

Mark Linimon  changed:

   What|Removed |Added

   Keywords||patch

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
freebsd-bugs@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-bugs
To unsubscribe, send any mail to "freebsd-bugs-unsubscr...@freebsd.org"


[Bug 217617] Typo in ip_fw_table.c

2017-03-07 Thread bugzilla-noreply
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=217617

Mark Linimon  changed:

   What|Removed |Added

   Keywords||patch
   Assignee|freebsd-bugs@FreeBSD.org|freebsd-i...@freebsd.org

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
freebsd-bugs@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-bugs
To unsubscribe, send any mail to "freebsd-bugs-unsubscr...@freebsd.org"


[Bug 217613] FreeBSD make -- local variable $(.PREFIX) does not strip preceding directory components

2017-03-07 Thread bugzilla-noreply
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=217613

Mark Linimon  changed:

   What|Removed |Added

   Keywords||patch
 CC||s...@freebsd.org

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
freebsd-bugs@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-bugs
To unsubscribe, send any mail to "freebsd-bugs-unsubscr...@freebsd.org"


[Bug 217610] ELF loader should have a special case for program headers with p_filesz == 0

2017-03-07 Thread bugzilla-noreply
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=217610

Mark Linimon  changed:

   What|Removed |Added

   Keywords||patch

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
freebsd-bugs@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-bugs
To unsubscribe, send any mail to "freebsd-bugs-unsubscr...@freebsd.org"


[Bug 217606] Bridge stops working after some days

2017-03-07 Thread bugzilla-noreply
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=217606

Mark Linimon  changed:

   What|Removed |Added

   Assignee|freebsd-bugs@FreeBSD.org|freebsd-...@freebsd.org

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
freebsd-bugs@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-bugs
To unsubscribe, send any mail to "freebsd-bugs-unsubscr...@freebsd.org"


[Bug 217607] ng_cisco only sends flow control messages to nodes connected via 'inet' hook

2017-03-07 Thread bugzilla-noreply
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=217607

Mark Linimon  changed:

   What|Removed |Added

Summary|ng_cisco flow control   |ng_cisco only sends flow
   |messages and IPv6   |control messages to nodes
   ||connected via 'inet' hook
   Assignee|freebsd-bugs@FreeBSD.org|freebsd-...@freebsd.org
   Keywords||patch

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
freebsd-bugs@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-bugs
To unsubscribe, send any mail to "freebsd-bugs-unsubscr...@freebsd.org"


[Bug 217600] Gateway enable not working

2017-03-07 Thread bugzilla-noreply
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=217600

Mark Linimon  changed:

   What|Removed |Added

   Assignee|freebsd-bugs@FreeBSD.org|freebsd-...@freebsd.org

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
freebsd-bugs@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-bugs
To unsubscribe, send any mail to "freebsd-bugs-unsubscr...@freebsd.org"


[Bug 217577] fix periodic configuration issue if MK_TCP_WRAPPERS} = no

2017-03-07 Thread bugzilla-noreply
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=217577

Mark Linimon  changed:

   What|Removed |Added

Summary|Periodic configuration  |fix periodic configuration
   |issue   |issue if MK_TCP_WRAPPERS} =
   ||no
   Keywords||patch

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
freebsd-bugs@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-bugs
To unsubscribe, send any mail to "freebsd-bugs-unsubscr...@freebsd.org"


[Bug 217625] Kernel panic during suspend to RAM from X11 context

2017-03-07 Thread bugzilla-noreply
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=217625

Bug ID: 217625
   Summary: Kernel panic during suspend to RAM from X11 context
   Product: Base System
   Version: 11.0-RELEASE
  Hardware: amd64
OS: Any
Status: New
  Severity: Affects Some People
  Priority: ---
 Component: kern
  Assignee: freebsd-bugs@FreeBSD.org
  Reporter: aks...@gmail.com

Created attachment 180619
  --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=180619&action=edit
Xorg log and output of pciconf -lbev

These problems started probably after I upgraded all my packages, which then
upgraded the X11 intel DDX driver. I am quite sure suspend to RAM worked fine
before that.

If I do suspend to RAM when switched to console first, there is no problem.

Previously, probably before the intel DDX upgrade, the system would switch to
console tty, then suspend, and during resume would switch back to X11 context.

I managed to get a crash dump. Here is a backtrace:
(kgdb) bt
#0  doadump (textdump=) at pcpu.h:221
#1  0x80ad8ee9 in kern_reboot (howto=260) at
/usr/src/sys/kern/kern_shutdown.c:366
#2  0x80ad949b in vpanic (fmt=, ap=) at /usr/src/sys/kern/kern_shutdown.c:759
#3  0x80ad92d3 in panic (fmt=0x0) at
/usr/src/sys/kern/kern_shutdown.c:690
#4  0x80fa1d51 in trap_fatal (frame=0xfe022367c5a0, eva=12) at
/usr/src/sys/amd64/amd64/trap.c:841
#5  0x80fa1f43 in trap_pfault (frame=0xfe022367c5a0, usermode=0) at
/usr/src/sys/amd64/amd64/trap.c:691
#6  0x80fa14ec in trap (frame=0xfe022367c5a0) at
/usr/src/sys/amd64/amd64/trap.c:442
#7  0x80f841c1 in calltrap () at
/usr/src/sys/amd64/amd64/exception.S:236
#8  0x829e0c05 in ironlake_crtc_enable (crtc=) at
/usr/src/sys/modules/drm2/i915kms/../../../dev/drm2/i915/intel_display.c:3136
#9  0x829dabcd in intel_set_mode (crtc=,
mode=0xf800069f2200, x=0, y=0, fb=0xf800954546b0)
at
/usr/src/sys/modules/drm2/i915kms/../../../dev/drm2/i915/intel_display.c:7993
#10 0x829ea13d in intel_crtc_set_config (set=) at
/usr/src/sys/modules/drm2/i915kms/../../../dev/drm2/i915/intel_display.c:8284
#11 0x82a59f8e in vt_restore_fbdev_mode (arg=,
pending=)
at /usr/src/sys/modules/drm2/drm2/../../../dev/drm2/drm_fb_helper.c:344
#12 0x80b3644a in taskqueue_run_locked (queue=) at
/usr/src/sys/kern/subr_taskqueue.c:449
#13 0x80b37358 in taskqueue_thread_loop (arg=) at
/usr/src/sys/kern/subr_taskqueue.c:703
#14 0x80a900d5 in fork_exit (callout=0x80b37270
, arg=0x81e144b0, frame=0xfe022367cac0) at
/usr/src/sys/kern/kern_fork.c:1038
#15 0x80f846fe in fork_trampoline () at
/usr/src/sys/amd64/amd64/exception.S:611
#16 0x in ?? ()

I've attached some files which describe my setup:
- Xorg.0.log.old - file /var/log/Xorg.0.log.old
- pciconf.txt - output of pciconf -lbev

The attached files are captured or created just after the reboot from crash.

Because the attachment size limit is 1M, I have uploaded the crash dump here:
https://drive.google.com/open?id=0B3u1MJ_t35aQazVQYVZZaFJnRjQ

Can somebody check if there's anything that could be done to make this work?
Unless this is fixed, I will have to shadow the zzz -utility with a shell
script that forces a vty switch to console before invoking the original zzz.
But that is an ugly kludge in my opinion.

At the time of crash I had not started web browsers or any other software which
would keep password or other similar things in memory, so I hope that crash
dump don't contain any info that can be used by randoms and/or botnets to hack
me.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
freebsd-bugs@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-bugs
To unsubscribe, send any mail to "freebsd-bugs-unsubscr...@freebsd.org"


[Bug 217577] fix periodic configuration issue if MK_TCP_WRAPPERS} = no

2017-03-07 Thread bugzilla-noreply
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=217577

Ngie Cooper  changed:

   What|Removed |Added

   Assignee|freebsd-bugs@FreeBSD.org|n...@freebsd.org
 CC||n...@freebsd.org

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
freebsd-bugs@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-bugs
To unsubscribe, send any mail to "freebsd-bugs-unsubscr...@freebsd.org"


[Bug 217613] FreeBSD make -- local variable $(.PREFIX) does not strip preceding directory components

2017-03-07 Thread bugzilla-noreply
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=217613

--- Comment #4 from Erik Nordstrøm  ---
Mark, you added the keyword "patch", but I have not made any patches. The
"BSDmakefile with typo fixed" is only an updated version of the attachment that
shows the problem in question. Apologies for any confusion caused.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
freebsd-bugs@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-bugs
To unsubscribe, send any mail to "freebsd-bugs-unsubscr...@freebsd.org"

[Bug 217626] Some scripts committed to usr.bin/fortune/tools/... lack $FreeBSD$ RCS keywords; will fail svn pre-commit script if touched

2017-03-07 Thread bugzilla-noreply
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=217626

Bug ID: 217626
   Summary: Some scripts committed to usr.bin/fortune/tools/...
lack $FreeBSD$ RCS keywords; will fail svn pre-commit
script if touched
   Product: Base System
   Version: CURRENT
  Hardware: Any
OS: Any
Status: New
  Severity: Affects Some People
  Priority: ---
 Component: bin
  Assignee: freebsd-bugs@FreeBSD.org
  Reporter: n...@freebsd.org

Just a heads up that the following items lack $FreeBSD$ RCS keywords, which
will cause someone some grief if/when they're modified/will be committed:

usr.bin/fortune/tools/...
.../Do_spell
.../Do_troff
.../Troff.mac
.../Troff.sed

It may or may not make sense to remove the scripts if they're unused (they seem
to be present for vestigial reasons, minus maybe "Do_spell").

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
freebsd-bugs@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-bugs
To unsubscribe, send any mail to "freebsd-bugs-unsubscr...@freebsd.org"


[Bug 210143] WITHOUT_MODULES doesn't work with subdirectories

2017-03-07 Thread bugzilla-noreply
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=210143

Sergey  changed:

   What|Removed |Added

 Resolution|--- |Feedback Timeout
 Status|New |Closed

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
freebsd-bugs@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-bugs
To unsubscribe, send any mail to "freebsd-bugs-unsubscr...@freebsd.org"


[Bug 210145] Additional WITHOUT_DTRACE options

2017-03-07 Thread bugzilla-noreply
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=210145

Sergey  changed:

   What|Removed |Added

 Status|New |Closed
 Resolution|--- |Feedback Timeout

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
freebsd-bugs@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-bugs
To unsubscribe, send any mail to "freebsd-bugs-unsubscr...@freebsd.org"


[Bug 210160] ctld and ctladm when WITHOUT_ISCSI=YES

2017-03-07 Thread bugzilla-noreply
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=210160

Sergey  changed:

   What|Removed |Added

 Status|New |Closed
 Resolution|--- |Feedback Timeout

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
freebsd-bugs@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-bugs
To unsubscribe, send any mail to "freebsd-bugs-unsubscr...@freebsd.org"


[Bug 214217] Nvidia NVS 300 fails to start under xorg

2017-03-07 Thread bugzilla-noreply
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=214217

Sergey  changed:

   What|Removed |Added

 Status|New |Closed
 Resolution|--- |Feedback Timeout

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
freebsd-bugs@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-bugs
To unsubscribe, send any mail to "freebsd-bugs-unsubscr...@freebsd.org"


[Bug 215334] Not possible to load compressed kernel modules once the system is running

2017-03-07 Thread bugzilla-noreply
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=215334

Sergey  changed:

   What|Removed |Added

 Status|New |Closed
 Resolution|--- |Feedback Timeout

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
freebsd-bugs@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-bugs
To unsubscribe, send any mail to "freebsd-bugs-unsubscr...@freebsd.org"


[Bug 214382] Kernel compilation error when gzip device enabled

2017-03-07 Thread bugzilla-noreply
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=214382

Sergey  changed:

   What|Removed |Added

 Status|New |Closed
 Resolution|--- |Feedback Timeout

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
freebsd-bugs@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-bugs
To unsubscribe, send any mail to "freebsd-bugs-unsubscr...@freebsd.org"


[Bug 213474] sed behavior change with a/i/c operands.

2017-03-07 Thread bugzilla-noreply
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=213474

Sergey  changed:

   What|Removed |Added

 Status|New |Closed
 Resolution|--- |Overcome By Events

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
freebsd-bugs@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-bugs
To unsubscribe, send any mail to "freebsd-bugs-unsubscr...@freebsd.org"


[Bug 210144] WITHOUT_SOMETHING variables from /etc/src.conf leave some stale files on the system.

2017-03-07 Thread bugzilla-noreply
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=210144

Sergey  changed:

   What|Removed |Added

 Resolution|--- |Feedback Timeout
 Status|New |Closed

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
freebsd-bugs@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-bugs
To unsubscribe, send any mail to "freebsd-bugs-unsubscr...@freebsd.org"


[Bug 217627] Not all files are removed when WITHOUT_AUDIT=YES

2017-03-07 Thread bugzilla-noreply
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=217627

Bug ID: 217627
   Summary: Not all files are removed when WITHOUT_AUDIT=YES
   Product: Base System
   Version: CURRENT
  Hardware: Any
OS: Any
Status: New
  Severity: Affects Many People
  Priority: ---
 Component: conf
  Assignee: freebsd-bugs@FreeBSD.org
  Reporter: kp...@protonmail.com

WITHOUT_AUDIT=YES option doesn't remove /lib/libauditd, /etc/rc.d/auditd and
/etc/rc.d/auditdistd

Though /lib/libauditd depends on libbsm (check /usr/src/lib/Makefile), neither
of them are removed when both WITHOUT_AUDIT=YES and WITHOUT_BSNMP=YES are set.

Best regards.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
freebsd-bugs@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-bugs
To unsubscribe, send any mail to "freebsd-bugs-unsubscr...@freebsd.org"


[Bug 217628] usr.sbin/rpcbind: multiple Coverity issues noted (resource leaks, uninitialized variables, etc)

2017-03-07 Thread bugzilla-noreply
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=217628

Bug ID: 217628
   Summary: usr.sbin/rpcbind: multiple Coverity issues noted
(resource leaks, uninitialized variables, etc)
   Product: Base System
   Version: CURRENT
  Hardware: Any
OS: Any
Status: New
  Severity: Affects Only Me
  Priority: ---
 Component: bin
  Assignee: freebsd-bugs@FreeBSD.org
  Reporter: n...@freebsd.org

Multiple resource leak issues, uninitialized variables, etc have been
identified by Coverity for rpcbind. The issues should be fixed so rpcbind is
more robust.

Access to details for Coverity can be found in the committer's guide:
https://www.freebsd.org/doc/en_US.ISO8859-1/articles/committers-guide/coverity.html
.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
freebsd-bugs@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-bugs
To unsubscribe, send any mail to "freebsd-bugs-unsubscr...@freebsd.org"


[Bug 217629] Not all files are removed when WITHOUT_BSNMP=YES

2017-03-07 Thread bugzilla-noreply
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=217629

Bug ID: 217629
   Summary: Not all files are removed when WITHOUT_BSNMP=YES
   Product: Base System
   Version: CURRENT
  Hardware: Any
OS: Any
Status: New
  Severity: Affects Many People
  Priority: ---
 Component: conf
  Assignee: freebsd-bugs@FreeBSD.org
  Reporter: kp...@protonmail.com

WITHOUT_BSNMP=YES option doesn't remove /lib/libbsm and /lib/libbegemot

Best regards.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
freebsd-bugs@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-bugs
To unsubscribe, send any mail to "freebsd-bugs-unsubscr...@freebsd.org"


[Bug 217630] sbin/devd: reports kldload errors for non-existent modules trying to be loaded

2017-03-07 Thread bugzilla-noreply
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=217630

Bug ID: 217630
   Summary: sbin/devd: reports kldload errors for non-existent
modules trying to be loaded
   Product: Base System
   Version: CURRENT
  Hardware: Any
OS: Any
Status: New
  Severity: Affects Some People
  Priority: ---
 Component: bin
  Assignee: freebsd-bugs@FreeBSD.org
  Reporter: n...@freebsd.org

Repro:

- Build kernel without ums support (either statically or as a module).
- Plug in USB mouse.

Expected result:

- The kernel module load should be attempted, but should fail.
- The error message doesn't seem sensible to expose to the end user; I
recommend it be quieted for improved user experience and to reduce log spam.

Real life scenario:
- Virtual USB keyboards and mice are generally emulated by BMC firmware. If the
developer decides to build the kernel without ukbd/ums, it will always warn
(via devd) that it failed to load the modules, because they do not exist.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
freebsd-bugs@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-bugs
To unsubscribe, send any mail to "freebsd-bugs-unsubscr...@freebsd.org"


[Bug 217631] Not all files are removed when WITHOUT_SVNLITE=YES

2017-03-07 Thread bugzilla-noreply
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=217631

Bug ID: 217631
   Summary: Not all files are removed when WITHOUT_SVNLITE=YES
   Product: Base System
   Version: CURRENT
  Hardware: amd64
OS: Any
Status: New
  Severity: Affects Many People
  Priority: ---
 Component: conf
  Assignee: freebsd-bugs@FreeBSD.org
  Reporter: kp...@protonmail.com

WITHOUT_SVNLITE=YES option doesn't remove /lib/libsqlite3 in file
/usr/src/lib/Makefile

Best regards.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
freebsd-bugs@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-bugs
To unsubscribe, send any mail to "freebsd-bugs-unsubscr...@freebsd.org"


[Bug 217632] Not all files are removed when WITHOUT_PF=YES

2017-03-07 Thread bugzilla-noreply
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=217632

Bug ID: 217632
   Summary: Not all files are removed when WITHOUT_PF=YES
   Product: Base System
   Version: CURRENT
  Hardware: Any
OS: Any
Status: New
  Severity: Affects Many People
  Priority: ---
 Component: conf
  Assignee: freebsd-bugs@FreeBSD.org
  Reporter: kp...@protonmail.com

WITHOUT_PF=YES option doesn't remove /etc/rc.d/pf, /etc/rc.d/pflog and
/etc/rc.d/pfsync in file /usr/src/etc/rc.d/Makefile

Best regards.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
freebsd-bugs@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-bugs
To unsubscribe, send any mail to "freebsd-bugs-unsubscr...@freebsd.org"


[Bug 217633] Not all files are removed when WITHOUT_IPFILTER=YES

2017-03-07 Thread bugzilla-noreply
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=217633

Bug ID: 217633
   Summary: Not all files are removed when WITHOUT_IPFILTER=YES
   Product: Base System
   Version: CURRENT
  Hardware: Any
OS: Any
Status: New
  Severity: Affects Many People
  Priority: ---
 Component: conf
  Assignee: freebsd-bugs@FreeBSD.org
  Reporter: kp...@protonmail.com

WITHOUT_IPFILTER=YES option doesn't remove /etc/rc.d/ipfilter, /etc/rc.d/ipfs,
etc/rc.d/ipmon and /etc/rc.d/ipnat in file /usr/src/etc/rc.d/Makefile

Best regards.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
freebsd-bugs@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-bugs
To unsubscribe, send any mail to "freebsd-bugs-unsubscr...@freebsd.org"


[Bug 217634] Not all files are removed when WITHOUT_QUOTAS=YES

2017-03-07 Thread bugzilla-noreply
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=217634

Bug ID: 217634
   Summary: Not all files are removed when WITHOUT_QUOTAS=YES
   Product: Base System
   Version: CURRENT
  Hardware: Any
OS: Any
Status: New
  Severity: Affects Many People
  Priority: ---
 Component: conf
  Assignee: freebsd-bugs@FreeBSD.org
  Reporter: kp...@protonmail.com

WITHOUT_QUOTAS=YES option doesn't remove /etc/rc.d/quota in file
/usr/src/etc/rc.d/Makefile

Best regards.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
freebsd-bugs@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-bugs
To unsubscribe, send any mail to "freebsd-bugs-unsubscr...@freebsd.org"


[Bug 217627] Not all files are removed when WITHOUT_AUDIT=YES

2017-03-07 Thread bugzilla-noreply
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=217627

--- Comment #1 from Conrad Meyer  ---
*** Bug 217634 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
freebsd-bugs@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-bugs
To unsubscribe, send any mail to "freebsd-bugs-unsubscr...@freebsd.org"


[Bug 217627] Not all files are removed when WITHOUT_AUDIT=YES

2017-03-07 Thread bugzilla-noreply
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=217627

--- Comment #2 from Conrad Meyer  ---
*** Bug 217633 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
freebsd-bugs@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-bugs
To unsubscribe, send any mail to "freebsd-bugs-unsubscr...@freebsd.org"


[Bug 217634] Not all files are removed when WITHOUT_QUOTAS=YES

2017-03-07 Thread bugzilla-noreply
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=217634

Conrad Meyer  changed:

   What|Removed |Added

 CC||c...@freebsd.org
 Status|New |Closed
 Resolution|--- |DUPLICATE

--- Comment #1 from Conrad Meyer  ---
These can all be one bug... please add additional issues around file removal
and options to the original bug.

*** This bug has been marked as a duplicate of bug 217627 ***

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
freebsd-bugs@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-bugs
To unsubscribe, send any mail to "freebsd-bugs-unsubscr...@freebsd.org"


[Bug 217633] Not all files are removed when WITHOUT_IPFILTER=YES

2017-03-07 Thread bugzilla-noreply
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=217633

Conrad Meyer  changed:

   What|Removed |Added

 Status|New |Closed
 Resolution|--- |DUPLICATE
 CC||c...@freebsd.org

--- Comment #1 from Conrad Meyer  ---


*** This bug has been marked as a duplicate of bug 217627 ***

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
freebsd-bugs@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-bugs
To unsubscribe, send any mail to "freebsd-bugs-unsubscr...@freebsd.org"


[Bug 217627] Not all files are removed when WITHOUT_AUDIT=YES

2017-03-07 Thread bugzilla-noreply
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=217627

--- Comment #4 from Conrad Meyer  ---
*** Bug 217631 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
freebsd-bugs@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-bugs
To unsubscribe, send any mail to "freebsd-bugs-unsubscr...@freebsd.org"


[Bug 217627] Not all files are removed when WITHOUT_AUDIT=YES

2017-03-07 Thread bugzilla-noreply
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=217627

--- Comment #3 from Conrad Meyer  ---
*** Bug 217632 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
freebsd-bugs@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-bugs
To unsubscribe, send any mail to "freebsd-bugs-unsubscr...@freebsd.org"


[Bug 217632] Not all files are removed when WITHOUT_PF=YES

2017-03-07 Thread bugzilla-noreply
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=217632

Conrad Meyer  changed:

   What|Removed |Added

 Status|New |Closed
 Resolution|--- |DUPLICATE
 CC||c...@freebsd.org

--- Comment #1 from Conrad Meyer  ---


*** This bug has been marked as a duplicate of bug 217627 ***

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
freebsd-bugs@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-bugs
To unsubscribe, send any mail to "freebsd-bugs-unsubscr...@freebsd.org"


[Bug 217629] Not all files are removed when WITHOUT_BSNMP=YES

2017-03-07 Thread bugzilla-noreply
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=217629

Conrad Meyer  changed:

   What|Removed |Added

 Status|New |Closed
 Resolution|--- |DUPLICATE
 CC||c...@freebsd.org

--- Comment #1 from Conrad Meyer  ---


*** This bug has been marked as a duplicate of bug 217627 ***

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
freebsd-bugs@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-bugs
To unsubscribe, send any mail to "freebsd-bugs-unsubscr...@freebsd.org"


[Bug 217631] Not all files are removed when WITHOUT_SVNLITE=YES

2017-03-07 Thread bugzilla-noreply
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=217631

Conrad Meyer  changed:

   What|Removed |Added

 CC||c...@freebsd.org
 Status|New |Closed
 Resolution|--- |DUPLICATE

--- Comment #1 from Conrad Meyer  ---


*** This bug has been marked as a duplicate of bug 217627 ***

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
freebsd-bugs@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-bugs
To unsubscribe, send any mail to "freebsd-bugs-unsubscr...@freebsd.org"


[Bug 217627] Not all files are removed when WITHOUT_AUDIT=YES

2017-03-07 Thread bugzilla-noreply
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=217627

--- Comment #5 from Conrad Meyer  ---
*** Bug 217629 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
freebsd-bugs@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-bugs
To unsubscribe, send any mail to "freebsd-bugs-unsubscr...@freebsd.org"