[Bug 211475] clang++ 3.8.0 false warning: wrong type/value involved in compiler's false message

2016-07-31 Thread bugzilla-noreply
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=211475

Bug ID: 211475
   Summary: clang++ 3.8.0 false warning: wrong type/value involved
in compiler's false message
   Product: Base System
   Version: 11.0-BETA3
  Hardware: Any
OS: Any
Status: New
  Severity: Affects Only Me
  Priority: ---
 Component: bin
  Assignee: freebsd-bugs@FreeBSD.org
  Reporter: mar...@dsl-only.net

The context here was a -r419343 /usr/ports based report, although later below I
show a 9-line, simple source that shows the issue . . .

devel/qmake5: . . ./corelib/tools/qmap.h:617:27: warning: returning address of
local temporary object

when compiled under a 11.0-BETA3 context: devel/qmake5 gets several reports of
returning the address of a local temporary object. For example:

--- metamakefile.o ---
In file included from
/usr/obj/portswork/usr/ports/devel/qmake5/work/qtbase-opensource-src-5.5.1/qmake/generators/metamakefile.cpp:37:
In file included from
/usr/obj/portswork/usr/ports/devel/qmake5/work/qtbase-opensource-src-5.5.1/include/QtCore/qdebug.h:1:
In file included from
/usr/obj/portswork/usr/ports/devel/qmake5/work/qtbase-opensource-src-5.5.1/include/QtCore/../../src/corelib/io/qdebug.h:40:
In file included from
/usr/obj/portswork/usr/ports/devel/qmake5/work/qtbase-opensource-src-5.5.1/include/QtCore/qmap.h:1:
/usr/obj/portswork/usr/ports/devel/qmake5/work/qtbase-opensource-src-5.5.1/include/QtCore/../../src/corelib/tools/qmap.h:617:27:
warning: returning address of local temporary object [-Wreturn-stack-address]
return n ? n->value : adefaultValue;
  ^
/usr/obj/portswork/usr/ports/devel/qmake5/work/qtbase-opensource-src-5.5.1/qmake/generators/win32/msvc_objectmodel.h:1064:32:
note: in instantiation of member function 'QMap::value'
requested here
TreeNode *n = children.value(newNodeName);
   ^
/usr/obj/portswork/usr/ports/devel/qmake5/work/qtbase-opensource-src-5.5.1/include/QtCore/../../src/corelib/tools/qmap.h:386:44:
note: binding reference variable 'adefaultValue' here
const T value(const Key &key, const T &defaultValue = T()) const;
   ^  ~~~
I'll not go through the details of this complicated context.


A short source showing the problem is:

# more wrong_type.cc 
#include 

template  const T value(const T &v = T()) { return v; }

int main ()
{
int* n = value();
return nullptr != n;
}

which when compiled reports:

# clang++ -std=c++14 wrong_type.cc
wrong_type.cc:3:64: warning: returning address of local temporary object
[-Wreturn-stack-address]
template  const T value(const T &v = T()) { return v; }
   ^
wrong_type.cc:7:14: note: in instantiation of function template specialization
'value' requested here
int* n = value();
 ^
wrong_type.cc:3:46: note: binding reference variable 'v' here
template  const T value(const T &v = T()) { return v; }
 ^   ~~~
1 warning generated.


Note that the "address of local temporary object" would have type int** in this
example and the value held would be a nullptr (translated to int*). T is int*
above.


The result of running the compiled result is:

# ./a.out && echo test
test

So n does end up matching nullptr, as it should. It does not end up with the
address of the local temporary object (which would not match nullptr).

# clang++ -std=c++11 -O0 wrong_type.cc

gets the same messages and the same result. Similarly for -std=c++98 or
-std=c++03.

So the warning does not match the execution behavior and the issue exists for
multiple c++ target-vintages.

It appears that for now the specific type of warning can not be relied on.


So this appears to be more than just a generic false-positive but an actual
reference to the wrong type and wrong value in the warning: the actual return
value in question is not a stack address at all.

Originally I was going to report this against devel/qmake5 but as I analyzed
the code and composed the submittal message I ended up with finding clang++ to
be referencing the wrong type and wrong value for the context in its message.
It appears to me that the C++ code generated is correct.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
freebsd-bugs@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-bugs
To unsubscribe, send any mail to "freebsd-bugs-unsubscr...@freebsd.org"


[Bug 211475] clang++ 3.8.0 false warning: wrong type/value involved in compiler's false message

2016-07-31 Thread bugzilla-noreply
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=211475

--- Comment #1 from Mark Millard  ---
(In reply to Mark Millard from comment #0)

I have submitted 28788 to llvm's bugzilla against 3.8 --a minor variation of
the same basic text as here.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
freebsd-bugs@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-bugs
To unsubscribe, send any mail to "freebsd-bugs-unsubscr...@freebsd.org"


[Bug 205690] [psm] [patch]: support for Elantech trackpads

2016-07-31 Thread bugzilla-noreply
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=205690

--- Comment #34 from Juan Ramón Molina Menor  ---
(In reply to Vladimir Kondratyev from comment #30)
>> Gest 1: Cursor jumps on p. 5. Scroll stops in p. 6. and cursor resumes 
>> moving.
>New version should eliminate cursor jump

Yes it does.

>>  Continued capabilities:
>>   capClickPad: 1
>Is it synaptics clickpad?
>If so, could you check proper softbuttons sizing? Pressing on to lower-right
>part of synaptics clickpad should produce middle or right mouse button events 
>rather than left button event. Zones are tuned via 
>hw.psm.synaptics.softbutton3_x, hw.psm.synaptics.softbutton2_x and 
>hw.psm.synaptics.softbuttons_y sysctls and their default values was taken to 
>match HP pavillion clickpad drawing. I wonder, if these values match your 
>touchpad geometry?

Thanks for pointing this, I didn’t know. Softbuttons are also working, but
require fine-tuning their position with the sysctl values. They also require an
actual click, tapping would not trigger them. All considered, I still prefer
double and triple tapping.

Best regards,
Juan

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
freebsd-bugs@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-bugs
To unsubscribe, send any mail to "freebsd-bugs-unsubscr...@freebsd.org"

[Bug 211485] fsck_ffs(8) doesn't exit with error code (but 0) on error (without -[pCF])

2016-07-31 Thread bugzilla-noreply
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=211485

Bug ID: 211485
   Summary: fsck_ffs(8) doesn't exit with error code (but 0) on
error (without -[pCF])
   Product: Base System
   Version: 11.0-STABLE
  Hardware: Any
OS: Any
Status: New
  Severity: Affects Some People
  Priority: ---
 Component: bin
  Assignee: freebsd-bugs@FreeBSD.org
  Reporter: bugzilla.free...@omnilan.de

Since r276737, some additional checks before setup() in checkfilesys() (calling
calcsb() in my case) lead to correct exit code on failure.
Now, only -p, -C or -F lead to correct exit code on failure e.g. if no
superblock was found (because there's no FFS yet...).

By default, fsck_ffs exits with 0 even on error, which most likely breaks
script for others too!

I could incorporate additional if-then-exit(with) lines, but that's most likely
not the FreeBSD way. So I'm really looking forward how to solve this more
sophisticated.

Thanks,

-Harry

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
freebsd-bugs@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-bugs
To unsubscribe, send any mail to "freebsd-bugs-unsubscr...@freebsd.org"


[Bug 211486] [panic] [IPSec] [IP6] Crash with IPv6 ESP usage

2016-07-31 Thread bugzilla-noreply
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=211486

Bug ID: 211486
   Summary: [panic] [IPSec] [IP6] Crash with IPv6 ESP usage
   Product: Base System
   Version: 11.0-STABLE
  Hardware: Any
OS: Any
Status: New
  Severity: Affects Many People
  Priority: ---
 Component: kern
  Assignee: freebsd-bugs@FreeBSD.org
  Reporter: bugzilla.free...@omnilan.de

Unread portion of the kernel message buffer:
Kernel page fault with the following non-sleepable locks held:
exclusive rw tcpinp (tcpinp) r = 0 (0xf80007b1fe18) locked @
/usr/local/share/deploy-tools/RELENG_11/src/sys/netinet6/in6_pcb.c:1172
shared rw tcp (tcp) r = 0 (0x82ad2bd8) locked @
/usr/local/share/deploy-tools/RELENG_11/src/sys/netinet/tcp_input.c:802
stack backtrace:
#0 0x80ab4d30 at witness_debugger+0x70
#1 0x80ab6017 at witness_warn+0x3d7
#2 0x80ec63d7 at trap_pfault+0x57
#3 0x80ec5a64 at trap+0x284
#4 0x80ea6161 at calltrap+0x8
#5 0x80c43c51 at tcp_twrespond+0x231
#6 0x80c436f5 at tcp_twstart+0x1f5
#7 0x80c34078 at tcp_do_segment+0x23c8
#8 0x80c310b4 at tcp_input+0xe44
#9 0x80c30221 at tcp6_input+0xf1
#10 0x80c82799 at ipsec6_common_input_cb+0x4c9
#11 0x80c97101 at esp_input_cb+0x671
#12 0x80ca9e69 at swcr_process+0xd69
#13 0x80ca6c2f at crypto_dispatch+0x7f
#14 0x80c9605a at esp_input+0x4fa
#15 0x80c8179b at ipsec_common_input+0x40b
#16 0x80c8222d at ipsec6_common_input+0xcd
#17 0x80c64070 at ip6_input+0xc70


Fatal trap 12: page fault while in kernel mode
cpuid = 2; apic id = 02
fault virtual address   = 0x1a
fault code  = supervisor read data, page not present
instruction pointer = 0x20:0x80c65afc
stack pointer   = 0x28:0xfe0091f1e5f0
frame pointer   = 0x28:0xfe0091f1e850
code segment= base 0x0, limit 0xf, type 0x1b
= DPL 0, pres 1, long 1, def32 0, gran 1
processor eflags= interrupt enabled, resume, IOPL = 0
current process = 0 (em0 que)


I have static keys and policy (via ipsec.conf) which is in use for several
years.
Updated stable/10 to stable/11 whci crashes the machine as soon as there's
traffic mathcing the IPSec policy.

core dump available, just tell me how I can help – not able to diagnose
furthere :-(

-Harry

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
freebsd-bugs@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-bugs
To unsubscribe, send any mail to "freebsd-bugs-unsubscr...@freebsd.org"

[Bug 211488] powerpc iso broken / does not burn correctly

2016-07-31 Thread bugzilla-noreply
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=211488

Bug ID: 211488
   Summary: powerpc iso broken / does not burn correctly
   Product: Base System
   Version: 11.0-BETA3
  Hardware: ppc
OS: Any
Status: New
  Severity: Affects Some People
  Priority: ---
 Component: misc
  Assignee: freebsd-bugs@FreeBSD.org
  Reporter: ventur...@geeklan.co.uk

The published powerpc iso files do not appear to burn correctly on disk utility
on OS X.
Confirmed on 10.3-RELEASE & 11-BETA3 powerpc iso using CD & DVD media with disk
utility application on OS X.
With DVD media for example, 523.7MB is used up yet 0 directories & files on
disk.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
freebsd-bugs@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-bugs
To unsubscribe, send any mail to "freebsd-bugs-unsubscr...@freebsd.org"


[Bug 211491] System hangs after "Uptime" on reboot

2016-07-31 Thread bugzilla-noreply
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=211491

Bug ID: 211491
   Summary: System hangs after "Uptime" on reboot
   Product: Base System
   Version: 11.0-BETA3
  Hardware: amd64
OS: Any
Status: New
  Severity: Affects Only Me
  Priority: ---
 Component: kern
  Assignee: freebsd-bugs@FreeBSD.org
  Reporter: g_amana...@yahoo.com
CC: freebsd-am...@freebsd.org
CC: freebsd-am...@freebsd.org

Created attachment 173147
  --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=173147&action=edit
dmesg

System is an Supermicro X9SCM running FreeBSD 11.0-BETA3 amd64 with GENERIC
kernel. When issuing "reboot" the system will hang after the "Uptime" message.
The system has to be reset by physically holding the power button or issuing a
power cycle from the IPMI interface.

I am attaching the dmesg and loader.conf output.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
freebsd-bugs@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-bugs
To unsubscribe, send any mail to "freebsd-bugs-unsubscr...@freebsd.org"


[Bug 211491] System hangs after "Uptime" on reboot

2016-07-31 Thread bugzilla-noreply
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=211491

--- Comment #2 from g_amana...@yahoo.com ---
Of note, despite issuing the "reboot" command, I can still ping the em0
interface on this machine.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
freebsd-bugs@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-bugs
To unsubscribe, send any mail to "freebsd-bugs-unsubscr...@freebsd.org"


[Bug 211491] System hangs after "Uptime" on reboot

2016-07-31 Thread bugzilla-noreply
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=211491

--- Comment #1 from g_amana...@yahoo.com ---
Created attachment 173148
  --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=173148&action=edit
loader.conf

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
freebsd-bugs@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-bugs
To unsubscribe, send any mail to "freebsd-bugs-unsubscr...@freebsd.org"