Re: kern/187238: vm.pmap.pcid_enabled="1" causes Java to coredump in FBSD 10
The following reply was made to PR kern/187238; it has been noted by GNATS. From: Henrik Gulbrandsen To: bug-follo...@freebsd.org, freebsd-j...@freebsd.org Cc: Craig Rodrigues , Konstantin Belousov , Alan Cox Subject: Re: kern/187238: =?UTF-8?Q?vm=2Epmap=2Epcid=5Fenabled=3D=22=31=22?= =?UTF-8?Q?=20causes=20Java=20to=20coredump=20in=20FBSD=20=31=30?= Date: Sun, 23 Mar 2014 13:03:00 +0100 --=_ef7706356ad2b17cefd08d9045174740 Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset=UTF-8; format=flowed This is the most time-consuming bug I've encountered in my life, and not only because I started looking for it in the JVM, but now it seems to have been hiding in plain sight. I'm pretty sure that pmap->pm_save is handled incorrectly in the current kernel. Judging from the code, it's supposed to include all CPUs where the pmap has been active since the latest call to pmap_invalidate_all(...). However, that means that it should always be a superset of pmap->pm_active, since any CPU where the pmap is active may cache pmap information at any time. Currently, this is not the case, and since only CPUs in pmap->pm_save are targeted in the TLB shootdown, we are left with inconsistencies that crash the process soon afterwards. The attached patch solves this by only clearing a CPU from pmap->pm_save if it is not currently included in pmap->pm_active. As far as I can tell, that eliminates the bug. The patch is against STABLE, since that's what I'm currently running, but CURRENT should be pretty close, except for the default setting of pmap_pcid_enabled. By the way, the logic in the invalidation functions is a bit messy now and can probably be simplified. Also, is there a good reason for ignoring the pmap argument in smp_masked_invltlb(...)? /Henrik P.S. After five days it turns out that mx1.FreeBSD.org has been rejecting this email due to a slight misconfiguration of my mail server. I hope that I haven't caused too many hours of frustration by this failure to report the bug fix in due time. Anyway, in the meantime my test (java/openjdk6 building itself) has been running continuously in the background. It used to fail almost every single time, but has now gone through 765 iterations without a single crash. I believe that indicates that the bug is fixed. --=_ef7706356ad2b17cefd08d9045174740 Content-Transfer-Encoding: base64 Content-Type: text/x-diff; name=pr187238.patch Content-Disposition: attachment; filename=pr187238.patch; size=1755 SW5kZXg6IHN5cy9hbWQ2NC9hbWQ2NC9hcGljX3ZlY3Rvci5TCj09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIHN5cy9h bWQ2NC9hbWQ2NC9hcGljX3ZlY3Rvci5TCShyZXZpc2lvbiAyNjMyOTApCisrKyBzeXMvYW1kNjQv YW1kNjQvYXBpY192ZWN0b3IuUwkod29ya2luZyBjb3B5KQpAQCAtMTc3LDcgKzE3NywxMCBAQAog CWp6CTJmCiAJc3dhcGdzCiAyOgorCWJ0bAklZWF4LFBNX0FDVElWRSglcmR4KQorCWpjCTNmCiAJ TEsgYnRjbAklZWF4LFBNX1NBVkUoJXJkeCkKKzM6CiAJU1VQRVJBTElHTl9URVhUCiBpbnZsdGxi X3JldF9yZHg6CiAJcG9wcQklcmR4CkluZGV4OiBzeXMvYW1kNjQvYW1kNjQvcG1hcC5jCj09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT0KLS0tIHN5cy9hbWQ2NC9hbWQ2NC9wbWFwLmMJKHJldmlzaW9uIDI2MzI5MCkKKysrIHN5 cy9hbWQ2NC9hbWQ2NC9wbWFwLmMJKHdvcmtpbmcgY29weSkKQEAgLTM2Nyw3ICszNjcsNyBAQAog CiBzdGF0aWMgc3RydWN0IHVucmhkciBwY2lkX3VucjsKIHN0YXRpYyBzdHJ1Y3QgbXR4IHBjaWRf bXR4OwotaW50IHBtYXBfcGNpZF9lbmFibGVkID0gMDsKK2ludCBwbWFwX3BjaWRfZW5hYmxlZCA9 IDE7CiBTWVNDVExfSU5UKF92bV9wbWFwLCBPSURfQVVUTywgcGNpZF9lbmFibGVkLCBDVExGTEFH X1JEVFVOLCAmcG1hcF9wY2lkX2VuYWJsZWQsCiAgICAgMCwgIklzIFRMQiBDb250ZXh0IElEIGVu YWJsZWQgPyIpOwogaW50IGludnBjaWRfd29ya3MgPSAwOwpAQCAtODM4LDcgKzgzOCw3IEBACiAJ a2VybmVsX3BtYXAtPnBtX3BtbDQgPSAocGRwX2VudHJ5X3QgKilQSFlTX1RPX0RNQVAoS1BNTDRw aHlzKTsKIAlrZXJuZWxfcG1hcC0+cG1fY3IzID0gS1BNTDRwaHlzOwogCUNQVV9GSUxMKCZrZXJu ZWxfcG1hcC0+cG1fYWN0aXZlKTsJLyogZG9uJ3QgYWxsb3cgZGVhY3RpdmF0aW9uICovCi0JQ1BV X1pFUk8oJmtlcm5lbF9wbWFwLT5wbV9zYXZlKTsKKwlDUFVfRklMTCgma2VybmVsX3BtYXAtPnBt X3NhdmUpOwkvKiBhbHdheXMgc3VwZXJzZXQgb2YgcG1fYWN0aXZlICovCiAJVEFJTFFfSU5JVCgm a2VybmVsX3BtYXAtPnBtX3B2Y2h1bmspOwogCWtlcm5lbF9wbWFwLT5wbV9mbGFncyA9IHBtYXBf ZmxhZ3M7CiAKQEAgLTE0OTIsNyArMTQ5Miw4IEBACiAJCX0gZWxzZSB7CiAJCQlpbnZsdGxiX2ds b2JwY2lkKCk7CiAJCX0KLQkJQ1BVX0NMUl9BVE9NSUMoY3B1aWQsICZwbWFwLT5wbV9zYXZlKTsK KwkJaWYgKCFDUFVfSVNTRVQoY3B1aWQsICZwbWFwLT5wbV9hY3RpdmUpKQorCQkJQ1BVX0NMUl9B VE9NSUMoY3B1aWQsICZwbWFwLT5wbV9zYXZlKTsKIAkJc21wX2ludmx0bGIocG1hcCk7CiAJfSBl bHNlIHsKIAkJb3RoZXJfY3B1cyA9IGFsbF9jcHVzOwpAQCAtMTUyNiw3ICsxNTI3LDggQEAKIAkJ CX0KIAkJfSBlbHNlIGlmIChDUFVfSVNTRVQoY3B1aWQsICZwbWFwLT5wbV9hY3RpdmUpKQogCQkJ aW52bHRsYigpOwotCQlDUFVfQ0xSX0FUT01JQyhjcHVpZCwgJnBtYXAtPnBtX3NhdmUpOworCQlp ZiAoIUNQVV9JU1NFVChjcHVpZCwgJnBtYXAtPnBtX2FjdGl2ZSkpCisJCQlDUFVfQ0xSX0FUT01J QyhjcHVpZCwgJnBtYXAtPnBtX3NhdmUpOwogCQlpZiAocG1hcF9wY2lkX2VuYWJsZWQpCiAJCQlD UFVfQU5EKCZvdGhlcl9jcHVzLCAmcG1hcC0+cG1fc2F2ZSk7CiAJCWVsc2UK --=_ef7706356ad2b17cefd08d9045174740-- ___
Re: ports/187815: PCRE 8.34 and issue with Vbulletin
Synopsis: PCRE 8.34 and issue with Vbulletin State-Changed-From-To: open->feedback State-Changed-By: linimon State-Changed-When: Sun Mar 23 15:48:05 UTC 2014 State-Changed-Why: to which port does this PR apply? Responsible-Changed-From-To: freebsd-bugs->linimon Responsible-Changed-By: linimon Responsible-Changed-When: Sun Mar 23 15:48:05 UTC 2014 Responsible-Changed-Why: http://www.freebsd.org/cgi/query-pr.cgi?pr=187815 ___ freebsd-bugs@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-bugs To unsubscribe, send any mail to "freebsd-bugs-unsubscr...@freebsd.org"
Re: bin/187728: [patch] bc(1) should print error message to stderr
The following reply was made to PR bin/187728; it has been noted by GNATS. From: Jilles Tjoelker To: bug-follo...@freebsd.org, ksmak...@dd.iij4u.or.jp Cc: Subject: Re: bin/187728: [patch] bc(1) should print error message to stderr Date: Sun, 23 Mar 2014 19:20:25 +0100 In PR bin/187728, you wrote: > bc(1) should prints error message to stderr. POSIX seems to require this in interactive mode; in non-interactive mode, invalid input causes undefined behaviour. Note that the patch changes more than just the destination of the error message. The code in the repository prints the error message if and when dc reaches the point of the error, rather than immediately when the error is detected in the patched version. Since the patched version is simpler, it seems that the original code may be deliberately written that way. -- Jilles Tjoelker ___ freebsd-bugs@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-bugs To unsubscribe, send any mail to "freebsd-bugs-unsubscr...@freebsd.org"
Re: kern/187238: [patch] vm.pmap.pcid_enabled="1" causes Java to coredump in FBSD 10
Synopsis: [patch] vm.pmap.pcid_enabled="1" causes Java to coredump in FBSD 10 Responsible-Changed-From-To: freebsd-bugs->kib Responsible-Changed-By: rodrigc Responsible-Changed-When: Sun Mar 23 11:45:18 PDT 2014 Responsible-Changed-Why: kib, can you please take a look? http://www.freebsd.org/cgi/query-pr.cgi?pr=187238 ___ freebsd-bugs@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-bugs To unsubscribe, send any mail to "freebsd-bugs-unsubscr...@freebsd.org"
misc/187858: update graphics/luminance to latest Qt4-Version
>Number: 187858
>Category: misc
>Synopsis: update graphics/luminance to latest Qt4-Version
>Confidential: no
>Severity: non-critical
>Priority: low
>Responsible:freebsd-bugs
>State: open
>Quarter:
>Keywords:
>Date-Required:
>Class: maintainer-update
>Submitter-Id: current-users
>Arrival-Date: Sun Mar 23 19:40:00 UTC 2014
>Closed-Date:
>Last-Modified:
>Originator: Hannes Hauswedell
>Release:10.0-RELEASE
>Organization:
FSFE
>Environment:
FreeBSD fbsdmain 10.0-RELEASE FreeBSD 10.0-RELEASE #0 r260789: Thu Jan 16
22:34:59 UTC 2014 r...@snap.freebsd.org:/usr/obj/usr/src/sys/GENERIC amd64
>Description:
Update to 2.3.1.
2.4.0 requires Qt5, so we have to wait for that to get the latest version.
>How-To-Repeat:
-
>Fix:
apply patch
Patch attached with submission follows:
diff -u luminance/Makefile luminanceNEW/Makefile
--- luminance/Makefile 2013-03-22 21:06:14.0 +0100
+++ luminanceNEW/Makefile 2014-03-23 20:24:48.518562234 +0100
@@ -1,13 +1,8 @@
-# New ports collection makefile for: Luminance HDR (nee Qtpfsgui)
-# Date created:28 Jul 2007
-# Whom:Yinghong Liu
-#
-# $FreeBSD: graphics/luminance/Makefile 314960 2013-03-22 20:06:14Z makc $
-#
+# Created by: Yinghong Liu
+# $FreeBSD: head/graphics/luminance/Makefile 341289 2014-01-26 21:20:03Z
rakuco $
PORTNAME= luminance-hdr
-PORTREVISION= 1
-DISTVERSION= 2.3.0
+DISTVERSION= 2.3.1
CATEGORIES=graphics
MASTER_SITES= SF/qtpfsgui/luminance/${DISTVERSION}
@@ -30,8 +25,8 @@
USE_QT4= gui sql webkit xml linguist_build moc_build qmake_build \
rcc_build uic_build imageformats_run
INSTALLS_ICONS=yes
-MAKE_JOBS_SAFE=yes
+NO_STAGE= yes
post-patch:
# Do not install yet another copy of GPL (we use license framework instead)
# and fix installation path for docs (but not for internal help files)
@@ -49,4 +44,20 @@
's,@GIT_SHA1@,be5409f2ed028b0a509d3f4cd44a970a09d2ef6c,' \
${WRKSRC}/src/Common/GitSHA1.cpp.in
+# Include in addition to where necessary, as this
+# is required for building with libc++
+ @${REINPLACE_CMD} -E '1s|^|#include \|;' \
+ ${WRKSRC}/src/TonemappingOperators/drago03/pfstmo_drago03.cpp \
+ ${WRKSRC}/src/TonemappingOperators/reinhard02/pfstmo_reinhard02.cpp \
+ ${WRKSRC}/src/TonemappingOperators/reinhard05/pfstmo_reinhard05.cpp \
+ ${WRKSRC}/src/TonemappingOperators/mantiuk08/display_function.cpp \
+ ${WRKSRC}/src/TonemappingOperators/mantiuk08/display_size.cpp \
+ ${WRKSRC}/src/TonemappingOperators/mantiuk08/pfstmo_mantiuk08.cpp \
+ ${WRKSRC}/src/TonemappingOperators/fattal02/pfstmo_fattal02.cpp \
+ ${WRKSRC}/src/TonemappingOperators/durand02/pfstmo_durand02.cpp \
+ ${WRKSRC}/src/TonemappingOperators/pattanaik00/pfstmo_pattanaik00.cpp \
+ ${WRKSRC}/src/Libpfs/io/pfsreader.cpp \
+ ${WRKSRC}/src/Libpfs/io/rgbereader.cpp \
+ ${WRKSRC}/src/Libpfs/colorspace/colorspace.cpp
+
.include
diff -u luminance/distinfo luminanceNEW/distinfo
--- luminance/distinfo 2012-09-21 17:19:13.0 +0200
+++ luminanceNEW/distinfo 2014-03-23 19:12:16.914558094 +0100
@@ -1,2 +1,2 @@
-SHA256 (luminance-hdr-2.3.0.tar.bz2) =
dada0795b58843912bcb57ce61dcd615bcb9f9437b610a37ff813ad2c899c676
-SIZE (luminance-hdr-2.3.0.tar.bz2) = 5398576
+SHA256 (luminance-hdr-2.3.1.tar.bz2) =
c2a4764986bf8860d448530f3c8d76143d7504cebb07b3e58e37eb0db5347722
+SIZE (luminance-hdr-2.3.1.tar.bz2) = 10323806
Only in luminance: files
diff -u luminance/pkg-plist luminanceNEW/pkg-plist
--- luminance/pkg-plist 2012-09-21 17:19:13.0 +0200
+++ luminanceNEW/pkg-plist 2014-03-23 20:17:28.540561608 +0100
@@ -60,9 +60,6 @@
%%DATADIR%%/help/en/tonemapping_cli.html
%%DATADIR%%/help/en/tonemapping_interactive.html
%%DATADIR%%/help/en/workflow.html
-%%DATADIR%%/help/js/jquery.js
-%%DATADIR%%/help/js/jquery.jtabs.pack.js
-@dirrm %%DATADIR%%/help/js
@dirrm %%DATADIR%%/help/en/images
@dirrm %%DATADIR%%/help/en
@dirrm %%DATADIR%%/help
>Release-Note:
>Audit-Trail:
>Unformatted:
___
freebsd-bugs@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-bugs
To unsubscribe, send any mail to "freebsd-bugs-unsubscr...@freebsd.org"
Re: ports/187858: update graphics/luminance to latest Qt4-Version
Synopsis: update graphics/luminance to latest Qt4-Version Responsible-Changed-From-To: freebsd-bugs->freebsd-ports-bugs Responsible-Changed-By: linimon Responsible-Changed-When: Sun Mar 23 19:57:33 UTC 2014 Responsible-Changed-Why: ports PR. http://www.freebsd.org/cgi/query-pr.cgi?pr=187858 ___ freebsd-bugs@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-bugs To unsubscribe, send any mail to "freebsd-bugs-unsubscr...@freebsd.org"
Re: misc/187858: update graphics/luminance to latest Qt4-Version
Sorry, the patch wasn't against current ports-tree. See attachment for
one that applies cleanly.
--
Best,
Hannes
diff -u luminance/Makefile luminanceNEW/Makefile
--- luminance/Makefile 2014-03-23 21:22:29.0 +0100
+++ luminanceNEW/Makefile 2014-03-23 20:24:48.518562234 +0100
@@ -2,8 +2,7 @@
# $FreeBSD: head/graphics/luminance/Makefile 341289 2014-01-26 21:20:03Z
rakuco $
PORTNAME= luminance-hdr
-PORTREVISION= 5
-DISTVERSION= 2.3.0
+DISTVERSION= 2.3.1
CATEGORIES=graphics
MASTER_SITES= SF/qtpfsgui/luminance/${DISTVERSION}
@@ -45,4 +44,20 @@
's,@GIT_SHA1@,be5409f2ed028b0a509d3f4cd44a970a09d2ef6c,' \
${WRKSRC}/src/Common/GitSHA1.cpp.in
+# Include in addition to where necessary, as this
+# is required for building with libc++
+ @${REINPLACE_CMD} -E '1s|^|#include \|;' \
+ ${WRKSRC}/src/TonemappingOperators/drago03/pfstmo_drago03.cpp \
+ ${WRKSRC}/src/TonemappingOperators/reinhard02/pfstmo_reinhard02.cpp \
+ ${WRKSRC}/src/TonemappingOperators/reinhard05/pfstmo_reinhard05.cpp \
+ ${WRKSRC}/src/TonemappingOperators/mantiuk08/display_function.cpp \
+ ${WRKSRC}/src/TonemappingOperators/mantiuk08/display_size.cpp \
+ ${WRKSRC}/src/TonemappingOperators/mantiuk08/pfstmo_mantiuk08.cpp \
+ ${WRKSRC}/src/TonemappingOperators/fattal02/pfstmo_fattal02.cpp \
+ ${WRKSRC}/src/TonemappingOperators/durand02/pfstmo_durand02.cpp \
+ ${WRKSRC}/src/TonemappingOperators/pattanaik00/pfstmo_pattanaik00.cpp \
+ ${WRKSRC}/src/Libpfs/io/pfsreader.cpp \
+ ${WRKSRC}/src/Libpfs/io/rgbereader.cpp \
+ ${WRKSRC}/src/Libpfs/colorspace/colorspace.cpp
+
.include
diff -u luminance/distinfo luminanceNEW/distinfo
--- luminance/distinfo 2014-03-23 21:22:29.0 +0100
+++ luminanceNEW/distinfo 2014-03-23 19:12:16.914558094 +0100
@@ -1,2 +1,2 @@
-SHA256 (luminance-hdr-2.3.0.tar.bz2) =
dada0795b58843912bcb57ce61dcd615bcb9f9437b610a37ff813ad2c899c676
-SIZE (luminance-hdr-2.3.0.tar.bz2) = 5398576
+SHA256 (luminance-hdr-2.3.1.tar.bz2) =
c2a4764986bf8860d448530f3c8d76143d7504cebb07b3e58e37eb0db5347722
+SIZE (luminance-hdr-2.3.1.tar.bz2) = 10323806
Only in luminance: files
diff -u luminance/pkg-plist luminanceNEW/pkg-plist
--- luminance/pkg-plist 2014-03-23 21:22:29.0 +0100
+++ luminanceNEW/pkg-plist 2014-03-23 20:17:28.540561608 +0100
@@ -60,9 +60,6 @@
%%DATADIR%%/help/en/tonemapping_cli.html
%%DATADIR%%/help/en/tonemapping_interactive.html
%%DATADIR%%/help/en/workflow.html
-%%DATADIR%%/help/js/jquery.js
-%%DATADIR%%/help/js/jquery.jtabs.pack.js
-@dirrm %%DATADIR%%/help/js
@dirrm %%DATADIR%%/help/en/images
@dirrm %%DATADIR%%/help/en
@dirrm %%DATADIR%%/help
___
freebsd-bugs@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-bugs
To unsubscribe, send any mail to "freebsd-bugs-unsubscr...@freebsd.org"
Re: kern/187778: [zfs] Two ZFS filesystems mounted on / at same time
Old Synopsis: Two ZFS filesystems mounted on / at same time New Synopsis: [zfs] Two ZFS filesystems mounted on / at same time Responsible-Changed-From-To: freebsd-bugs->freebsd-fs Responsible-Changed-By: linimon Responsible-Changed-When: Mon Mar 24 05:24:50 UTC 2014 Responsible-Changed-Why: Over to maintainer(s). http://www.freebsd.org/cgi/query-pr.cgi?pr=187778 ___ freebsd-bugs@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-bugs To unsubscribe, send any mail to "freebsd-bugs-unsubscr...@freebsd.org"
